All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-14 21:09 ` Sergei Shtylyov
  0 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-14 21:09 UTC (permalink / raw)
  To: Simon Horman, Rob Herring, Mark Rutland,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: Magnus Damm, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Sergei Shtylyov

[-- Attachment #1: ARM-dts-r8a7743-add-PFC-support.patch --]
[-- Type: text/plain, Size: 1281 bytes --]

Define the generic R8A7743 part of the PFC device node.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

---
 arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
+++ renesas/arch/arm/boot/dts/r8a7743.dtsi
@@ -1,7 +1,7 @@
 /*
  * Device Tree Source for the r8a7743 SoC
  *
- * Copyright (C) 2016 Cogent Embedded Inc.
+ * Copyright (C) 2016-2017 Cogent Embedded Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2. This program is licensed "as is" without any warranty of any
@@ -123,6 +123,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		pfc: pin-controller@e6060000 {
+			compatible = "renesas,pfc-r8a7743";
+			reg = <0 0xe6060000 0 0x250>;
+		};
+
 		dmac0: dma-controller@e6700000 {
 			compatible = "renesas,dmac-r8a7743",
 				     "renesas,rcar-dmac";

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-14 21:09 ` Sergei Shtylyov
  0 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-14 21:09 UTC (permalink / raw)
  To: Simon Horman, Rob Herring, Mark Rutland, linux-renesas-soc, devicetree
  Cc: Magnus Damm, Russell King, linux-arm-kernel, Sergei Shtylyov

[-- Attachment #1: ARM-dts-r8a7743-add-PFC-support.patch --]
[-- Type: text/plain, Size: 1032 bytes --]

Define the generic R8A7743 part of the PFC device node.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
+++ renesas/arch/arm/boot/dts/r8a7743.dtsi
@@ -1,7 +1,7 @@
 /*
  * Device Tree Source for the r8a7743 SoC
  *
- * Copyright (C) 2016 Cogent Embedded Inc.
+ * Copyright (C) 2016-2017 Cogent Embedded Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2. This program is licensed "as is" without any warranty of any
@@ -123,6 +123,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		pfc: pin-controller@e6060000 {
+			compatible = "renesas,pfc-r8a7743";
+			reg = <0 0xe6060000 0 0x250>;
+		};
+
 		dmac0: dma-controller@e6700000 {
 			compatible = "renesas,dmac-r8a7743",
 				     "renesas,rcar-dmac";


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-14 21:09 ` Sergei Shtylyov
  0 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-14 21:09 UTC (permalink / raw)
  To: linux-arm-kernel

Define the generic R8A7743 part of the PFC device node.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
+++ renesas/arch/arm/boot/dts/r8a7743.dtsi
@@ -1,7 +1,7 @@
 /*
  * Device Tree Source for the r8a7743 SoC
  *
- * Copyright (C) 2016 Cogent Embedded Inc.
+ * Copyright (C) 2016-2017 Cogent Embedded Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2. This program is licensed "as is" without any warranty of any
@@ -123,6 +123,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		pfc: pin-controller at e6060000 {
+			compatible = "renesas,pfc-r8a7743";
+			reg = <0 0xe6060000 0 0x250>;
+		};
+
 		dmac0: dma-controller at e6700000 {
 			compatible = "renesas,dmac-r8a7743",
 				     "renesas,rcar-dmac";

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7743: add PFC support
  2017-04-14 21:09 ` Sergei Shtylyov
@ 2017-04-20  8:51   ` Simon Horman
  -1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2017-04-20  8:51 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Rob Herring, Mark Rutland, linux-renesas-soc, devicetree,
	Magnus Damm, Russell King, linux-arm-kernel

On Sat, Apr 15, 2017 at 12:09:42AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7743 part of the PFC device node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1,7 +1,7 @@
>  /*
>   * Device Tree Source for the r8a7743 SoC
>   *
> - * Copyright (C) 2016 Cogent Embedded Inc.
> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>   *
>   * This file is licensed under the terms of the GNU General Public License
>   * version 2. This program is licensed "as is" without any warranty of any
> @@ -123,6 +123,11 @@
>  			#power-domain-cells = <1>;
>  		};
>  
> +		pfc: pin-controller@e6060000 {
> +			compatible = "renesas,pfc-r8a7743";
> +			reg = <0 0xe6060000 0 0x250>;
> +		};
> +

I am curious to know why pin-controller was chosen rather than pfc which
is dominant in the DT for Renesas SoCs. And as a follow-up question, do
you think it would be worth creating patches to make this uniform
across the DT for Renesas SoCs.

>  		dmac0: dma-controller@e6700000 {
>  			compatible = "renesas,dmac-r8a7743",
>  				     "renesas,rcar-dmac";
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-20  8:51   ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2017-04-20  8:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 15, 2017 at 12:09:42AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7743 part of the PFC device node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1,7 +1,7 @@
>  /*
>   * Device Tree Source for the r8a7743 SoC
>   *
> - * Copyright (C) 2016 Cogent Embedded Inc.
> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>   *
>   * This file is licensed under the terms of the GNU General Public License
>   * version 2. This program is licensed "as is" without any warranty of any
> @@ -123,6 +123,11 @@
>  			#power-domain-cells = <1>;
>  		};
>  
> +		pfc: pin-controller at e6060000 {
> +			compatible = "renesas,pfc-r8a7743";
> +			reg = <0 0xe6060000 0 0x250>;
> +		};
> +

I am curious to know why pin-controller was chosen rather than pfc which
is dominant in the DT for Renesas SoCs. And as a follow-up question, do
you think it would be worth creating patches to make this uniform
across the DT for Renesas SoCs.

>  		dmac0: dma-controller at e6700000 {
>  			compatible = "renesas,dmac-r8a7743",
>  				     "renesas,rcar-dmac";
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7743: add PFC support
  2017-04-20  8:51   ` Simon Horman
  (?)
@ 2017-04-20 12:24       ` Sergei Shtylyov
  -1 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-20 12:24 UTC (permalink / raw)
  To: Simon Horman
  Cc: Rob Herring, Mark Rutland,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Magnus Damm, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hello.

On 04/20/2017 11:51 AM, Simon Horman wrote:

>> Define the generic R8A7743 part of the PFC device node.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>>
>> ---
>>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
>> @@ -1,7 +1,7 @@
>>  /*
>>   * Device Tree Source for the r8a7743 SoC
>>   *
>> - * Copyright (C) 2016 Cogent Embedded Inc.
>> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>>   *
>>   * This file is licensed under the terms of the GNU General Public License
>>   * version 2. This program is licensed "as is" without any warranty of any
>> @@ -123,6 +123,11 @@
>>  			#power-domain-cells = <1>;
>>  		};
>>
>> +		pfc: pin-controller@e6060000 {
>> +			compatible = "renesas,pfc-r8a7743";
>> +			reg = <0 0xe6060000 0 0x250>;
>> +		};
>> +
>
> I am curious to know why pin-controller was chosen rather than pfc which
> is dominant in the DT for Renesas SoCs.

    The reason is simple: I was trying to follow the DT specs which require 
generic node names. The "pin-controller" looked more generic than "pfc".

> And as a follow-up question, do
> you think it would be worth creating patches to make this uniform
> across the DT for Renesas SoCs.

    Yes, probably.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-20 12:24       ` Sergei Shtylyov
  0 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-20 12:24 UTC (permalink / raw)
  To: Simon Horman
  Cc: Rob Herring, Mark Rutland, linux-renesas-soc, devicetree,
	Magnus Damm, Russell King, linux-arm-kernel

Hello.

On 04/20/2017 11:51 AM, Simon Horman wrote:

>> Define the generic R8A7743 part of the PFC device node.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
>> @@ -1,7 +1,7 @@
>>  /*
>>   * Device Tree Source for the r8a7743 SoC
>>   *
>> - * Copyright (C) 2016 Cogent Embedded Inc.
>> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>>   *
>>   * This file is licensed under the terms of the GNU General Public License
>>   * version 2. This program is licensed "as is" without any warranty of any
>> @@ -123,6 +123,11 @@
>>  			#power-domain-cells = <1>;
>>  		};
>>
>> +		pfc: pin-controller@e6060000 {
>> +			compatible = "renesas,pfc-r8a7743";
>> +			reg = <0 0xe6060000 0 0x250>;
>> +		};
>> +
>
> I am curious to know why pin-controller was chosen rather than pfc which
> is dominant in the DT for Renesas SoCs.

    The reason is simple: I was trying to follow the DT specs which require 
generic node names. The "pin-controller" looked more generic than "pfc".

> And as a follow-up question, do
> you think it would be worth creating patches to make this uniform
> across the DT for Renesas SoCs.

    Yes, probably.

[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-20 12:24       ` Sergei Shtylyov
  0 siblings, 0 replies; 10+ messages in thread
From: Sergei Shtylyov @ 2017-04-20 12:24 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 04/20/2017 11:51 AM, Simon Horman wrote:

>> Define the generic R8A7743 part of the PFC device node.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
>> @@ -1,7 +1,7 @@
>>  /*
>>   * Device Tree Source for the r8a7743 SoC
>>   *
>> - * Copyright (C) 2016 Cogent Embedded Inc.
>> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>>   *
>>   * This file is licensed under the terms of the GNU General Public License
>>   * version 2. This program is licensed "as is" without any warranty of any
>> @@ -123,6 +123,11 @@
>>  			#power-domain-cells = <1>;
>>  		};
>>
>> +		pfc: pin-controller at e6060000 {
>> +			compatible = "renesas,pfc-r8a7743";
>> +			reg = <0 0xe6060000 0 0x250>;
>> +		};
>> +
>
> I am curious to know why pin-controller was chosen rather than pfc which
> is dominant in the DT for Renesas SoCs.

    The reason is simple: I was trying to follow the DT specs which require 
generic node names. The "pin-controller" looked more generic than "pfc".

> And as a follow-up question, do
> you think it would be worth creating patches to make this uniform
> across the DT for Renesas SoCs.

    Yes, probably.

[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7743: add PFC support
  2017-04-14 21:09 ` Sergei Shtylyov
@ 2017-04-20 14:07   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2017-04-20 14:07 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Simon Horman, Rob Herring, Mark Rutland, Linux-Renesas,
	devicetree, Magnus Damm, Russell King, linux-arm-kernel

On Fri, Apr 14, 2017 at 11:09 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A7743 part of the PFC device node.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7743: add PFC support
@ 2017-04-20 14:07   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2017-04-20 14:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Apr 14, 2017 at 11:09 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A7743 part of the PFC device node.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-04-20 14:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 21:09 [PATCH 1/3] ARM: dts: r8a7743: add PFC support Sergei Shtylyov
2017-04-14 21:09 ` Sergei Shtylyov
2017-04-14 21:09 ` Sergei Shtylyov
2017-04-20  8:51 ` Simon Horman
2017-04-20  8:51   ` Simon Horman
     [not found]   ` <20170420085112.GF3760-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-04-20 12:24     ` Sergei Shtylyov
2017-04-20 12:24       ` Sergei Shtylyov
2017-04-20 12:24       ` Sergei Shtylyov
2017-04-20 14:07 ` Geert Uytterhoeven
2017-04-20 14:07   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.