From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bhavya Kapoor <b-kapoor@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, dmitry.baryshkov@linaro.org, arnd@arndb.de,
krzysztof.kozlowski@linaro.org, geert+renesas@glider.be,
nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl
Subject: Re: [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver
Date: Thu, 23 Mar 2023 17:09:06 +0100 [thread overview]
Message-ID: <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com> (raw)
In-Reply-To: <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> > Enable CAN PHY transceiver driver to be built as a module.
>
> Please use the commit message to describe why the driver should be
> enabled. The patch and the subject already states clearly that the
> driver is being enabled.
And if no one has inspiration: I wouldn't mind "because it is needed
for CAN-FD on the Renesas White-Hawk development board" ;-)
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
> > CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> > CONFIG_RESET_TI_SCI=y
> > CONFIG_PHY_XGENE=y
> > +CONFIG_PHY_CAN_TRANSCEIVER=m
> > CONFIG_PHY_SUN4I_USB=y
> > CONFIG_PHY_CADENCE_TORRENT=m
> > CONFIG_PHY_CADENCE_SIERRA=m
For the actual change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bhavya Kapoor <b-kapoor@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, dmitry.baryshkov@linaro.org, arnd@arndb.de,
krzysztof.kozlowski@linaro.org, geert+renesas@glider.be,
nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl
Subject: Re: [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver
Date: Thu, 23 Mar 2023 17:09:06 +0100 [thread overview]
Message-ID: <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com> (raw)
In-Reply-To: <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> > Enable CAN PHY transceiver driver to be built as a module.
>
> Please use the commit message to describe why the driver should be
> enabled. The patch and the subject already states clearly that the
> driver is being enabled.
And if no one has inspiration: I wouldn't mind "because it is needed
for CAN-FD on the Renesas White-Hawk development board" ;-)
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
> > CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> > CONFIG_RESET_TI_SCI=y
> > CONFIG_PHY_XGENE=y
> > +CONFIG_PHY_CAN_TRANSCEIVER=m
> > CONFIG_PHY_SUN4I_USB=y
> > CONFIG_PHY_CADENCE_TORRENT=m
> > CONFIG_PHY_CADENCE_SIERRA=m
For the actual change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-23 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 11:33 [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver Bhavya Kapoor
2023-03-23 11:33 ` Bhavya Kapoor
2023-03-23 13:53 ` Bjorn Andersson
2023-03-23 13:53 ` Bjorn Andersson
2023-03-23 16:09 ` Geert Uytterhoeven [this message]
2023-03-23 16:09 ` Geert Uytterhoeven
2023-03-24 6:15 ` [EXTERNAL] " Bhavya Kapoor
2023-03-24 6:15 ` Bhavya Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=b-kapoor@ti.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=quic_bjorande@quicinc.com \
--cc=rafal@milecki.pl \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.