All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h>
Date: Thu, 14 May 2020 15:23:55 +0200	[thread overview]
Message-ID: <CAMuHMdUP8sT5G9TruLcJC8CoXTUrFZGKr07C3sqbbm0sXbjJbQ@mail.gmail.com> (raw)
In-Reply-To: <CAPY8ntDwffdgQadkBLSdJr0q7nThFHEBO_nPmja1EUVhnRa7YQ@mail.gmail.com>

Hi Dave

On Thu, May 14, 2020 at 3:12 PM Dave Stevenson
<dave.stevenson@raspberrypi.com> wrote:
> On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > The IMX219 camera driver is not a clock provider, but merely a clock
> > consumer, and thus does not need to include <linux/clk-provider.h> and
> > <linux/clkdev.h>.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I'm no expert on the clock frameworks, but that seems logical.
> Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Thank you.

> The same appears to be true for drivers/media/i2c/ov5640.c unless it's
> been fixed since 5.7-rc5.

Quite possible: I did a sweep a while ago, and looked at recently introduced
offenders, but I may have missed some.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2020-05-14 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 12:03 [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h> Geert Uytterhoeven
2020-05-12 21:13 ` Stephen Boyd
2020-05-14 13:12 ` Dave Stevenson
2020-05-14 13:23   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUP8sT5G9TruLcJC8CoXTUrFZGKr07C3sqbbm0sXbjJbQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.