Re: [PATCH] mm:%Lx is non-standard C

Re: [PATCH] mm:%Lx is non-standard C

[Geert Uytterhoeven]

CC linux-m68k.

On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
> replace %Lx with %lx, because %Lx is not standard
>
> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.20 branch.

> --- a/arch/m68k/sun3/sun3dvma.c
> +++ b/arch/m68k/sun3/sun3dvma.c
> @@ -77,7 +77,7 @@ static void print_use(void)
>         pr_info("%d entries in use total\n", j);
>
>         pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
> -       pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
> +       pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
>                 dvma_free_bytes);
>  }

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mm:%Lx is non-standard C

[Andreas Schwab]

On Jul 17 2022, Geert Uytterhoeven wrote:

> CC linux-m68k.
>
> On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
>> replace %Lx with %lx, because %Lx is not standard
>>
>> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v5.20 branch.
>
>> --- a/arch/m68k/sun3/sun3dvma.c
>> +++ b/arch/m68k/sun3/sun3dvma.c
>> @@ -77,7 +77,7 @@ static void print_use(void)
>>         pr_info("%d entries in use total\n", j);
>>
>>         pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
>> -       pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
>> +       pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
>>                 dvma_free_bytes);

Does that actually work?  The L modifier is equivalent to `ll', not `l',
and dvma_alloc_bytes and dvma_free_bytes are in fact of type unsigned
long long.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [PATCH] mm:%Lx is non-standard C

[Geert Uytterhoeven]

On Sun, Jul 17, 2022 at 12:03 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Jul 17 2022, Geert Uytterhoeven wrote:
> > CC linux-m68k.
> >
> > On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
> >> replace %Lx with %lx, because %Lx is not standard
> >>
> >> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > i.e. will queue in the m68k for-v5.20 branch.
> >
> >> --- a/arch/m68k/sun3/sun3dvma.c
> >> +++ b/arch/m68k/sun3/sun3dvma.c
> >> @@ -77,7 +77,7 @@ static void print_use(void)
> >>         pr_info("%d entries in use total\n", j);
> >>
> >>         pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
> >> -       pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
> >> +       pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
> >>                 dvma_free_bytes);
>
> Does that actually work?  The L modifier is equivalent to `ll', not `l',
> and dvma_alloc_bytes and dvma_free_bytes are in fact of type unsigned
> long long.

You're absolutely right.  More coffee needed....

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds