All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: "David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Stafford Horne" <shorne@gmail.com>,
	"Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Linux Fbdev development list" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] video: hd44780: Add hd44780 lcd display driver
Date: Wed, 6 Dec 2017 16:04:10 +0100	[thread overview]
Message-ID: <CAMuHMdUn-wx7YC=QWazb4e-vJGts8iXbkC64NYiEjha-kQPKLg@mail.gmail.com> (raw)
In-Reply-To: <20171206135255.6990-1-poeschel@lemonage.de>

Hi Lars,

On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel <poeschel@lemonage.de> wrote:
> This adds a console driver for hd44780 based character lcd displays and
> clones. The driver currently supports 20x4 character displays with
> character ROMs A00 and A02.
> The hardware wirings to the display have to be supplied to the kernel in
> the devicetree. The binding doc has the necessary information.
> There are also tons of these cheap displays sold with a serial
> interface. Many of them use a simple pcf8574 gpio expanders. An example
> for using that kind of display is also in the binding doc.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Thanks for your patch!

> ---
>  .../bindings/video/console/hd44780con.txt          |  42 ++
>  drivers/video/console/Kconfig                      |  13 +
>  drivers/video/console/Makefile                     |   1 +
>  drivers/video/console/hd44780con.c                 | 676 +++++++++++++++++++++

I'm wondering if you could implement this on top of the existing charlcd
framework:

    drivers/auxdisplay/charlcd.c
    include/misc/charlcd.h

which can use the existing hd44780 backend:

    Documentation/devicetree/bindings/auxdisplay/hit,hd44780.txt
    drivers/auxdisplay/hd44780.c

That way it can be used on other character LCDs, like the one supported by
drivers/auxdisplay/panel.c.

Thanks!

P.S. I did something similar a long time ago, cfr.
     https://github.com/geertu/hd44780/blob/master/lcdcon.c

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: "David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Stafford Horne" <shorne@gmail.com>,
	"Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: hd44780: Add hd44780 lcd display driver
Date: Wed, 6 Dec 2017 16:04:10 +0100	[thread overview]
Message-ID: <CAMuHMdUn-wx7YC=QWazb4e-vJGts8iXbkC64NYiEjha-kQPKLg@mail.gmail.com> (raw)
In-Reply-To: <20171206135255.6990-1-poeschel@lemonage.de>

Hi Lars,

On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel <poeschel@lemonage.de> wrote:
> This adds a console driver for hd44780 based character lcd displays and
> clones. The driver currently supports 20x4 character displays with
> character ROMs A00 and A02.
> The hardware wirings to the display have to be supplied to the kernel in
> the devicetree. The binding doc has the necessary information.
> There are also tons of these cheap displays sold with a serial
> interface. Many of them use a simple pcf8574 gpio expanders. An example
> for using that kind of display is also in the binding doc.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Thanks for your patch!

> ---
>  .../bindings/video/console/hd44780con.txt          |  42 ++
>  drivers/video/console/Kconfig                      |  13 +
>  drivers/video/console/Makefile                     |   1 +
>  drivers/video/console/hd44780con.c                 | 676 +++++++++++++++++++++

I'm wondering if you could implement this on top of the existing charlcd
framework:

    drivers/auxdisplay/charlcd.c
    include/misc/charlcd.h

which can use the existing hd44780 backend:

    Documentation/devicetree/bindings/auxdisplay/hit,hd44780.txt
    drivers/auxdisplay/hd44780.c

That way it can be used on other character LCDs, like the one supported by
drivers/auxdisplay/panel.c.

Thanks!

P.S. I did something similar a long time ago, cfr.
     https://github.com/geertu/hd44780/blob/master/lcdcon.c

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: "David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Stafford Horne" <shorne@gmail.com>,
	"Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: hd44780: Add hd44780 lcd display driver
Date: Wed, 06 Dec 2017 15:04:10 +0000	[thread overview]
Message-ID: <CAMuHMdUn-wx7YC=QWazb4e-vJGts8iXbkC64NYiEjha-kQPKLg@mail.gmail.com> (raw)
In-Reply-To: <20171206135255.6990-1-poeschel@lemonage.de>

Hi Lars,

On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel <poeschel@lemonage.de> wrote:
> This adds a console driver for hd44780 based character lcd displays and
> clones. The driver currently supports 20x4 character displays with
> character ROMs A00 and A02.
> The hardware wirings to the display have to be supplied to the kernel in
> the devicetree. The binding doc has the necessary information.
> There are also tons of these cheap displays sold with a serial
> interface. Many of them use a simple pcf8574 gpio expanders. An example
> for using that kind of display is also in the binding doc.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Thanks for your patch!

> ---
>  .../bindings/video/console/hd44780con.txt          |  42 ++
>  drivers/video/console/Kconfig                      |  13 +
>  drivers/video/console/Makefile                     |   1 +
>  drivers/video/console/hd44780con.c                 | 676 +++++++++++++++++++++

I'm wondering if you could implement this on top of the existing charlcd
framework:

    drivers/auxdisplay/charlcd.c
    include/misc/charlcd.h

which can use the existing hd44780 backend:

    Documentation/devicetree/bindings/auxdisplay/hit,hd44780.txt
    drivers/auxdisplay/hd44780.c

That way it can be used on other character LCDs, like the one supported by
drivers/auxdisplay/panel.c.

Thanks!

P.S. I did something similar a long time ago, cfr.
     https://github.com/geertu/hd44780/blob/master/lcdcon.c

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2017-12-06 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 13:52 [PATCH] video: hd44780: Add hd44780 lcd display driver Lars Poeschel
2017-12-06 13:52 ` Lars Poeschel
2017-12-06 15:04 ` Geert Uytterhoeven [this message]
2017-12-06 15:04   ` Geert Uytterhoeven
2017-12-06 15:04   ` Geert Uytterhoeven
2017-12-07  8:33   ` Lars Poeschel
2017-12-07  8:33     ` Lars Poeschel
2017-12-07  8:33     ` Lars Poeschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUn-wx7YC=QWazb4e-vJGts8iXbkC64NYiEjha-kQPKLg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=daniel.vetter@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.schoelling@gmx.de \
    --cc=mark.rutland@arm.com \
    --cc=poeschel@lemonage.de \
    --cc=pombredanne@nexb.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=shorne@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.