All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] pinctrl: renesas: remove unneeded semicolon
@ 2022-07-05  1:50 Yang Li
  2022-07-05  6:44 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-07-05  1:50 UTC (permalink / raw)
  To: linus.walleij
  Cc: geert+renesas, linux-renesas-soc, linux-gpio, linux-kernel, Yang Li

Eliminate the following coccicheck warnings:
./drivers/pinctrl/renesas/pinctrl-rzv2m.c:487:3-4: Unneeded semicolon
./drivers/pinctrl/renesas/pinctrl-rzv2m.c:519:3-4: Unneeded semicolon
./drivers/pinctrl/renesas/pinctrl-rzv2m.c:591:4-5: Unneeded semicolon
./drivers/pinctrl/renesas/pinctrl-rzv2m.c:620:4-5: Unneeded semicolon

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/pinctrl/renesas/pinctrl-rzv2m.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index 1afc6bb4386a..e8c18198bebd 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -484,7 +484,7 @@ static int rzv2m_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
 			break;
 		default:
 			bias = PIN_CONFIG_BIAS_DISABLE;
-		};
+		}
 
 		if (bias != param)
 			return -EINVAL;
@@ -516,7 +516,7 @@ static int rzv2m_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
 			break;
 		default:
 			return -EINVAL;
-		};
+		}
 
 		break;
 
@@ -588,7 +588,7 @@ static int rzv2m_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
 				break;
 			default:
 				val = 1;
-			};
+			}
 
 			rzv2m_rmw_pin_config(pctrl, PUPD(port), bit, PUPD_MASK, val);
 			break;
@@ -617,7 +617,7 @@ static int rzv2m_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
 				break;
 			default:
 				return -EINVAL;
-			};
+			}
 
 			for (index = 0; index < 4; index++) {
 				if (arg == drv_strengths[index])
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] pinctrl: renesas: remove unneeded semicolon
  2022-07-05  1:50 [PATCH -next] pinctrl: renesas: remove unneeded semicolon Yang Li
@ 2022-07-05  6:44 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-07-05  6:44 UTC (permalink / raw)
  To: Yang Li
  Cc: Linus Walleij, Geert Uytterhoeven, Linux-Renesas,
	open list:GPIO SUBSYSTEM, Linux Kernel Mailing List

On Tue, Jul 5, 2022 at 3:50 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
> Eliminate the following coccicheck warnings:
> ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:487:3-4: Unneeded semicolon
> ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:519:3-4: Unneeded semicolon
> ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:591:4-5: Unneeded semicolon
> ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:620:4-5: Unneeded semicolon
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
As the original commit has not been pulled into the pinctrl tree
yet, I will amend the original commit in renesas-pinctrl-for-v5.20.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-05  6:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05  1:50 [PATCH -next] pinctrl: renesas: remove unneeded semicolon Yang Li
2022-07-05  6:44 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.