All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] To remove non-ascii characters in of_selftest.txt
@ 2014-09-28 19:38 Gaurav Minocha
       [not found] ` <1411933087-4272-1-git-send-email-gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Gaurav Minocha @ 2014-09-28 19:38 UTC (permalink / raw)
  To: devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A,
	rob.herring-QSEj5FYQhm4dnm+yROfE0A, Gaurav Minocha

This patch removes the non-ascii characters in
Documentation/devicetree/of_selftest.txt

Signed-off-by: Gaurav Minocha <gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 Documentation/devicetree/of_selftest.txt | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt
index 9326bba..99f8d8b 100644
--- a/Documentation/devicetree/of_selftest.txt
+++ b/Documentation/devicetree/of_selftest.txt
@@ -67,14 +67,14 @@ struct device_node {
     ...
  };
 
-Figure 1, describes a generic structure of machine’s un-flattened device tree
+Figure 1, describes a generic structure of machine's un-flattened device tree
 considering only child and sibling pointers. There exists another pointer,
 *parent, that is used to traverse the tree in the reverse direction. So, at
 a particular level the child node and all the sibling nodes will have a parent
-pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4’s
+pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's
 parent points to root node)
 
-root (‘/’)
+root ('/')
    |
 child1 -> sibling2 -> sibling3 -> sibling4 -> null
    |         |           |           |
@@ -110,7 +110,7 @@ __dtb_testcases_begin - address marking the start of test data blob
 __dtb_testcases_end   - address marking the end of test data blob
 
 Secondly, it calls of_fdt_unflatten_device_tree() to unflatten the flattened
-blob. And finally, if the machine’s device tree (i.e live tree) is present,
+blob. And finally, if the machine's device tree (i.e live tree) is present,
 then it attaches the unflattened test data tree to the live tree, else it
 attaches itself as a live device tree.
 
@@ -118,7 +118,7 @@ attach_node_and_children() uses of_attach_node() to attach the nodes into the
 live tree as explained below. To explain the same, the test data tree described
  in Figure 2 is attached to the live tree described in Figure 1.
 
-root (‘/’)
+root ('/')
     |
  testcase-data
     |
@@ -134,8 +134,8 @@ root->testcase-data->test-child0->test-child01->test-sibling1->test-sibling2
 
 Figure 2: Example test data tree to be attached to live tree.
 
-According to the scenario above, the live tree is already present so it isn’t
-required to attach the root(‘/’) node. All other nodes are attached by calling
+According to the scenario above, the live tree is already present so it isn't
+required to attach the root('/') node. All other nodes are attached by calling
 of_attach_node() on each node.
 
 In the function of_attach_node(), the new node is attached as the child of the
@@ -144,7 +144,7 @@ replaces the current child and turns it into its sibling. So, when the testcase
 data node is attached to the live tree above (Figure 1), the final structure is
  as shown in Figure 3.
 
-root (‘/’)
+root ('/')
    |
 testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null
    |               |          |           |           |
@@ -163,7 +163,7 @@ testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null
                                           null
 -----------------------------------------------------------------------
 
-root (‘/’)
+root ('/')
    |
 testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null
    |               |          |           |           |
@@ -184,8 +184,8 @@ test-child0 the test-sibling1 is attached that pushes the child node
  as mentioned above.
 
 If a duplicate node is found (i.e. if a node with same full_name property is
-already present in the live tree), then the node isn’t attached rather its
-properties are updated to the live tree’s node by calling the function
+already present in the live tree), then the node isn't attached rather its
+properties are updated to the live tree's node by calling the function
 update_node_properties().
 
 
@@ -198,7 +198,7 @@ whole tree). selftest_data_remove() calls detach_node_and_children() that uses
 of_detach_node() to detach the nodes from the live device tree.
 
 To detach a node, of_detach_node() first updates all_next linked list, by
-attaching the previous node’s allnext to current node’s allnext pointer. And
-then, it either updates the child pointer of given node’s parent to its
-sibling or attaches the previous sibling to the given node’s sibling, as
+attaching the previous node's allnext to current node's allnext pointer. And
+then, it either updates the child pointer of given node's parent to its
+sibling or attaches the previous sibling to the given node's sibling, as
 appropriate. That is it :)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] To remove non-ascii characters in of_selftest.txt
       [not found] ` <1411933087-4272-1-git-send-email-gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2014-09-29  8:07   ` Geert Uytterhoeven
       [not found]     ` <CAMuHMdUvr49-iWUwNDrC6iDkrY_rE2hpynzeFS47j1W-69OfNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-09-29  8:07 UTC (permalink / raw)
  To: Gaurav Minocha
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Grant Likely, Rob Herring

Hi Gaurav, Grant,

On Sun, Sep 28, 2014 at 9:38 PM, Gaurav Minocha
<gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch removes the non-ascii characters in
> Documentation/devicetree/of_selftest.txt

I was wondering against which tree this was, as this file was not in my
local copy of linux-next (which was still at next-20140925).

Perhaps the filename was wrong?

So I grepped for "of_fdt_unflatten_device_tree", as this looked like a good
search pattern, cfr.

>  Secondly, it calls of_fdt_unflatten_device_tree() to unflatten the flattened

Surprise! No occurrences of  "of_fdt_unflatten_device_tree" found!

[ more digging ]

Ah, found it, it went almost straight into Linus' tree, and thus appeared in
next-20140926 after the fact.

Still:

$ git grep of_fdt_unflatten_device_tree | cat
Documentation/devicetree/of_selftest.txt:Secondly, it calls
of_fdt_unflatten_device_tree() to unflatten the flattened
$

So this part of the documentation is not correct.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] To remove non-ascii characters in of_selftest.txt
       [not found]     ` <CAMuHMdUvr49-iWUwNDrC6iDkrY_rE2hpynzeFS47j1W-69OfNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-09-29 20:02       ` Gaurav Minocha
       [not found]         ` <CA+rpMb+UDSvn0jDZDoJzcQJjf56PpLMb-ta_9yvpohV26A-3Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Gaurav Minocha @ 2014-09-29 20:02 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Grant Likely, Rob Herring

On Mon, Sep 29, 2014 at 1:07 AM, Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> wrote:
> Hi Gaurav, Grant,
>
> On Sun, Sep 28, 2014 at 9:38 PM, Gaurav Minocha
> <gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> This patch removes the non-ascii characters in
>> Documentation/devicetree/of_selftest.txt
>
> I was wondering against which tree this was, as this file was not in my
> local copy of linux-next (which was still at next-20140925).
>
> Perhaps the filename was wrong?
>
> So I grepped for "of_fdt_unflatten_device_tree", as this looked like a good
> search pattern, cfr.
>
>>  Secondly, it calls of_fdt_unflatten_device_tree() to unflatten the flattened
>
> Surprise! No occurrences of  "of_fdt_unflatten_device_tree" found!
>
> [ more digging ]
>
> Ah, found it, it went almost straight into Linus' tree, and thus appeared in
> next-20140926 after the fact.
>
> Still:
>
> $ git grep of_fdt_unflatten_device_tree | cat
> Documentation/devicetree/of_selftest.txt:Secondly, it calls
> of_fdt_unflatten_device_tree() to unflatten the flattened
> $
>
> So this part of the documentation is not correct.

Yes, my bad. That is supposed to be of_fdt_unflatten_tree.

Will fix it. Thanks!

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] To remove non-ascii characters in of_selftest.txt
       [not found]         ` <CA+rpMb+UDSvn0jDZDoJzcQJjf56PpLMb-ta_9yvpohV26A-3Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-10-06  8:56           ` Grant Likely
  0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2014-10-06  8:56 UTC (permalink / raw)
  To: Gaurav Minocha, Geert Uytterhoeven
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring

On Mon, 29 Sep 2014 13:02:21 -0700
, Gaurav Minocha <gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
 wrote:
> On Mon, Sep 29, 2014 at 1:07 AM, Geert Uytterhoeven
> <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> wrote:
> > Hi Gaurav, Grant,
> >
> > On Sun, Sep 28, 2014 at 9:38 PM, Gaurav Minocha
> > <gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >> This patch removes the non-ascii characters in
> >> Documentation/devicetree/of_selftest.txt
> >
> > I was wondering against which tree this was, as this file was not in my
> > local copy of linux-next (which was still at next-20140925).
> >
> > Perhaps the filename was wrong?
> >
> > So I grepped for "of_fdt_unflatten_device_tree", as this looked like a good
> > search pattern, cfr.
> >
> >>  Secondly, it calls of_fdt_unflatten_device_tree() to unflatten the flattened
> >
> > Surprise! No occurrences of  "of_fdt_unflatten_device_tree" found!
> >
> > [ more digging ]
> >
> > Ah, found it, it went almost straight into Linus' tree, and thus appeared in
> > next-20140926 after the fact.
> >
> > Still:
> >
> > $ git grep of_fdt_unflatten_device_tree | cat
> > Documentation/devicetree/of_selftest.txt:Secondly, it calls
> > of_fdt_unflatten_device_tree() to unflatten the flattened
> > $
> >
> > So this part of the documentation is not correct.
> 
> Yes, my bad. That is supposed to be of_fdt_unflatten_tree.
> 
> Will fix it. Thanks!

Applied and typo fixed up. Thanks!

g.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-10-06  8:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-28 19:38 [PATCH] To remove non-ascii characters in of_selftest.txt Gaurav Minocha
     [not found] ` <1411933087-4272-1-git-send-email-gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-29  8:07   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdUvr49-iWUwNDrC6iDkrY_rE2hpynzeFS47j1W-69OfNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-29 20:02       ` Gaurav Minocha
     [not found]         ` <CA+rpMb+UDSvn0jDZDoJzcQJjf56PpLMb-ta_9yvpohV26A-3Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-06  8:56           ` Grant Likely

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.