[PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[Biju Das]

HiHope RZG2[HMN] boards uses Realtek phy and the driver does not support
rxc-skew-ps property. So remove rxc-skew-ps from ethernet-phy node.

Fixes: 7433f1fb8ec8fe ("arm64: dts: renesas: Add HiHope RZ/G2M sub board support")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
index 178401a34cbf..b9e46aed5336 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
@@ -23,7 +23,6 @@
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		rxc-skew-ps = <1500>;
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
-- 
2.17.1

[PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps from ethernet-phy node

[Biju Das]

The CAT875 sub board from Silicon Linux uses Realtek phy and the driver
does not support rxc-skew-ps property.

Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet support")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/cat875.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi
index 33daa9570684..801ea54b027c 100644
--- a/arch/arm64/boot/dts/renesas/cat875.dtsi
+++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
@@ -21,7 +21,6 @@
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		rxc-skew-ps = <1500>;
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
-- 
2.17.1

Re: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps from ethernet-phy node

[Geert Uytterhoeven]

Hi Biju,

On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The CAT875 sub board from Silicon Linux uses Realtek phy and the driver
> does not support rxc-skew-ps property.
>
> Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> @@ -21,7 +21,6 @@
>         status = "okay";
>
>         phy0: ethernet-phy@0 {
> -               rxc-skew-ps = <1500>;
>                 reg = <0>;
>                 interrupt-parent = <&gpio2>;
>                 interrupts = <21 IRQ_TYPE_LEVEL_LOW>;

Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
(after [1] has entered v5.10-rc1, and the DTS part of [2] has been
 applied to renesas-devel)?

[1] [PATCH net-next v4 resend 5/5] ravb: Add support for explicit
internal clock delay configuration
    https://lore.kernel.org/linux-renesas-soc/20201001101008.14365-6-geert+renesas@glider.be/
[2] [PATCH v3 0/7] net/ravb: Add support for explicit internal clock
delay configuration
    https://lore.kernel.org/linux-renesas-soc/20200819134344.27813-1-geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[Geert Uytterhoeven]

Hi Biju,

On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> HiHope RZG2[HMN] boards uses Realtek phy and the driver does not support
> rxc-skew-ps property. So remove rxc-skew-ps from ethernet-phy node.
>
> Fixes: 7433f1fb8ec8fe ("arm64: dts: renesas: Add HiHope RZ/G2M sub board support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> @@ -23,7 +23,6 @@
>         status = "okay";
>
>         phy0: ethernet-phy@0 {
> -               rxc-skew-ps = <1500>;
>                 reg = <0>;
>                 interrupt-parent = <&gpio2>;
>                 interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
(after [1] has entered v5.10-rc1, and the DTS part of [2] has been
 applied to renesas-devel)?

[1] [PATCH net-next v4 resend 5/5] ravb: Add support for explicit
internal clock delay configuration
    https://lore.kernel.org/linux-renesas-soc/20201001101008.14365-6-geert+renesas@glider.be/
[2] [PATCH v3 0/7] net/ravb: Add support for explicit internal clock
delay configuration
    https://lore.kernel.org/linux-renesas-soc/20200819134344.27813-1-geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps from ethernet-phy node

[Biju Das]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps
> from ethernet-phy node
> 
> Hi Biju,
> 
> On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > The CAT875 sub board from Silicon Linux uses Realtek phy and the
> > driver does not support rxc-skew-ps property.
> >
> > Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet
> > support")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > @@ -21,7 +21,6 @@
> >         status = "okay";
> >
> >         phy0: ethernet-phy@0 {
> > -               rxc-skew-ps = <1500>;
> >                 reg = <0>;
> >                 interrupt-parent = <&gpio2>;
> >                 interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> 
> Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
> (after [1] has entered v5.10-rc1, and the DTS part of [2] has been  applied to
> renesas-devel)?

Looking at the schematic, it is not needed, since it has "2ns" internal delay  (4.7K Ohm latched to 2.5 V) on the Rx side.

Cheers,
Biju

> [1] [PATCH net-next v4 resend 5/5] ravb: Add support for explicit internal
> clock delay configuration
>     https://lore.kernel.org/linux-renesas-soc/20201001101008.14365-6-
> geert+renesas@glider.be/
> [2] [PATCH v3 0/7] net/ravb: Add support for explicit internal clock delay
> configuration
>     https://lore.kernel.org/linux-renesas-soc/20200819134344.27813-1-
> geert+renesas@glider.be
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

RE: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[Biju Das]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-
> skew-ps from ethernet-phy node
> 
> Hi Biju,
> 
> On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > HiHope RZG2[HMN] boards uses Realtek phy and the driver does not
> > support rxc-skew-ps property. So remove rxc-skew-ps from ethernet-phy
> node.
> >
> > Fixes: 7433f1fb8ec8fe ("arm64: dts: renesas: Add HiHope RZ/G2M sub
> > board support")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > @@ -23,7 +23,6 @@
> >         status = "okay";
> >
> >         phy0: ethernet-phy@0 {
> > -               rxc-skew-ps = <1500>;
> >                 reg = <0>;
> >                 interrupt-parent = <&gpio2>;
> >                 interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> 
> Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
> (after [1] has entered v5.10-rc1, and the DTS part of [2] has been  applied to
> renesas-devel)?

Looking at the schematic, it is not needed, since it has "2ns" internal delay  (4.7K Ohm latched to 2.5 V) on the Rx side.

Cheers,
Biju
 
> [1] [PATCH net-next v4 resend 5/5] ravb: Add support for explicit internal
> clock delay configuration
>     https://lore.kernel.org/linux-renesas-soc/20201001101008.14365-6-
> geert+renesas@glider.be/
> [2] [PATCH v3 0/7] net/ravb: Add support for explicit internal clock delay
> configuration
>     https://lore.kernel.org/linux-renesas-soc/20200819134344.27813-1-
> geert+renesas@glider.be
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[Geert Uytterhoeven]

Hi Biju,

On Fri, Oct 16, 2020 at 8:15 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-
> > skew-ps from ethernet-phy node
> > On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > HiHope RZG2[HMN] boards uses Realtek phy and the driver does not
> > > support rxc-skew-ps property. So remove rxc-skew-ps from ethernet-phy
> > node.
> > >
> > > Fixes: 7433f1fb8ec8fe ("arm64: dts: renesas: Add HiHope RZ/G2M sub
> > > board support")
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> > lad.rj@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > > @@ -23,7 +23,6 @@
> > >         status = "okay";
> > >
> > >         phy0: ethernet-phy@0 {
> > > -               rxc-skew-ps = <1500>;
> > >                 reg = <0>;
> > >                 interrupt-parent = <&gpio2>;
> > >                 interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> >
> > Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
> > (after [1] has entered v5.10-rc1, and the DTS part of [2] has been  applied to
> > renesas-devel)?
>
> Looking at the schematic, it is not needed, since it has "2ns" internal delay  (4.7K Ohm latched to 2.5 V) on the Rx side.

Thanks for the pointer, I can confirm LED2_RXDLY is strapped high
(to 3.3V, not 2.5V though).

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps from ethernet-phy node

[Geert Uytterhoeven]

Hi Biju,

On Fri, Oct 16, 2020 at 8:13 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps
> > from ethernet-phy node
> > On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > The CAT875 sub board from Silicon Linux uses Realtek phy and the
> > > driver does not support rxc-skew-ps property.
> > >
> > > Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet
> > > support")
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> > lad.rj@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > @@ -21,7 +21,6 @@
> > >         status = "okay";
> > >
> > >         phy0: ethernet-phy@0 {
> > > -               rxc-skew-ps = <1500>;
> > >                 reg = <0>;
> > >                 interrupt-parent = <&gpio2>;
> > >                 interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> >
> > Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
> > (after [1] has entered v5.10-rc1, and the DTS part of [2] has been  applied to
> > renesas-devel)?
>
> Looking at the schematic, it is not needed, since it has "2ns" internal delay  (4.7K Ohm latched to 2.5 V) on the Rx side.

Thanks for the pointer, I can confirm LED2_RXDLY is strapped high
(to 3.3V, not 2.5V though).

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds