* [PATCH v2 0/2] pinctrl: iproc: improve error handling
@ 2019-10-03 0:03 ` Chris Packham
0 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Chris Packham
I noticed these when debugging another issue. The first patch is a fix
to address some error handling. The second is just cosmetic.
Changes in v2:
- split bug-fix from cosmetic change
Chris Packham (2):
pinctrl: iproc: allow for error from platform_get_irq()
pinctrl: iproc: use unique name for irq chip
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 0/2] pinctrl: iproc: improve error handling
@ 2019-10-03 0:03 ` Chris Packham
0 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, Chris Packham, linux-kernel, linux-arm-kernel
I noticed these when debugging another issue. The first patch is a fix
to address some error handling. The second is just cosmetic.
Changes in v2:
- split bug-fix from cosmetic change
Chris Packham (2):
pinctrl: iproc: allow for error from platform_get_irq()
pinctrl: iproc: use unique name for irq chip
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
2019-10-03 0:03 ` Chris Packham
@ 2019-10-03 0:03 ` Chris Packham
-1 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Chris Packham
platform_get_irq() can return an error code. Allow for this when getting
the irq.
Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 6f7d3a2f2e97..8971fc54e974 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -853,7 +853,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
/* optional GPIO interrupt support */
irq = platform_get_irq(pdev, 0);
- if (irq) {
+ if (irq > 0) {
struct irq_chip *irqc;
struct gpio_irq_chip *girq;
--
2.23.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
@ 2019-10-03 0:03 ` Chris Packham
0 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, Chris Packham, linux-kernel, linux-arm-kernel
platform_get_irq() can return an error code. Allow for this when getting
the irq.
Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 6f7d3a2f2e97..8971fc54e974 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -853,7 +853,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
/* optional GPIO interrupt support */
irq = platform_get_irq(pdev, 0);
- if (irq) {
+ if (irq > 0) {
struct irq_chip *irqc;
struct gpio_irq_chip *girq;
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-03 0:03 ` Chris Packham
@ 2019-10-03 0:03 ` Chris Packham
-1 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Chris Packham
Use the dev_name(dev) for the irqc->name so that we get unique names
when we have multiple instances of this driver.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 8971fc54e974..c24d49d436ce 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
struct gpio_irq_chip *girq;
irqc = &chip->irqchip;
- irqc->name = "bcm-iproc-gpio";
+ irqc->name = dev_name(dev);
irqc->irq_ack = iproc_gpio_irq_ack;
irqc->irq_mask = iproc_gpio_irq_mask;
irqc->irq_unmask = iproc_gpio_irq_unmask;
--
2.23.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-03 0:03 ` Chris Packham
0 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-03 0:03 UTC (permalink / raw)
To: linus.walleij, rjui, sbranden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin
Cc: linux-gpio, Chris Packham, linux-kernel, linux-arm-kernel
Use the dev_name(dev) for the irqc->name so that we get unique names
when we have multiple instances of this driver.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 8971fc54e974..c24d49d436ce 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
struct gpio_irq_chip *girq;
irqc = &chip->irqchip;
- irqc->name = "bcm-iproc-gpio";
+ irqc->name = dev_name(dev);
irqc->irq_ack = iproc_gpio_irq_ack;
irqc->irq_mask = iproc_gpio_irq_mask;
irqc->irq_unmask = iproc_gpio_irq_unmask;
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
2019-10-03 0:03 ` Chris Packham
@ 2019-10-03 18:36 ` Scott Branden
-1 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-03 18:36 UTC (permalink / raw)
To: Chris Packham, linus.walleij, rjui, sbranden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-arm-kernel, linux-kernel
Thanks for fix.
On 2019-10-02 5:03 p.m., Chris Packham wrote:
> platform_get_irq() can return an error code. Allow for this when getting
> the irq.
>
> Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 6f7d3a2f2e97..8971fc54e974 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -853,7 +853,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>
> /* optional GPIO interrupt support */
> irq = platform_get_irq(pdev, 0);
> - if (irq) {
> + if (irq > 0) {
> struct irq_chip *irqc;
> struct gpio_irq_chip *girq;
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
@ 2019-10-03 18:36 ` Scott Branden
0 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-03 18:36 UTC (permalink / raw)
To: Chris Packham, linus.walleij, rjui, sbranden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-kernel, linux-arm-kernel
Thanks for fix.
On 2019-10-02 5:03 p.m., Chris Packham wrote:
> platform_get_irq() can return an error code. Allow for this when getting
> the irq.
>
> Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 6f7d3a2f2e97..8971fc54e974 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -853,7 +853,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>
> /* optional GPIO interrupt support */
> irq = platform_get_irq(pdev, 0);
> - if (irq) {
> + if (irq > 0) {
> struct irq_chip *irqc;
> struct gpio_irq_chip *girq;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-03 0:03 ` Chris Packham
@ 2019-10-03 18:36 ` Scott Branden
-1 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-03 18:36 UTC (permalink / raw)
To: Chris Packham, linus.walleij, rjui, sbranden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-arm-kernel, linux-kernel
looks fine
On 2019-10-02 5:03 p.m., Chris Packham wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 8971fc54e974..c24d49d436ce 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> struct gpio_irq_chip *girq;
>
> irqc = &chip->irqchip;
> - irqc->name = "bcm-iproc-gpio";
> + irqc->name = dev_name(dev);
> irqc->irq_ack = iproc_gpio_irq_ack;
> irqc->irq_mask = iproc_gpio_irq_mask;
> irqc->irq_unmask = iproc_gpio_irq_unmask;
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-03 18:36 ` Scott Branden
0 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-03 18:36 UTC (permalink / raw)
To: Chris Packham, linus.walleij, rjui, sbranden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin
Cc: linux-gpio, linux-kernel, linux-arm-kernel
looks fine
On 2019-10-02 5:03 p.m., Chris Packham wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 8971fc54e974..c24d49d436ce 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> struct gpio_irq_chip *girq;
>
> irqc = &chip->irqchip;
> - irqc->name = "bcm-iproc-gpio";
> + irqc->name = dev_name(dev);
> irqc->irq_ack = iproc_gpio_irq_ack;
> irqc->irq_mask = iproc_gpio_irq_mask;
> irqc->irq_unmask = iproc_gpio_irq_unmask;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
2019-10-03 0:03 ` Chris Packham
@ 2019-10-05 16:35 ` Linus Walleij
-1 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-05 16:35 UTC (permalink / raw)
To: Chris Packham
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Rayagonda Kokatanur, Li Jin, open list:GPIO SUBSYSTEM, Linux ARM,
linux-kernel
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> platform_get_irq() can return an error code. Allow for this when getting
> the irq.
>
> Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq()
@ 2019-10-05 16:35 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-05 16:35 UTC (permalink / raw)
To: Chris Packham
Cc: Scott Branden, Rayagonda Kokatanur, Ray Jui, linux-kernel,
open list:GPIO SUBSYSTEM, bcm-kernel-feedback-list, Li Jin,
Linux ARM
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> platform_get_irq() can return an error code. Allow for this when getting
> the irq.
>
> Fixes: 6f265e5d4da7 ("pinctrl: bcm-iproc: Pass irqchip when adding gpiochip")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Patch applied for fixes.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-03 0:03 ` Chris Packham
@ 2019-10-05 16:37 ` Linus Walleij
-1 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-05 16:37 UTC (permalink / raw)
To: Chris Packham
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Rayagonda Kokatanur, Li Jin, open list:GPIO SUBSYSTEM, Linux ARM,
linux-kernel
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-05 16:37 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-05 16:37 UTC (permalink / raw)
To: Chris Packham
Cc: Scott Branden, Rayagonda Kokatanur, Ray Jui, linux-kernel,
open list:GPIO SUBSYSTEM, bcm-kernel-feedback-list, Li Jin,
Linux ARM
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-03 0:03 ` Chris Packham
@ 2019-10-07 7:30 ` Geert Uytterhoeven
-1 siblings, 0 replies; 24+ messages in thread
From: Geert Uytterhoeven @ 2019-10-07 7:30 UTC (permalink / raw)
To: Chris Packham
Cc: Linus Walleij, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
rayagonda.kokatanur, li.jin, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, Linux ARM, Marc Zyngier
Hi Chris,
CC MarcZ
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
A while ago, Marc Zyngier pointed out that the irq_chip .name field
should contain the device's class name, not the instance's name.
Hence the current code is correct?
See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
(https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
Note that the irqchip patches in that series have been applied; the gpio
patches haven't been applied yet.
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> struct gpio_irq_chip *girq;
>
> irqc = &chip->irqchip;
> - irqc->name = "bcm-iproc-gpio";
> + irqc->name = dev_name(dev);
> irqc->irq_ack = iproc_gpio_irq_ack;
> irqc->irq_mask = iproc_gpio_irq_mask;
> irqc->irq_unmask = iproc_gpio_irq_unmask;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-07 7:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 24+ messages in thread
From: Geert Uytterhoeven @ 2019-10-07 7:30 UTC (permalink / raw)
To: Chris Packham
Cc: Scott Branden, rayagonda.kokatanur, Ray Jui, Linus Walleij,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
bcm-kernel-feedback-list, Marc Zyngier, li.jin, Linux ARM
Hi Chris,
CC MarcZ
On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Use the dev_name(dev) for the irqc->name so that we get unique names
> when we have multiple instances of this driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
A while ago, Marc Zyngier pointed out that the irq_chip .name field
should contain the device's class name, not the instance's name.
Hence the current code is correct?
See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
(https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
Note that the irqchip patches in that series have been applied; the gpio
patches haven't been applied yet.
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> struct gpio_irq_chip *girq;
>
> irqc = &chip->irqchip;
> - irqc->name = "bcm-iproc-gpio";
> + irqc->name = dev_name(dev);
> irqc->irq_ack = iproc_gpio_irq_ack;
> irqc->irq_mask = iproc_gpio_irq_mask;
> irqc->irq_unmask = iproc_gpio_irq_unmask;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-07 7:30 ` Geert Uytterhoeven
@ 2019-10-07 8:14 ` Marc Zyngier
-1 siblings, 0 replies; 24+ messages in thread
From: Marc Zyngier @ 2019-10-07 8:14 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Chris Packham, Linus Walleij, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List, Linux ARM
On Mon, 07 Oct 2019 08:30:50 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Chris,
>
> CC MarcZ
>
> On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > Use the dev_name(dev) for the irqc->name so that we get unique names
> > when we have multiple instances of this driver.
> >
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> A while ago, Marc Zyngier pointed out that the irq_chip .name field
> should contain the device's class name, not the instance's name.
> Hence the current code is correct?
Thanks Geert for looping me in. The main reasons why I oppose this
kind of "let's show as much information as we can in /proc/interrupts"
are:
- It clutters the output badly: the formatting of this file, which is
bad enough when you have a small number of CPUs, becomes unreadable
when you have a large number of them *and* stupidly long strings
that only make sense on a given platform.
- Like it or not, /proc is ABI. We don't change things randomly there
without a good reason, and debugging isn't one of them.
- Debug information belongs to debugfs, where we already have plenty
of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
this infrastructure if needed, rather than add platform specific
hacks.
</rant>
Thanks,
M.
>
> See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
> (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
> Note that the irqchip patches in that series have been applied; the gpio
> patches haven't been applied yet.
>
> > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> > struct gpio_irq_chip *girq;
> >
> > irqc = &chip->irqchip;
> > - irqc->name = "bcm-iproc-gpio";
> > + irqc->name = dev_name(dev);
> > irqc->irq_ack = iproc_gpio_irq_ack;
> > irqc->irq_mask = iproc_gpio_irq_mask;
> > irqc->irq_unmask = iproc_gpio_irq_unmask;
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Jazz is not dead, it just smells funny.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-07 8:14 ` Marc Zyngier
0 siblings, 0 replies; 24+ messages in thread
From: Marc Zyngier @ 2019-10-07 8:14 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Scott Branden, rayagonda.kokatanur, Ray Jui, Linus Walleij,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
Chris Packham, bcm-kernel-feedback-list, li.jin, Linux ARM
On Mon, 07 Oct 2019 08:30:50 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Chris,
>
> CC MarcZ
>
> On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > Use the dev_name(dev) for the irqc->name so that we get unique names
> > when we have multiple instances of this driver.
> >
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> A while ago, Marc Zyngier pointed out that the irq_chip .name field
> should contain the device's class name, not the instance's name.
> Hence the current code is correct?
Thanks Geert for looping me in. The main reasons why I oppose this
kind of "let's show as much information as we can in /proc/interrupts"
are:
- It clutters the output badly: the formatting of this file, which is
bad enough when you have a small number of CPUs, becomes unreadable
when you have a large number of them *and* stupidly long strings
that only make sense on a given platform.
- Like it or not, /proc is ABI. We don't change things randomly there
without a good reason, and debugging isn't one of them.
- Debug information belongs to debugfs, where we already have plenty
of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
this infrastructure if needed, rather than add platform specific
hacks.
</rant>
Thanks,
M.
>
> See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
> (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
> Note that the irqchip patches in that series have been applied; the gpio
> patches haven't been applied yet.
>
> > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> > struct gpio_irq_chip *girq;
> >
> > irqc = &chip->irqchip;
> > - irqc->name = "bcm-iproc-gpio";
> > + irqc->name = dev_name(dev);
> > irqc->irq_ack = iproc_gpio_irq_ack;
> > irqc->irq_mask = iproc_gpio_irq_mask;
> > irqc->irq_unmask = iproc_gpio_irq_unmask;
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Jazz is not dead, it just smells funny.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-07 8:14 ` Marc Zyngier
@ 2019-10-07 17:10 ` Scott Branden
-1 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-07 17:10 UTC (permalink / raw)
To: Marc Zyngier, Geert Uytterhoeven
Cc: Chris Packham, Linus Walleij, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, rayagonda.kokatanur, li.jin,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List, Linux ARM
On 2019-10-07 1:14 a.m., Marc Zyngier wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> Hi Chris,
>>
>> CC MarcZ
>>
>> On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
>> <chris.packham@alliedtelesis.co.nz> wrote:
>>> Use the dev_name(dev) for the irqc->name so that we get unique names
>>> when we have multiple instances of this driver.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> A while ago, Marc Zyngier pointed out that the irq_chip .name field
>> should contain the device's class name, not the instance's name.
>> Hence the current code is correct?
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> are:
>
> - It clutters the output badly: the formatting of this file, which is
> bad enough when you have a small number of CPUs, becomes unreadable
> when you have a large number of them *and* stupidly long strings
> that only make sense on a given platform.
>
> - Like it or not, /proc is ABI. We don't change things randomly there
> without a good reason, and debugging isn't one of them.
>
> - Debug information belongs to debugfs, where we already have plenty
> of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> this infrastructure if needed, rather than add platform specific
> hacks.
>
> </rant>
>
> Thanks,
>
> M.
Thanks Marc/Geert. Sounds like we should drop patch 2 from series.
>
>> See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
>> (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
>> Note that the irqchip patches in that series have been applied; the gpio
>> patches haven't been applied yet.
>>
>>> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
>>> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
>>> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>>> struct gpio_irq_chip *girq;
>>>
>>> irqc = &chip->irqchip;
>>> - irqc->name = "bcm-iproc-gpio";
>>> + irqc->name = dev_name(dev);
>>> irqc->irq_ack = iproc_gpio_irq_ack;
>>> irqc->irq_mask = iproc_gpio_irq_mask;
>>> irqc->irq_unmask = iproc_gpio_irq_unmask;
>> Gr{oetje,eeting}s,
>>
>> Geert
>>
>> --
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a hacker. But
>> when I'm talking to journalists I just say "programmer" or something like that.
>> -- Linus Torvalds
>>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-07 17:10 ` Scott Branden
0 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2019-10-07 17:10 UTC (permalink / raw)
To: Marc Zyngier, Geert Uytterhoeven
Cc: Scott Branden, rayagonda.kokatanur, Ray Jui, Linus Walleij,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
Chris Packham, bcm-kernel-feedback-list, li.jin, Linux ARM
On 2019-10-07 1:14 a.m., Marc Zyngier wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> Hi Chris,
>>
>> CC MarcZ
>>
>> On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
>> <chris.packham@alliedtelesis.co.nz> wrote:
>>> Use the dev_name(dev) for the irqc->name so that we get unique names
>>> when we have multiple instances of this driver.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> A while ago, Marc Zyngier pointed out that the irq_chip .name field
>> should contain the device's class name, not the instance's name.
>> Hence the current code is correct?
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> are:
>
> - It clutters the output badly: the formatting of this file, which is
> bad enough when you have a small number of CPUs, becomes unreadable
> when you have a large number of them *and* stupidly long strings
> that only make sense on a given platform.
>
> - Like it or not, /proc is ABI. We don't change things randomly there
> without a good reason, and debugging isn't one of them.
>
> - Debug information belongs to debugfs, where we already have plenty
> of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> this infrastructure if needed, rather than add platform specific
> hacks.
>
> </rant>
>
> Thanks,
>
> M.
Thanks Marc/Geert. Sounds like we should drop patch 2 from series.
>
>> See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
>> (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
>> Note that the irqchip patches in that series have been applied; the gpio
>> patches haven't been applied yet.
>>
>>> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
>>> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
>>> @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>>> struct gpio_irq_chip *girq;
>>>
>>> irqc = &chip->irqchip;
>>> - irqc->name = "bcm-iproc-gpio";
>>> + irqc->name = dev_name(dev);
>>> irqc->irq_ack = iproc_gpio_irq_ack;
>>> irqc->irq_mask = iproc_gpio_irq_mask;
>>> irqc->irq_unmask = iproc_gpio_irq_unmask;
>> Gr{oetje,eeting}s,
>>
>> Geert
>>
>> --
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a hacker. But
>> when I'm talking to journalists I just say "programmer" or something like that.
>> -- Linus Torvalds
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-07 8:14 ` Marc Zyngier
@ 2019-10-11 7:26 ` Linus Walleij
-1 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-11 7:26 UTC (permalink / raw)
To: Marc Zyngier
Cc: Geert Uytterhoeven, Chris Packham, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Rayagonda Kokatanur, Li Jin,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List, Linux ARM
On Mon, Oct 7, 2019 at 10:14 AM Marc Zyngier <maz@kernel.org> wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Chris,
> >
> > CC MarcZ
> >
> > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
> > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > when we have multiple instances of this driver.
> > >
> > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> >
> > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > should contain the device's class name, not the instance's name.
> > Hence the current code is correct?
>
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> are:
>
> - It clutters the output badly: the formatting of this file, which is
> bad enough when you have a small number of CPUs, becomes unreadable
> when you have a large number of them *and* stupidly long strings
> that only make sense on a given platform.
>
> - Like it or not, /proc is ABI. We don't change things randomly there
> without a good reason, and debugging isn't one of them.
>
> - Debug information belongs to debugfs, where we already have plenty
> of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> this infrastructure if needed, rather than add platform specific
> hacks.
>
> </rant>
I have reverted the patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-11 7:26 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2019-10-11 7:26 UTC (permalink / raw)
To: Marc Zyngier
Cc: Scott Branden, Rayagonda Kokatanur, Ray Jui,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
Chris Packham, Geert Uytterhoeven, Li Jin,
bcm-kernel-feedback-list, Linux ARM
On Mon, Oct 7, 2019 at 10:14 AM Marc Zyngier <maz@kernel.org> wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Chris,
> >
> > CC MarcZ
> >
> > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
> > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > when we have multiple instances of this driver.
> > >
> > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> >
> > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > should contain the device's class name, not the instance's name.
> > Hence the current code is correct?
>
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> are:
>
> - It clutters the output badly: the formatting of this file, which is
> bad enough when you have a small number of CPUs, becomes unreadable
> when you have a large number of them *and* stupidly long strings
> that only make sense on a given platform.
>
> - Like it or not, /proc is ABI. We don't change things randomly there
> without a good reason, and debugging isn't one of them.
>
> - Debug information belongs to debugfs, where we already have plenty
> of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> this infrastructure if needed, rather than add platform specific
> hacks.
>
> </rant>
I have reverted the patch.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
2019-10-07 17:10 ` Scott Branden
@ 2019-10-13 21:02 ` Chris Packham
-1 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-13 21:02 UTC (permalink / raw)
To: maz, scott.branden, geert
Cc: linux-kernel, bcm-kernel-feedback-list, linus.walleij,
linux-gpio, rjui, rayagonda.kokatanur, sbranden,
linux-arm-kernel, li.jin
Hi LinusW, Scott, Geert, MarcZ,
On Mon, 2019-10-07 at 10:10 -0700, Scott Branden wrote:
>
> On 2019-10-07 1:14 a.m., Marc Zyngier wrote:
> > On Mon, 07 Oct 2019 08:30:50 +0100,
> > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > Hi Chris,
> > >
> > > CC MarcZ
> > >
> > > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > > <chris.packham@alliedtelesis.co.nz> wrote:
> > > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > > when we have multiple instances of this driver.
> > > >
> > > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > >
> > > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > > should contain the device's class name, not the instance's name.
> > > Hence the current code is correct?
> >
> > Thanks Geert for looping me in. The main reasons why I oppose this
> > kind of "let's show as much information as we can in /proc/interrupts"
> > are:
> >
> > - It clutters the output badly: the formatting of this file, which is
> > bad enough when you have a small number of CPUs, becomes unreadable
> > when you have a large number of them *and* stupidly long strings
> > that only make sense on a given platform.
> >
> > - Like it or not, /proc is ABI. We don't change things randomly there
> > without a good reason, and debugging isn't one of them.
> >
> > - Debug information belongs to debugfs, where we already have plenty
> > of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> > this infrastructure if needed, rather than add platform specific
> > hacks.
> >
> > </rant>
> >
> > Thanks,
> >
> > M.
>
> Thanks Marc/Geert. Sounds like we should drop patch 2 from series.
Sorry for not responding earlier (I was on vacation for a week). I'm
fine with dropping this patch.
> >
> > > See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
> > > (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
> > > Note that the irqchip patches in that series have been applied; the gpio
> > > patches haven't been applied yet.
> > >
> > > > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > > > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > > > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> > > > struct gpio_irq_chip *girq;
> > > >
> > > > irqc = &chip->irqchip;
> > > > - irqc->name = "bcm-iproc-gpio";
> > > > + irqc->name = dev_name(dev);
> > > > irqc->irq_ack = iproc_gpio_irq_ack;
> > > > irqc->irq_mask = iproc_gpio_irq_mask;
> > > > irqc->irq_unmask = iproc_gpio_irq_unmask;
> > >
> > > Gr{oetje,eeting}s,
> > >
> > > Geert
> > >
> > > --
> > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> > >
> > > In personal conversations with technical people, I call myself a hacker. But
> > > when I'm talking to journalists I just say "programmer" or something like that.
> > > -- Linus Torvalds
> > >
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
@ 2019-10-13 21:02 ` Chris Packham
0 siblings, 0 replies; 24+ messages in thread
From: Chris Packham @ 2019-10-13 21:02 UTC (permalink / raw)
To: maz, scott.branden, geert
Cc: sbranden, rayagonda.kokatanur, rjui, linus.walleij, linux-kernel,
linux-gpio, bcm-kernel-feedback-list, li.jin, linux-arm-kernel
Hi LinusW, Scott, Geert, MarcZ,
On Mon, 2019-10-07 at 10:10 -0700, Scott Branden wrote:
>
> On 2019-10-07 1:14 a.m., Marc Zyngier wrote:
> > On Mon, 07 Oct 2019 08:30:50 +0100,
> > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > Hi Chris,
> > >
> > > CC MarcZ
> > >
> > > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > > <chris.packham@alliedtelesis.co.nz> wrote:
> > > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > > when we have multiple instances of this driver.
> > > >
> > > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > >
> > > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > > should contain the device's class name, not the instance's name.
> > > Hence the current code is correct?
> >
> > Thanks Geert for looping me in. The main reasons why I oppose this
> > kind of "let's show as much information as we can in /proc/interrupts"
> > are:
> >
> > - It clutters the output badly: the formatting of this file, which is
> > bad enough when you have a small number of CPUs, becomes unreadable
> > when you have a large number of them *and* stupidly long strings
> > that only make sense on a given platform.
> >
> > - Like it or not, /proc is ABI. We don't change things randomly there
> > without a good reason, and debugging isn't one of them.
> >
> > - Debug information belongs to debugfs, where we already have plenty
> > of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> > this infrastructure if needed, rather than add platform specific
> > hacks.
> >
> > </rant>
> >
> > Thanks,
> >
> > M.
>
> Thanks Marc/Geert. Sounds like we should drop patch 2 from series.
Sorry for not responding earlier (I was on vacation for a week). I'm
fine with dropping this patch.
> >
> > > See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
> > > (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
> > > Note that the irqchip patches in that series have been applied; the gpio
> > > patches haven't been applied yet.
> > >
> > > > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > > > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > > > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> > > > struct gpio_irq_chip *girq;
> > > >
> > > > irqc = &chip->irqchip;
> > > > - irqc->name = "bcm-iproc-gpio";
> > > > + irqc->name = dev_name(dev);
> > > > irqc->irq_ack = iproc_gpio_irq_ack;
> > > > irqc->irq_mask = iproc_gpio_irq_mask;
> > > > irqc->irq_unmask = iproc_gpio_irq_unmask;
> > >
> > > Gr{oetje,eeting}s,
> > >
> > > Geert
> > >
> > > --
> > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> > >
> > > In personal conversations with technical people, I call myself a hacker. But
> > > when I'm talking to journalists I just say "programmer" or something like that.
> > > -- Linus Torvalds
> > >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2019-10-13 21:04 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 0:03 [PATCH v2 0/2] pinctrl: iproc: improve error handling Chris Packham
2019-10-03 0:03 ` Chris Packham
2019-10-03 0:03 ` [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq() Chris Packham
2019-10-03 0:03 ` Chris Packham
2019-10-03 18:36 ` Scott Branden
2019-10-03 18:36 ` Scott Branden
2019-10-05 16:35 ` Linus Walleij
2019-10-05 16:35 ` Linus Walleij
2019-10-03 0:03 ` [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip Chris Packham
2019-10-03 0:03 ` Chris Packham
2019-10-03 18:36 ` Scott Branden
2019-10-03 18:36 ` Scott Branden
2019-10-05 16:37 ` Linus Walleij
2019-10-05 16:37 ` Linus Walleij
2019-10-07 7:30 ` Geert Uytterhoeven
2019-10-07 7:30 ` Geert Uytterhoeven
2019-10-07 8:14 ` Marc Zyngier
2019-10-07 8:14 ` Marc Zyngier
2019-10-07 17:10 ` Scott Branden
2019-10-07 17:10 ` Scott Branden
2019-10-13 21:02 ` Chris Packham
2019-10-13 21:02 ` Chris Packham
2019-10-11 7:26 ` Linus Walleij
2019-10-11 7:26 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.