Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Rob,

On Wed, Jan 27, 2021 at 3:00 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, 26 Jan 2021 17:39:55 +0100, Geert Uytterhoeven wrote:
> >   - Remove unneeded reference for "idt,slew-percent", as vendor specific
> >     properties having a standard unit suffix don't need a type,
> >   - Add missing "additionalProperties: false" for subnodes, to catch
> >     typos in properties,
> >   - Fix property names in example.
> >
> > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
> > https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be

>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
>         'type' is a required property
>         Additional properties are not allowed ('enum' was unexpected)
>         /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
>                 '$ref' is a required property
>                 'allOf' is a required property
>         80 is not of type 'string'
>         85 is not of type 'string'
>         90 is not of type 'string'
>         100 is not of type 'string'
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: ignoring, error in schema: patternProperties: ^OUT[1-4]$: properties: idt,slew-percent
> warning: no schema found in file: ./Documentation/devicetree/bindings/clock/idt,versaclock5.yaml

Yep, your bot didn't take into account the dependencies mentioned above ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds