From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Luca Ceresoli <luca@lucaceresoli.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Adam Ford <aford173@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
Date: Tue, 26 Jan 2021 17:39:55 +0100 [thread overview]
Message-ID: <20210126163955.1933893-1-geert+renesas@glider.be> (raw)
- Remove unneeded reference for "idt,slew-percent", as vendor specific
properties having a standard unit suffix don't need a type,
- Add missing "additionalProperties: false" for subnodes, to catch
typos in properties,
- Fix property names in example.
Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
v3:
- Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
v2:
- Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
('clk: vc5: Use "idt,voltage-microvolt" instead of
"idt,voltage-microvolts"'),
- Drop reference to clock.yaml, which is already applied
unconditionally,
- Drop removal of allOf around if condition, as it is unnecessary
churn.
---
.../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index 2ac1131fd9222a86..116ecce758bc22cf 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -78,9 +78,10 @@ patternProperties:
enum: [ 1800000, 2500000, 3300000 ]
idt,slew-percent:
description: The Slew rate control for CMOS single-ended.
- $ref: /schemas/types.yaml#/definitions/uint32
enum: [ 80, 85, 90, 100 ]
+ additionalProperties: false
+
required:
- compatible
- reg
@@ -135,13 +136,13 @@ examples:
clock-names = "xin";
OUT1 {
- idt,drive-mode = <VC5_CMOSD>;
- idt,voltage-microvolts = <1800000>;
+ idt,mode = <VC5_CMOSD>;
+ idt,voltage-microvolt = <1800000>;
idt,slew-percent = <80>;
};
OUT4 {
- idt,drive-mode = <VC5_LVDS>;
+ idt,mode = <VC5_LVDS>;
};
};
};
--
2.25.1
next reply other threads:[~2021-01-27 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 16:39 Geert Uytterhoeven [this message]
2021-01-27 14:00 ` [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Rob Herring
2021-01-27 14:23 ` Geert Uytterhoeven
2021-01-27 14:36 ` Luca Ceresoli
2021-02-04 15:57 ` Rob Herring
2021-02-05 3:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126163955.1933893-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.