From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tom Rix <trix@redhat.com>
Cc: Helge Deller <deller@gmx.de>,
Thomas Zimmermann <tzimmermann@suse.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: remove setting of 'transp' parameter
Date: Sun, 22 May 2022 12:30:23 +0200 [thread overview]
Message-ID: <CAMuHMdVELy4M2Xog+NykEpb=k5sw+B1iYzC6O1Otsz75qMWBRA@mail.gmail.com> (raw)
In-Reply-To: <20220521195942.645048-1-trix@redhat.com>
On Sun, May 22, 2022 at 3:22 AM Tom Rix <trix@redhat.com> wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tom Rix <trix@redhat.com>
Cc: Juergen Gross <jgross@suse.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Helge Deller <deller@gmx.de>,
Javier Martinez Canillas <javierm@redhat.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen: remove setting of 'transp' parameter
Date: Sun, 22 May 2022 12:30:23 +0200 [thread overview]
Message-ID: <CAMuHMdVELy4M2Xog+NykEpb=k5sw+B1iYzC6O1Otsz75qMWBRA@mail.gmail.com> (raw)
In-Reply-To: <20220521195942.645048-1-trix@redhat.com>
On Sun, May 22, 2022 at 3:22 AM Tom Rix <trix@redhat.com> wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-05-22 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 19:59 [PATCH] xen: remove setting of 'transp' parameter Tom Rix
2022-05-21 19:59 ` Tom Rix
2022-05-22 10:30 ` Geert Uytterhoeven [this message]
2022-05-22 10:30 ` Geert Uytterhoeven
2022-05-23 7:02 ` Juergen Gross
2022-05-23 7:02 ` Juergen Gross
2022-05-25 12:17 ` Helge Deller
2022-05-25 12:17 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVELy4M2Xog+NykEpb=k5sw+B1iYzC6O1Otsz75qMWBRA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=boris.ostrovsky@oracle.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jgross@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.