* [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture
@ 2014-08-04 18:24 Chen Gang
2014-08-04 19:23 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2014-08-04 18:24 UTC (permalink / raw)
To: isdn; +Cc: davem, Jean Delvare, netdev, linux-kernel, monstr
For HISAX_NETJET, HISAX_NETJET_U or related config needs !__BIG_ENDIAN,
so skip microblaze, just like skip all other architectures which have
no CONFIG_*_ENDIAN.
The related error (with allmodconfig under microblaze):
CC [M] drivers/isdn/hisax/nj_s.o
drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
#error "not running on big endian machines now"
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/isdn/hisax/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
index 97465ac..eb83d94 100644
--- a/drivers/isdn/hisax/Kconfig
+++ b/drivers/isdn/hisax/Kconfig
@@ -237,7 +237,7 @@ config HISAX_MIC
config HISAX_NETJET
bool "NETjet card"
- depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
depends on VIRT_TO_BUS
help
This enables HiSax support for the NetJet from Traverse
@@ -249,7 +249,7 @@ config HISAX_NETJET
config HISAX_NETJET_U
bool "NETspider U card"
- depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
depends on VIRT_TO_BUS
help
This enables HiSax support for the Netspider U interface ISDN card
--
1.7.11.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture
2014-08-04 18:24 [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture Chen Gang
@ 2014-08-04 19:23 ` Jean Delvare
2014-08-04 19:44 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2014-08-04 19:23 UTC (permalink / raw)
To: Chen Gang; +Cc: isdn, davem, netdev, linux-kernel, monstr
Hi Chen Gang,
On Tue, 05 Aug 2014 02:24:09 +0800, Chen Gang wrote:
> For HISAX_NETJET, HISAX_NETJET_U or related config needs !__BIG_ENDIAN,
> so skip microblaze, just like skip all other architectures which have
> no CONFIG_*_ENDIAN.
>
> The related error (with allmodconfig under microblaze):
>
> CC [M] drivers/isdn/hisax/nj_s.o
> drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
> drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
> #error "not running on big endian machines now"
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/isdn/hisax/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
> index 97465ac..eb83d94 100644
> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -237,7 +237,7 @@ config HISAX_MIC
>
> config HISAX_NETJET
> bool "NETjet card"
> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
> depends on VIRT_TO_BUS
> help
> This enables HiSax support for the NetJet from Traverse
> @@ -249,7 +249,7 @@ config HISAX_NETJET
>
> config HISAX_NETJET_U
> bool "NETspider U card"
> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
> depends on VIRT_TO_BUS
> help
> This enables HiSax support for the Netspider U interface ISDN card
Fine with me, however the list is getting long. It would be better if
we could depend on a functional symbol rather than a negated list of
architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN
defined on all little-endian architectures, so that driver can depend
on that if needed?
Alternatively, it might make more sense to list the architectures where
these drivers are actually used in practice. I guess that's X86, maybe
ARM and IA64, and that's all?
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture
2014-08-04 19:23 ` Jean Delvare
@ 2014-08-04 19:44 ` Geert Uytterhoeven
2014-08-05 4:21 ` Chen Gang
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2014-08-04 19:44 UTC (permalink / raw)
To: Jean Delvare
Cc: Chen Gang, Karsten Keil, David S. Miller, netdev, linux-kernel,
Michal Simek
On Mon, Aug 4, 2014 at 9:23 PM, Jean Delvare <jdelvare@suse.de> wrote:
>> --- a/drivers/isdn/hisax/Kconfig
>> +++ b/drivers/isdn/hisax/Kconfig
>> @@ -237,7 +237,7 @@ config HISAX_MIC
>>
>> config HISAX_NETJET
>> bool "NETjet card"
>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>> depends on VIRT_TO_BUS
>> help
>> This enables HiSax support for the NetJet from Traverse
>> @@ -249,7 +249,7 @@ config HISAX_NETJET
>>
>> config HISAX_NETJET_U
>> bool "NETspider U card"
>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>> depends on VIRT_TO_BUS
>> help
>> This enables HiSax support for the Netspider U interface ISDN card
>
> Fine with me, however the list is getting long. It would be better if
> we could depend on a functional symbol rather than a negated list of
> architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN
> defined on all little-endian architectures, so that driver can depend
> on that if needed?
Yes, that idea pops up once in a while.
BTW, these days little endian PPC is also supported by Linux...
> Alternatively, it might make more sense to list the architectures where
> these drivers are actually used in practice. I guess that's X86, maybe
> ARM and IA64, and that's all?
|| COMPILE_TEST ....
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture
2014-08-04 19:44 ` Geert Uytterhoeven
@ 2014-08-05 4:21 ` Chen Gang
2014-08-05 16:30 ` Chen Gang
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2014-08-05 4:21 UTC (permalink / raw)
To: Geert Uytterhoeven, Jean Delvare
Cc: Karsten Keil, David S. Miller, netdev, linux-kernel, Michal Simek
On 08/05/2014 03:44 AM, Geert Uytterhoeven wrote:
> On Mon, Aug 4, 2014 at 9:23 PM, Jean Delvare <jdelvare@suse.de> wrote:
>>> --- a/drivers/isdn/hisax/Kconfig
>>> +++ b/drivers/isdn/hisax/Kconfig
>>> @@ -237,7 +237,7 @@ config HISAX_MIC
>>>
>>> config HISAX_NETJET
>>> bool "NETjet card"
>>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>>> depends on VIRT_TO_BUS
>>> help
>>> This enables HiSax support for the NetJet from Traverse
>>> @@ -249,7 +249,7 @@ config HISAX_NETJET
>>>
>>> config HISAX_NETJET_U
>>> bool "NETspider U card"
>>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>>> depends on VIRT_TO_BUS
>>> help
>>> This enables HiSax support for the Netspider U interface ISDN card
>>
>> Fine with me, however the list is getting long. It would be better if
>> we could depend on a functional symbol rather than a negated list of
>> architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN
>> defined on all little-endian architectures, so that driver can depend
>> on that if needed?
>
> Yes, that idea pops up once in a while.
>
> BTW, these days little endian PPC is also supported by Linux...
>
>> Alternatively, it might make more sense to list the architectures where
>> these drivers are actually used in practice. I guess that's X86, maybe
>> ARM and IA64, and that's all?
>
> || COMPILE_TEST ....
>
OK, thanks, what all of you said sounds reasonable to me.
Hello Geert:
Could you help send the related patch for it?
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture
2014-08-05 4:21 ` Chen Gang
@ 2014-08-05 16:30 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2014-08-05 16:30 UTC (permalink / raw)
To: Geert Uytterhoeven, Jean Delvare
Cc: Karsten Keil, David S. Miller, netdev, linux-kernel,
Michal Simek, Arnd Bergmann
On 08/05/2014 12:21 PM, Chen Gang wrote:
>
>
> On 08/05/2014 03:44 AM, Geert Uytterhoeven wrote:
>> On Mon, Aug 4, 2014 at 9:23 PM, Jean Delvare <jdelvare@suse.de> wrote:
>>>> --- a/drivers/isdn/hisax/Kconfig
>>>> +++ b/drivers/isdn/hisax/Kconfig
>>>> @@ -237,7 +237,7 @@ config HISAX_MIC
>>>>
>>>> config HISAX_NETJET
>>>> bool "NETjet card"
>>>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>>>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>>>> depends on VIRT_TO_BUS
>>>> help
>>>> This enables HiSax support for the NetJet from Traverse
>>>> @@ -249,7 +249,7 @@ config HISAX_NETJET
>>>>
>>>> config HISAX_NETJET_U
>>>> bool "NETspider U card"
>>>> - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>>>> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE))
>>>> depends on VIRT_TO_BUS
>>>> help
>>>> This enables HiSax support for the Netspider U interface ISDN card
>>>
>>> Fine with me, however the list is getting long. It would be better if
>>> we could depend on a functional symbol rather than a negated list of
>>> architectures. Would it make sense to have CONFIG_CPU_LITTLE_ENDIAN
>>> defined on all little-endian architectures, so that driver can depend
>>> on that if needed?
>>
>> Yes, that idea pops up once in a while.
>>
>> BTW, these days little endian PPC is also supported by Linux...
>>
>>> Alternatively, it might make more sense to list the architectures where
>>> these drivers are actually used in practice. I guess that's X86, maybe
>>> ARM and IA64, and that's all?
>>
>> || COMPILE_TEST ....
>>
>
If no additional response within 3 days, I shall continue to try to send
patch for it.
Excuse me, I need additional thinking of for it, so I plan to send patch
for discussing and review within next week end (2014-08-17).
And welcome any members' ideas, suggestions and completions.
Thanks.
> OK, thanks, what all of you said sounds reasonable to me.
>
> Hello Geert:
>
> Could you help send the related patch for it?
>
>
> Thanks.
>
--
Chen Gang
Open share and attitude like air water and life which God blessed
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-05 16:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04 18:24 [PATCH] drivers/isdn/hisax/Kconfig: Let HISAX_NETJET skip microblaze architecture Chen Gang
2014-08-04 19:23 ` Jean Delvare
2014-08-04 19:44 ` Geert Uytterhoeven
2014-08-05 4:21 ` Chen Gang
2014-08-05 16:30 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.