* Re: Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 5:27 ` MyungJoo Ham
0 siblings, 0 replies; 10+ messages in thread
From: MyungJoo Ham @ 2014-08-21 5:27 UTC (permalink / raw)
To: 최찬우, Geert Uytterhoeven
Cc: Mark Brown, Greg Kroah-Hartman, linux-kernel, linux-i2c, linux-spi
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2532 bytes --]
> Hi Geert
>
> Thanks for your report. I already sent a patch[1] to fix this build break
> and I'll send pull request to includec this patch in 3.17-rc2.
>
> [1] https://lkml.org/lkml/2014/8/13/761
>
> Best Regards,
> Chanwoo Choi
I do not object to this patch or your patch[1].
However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
When you use REGMAP_I2C, you assume that I2C is already there, don't you?
Cheers,
MyungJoo
>
>
> On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
> > EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
> >
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_byte_reg_read¡¯:
> > drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ¡®i2c_smbus_read_byte_data¡¯
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_byte_reg_write¡¯:
> > drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ¡®i2c_smbus_write_byte_data¡¯
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_word_reg_read¡¯:
> > drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ¡®i2c_smbus_read_word_data¡¯
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_word_reg_write¡¯:
> > drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ¡®i2c_smbus_write_word_data¡¯
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_i2c_write¡¯:
> > drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ¡®i2c_master_send¡¯
> > drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_i2c_gather_write¡¯:
> > drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ¡®i2c_check_functionality¡¯
> > drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ¡®i2c_transfer¡¯
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > drivers/extcon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> > index 6f2f4727de2c..764f3a113e0a 100644
> > --- a/drivers/extcon/Kconfig
> > +++ b/drivers/extcon/Kconfig
> > @@ -72,6 +72,7 @@ config EXTCON_PALMAS
> >
> > config EXTCON_SM5502
> > tristate "SM5502 EXTCON support"
> > + depends on I2C
> > select IRQ_DOMAIN
> > select REGMAP_I2C
> > select REGMAP_IRQ
> >
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 5:27 ` MyungJoo Ham
0 siblings, 0 replies; 10+ messages in thread
From: MyungJoo Ham @ 2014-08-21 5:27 UTC (permalink / raw)
To: 최찬우, Geert Uytterhoeven
Cc: Mark Brown, Greg Kroah-Hartman,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-spi-u79uwXL29TY76Z2rM5mHXA
> Hi Geert
>
> Thanks for your report. I already sent a patch[1] to fix this build break
> and I'll send pull request to includec this patch in 3.17-rc2.
>
> [1] https://lkml.org/lkml/2014/8/13/761
>
> Best Regards,
> Chanwoo Choi
I do not object to this patch or your patch[1].
However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
When you use REGMAP_I2C, you assume that I2C is already there, don't you?
Cheers,
MyungJoo
>
>
> On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
> > EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
> >
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
> > drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
> > drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
> > drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
> > drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
> > drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
> > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
> > drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
> > drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > drivers/extcon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> > index 6f2f4727de2c..764f3a113e0a 100644
> > --- a/drivers/extcon/Kconfig
> > +++ b/drivers/extcon/Kconfig
> > @@ -72,6 +72,7 @@ config EXTCON_PALMAS
> >
> > config EXTCON_SM5502
> > tristate "SM5502 EXTCON support"
> > + depends on I2C
> > select IRQ_DOMAIN
> > select REGMAP_I2C
> > select REGMAP_IRQ
> >
>
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
2014-08-21 5:27 ` MyungJoo Ham
@ 2014-08-21 5:45 ` Chanwoo Choi
-1 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2014-08-21 5:45 UTC (permalink / raw)
To: myungjoo.ham
Cc: Geert Uytterhoeven, Mark Brown, Greg Kroah-Hartman, linux-kernel,
linux-i2c, linux-spi
Dear Myungjoo,
On 08/21/2014 02:27 PM, MyungJoo Ham wrote:
>> Hi Geert
>>
>> Thanks for your report. I already sent a patch[1] to fix this build break
>> and I'll send pull request to includec this patch in 3.17-rc2.
>>
>> [1] https://lkml.org/lkml/2014/8/13/761
>>
>> Best Regards,
>> Chanwoo Choi
>
> I do not object to this patch or your patch[1].
>
> However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
> When you use REGMAP_I2C, you assume that I2C is already there, don't you?
The previous REGMAP_I2C has not the dependency on I2C.
So, Greert posted following patch[1] to fix it.
[1] https://lkml.org/lkml/2014/8/17/27
Also, if I2C is 'm' (module) and some driver has not dependency on I2C,
build break happen.
Thanks
Chanwoo Choi,
>
>
> Cheers,
> MyungJoo
>
>>
>>
>> On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
>>> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
>>>
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
>>> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
>>> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
>>> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
>>> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
>>> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
>>> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
>>> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> ---
>>> drivers/extcon/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>>> index 6f2f4727de2c..764f3a113e0a 100644
>>> --- a/drivers/extcon/Kconfig
>>> +++ b/drivers/extcon/Kconfig
>>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>>>
>>> config EXTCON_SM5502
>>> tristate "SM5502 EXTCON support"
>>> + depends on I2C
>>> select IRQ_DOMAIN
>>> select REGMAP_I2C
>>> select REGMAP_IRQ
>>>
>>
>>
>>
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 5:45 ` Chanwoo Choi
0 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2014-08-21 5:45 UTC (permalink / raw)
To: myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ
Cc: Geert Uytterhoeven, Mark Brown, Greg Kroah-Hartman,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-spi-u79uwXL29TY76Z2rM5mHXA
Dear Myungjoo,
On 08/21/2014 02:27 PM, MyungJoo Ham wrote:
>> Hi Geert
>>
>> Thanks for your report. I already sent a patch[1] to fix this build break
>> and I'll send pull request to includec this patch in 3.17-rc2.
>>
>> [1] https://lkml.org/lkml/2014/8/13/761
>>
>> Best Regards,
>> Chanwoo Choi
>
> I do not object to this patch or your patch[1].
>
> However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
> When you use REGMAP_I2C, you assume that I2C is already there, don't you?
The previous REGMAP_I2C has not the dependency on I2C.
So, Greert posted following patch[1] to fix it.
[1] https://lkml.org/lkml/2014/8/17/27
Also, if I2C is 'm' (module) and some driver has not dependency on I2C,
build break happen.
Thanks
Chanwoo Choi,
>
>
> Cheers,
> MyungJoo
>
>>
>>
>> On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
>>> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
>>>
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
>>> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
>>> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
>>> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
>>> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
>>> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
>>> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
>>> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
>>> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
>>> ---
>>> drivers/extcon/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>>> index 6f2f4727de2c..764f3a113e0a 100644
>>> --- a/drivers/extcon/Kconfig
>>> +++ b/drivers/extcon/Kconfig
>>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>>>
>>> config EXTCON_SM5502
>>> tristate "SM5502 EXTCON support"
>>> + depends on I2C
>>> select IRQ_DOMAIN
>>> select REGMAP_I2C
>>> select REGMAP_IRQ
>>>
>>
>>
>>
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 7:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2014-08-21 7:10 UTC (permalink / raw)
To: Chanwoo Choi
Cc: myungjoo.ham, Mark Brown, Greg Kroah-Hartman, linux-kernel,
linux-i2c, linux-spi
On Thu, Aug 21, 2014 at 7:45 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> On 08/21/2014 02:27 PM, MyungJoo Ham wrote:
>>> Thanks for your report. I already sent a patch[1] to fix this build break
>>> and I'll send pull request to includec this patch in 3.17-rc2.
>>>
>>> [1] https://lkml.org/lkml/2014/8/13/761
>>>
>>> Best Regards,
>>> Chanwoo Choi
>>
>> I do not object to this patch or your patch[1].
>>
>> However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
>> When you use REGMAP_I2C, you assume that I2C is already there, don't you?
REGMAP_I2C is meant to be "select"ed by its users. So these users
should depend on I2C, as "select" does not check dependencies.
> The previous REGMAP_I2C has not the dependency on I2C.
> So, Greert posted following patch[1] to fix it.
> [1] https://lkml.org/lkml/2014/8/17/27
>
> Also, if I2C is 'm' (module) and some driver has not dependency on I2C,
> build break happen.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 7:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2014-08-21 7:10 UTC (permalink / raw)
To: Chanwoo Choi
Cc: myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ, Mark Brown,
Greg Kroah-Hartman, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-spi-u79uwXL29TY76Z2rM5mHXA
On Thu, Aug 21, 2014 at 7:45 AM, Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> On 08/21/2014 02:27 PM, MyungJoo Ham wrote:
>>> Thanks for your report. I already sent a patch[1] to fix this build break
>>> and I'll send pull request to includec this patch in 3.17-rc2.
>>>
>>> [1] https://lkml.org/lkml/2014/8/13/761
>>>
>>> Best Regards,
>>> Chanwoo Choi
>>
>> I do not object to this patch or your patch[1].
>>
>> However, wouldn't it be better to add depends on I2C at REGMAP_I2C?
>> When you use REGMAP_I2C, you assume that I2C is already there, don't you?
REGMAP_I2C is meant to be "select"ed by its users. So these users
should depend on I2C, as "select" does not check dependencies.
> The previous REGMAP_I2C has not the dependency on I2C.
> So, Greert posted following patch[1] to fix it.
> [1] https://lkml.org/lkml/2014/8/17/27
>
> Also, if I2C is 'm' (module) and some driver has not dependency on I2C,
> build break happen.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 2:18 ` Chanwoo Choi
0 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2014-08-21 2:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mark Brown, Greg Kroah-Hartman, MyungJoo Ham, linux-kernel,
linux-i2c, linux-spi
Hi Geert
Thanks for your report. I already sent a patch[1] to fix this build break
and I'll send pull request to includec this patch in 3.17-rc2.
[1] https://lkml.org/lkml/2014/8/13/761
Best Regards,
Chanwoo Choi
On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
>
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 6f2f4727de2c..764f3a113e0a 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>
> config EXTCON_SM5502
> tristate "SM5502 EXTCON support"
> + depends on I2C
> select IRQ_DOMAIN
> select REGMAP_I2C
> select REGMAP_IRQ
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-21 2:18 ` Chanwoo Choi
0 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2014-08-21 2:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mark Brown, Greg Kroah-Hartman, MyungJoo Ham,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-spi-u79uwXL29TY76Z2rM5mHXA
Hi Geert
Thanks for your report. I already sent a patch[1] to fix this build break
and I'll send pull request to includec this patch in 3.17-rc2.
[1] https://lkml.org/lkml/2014/8/13/761
Best Regards,
Chanwoo Choi
On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
>
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
> drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
>
> Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 6f2f4727de2c..764f3a113e0a 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>
> config EXTCON_SM5502
> tristate "SM5502 EXTCON support"
> + depends on I2C
> select IRQ_DOMAIN
> select REGMAP_I2C
> select REGMAP_IRQ
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-17 10:08 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2014-08-17 10:08 UTC (permalink / raw)
To: Mark Brown, Greg Kroah-Hartman, MyungJoo Ham, Chanwoo Choi
Cc: linux-kernel, linux-i2c, linux-spi, Geert Uytterhoeven
EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 6f2f4727de2c..764f3a113e0a 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
config EXTCON_SM5502
tristate "SM5502 EXTCON support"
+ depends on I2C
select IRQ_DOMAIN
select REGMAP_I2C
select REGMAP_IRQ
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C
@ 2014-08-17 10:08 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2014-08-17 10:08 UTC (permalink / raw)
To: Mark Brown, Greg Kroah-Hartman, MyungJoo Ham, Chanwoo Choi
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-spi-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’:
drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’:
drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’:
drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’:
drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’:
drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’
drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’:
drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’
drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’
Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 6f2f4727de2c..764f3a113e0a 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
config EXTCON_SM5502
tristate "SM5502 EXTCON support"
+ depends on I2C
select IRQ_DOMAIN
select REGMAP_I2C
select REGMAP_IRQ
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-21 7:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-21 5:27 Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C MyungJoo Ham
2014-08-21 5:27 ` MyungJoo Ham
2014-08-21 5:45 ` Chanwoo Choi
2014-08-21 5:45 ` Chanwoo Choi
2014-08-21 7:10 ` Geert Uytterhoeven
2014-08-21 7:10 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2014-08-17 10:08 [PATCH 1/2] regmap: Add eplicit dependencies to catch "select" misuse Geert Uytterhoeven
2014-08-17 10:08 ` [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C Geert Uytterhoeven
2014-08-17 10:08 ` Geert Uytterhoeven
2014-08-21 2:18 ` Chanwoo Choi
2014-08-21 2:18 ` Chanwoo Choi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.