All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
@ 2021-01-19 13:33 Wolfram Sang
  2021-01-19 18:43 ` Adam Ford
  2021-01-22  9:58 ` Geert Uytterhoeven
  0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-01-19 13:33 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Geert Uytterhoeven, Wolfram Sang

Some SDHI instances are solely used for eMMC. Disable SD and SDIO
for faster initialization.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

I recall that ARM64 maintainers prefer such changes in one block and not
individual patches. If that's not true, I can convert, of course.

 arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi | 2 ++
 arch/arm64/boot/dts/renesas/hihope-common.dtsi      | 2 ++
 arch/arm64/boot/dts/renesas/r8a77980-condor.dts     | 2 ++
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts      | 2 ++
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts      | 2 ++
 arch/arm64/boot/dts/renesas/salvator-common.dtsi    | 2 ++
 arch/arm64/boot/dts/renesas/ulcb.dtsi               | 2 ++
 7 files changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
index f4201e1c2226..c9bf5234dbd0 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
@@ -312,6 +312,8 @@ &sdhi3 {
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	no-sd;
+	no-sdio;
 	non-removable;
 	fixed-emmc-driver-type = <1>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 2eda9f66ae81..7a3da9b06f67 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -328,6 +328,8 @@ &sdhi3 {
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	no-sd;
+	no-sdio;
 	non-removable;
 	fixed-emmc-driver-type = <1>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
index 422ec53740cb..04d47c0c9bb9 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
@@ -217,6 +217,8 @@ &mmc0 {
 	vqmmc-supply = <&vddq_vin01>;
 	mmc-hs200-1_8v;
 	bus-width = <8>;
+	no-sd;
+	no-sdio;
 	non-removable;
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index e0ccca2222d2..f74f8b9993f1 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -712,6 +712,8 @@ &sdhi3 {
 	mmc-hs200-1_8v;
 	mmc-hs400-1_8v;
 	bus-width = <8>;
+	no-sd;
+	no-sdio;
 	non-removable;
 	full-pwr-cycle-in-suspend;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 8f471881b7a3..6783c3ad0856 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -496,6 +496,8 @@ &sdhi2 {
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	no-sd;
+	no-sdio;
 	non-removable;
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 6c643ed74fc5..c22bb38994e8 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -831,6 +831,8 @@ &sdhi2 {
 	bus-width = <8>;
 	mmc-hs200-1_8v;
 	mmc-hs400-1_8v;
+	no-sd;
+	no-sdio;
 	non-removable;
 	fixed-emmc-driver-type = <1>;
 	full-pwr-cycle-in-suspend;
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 8f8d7371d8e2..a04eae55dd6c 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -468,6 +468,8 @@ &sdhi2 {
 	bus-width = <8>;
 	mmc-hs200-1_8v;
 	mmc-hs400-1_8v;
+	no-sd;
+	no-sdio;
 	non-removable;
 	full-pwr-cycle-in-suspend;
 	status = "okay";
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
  2021-01-19 13:33 [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC Wolfram Sang
@ 2021-01-19 18:43 ` Adam Ford
  2021-01-19 20:35   ` Geert Uytterhoeven
  2021-01-22  9:58 ` Geert Uytterhoeven
  1 sibling, 1 reply; 6+ messages in thread
From: Adam Ford @ 2021-01-19 18:43 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Linux-Renesas, Geert Uytterhoeven

On Tue, Jan 19, 2021 at 8:48 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Some SDHI instances are solely used for eMMC. Disable SD and SDIO
> for faster initialization.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> I recall that ARM64 maintainers prefer such changes in one block and not
> individual patches. If that's not true, I can convert, of course.
>
>  arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi | 2 ++
>  arch/arm64/boot/dts/renesas/hihope-common.dtsi      | 2 ++
>  arch/arm64/boot/dts/renesas/r8a77980-condor.dts     | 2 ++
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts      | 2 ++
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts      | 2 ++
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi    | 2 ++
>  arch/arm64/boot/dts/renesas/ulcb.dtsi               | 2 ++
>  7 files changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> index f4201e1c2226..c9bf5234dbd0 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> @@ -312,6 +312,8 @@ &sdhi3 {
>         vqmmc-supply = <&reg_1p8v>;
>         bus-width = <8>;
>         mmc-hs200-1_8v;
> +       no-sd;
> +       no-sdio;

No objections on the Beacon board.   I cannot speak for the rest.

adam
>         non-removable;
>         fixed-emmc-driver-type = <1>;
>         status = "okay";
> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> index 2eda9f66ae81..7a3da9b06f67 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -328,6 +328,8 @@ &sdhi3 {
>         vqmmc-supply = <&reg_1p8v>;
>         bus-width = <8>;
>         mmc-hs200-1_8v;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         fixed-emmc-driver-type = <1>;
>         status = "okay";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> index 422ec53740cb..04d47c0c9bb9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> @@ -217,6 +217,8 @@ &mmc0 {
>         vqmmc-supply = <&vddq_vin01>;
>         mmc-hs200-1_8v;
>         bus-width = <8>;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index e0ccca2222d2..f74f8b9993f1 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -712,6 +712,8 @@ &sdhi3 {
>         mmc-hs200-1_8v;
>         mmc-hs400-1_8v;
>         bus-width = <8>;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         full-pwr-cycle-in-suspend;
>         status = "okay";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index 8f471881b7a3..6783c3ad0856 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -496,6 +496,8 @@ &sdhi2 {
>         vqmmc-supply = <&reg_1p8v>;
>         bus-width = <8>;
>         mmc-hs200-1_8v;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 6c643ed74fc5..c22bb38994e8 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -831,6 +831,8 @@ &sdhi2 {
>         bus-width = <8>;
>         mmc-hs200-1_8v;
>         mmc-hs400-1_8v;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         fixed-emmc-driver-type = <1>;
>         full-pwr-cycle-in-suspend;
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> index 8f8d7371d8e2..a04eae55dd6c 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -468,6 +468,8 @@ &sdhi2 {
>         bus-width = <8>;
>         mmc-hs200-1_8v;
>         mmc-hs400-1_8v;
> +       no-sd;
> +       no-sdio;
>         non-removable;
>         full-pwr-cycle-in-suspend;
>         status = "okay";
> --
> 2.29.2
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
  2021-01-19 18:43 ` Adam Ford
@ 2021-01-19 20:35   ` Geert Uytterhoeven
  2021-01-19 20:46     ` Adam Ford
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-19 20:35 UTC (permalink / raw)
  To: Adam Ford; +Cc: Wolfram Sang, Linux-Renesas

Hi Adam,

On Tue, Jan 19, 2021 at 7:43 PM Adam Ford <aford173@gmail.com> wrote:
> On Tue, Jan 19, 2021 at 8:48 AM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> >
> > Some SDHI instances are solely used for eMMC. Disable SD and SDIO
> > for faster initialization.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> > --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > @@ -312,6 +312,8 @@ &sdhi3 {
> >         vqmmc-supply = <&reg_1p8v>;
> >         bus-width = <8>;
> >         mmc-hs200-1_8v;
> > +       no-sd;
> > +       no-sdio;
>
> No objections on the Beacon board.   I cannot speak for the rest.

Does this mean I can add your

    Acked-by: Adam Ford <aford173@gmail.com> [beacon]

?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
  2021-01-19 20:35   ` Geert Uytterhoeven
@ 2021-01-19 20:46     ` Adam Ford
  2021-01-19 20:52       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Adam Ford @ 2021-01-19 20:46 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Wolfram Sang, Linux-Renesas

On Tue, Jan 19, 2021 at 2:35 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Adam,
>
> On Tue, Jan 19, 2021 at 7:43 PM Adam Ford <aford173@gmail.com> wrote:
> > On Tue, Jan 19, 2021 at 8:48 AM Wolfram Sang
> > <wsa+renesas@sang-engineering.com> wrote:
> > >
> > > Some SDHI instances are solely used for eMMC. Disable SD and SDIO
> > > for faster initialization.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> > > --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > > @@ -312,6 +312,8 @@ &sdhi3 {
> > >         vqmmc-supply = <&reg_1p8v>;
> > >         bus-width = <8>;
> > >         mmc-hs200-1_8v;
> > > +       no-sd;
> > > +       no-sdio;
> >
> > No objections on the Beacon board.   I cannot speak for the rest.
>
> Does this mean I can add your
>
>     Acked-by: Adam Ford <aford173@gmail.com> [beacon]
>

Yes.  I wasn't sure what the appropriate response sould be. (Review-by
or Acked-by)

adam
> ?
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
  2021-01-19 20:46     ` Adam Ford
@ 2021-01-19 20:52       ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-19 20:52 UTC (permalink / raw)
  To: Adam Ford; +Cc: Wolfram Sang, Linux-Renesas

Hi Adam,

On Tue, Jan 19, 2021 at 9:46 PM Adam Ford <aford173@gmail.com> wrote:
> On Tue, Jan 19, 2021 at 2:35 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Jan 19, 2021 at 7:43 PM Adam Ford <aford173@gmail.com> wrote:
> > > On Tue, Jan 19, 2021 at 8:48 AM Wolfram Sang
> > > <wsa+renesas@sang-engineering.com> wrote:
> > > >
> > > > Some SDHI instances are solely used for eMMC. Disable SD and SDIO
> > > > for faster initialization.
> > > >
> > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > > > --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> > > > @@ -312,6 +312,8 @@ &sdhi3 {
> > > >         vqmmc-supply = <&reg_1p8v>;
> > > >         bus-width = <8>;
> > > >         mmc-hs200-1_8v;
> > > > +       no-sd;
> > > > +       no-sdio;
> > >
> > > No objections on the Beacon board.   I cannot speak for the rest.
> >
> > Does this mean I can add your
> >
> >     Acked-by: Adam Ford <aford173@gmail.com> [beacon]
> >
>
> Yes.  I wasn't sure what the appropriate response sould be. (Review-by
> or Acked-by)

I think "no objections" maps to "Acked-by" ;-)
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC
  2021-01-19 13:33 [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC Wolfram Sang
  2021-01-19 18:43 ` Adam Ford
@ 2021-01-22  9:58 ` Geert Uytterhoeven
  1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-22  9:58 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Linux-Renesas

On Tue, Jan 19, 2021 at 2:33 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Some SDHI instances are solely used for eMMC. Disable SD and SDIO
> for faster initialization.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.12.

> ---
>
> I recall that ARM64 maintainers prefer such changes in one block and not
> individual patches. If that's not true, I can convert, of course.

Correct, thx!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-22 10:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 13:33 [PATCH] arm64: dts: renesas: disable SD functions for plain eMMC Wolfram Sang
2021-01-19 18:43 ` Adam Ford
2021-01-19 20:35   ` Geert Uytterhoeven
2021-01-19 20:46     ` Adam Ford
2021-01-19 20:52       ` Geert Uytterhoeven
2021-01-22  9:58 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.