Re: [PATCH v3] fbcon: Silence fbcon logo on 'quiet' boots

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Petr,

On Wed, Jan 2, 2019 at 6:43 PM Petr Mladek <pmladek@suse.com> wrote:
> On Thu 2018-12-20 17:31:57, Bartlomiej Zolnierkiewicz wrote:
> > [ added Petr & Sergey to Cc: ]
> >
> > Hi,
> >
> > On 10/30/2018 04:44 PM, Prarit Bhargava wrote:
> > > On text-based systems the 'quiet' boot option will show printk levels
> > > higher than CONSOLE_LOGLEVEL_QUIET.  The displaying of the Tux logo
> > > during boot can cause some consoles to lose display data and as a result
> > > confuse the end user.
> > >
> > > Do not display the Tux logo on systems that are in 'quiet' boot.
> > >
> > > v2: It helps to commit all my changes before sending them.  Remove extra
> > > bracket.
> > > v3: buildbot error fix: fbcon can be built as part of a module so export console_printk
> > >
> > > Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > Cc: Marko Myllynen <myllynen@redhat.com>
> > > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Cc: Kees Cook <keescook@chromium.org>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Thierry Reding <treding@nvidia.com>
> > > Cc: Yisheng Xie <ysxie@foxmail.com>
> > > Cc: dri-devel@lists.freedesktop.org

> > > --- a/kernel/printk/printk.c
> > > +++ b/kernel/printk/printk.c
> > > @@ -66,6 +66,7 @@ int console_printk[4] = {
> > >     CONSOLE_LOGLEVEL_MIN,           /* minimum_console_loglevel */
> > >     CONSOLE_LOGLEVEL_DEFAULT,       /* default_console_loglevel */
> > >  };
> > > +EXPORT_SYMBOL(console_printk);
> >
> > You need printk Maintainers Ack on it.
>
> I am fine with the added export (as a printk maintainer).

EXPORT_SYMBOL_GPL()?

The file seems to use a strange mix of both...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds