From: Geert Uytterhoeven <geert@linux-m68k.org> To: Mark Brown <broonie@kernel.org> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>, Linux-sh list <linux-sh@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h Date: Tue, 06 Nov 2018 18:21:41 +0000 [thread overview] Message-ID: <CAMuHMdVYK0SwkTDKrU+bfmCiQ2N5qERuGcqoaXzAsn-aPcCW=w@mail.gmail.com> (raw) In-Reply-To: <20181106175142.27988-1-broonie@kernel.org> Hi Mark, On Tue, Nov 6, 2018 at 6:52 PM Mark Brown <broonie@kernel.org> wrote: > Most architectures provide prototypes for the PCI I/O mapping operations > when asm/io.h is included but SH doesn't currently do that, leading to > for example warnings in sound/pci/hda/patch_ca0132.c when pci_iomap() is > used on current -next. Make SH more consistent with other architectures Also on v4.20-rc1, cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/13576888/ > by including asm-generic/pci_iomap.h in asm/io.h. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Mark Brown <broonie@kernel.org> Thanks for your patch! > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -24,6 +24,7 @@ > #define __IO_PREFIX generic > #include <asm/io_generic.h> > #include <asm/io_trapped.h> > +#include <asm-generic/pci_iomap.h> Is this sufficient? include/asm-generic/pci_iomap.h provides the dummies if CONFIG_PCI=n and CONFIG_GENERIC_PCI_IOMAP=y, while arch/sh/Kconfig selects GENERIC_PCI_IOMAP only if PCI is enabled. Hence it's not set in the failing config (sh/allyesconfig). Probably SH should select GENERIC_PCI_IOMAP unconditionally, like most other architectures do (alpha and powerpc select it conditionally, though)? > #include <mach/mangle-port.h> > > #define __raw_writeb(v,a) (__chk_io_ptr(a), *(volatile u8 __force *)(a) = (v)) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Mark Brown <broonie@kernel.org> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>, Linux-sh list <linux-sh@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h Date: Tue, 6 Nov 2018 19:21:41 +0100 [thread overview] Message-ID: <CAMuHMdVYK0SwkTDKrU+bfmCiQ2N5qERuGcqoaXzAsn-aPcCW=w@mail.gmail.com> (raw) In-Reply-To: <20181106175142.27988-1-broonie@kernel.org> Hi Mark, On Tue, Nov 6, 2018 at 6:52 PM Mark Brown <broonie@kernel.org> wrote: > Most architectures provide prototypes for the PCI I/O mapping operations > when asm/io.h is included but SH doesn't currently do that, leading to > for example warnings in sound/pci/hda/patch_ca0132.c when pci_iomap() is > used on current -next. Make SH more consistent with other architectures Also on v4.20-rc1, cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/13576888/ > by including asm-generic/pci_iomap.h in asm/io.h. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Mark Brown <broonie@kernel.org> Thanks for your patch! > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -24,6 +24,7 @@ > #define __IO_PREFIX generic > #include <asm/io_generic.h> > #include <asm/io_trapped.h> > +#include <asm-generic/pci_iomap.h> Is this sufficient? include/asm-generic/pci_iomap.h provides the dummies if CONFIG_PCI=n and CONFIG_GENERIC_PCI_IOMAP=y, while arch/sh/Kconfig selects GENERIC_PCI_IOMAP only if PCI is enabled. Hence it's not set in the failing config (sh/allyesconfig). Probably SH should select GENERIC_PCI_IOMAP unconditionally, like most other architectures do (alpha and powerpc select it conditionally, though)? > #include <mach/mangle-port.h> > > #define __raw_writeb(v,a) (__chk_io_ptr(a), *(volatile u8 __force *)(a) = (v)) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2018-11-06 18:21 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-12 12:12 [PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h Mark Brown 2018-11-06 17:51 ` Mark Brown 2018-11-06 17:51 ` Mark Brown 2018-11-06 18:21 ` Geert Uytterhoeven [this message] 2018-11-06 18:21 ` Geert Uytterhoeven 2018-11-06 18:26 ` Mark Brown 2018-11-06 18:26 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdVYK0SwkTDKrU+bfmCiQ2N5qERuGcqoaXzAsn-aPcCW=w@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=dalias@libc.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.