All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-renesas-soc@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices
Date: Fri, 22 Apr 2016 09:59:58 +0200	[thread overview]
Message-ID: <CAMuHMdVb46Get_+e0FzYhJMCwat-YaEDOcgFKqyGhtVBTOdJ8A@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFqcDDq-FGd9-PgJmig-Csqrj6LxqKtm1pMf1fq-LtGKvw@mail.gmail.com>

Hi Ulf,

On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct generic_pm_domain *genpd)
>>         return rcar_sysc_power_up(&pd->ch);
>>  }
>>
>> +static bool has_cpg_mstp;
>> +
>
> That's seems lazy. :-)
>
> Sure you can provide this as an input parameter to
> rcar_sysc_pd_setup() instead, no?

This variable is intended to go away, once all R-Car SoCs have been converted
to use the CPG/MSSR driver, and has_cpg_mstp will always be false.
Then we can just remove those lines, instead of reworking the parameter
passing.

(I have to admit I just didn't think about using a parameter, but the
 explanation above is still valid)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices
Date: Fri, 22 Apr 2016 09:59:58 +0200	[thread overview]
Message-ID: <CAMuHMdVb46Get_+e0FzYhJMCwat-YaEDOcgFKqyGhtVBTOdJ8A@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFqcDDq-FGd9-PgJmig-Csqrj6LxqKtm1pMf1fq-LtGKvw@mail.gmail.com>

Hi Ulf,

On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct generic_pm_domain *genpd)
>>         return rcar_sysc_power_up(&pd->ch);
>>  }
>>
>> +static bool has_cpg_mstp;
>> +
>
> That's seems lazy. :-)
>
> Sure you can provide this as an input parameter to
> rcar_sysc_pd_setup() instead, no?

This variable is intended to go away, once all R-Car SoCs have been converted
to use the CPG/MSSR driver, and has_cpg_mstp will always be false.
Then we can just remove those lines, instead of reworking the parameter
passing.

(I have to admit I just didn't think about using a parameter, but the
 explanation above is still valid)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2016-04-22  7:59 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 12:02 [PATCH v6 00/11] soc: renesas: Add R-Car SYSC PM Domain Support Geert Uytterhoeven
2016-04-20 12:02 ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 01/11] soc: renesas: Move pm-rcar to drivers/soc/renesas/rcar-sysc Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 02/11] soc: renesas: rcar-sysc: Improve rcar_sysc_power() debug info Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 13:59   ` Laurent Pinchart
2016-04-20 13:59     ` Laurent Pinchart
2016-04-22  7:21   ` Ulf Hansson
2016-04-22  7:21     ` Ulf Hansson
2016-04-20 12:02 ` [PATCH v6 04/11] soc: renesas: rcar-sysc: Make rcar_sysc_power_is_off() static Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-22  7:28   ` Ulf Hansson
2016-04-22  7:28     ` Ulf Hansson
2016-04-22  7:59     ` Geert Uytterhoeven [this message]
2016-04-22  7:59       ` Geert Uytterhoeven
2016-04-25  8:30       ` Ulf Hansson
2016-04-25  8:30         ` Ulf Hansson
2016-04-20 12:02 ` [PATCH v6 06/11] soc: renesas: rcar-sysc: Add support for R-Car H1 power areas Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 07/11] soc: renesas: rcar-sysc: Add support for R-Car H2 " Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 08/11] soc: renesas: rcar-sysc: Add support for R-Car M2-W " Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 09/11] soc: renesas: rcar-sysc: Add support for R-Car M2-N " Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 10/11] soc: renesas: rcar-sysc: Add support for R-Car E2 " Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-20 12:02 ` [PATCH v6 11/11] soc: renesas: rcar-sysc: Add support for R-Car H3 " Geert Uytterhoeven
2016-04-20 12:02   ` Geert Uytterhoeven
2016-04-21  3:28 ` [PATCH v6 00/11] soc: renesas: Add R-Car SYSC PM Domain Support Simon Horman
2016-04-21  3:28   ` Simon Horman
2016-04-21 15:14   ` Geert Uytterhoeven
2016-04-21 15:14     ` Geert Uytterhoeven
2016-04-22  0:33     ` Simon Horman
2016-04-22  0:33       ` Simon Horman
2016-04-22  4:12       ` Laurent Pinchart
2016-04-22  4:12         ` Laurent Pinchart
2016-04-22  8:15         ` Simon Horman
2016-04-22  8:15           ` Simon Horman
2016-04-23  0:30           ` Laurent Pinchart
2016-04-23  0:30             ` Laurent Pinchart
2016-04-22  7:02       ` Geert Uytterhoeven
2016-04-22  7:02         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVb46Get_+e0FzYhJMCwat-YaEDOcgFKqyGhtVBTOdJ8A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=khilman@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.