From: Geert Uytterhoeven <geert@linux-m68k.org> To: Michel Pollet <michel.pollet@bp.renesas.com> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Phil Edworthy <phil.edworthy@renesas.com>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/2] arm: rzn1: Add basic support for RZN1D-DB Board Date: Mon, 5 Mar 2018 10:52:16 +0100 [thread overview] Message-ID: <CAMuHMdVdXh428vfLW5has3THUWq5x6iA-6CLL+uQudOGOJfTrA@mail.gmail.com> (raw) In-Reply-To: <1519647518-15579-3-git-send-email-michel.pollet@bp.renesas.com> Hi Michel, On Mon, Feb 26, 2018 at 1:18 PM, Michel Pollet <michel.pollet@bp.renesas.com> wrote: > Only enables the uart0 for now, and also relies on the bootloader > for setting up the clocks and pinctrl. > > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> Thanks for your patch! This should be split in two parts: > Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1. DT bindings > arch/arm/boot/dts/rzn1d400-db.dts | 25 ++++++++++++++++++++++ 2. Board DTS + (missing) arch/arm/boot/dts/Makefile update. > --- /dev/null > +++ b/arch/arm/boot/dts/rzn1d400-db.dts Why the 400? 400-pin package? Please follow <SoC>-<board>.dts naming convention, i.e. r9a06g032-rzn1d-db.dts > @@ -0,0 +1,25 @@ > +/* > + * Device Tree Source for the RZN1D-DB Board > + * > + * Copyright (C) 2018 Renesas Electronics Europe Limited > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > + > +/dts-v1/; > + > +#include "rzn1.dtsi" > + > +/ { > + model = "RZN1D-DB Board"; > + compatible = "renesas,rzn1d-db", "renesas,r9a06g032"; > + > + chosen { > + bootargs = "console=ttyS0,115200"; "console=" is not needed, as it is handled by stdout-path these days, so you can remove bootargs for now. > + stdout-path = &uart0; stdout-path = "serial0:115200n8"; Please move the serial0 alias definition to the board DTS, as labeling of serial ports is board-specific. > + linux,stdout-path = &uart0; linux,stdout-path is deprecated, please remove it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] arm: rzn1: Add basic support for RZN1D-DB Board Date: Mon, 5 Mar 2018 10:52:16 +0100 [thread overview] Message-ID: <CAMuHMdVdXh428vfLW5has3THUWq5x6iA-6CLL+uQudOGOJfTrA@mail.gmail.com> (raw) In-Reply-To: <1519647518-15579-3-git-send-email-michel.pollet@bp.renesas.com> Hi Michel, On Mon, Feb 26, 2018 at 1:18 PM, Michel Pollet <michel.pollet@bp.renesas.com> wrote: > Only enables the uart0 for now, and also relies on the bootloader > for setting up the clocks and pinctrl. > > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> Thanks for your patch! This should be split in two parts: > Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1. DT bindings > arch/arm/boot/dts/rzn1d400-db.dts | 25 ++++++++++++++++++++++ 2. Board DTS + (missing) arch/arm/boot/dts/Makefile update. > --- /dev/null > +++ b/arch/arm/boot/dts/rzn1d400-db.dts Why the 400? 400-pin package? Please follow <SoC>-<board>.dts naming convention, i.e. r9a06g032-rzn1d-db.dts > @@ -0,0 +1,25 @@ > +/* > + * Device Tree Source for the RZN1D-DB Board > + * > + * Copyright (C) 2018 Renesas Electronics Europe Limited > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > + > +/dts-v1/; > + > +#include "rzn1.dtsi" > + > +/ { > + model = "RZN1D-DB Board"; > + compatible = "renesas,rzn1d-db", "renesas,r9a06g032"; > + > + chosen { > + bootargs = "console=ttyS0,115200"; "console=" is not needed, as it is handled by stdout-path these days, so you can remove bootargs for now. > + stdout-path = &uart0; stdout-path = "serial0:115200n8"; Please move the serial0 alias definition to the board DTS, as labeling of serial ports is board-specific. > + linux,stdout-path = &uart0; linux,stdout-path is deprecated, please remove it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2018-03-05 9:52 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-26 12:18 [PATCH 0/2] arm: Support for Renesas RZ/N1D (R9A06G032) Michel Pollet 2018-02-26 12:18 ` Michel Pollet 2018-02-26 12:18 ` [PATCH 1/2] arm: add basic support for Renesas RZ/N1 boards Michel Pollet 2018-02-26 12:18 ` Michel Pollet 2018-03-02 23:12 ` Rob Herring 2018-03-02 23:12 ` Rob Herring 2018-03-05 9:43 ` Geert Uytterhoeven 2018-03-05 9:43 ` Geert Uytterhoeven 2018-02-26 12:18 ` [PATCH 2/2] arm: rzn1: Add basic support for RZN1D-DB Board Michel Pollet 2018-02-26 12:18 ` Michel Pollet 2018-03-05 9:52 ` Geert Uytterhoeven [this message] 2018-03-05 9:52 ` Geert Uytterhoeven 2018-02-27 13:10 ` [PATCH 0/2] arm: Support for Renesas RZ/N1D (R9A06G032) Phil Edworthy 2018-02-27 13:10 ` Phil Edworthy 2018-02-27 13:10 ` Phil Edworthy 2018-03-01 9:35 ` Simon Horman 2018-03-01 9:35 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdVdXh428vfLW5has3THUWq5x6iA-6CLL+uQudOGOJfTrA@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=michel.pollet@bp.renesas.com \ --cc=phil.edworthy@renesas.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.