* [PATCH 0/2] add config option to center the bootup logo
@ 2018-11-26 21:57 Peter Rosin
2018-11-26 21:57 ` [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height Peter Rosin
2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin
0 siblings, 2 replies; 33+ messages in thread
From: Peter Rosin @ 2018-11-26 21:57 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Rosin, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev
Hi!
I'm using these patches to get early display output at the center of
the screen. Maybe someone else will also find that useful?
Cheers,
Peter
Peter Rosin (2):
fbdev: fbmem: make fb_show_logo_line return the end instead of the
height
fbdev: fbmem: add config option to center the bootup logo
drivers/video/fbdev/core/fbmem.c | 31 +++++++++++++++++++++++++++----
drivers/video/logo/Kconfig | 9 +++++++++
2 files changed, 36 insertions(+), 4 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height 2018-11-26 21:57 [PATCH 0/2] add config option to center the bootup logo Peter Rosin @ 2018-11-26 21:57 ` Peter Rosin 2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz 2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin 1 sibling, 1 reply; 33+ messages in thread From: Peter Rosin @ 2018-11-26 21:57 UTC (permalink / raw) To: linux-kernel Cc: Peter Rosin, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev In preparation for allowing centering of the bootup logo, make fb_show_logo_line return where the next free framebuffer line is, instead of returning the height of the shown logo. Signed-off-by: Peter Rosin <peda@axentia.se> --- drivers/video/fbdev/core/fbmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 861bf8081619..43d4047f472a 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -521,7 +521,7 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, info->pseudo_palette = saved_pseudo_palette; kfree(logo_new); kfree(logo_rotate); - return logo->height; + return image.dy + logo->height; } @@ -573,8 +573,8 @@ static int fb_show_extra_logos(struct fb_info *info, int y, int rotate) unsigned int i; for (i = 0; i < fb_logo_ex_num; i++) - y += fb_show_logo_line(info, rotate, - fb_logo_ex[i].logo, y, fb_logo_ex[i].n); + y = fb_show_logo_line(info, rotate, + fb_logo_ex[i].logo, y, fb_logo_ex[i].n); return y; } -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height 2018-11-26 21:57 ` [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height Peter Rosin @ 2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-12-20 17:37 UTC (permalink / raw) To: Peter Rosin; +Cc: linux-kernel, dri-devel, linux-fbdev On 11/26/2018 10:57 PM, Peter Rosin wrote: > In preparation for allowing centering of the bootup logo, make > fb_show_logo_line return where the next free framebuffer line is, > instead of returning the height of the shown logo. > > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height @ 2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-12-20 17:37 UTC (permalink / raw) To: Peter Rosin; +Cc: linux-kernel, dri-devel, linux-fbdev On 11/26/2018 10:57 PM, Peter Rosin wrote: > In preparation for allowing centering of the bootup logo, make > fb_show_logo_line return where the next free framebuffer line is, > instead of returning the height of the shown logo. > > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo 2018-11-26 21:57 [PATCH 0/2] add config option to center the bootup logo Peter Rosin 2018-11-26 21:57 ` [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height Peter Rosin @ 2018-11-26 21:57 ` Peter Rosin 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 2019-01-06 9:33 ` Geert Uytterhoeven 1 sibling, 2 replies; 33+ messages in thread From: Peter Rosin @ 2018-11-26 21:57 UTC (permalink / raw) To: linux-kernel Cc: Peter Rosin, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these extra logos are not considered when centering the first logo vertically. Signed-off-by: Peter Rosin <peda@axentia.se> --- drivers/video/fbdev/core/fbmem.c | 25 ++++++++++++++++++++++++- drivers/video/logo/Kconfig | 9 +++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 43d4047f472a..fdbad029e5e6 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -502,8 +502,25 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, fb_set_logo(info, logo, logo_new, fb_logo.depth); } +#ifdef CONFIG_FB_LOGO_CENTER + { + int xres = info->var.xres; + int yres = info->var.yres; + + if (rotate == FB_ROTATE_CW || rotate == FB_ROTATE_CCW) { + xres = info->var.yres; + yres = info->var.xres; + } + + while (n && (n * (logo->width + 8) - 8 > xres)) + --n; + image.dx = (xres - n * (logo->width + 8) - 8) / 2; + image.dy = y ?: (yres - logo->height) / 2; + } +#else image.dx = 0; image.dy = y; +#endif image.width = logo->width; image.height = logo->height; @@ -600,6 +617,7 @@ int fb_prepare_logo(struct fb_info *info, int rotate) { int depth = fb_get_color_depth(&info->var, &info->fix); unsigned int yres; + int height; memset(&fb_logo, 0, sizeof(struct logo_data)); @@ -661,7 +679,12 @@ int fb_prepare_logo(struct fb_info *info, int rotate) } } - return fb_prepare_extra_logos(info, fb_logo.logo->height, yres); + height = fb_logo.logo->height; +#ifdef CONFIG_FB_LOGO_CENTER + height += (yres - fb_logo.logo->height) / 2; +#endif + + return fb_prepare_extra_logos(info, height, yres); } int fb_show_logo(struct fb_info *info, int rotate) diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig index d1f6196c8b9a..1e972c4e88b1 100644 --- a/drivers/video/logo/Kconfig +++ b/drivers/video/logo/Kconfig @@ -10,6 +10,15 @@ menuconfig LOGO if LOGO +config FB_LOGO_CENTER + bool "Center the logo" + depends on FB=y + help + When this option is selected, the bootup logo is centered both + horizontally and vertically. If more than one logo is displayed + due to multiple CPUs, the collected line of logos is centered + as a whole. + config FB_LOGO_EXTRA bool depends on FB=y -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo 2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz @ 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-12-20 17:38 UTC (permalink / raw) To: Peter Rosin; +Cc: linux-kernel, dri-devel, linux-fbdev On 11/26/2018 10:57 PM, Peter Rosin wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo @ 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-12-20 17:38 UTC (permalink / raw) To: Peter Rosin; +Cc: linux-fbdev, linux-kernel, dri-devel On 11/26/2018 10:57 PM, Peter Rosin wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo @ 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-12-20 17:38 UTC (permalink / raw) To: Peter Rosin; +Cc: linux-fbdev, linux-kernel, dri-devel On 11/26/2018 10:57 PM, Peter Rosin wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo 2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz @ 2019-01-06 9:33 ` Geert Uytterhoeven 1 sibling, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-06 9:33 UTC (permalink / raw) To: Peter Rosin Cc: linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev Hi Peter, On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- a/drivers/video/logo/Kconfig > +++ b/drivers/video/logo/Kconfig > @@ -10,6 +10,15 @@ menuconfig LOGO > > if LOGO > > +config FB_LOGO_CENTER > + bool "Center the logo" > + depends on FB=y > + help > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed > + due to multiple CPUs, the collected line of logos is centered > + as a whole. > + Isn't a kernel command line option more suitable to configure the position of the logo? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo @ 2019-01-06 9:33 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-06 9:33 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- a/drivers/video/logo/Kconfig > +++ b/drivers/video/logo/Kconfig > @@ -10,6 +10,15 @@ menuconfig LOGO > > if LOGO > > +config FB_LOGO_CENTER > + bool "Center the logo" > + depends on FB=y > + help > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed > + due to multiple CPUs, the collected line of logos is centered > + as a whole. > + Isn't a kernel command line option more suitable to configure the position of the logo? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo @ 2019-01-06 9:33 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-06 9:33 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- a/drivers/video/logo/Kconfig > +++ b/drivers/video/logo/Kconfig > @@ -10,6 +10,15 @@ menuconfig LOGO > > if LOGO > > +config FB_LOGO_CENTER > + bool "Center the logo" > + depends on FB=y > + help > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed > + due to multiple CPUs, the collected line of logos is centered > + as a whole. > + Isn't a kernel command line option more suitable to configure the position of the logo? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option 2019-01-06 9:33 ` Geert Uytterhoeven @ 2019-01-07 8:26 ` Peter Rosin -1 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 8:26 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 2019-01-06 10:33, Geert Uytterhoeven wrote: > Hi Peter, > > On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >> extra logos are not considered when centering the first logo vertically. >> >> Signed-off-by: Peter Rosin <peda@axentia.se> > >> --- a/drivers/video/logo/Kconfig >> +++ b/drivers/video/logo/Kconfig >> @@ -10,6 +10,15 @@ menuconfig LOGO >> >> if LOGO >> >> +config FB_LOGO_CENTER >> + bool "Center the logo" >> + depends on FB=y >> + help >> + When this option is selected, the bootup logo is centered both >> + horizontally and vertically. If more than one logo is displayed >> + due to multiple CPUs, the collected line of logos is centered >> + as a whole. >> + > > Isn't a kernel command line option more suitable to configure the position > of the logo? That didn't occur to me previously, but it does make sense now that you mention it. This is on top of v5.0-rc1, and if applied before v5.0 we can avoid possible regressions for folks who might start to rely on CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. Cheers, Peter From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 From: Peter Rosin <peda@axentia.se> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Peter Rosin <peda@axentia.se> Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Cc: linux-doc@vger.kernel.org To: linux-kernel@vger.kernel.org Date: Mon, 7 Jan 2019 08:35:26 +0100 Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line option A command line option is much more flexible than a config option and the supporting code is small. Gets rid of #ifdefs in the code too... Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Peter Rosin <peda@axentia.se> --- Documentation/fb/fbcon.txt | 6 ++++++ drivers/video/fbdev/core/fbcon.c | 5 +++++ drivers/video/fbdev/core/fbmem.c | 19 ++++++++++--------- drivers/video/logo/Kconfig | 9 --------- include/linux/fb.h | 1 + 5 files changed, 22 insertions(+), 18 deletions(-) diff --git a/Documentation/fb/fbcon.txt b/Documentation/fb/fbcon.txt index 62af30511a95..fb5fa0a8d553 100644 --- a/Documentation/fb/fbcon.txt +++ b/Documentation/fb/fbcon.txt @@ -163,6 +163,12 @@ C. Boot options be preserved until there actually is some text is output to the console. This option causes fbcon to bind immediately to the fbdev device. +7. fbcon=center-logo + + When this option is selected, the bootup logo is centered both + horizontally and vertically. If more than one logo is displayed due to + multiple CPUs, the collected line of logos is centered as a whole. + C. Attaching, Detaching and Unloading Before going on to how to attach, detach and unload the framebuffer console, an diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 8976190b6c1f..552cfee63d76 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -510,6 +510,11 @@ static int __init fb_console_setup(char *this_opt) continue; } #endif + + if (!strcmp(options, "center-logo")) { + fb_center_logo = true; + continue; + } } return 1; } diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 558ed2ed3124..cb43a2258c51 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -53,6 +53,9 @@ EXPORT_SYMBOL(registered_fb); int num_registered_fb __read_mostly; EXPORT_SYMBOL(num_registered_fb); +bool fb_center_logo __read_mostly; +EXPORT_SYMBOL(fb_center_logo); + static struct fb_info *get_fb_info(unsigned int idx) { struct fb_info *fb_info; @@ -506,8 +509,7 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, fb_set_logo(info, logo, logo_new, fb_logo.depth); } -#ifdef CONFIG_FB_LOGO_CENTER - { + if (fb_center_logo) { int xres = info->var.xres; int yres = info->var.yres; @@ -520,11 +522,11 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, --n; image.dx = (xres - n * (logo->width + 8) - 8) / 2; image.dy = y ?: (yres - logo->height) / 2; + } else { + image.dx = 0; + image.dy = y; } -#else - image.dx = 0; - image.dy = y; -#endif + image.width = logo->width; image.height = logo->height; @@ -684,9 +686,8 @@ int fb_prepare_logo(struct fb_info *info, int rotate) } height = fb_logo.logo->height; -#ifdef CONFIG_FB_LOGO_CENTER - height += (yres - fb_logo.logo->height) / 2; -#endif + if (fb_center_logo) + height += (yres - fb_logo.logo->height) / 2; return fb_prepare_extra_logos(info, height, yres); } diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig index 1e972c4e88b1..d1f6196c8b9a 100644 --- a/drivers/video/logo/Kconfig +++ b/drivers/video/logo/Kconfig @@ -10,15 +10,6 @@ menuconfig LOGO if LOGO -config FB_LOGO_CENTER - bool "Center the logo" - depends on FB=y - help - When this option is selected, the bootup logo is centered both - horizontally and vertically. If more than one logo is displayed - due to multiple CPUs, the collected line of logos is centered - as a whole. - config FB_LOGO_EXTRA bool depends on FB=y diff --git a/include/linux/fb.h b/include/linux/fb.h index 7cdd31a69719..f52ef0ad6781 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -653,6 +653,7 @@ extern int fb_new_modelist(struct fb_info *info); extern struct fb_info *registered_fb[FB_MAX]; extern int num_registered_fb; +extern bool fb_center_logo; extern struct class *fb_class; #define for_each_registered_fb(i) \ -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 8:26 ` Peter Rosin 0 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 8:26 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List T24gMjAxOS0wMS0wNiAxMDozMywgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOg0KPiBIaSBQZXRl ciwNCj4gDQo+IE9uIE1vbiwgTm92IDI2LCAyMDE4IGF0IDEwOjU5IFBNIFBldGVyIFJvc2luIDxw ZWRhQGF4ZW50aWEuc2U+IHdyb3RlOg0KPj4gSWYgdGhlcmUgYXJlIGV4dHJhIGxvZ29zIChDT05G SUdfRkJfTE9HT19FWFRSQSkgdGhlIGhlaWdodHMgb2YgdGhlc2UNCj4+IGV4dHJhIGxvZ29zIGFy ZSBub3QgY29uc2lkZXJlZCB3aGVuIGNlbnRlcmluZyB0aGUgZmlyc3QgbG9nbyB2ZXJ0aWNhbGx5 Lg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQo+ IA0KPj4gLS0tIGEvZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcNCj4+ICsrKyBiL2RyaXZlcnMv dmlkZW8vbG9nby9LY29uZmlnDQo+PiBAQCAtMTAsNiArMTAsMTUgQEAgbWVudWNvbmZpZyBMT0dP DQo+Pg0KPj4gIGlmIExPR08NCj4+DQo+PiArY29uZmlnIEZCX0xPR09fQ0VOVEVSDQo+PiArICAg ICAgIGJvb2wgIkNlbnRlciB0aGUgbG9nbyINCj4+ICsgICAgICAgZGVwZW5kcyBvbiBGQj15DQo+ PiArICAgICAgIGhlbHANCj4+ICsgICAgICAgICBXaGVuIHRoaXMgb3B0aW9uIGlzIHNlbGVjdGVk LCB0aGUgYm9vdHVwIGxvZ28gaXMgY2VudGVyZWQgYm90aA0KPj4gKyAgICAgICAgIGhvcml6b250 YWxseSBhbmQgdmVydGljYWxseS4gSWYgbW9yZSB0aGFuIG9uZSBsb2dvIGlzIGRpc3BsYXllZA0K Pj4gKyAgICAgICAgIGR1ZSB0byBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2Yg bG9nb3MgaXMgY2VudGVyZWQNCj4+ICsgICAgICAgICBhcyBhIHdob2xlLg0KPj4gKw0KPiANCj4g SXNuJ3QgYSBrZXJuZWwgY29tbWFuZCBsaW5lIG9wdGlvbiBtb3JlIHN1aXRhYmxlIHRvIGNvbmZp Z3VyZSB0aGUgcG9zaXRpb24NCj4gb2YgdGhlIGxvZ28/DQoNClRoYXQgZGlkbid0IG9jY3VyIHRv IG1lIHByZXZpb3VzbHksIGJ1dCBpdCBkb2VzIG1ha2Ugc2Vuc2Ugbm93IHRoYXQgeW91DQptZW50 aW9uIGl0LiBUaGlzIGlzIG9uIHRvcCBvZiB2NS4wLXJjMSwgYW5kIGlmIGFwcGxpZWQgYmVmb3Jl IHY1LjAgd2UNCmNhbiBhdm9pZCBwb3NzaWJsZSByZWdyZXNzaW9ucyBmb3IgZm9sa3Mgd2hvIG1p Z2h0IHN0YXJ0IHRvIHJlbHkgb24NCkNPTkZJR19GQl9MT0dPX0NFTlRFUiBpZiB2NS4wIGlzIHJl bGVhc2VkIHcvbyB0aGlzLg0KDQpDaGVlcnMsDQpQZXRlcg0KDQpGcm9tIGRlNzM1M2FiNTE5YmE5 YjVjOWVhM2Y2MmQ2MDdiYjhlOTRiNjg3Y2MgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxDQpGcm9t OiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPg0KQ2M6IEJhcnRsb21pZWogWm9sbmllcmtp ZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4NCkNjOiBKb25hdGhhbiBDb3JiZXQgPGNv cmJldEBsd24ubmV0Pg0KQ2M6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQpDYzogZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVs Lm9yZw0KQ2M6IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmcNClRvOiBsaW51eC1rZXJuZWxAdmdl ci5rZXJuZWwub3JnDQpEYXRlOiBNb24sIDcgSmFuIDIwMTkgMDg6MzU6MjYgKzAxMDANClN1Ympl Y3Q6IFtQQVRDSF0gZmJkZXY6IGZibWVtOiBjb252ZXJ0IENPTkZJR19GQl9MT0dPX0NFTlRFUiBp bnRvIGEgY21kIGxpbmUNCiBvcHRpb24NCg0KQSBjb21tYW5kIGxpbmUgb3B0aW9uIGlzIG11Y2gg bW9yZSBmbGV4aWJsZSB0aGFuIGEgY29uZmlnIG9wdGlvbiBhbmQNCnRoZSBzdXBwb3J0aW5nIGNv ZGUgaXMgc21hbGwuIEdldHMgcmlkIG9mICNpZmRlZnMgaW4gdGhlIGNvZGUgdG9vLi4uDQoNClN1 Z2dlc3RlZC1ieTogR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydEBsaW51eC1tNjhrLm9yZz4NClNp Z25lZC1vZmYtYnk6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQotLS0NCiBEb2N1bWVu dGF0aW9uL2ZiL2ZiY29uLnR4dCAgICAgICB8ICA2ICsrKysrKw0KIGRyaXZlcnMvdmlkZW8vZmJk ZXYvY29yZS9mYmNvbi5jIHwgIDUgKysrKysNCiBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJt ZW0uYyB8IDE5ICsrKysrKysrKystLS0tLS0tLS0NCiBkcml2ZXJzL3ZpZGVvL2xvZ28vS2NvbmZp ZyAgICAgICB8ICA5IC0tLS0tLS0tLQ0KIGluY2x1ZGUvbGludXgvZmIuaCAgICAgICAgICAgICAg IHwgIDEgKw0KIDUgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25z KC0pDQoNCmRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2ZiL2ZiY29uLnR4dCBiL0RvY3VtZW50 YXRpb24vZmIvZmJjb24udHh0DQppbmRleCA2MmFmMzA1MTFhOTUuLmZiNWZhMGE4ZDU1MyAxMDA2 NDQNCi0tLSBhL0RvY3VtZW50YXRpb24vZmIvZmJjb24udHh0DQorKysgYi9Eb2N1bWVudGF0aW9u L2ZiL2ZiY29uLnR4dA0KQEAgLTE2Myw2ICsxNjMsMTIgQEAgQy4gQm9vdCBvcHRpb25zDQogCWJl IHByZXNlcnZlZCB1bnRpbCB0aGVyZSBhY3R1YWxseSBpcyBzb21lIHRleHQgaXMgb3V0cHV0IHRv IHRoZSBjb25zb2xlLg0KIAlUaGlzIG9wdGlvbiBjYXVzZXMgZmJjb24gdG8gYmluZCBpbW1lZGlh dGVseSB0byB0aGUgZmJkZXYgZGV2aWNlLg0KIA0KKzcuIGZiY29uPWNlbnRlci1sb2dvDQorDQor CVdoZW4gdGhpcyBvcHRpb24gaXMgc2VsZWN0ZWQsIHRoZSBib290dXAgbG9nbyBpcyBjZW50ZXJl ZCBib3RoDQorCWhvcml6b250YWxseSBhbmQgdmVydGljYWxseS4gSWYgbW9yZSB0aGFuIG9uZSBs b2dvIGlzIGRpc3BsYXllZCBkdWUgdG8NCisJbXVsdGlwbGUgQ1BVcywgdGhlIGNvbGxlY3RlZCBs aW5lIG9mIGxvZ29zIGlzIGNlbnRlcmVkIGFzIGEgd2hvbGUuDQorDQogQy4gQXR0YWNoaW5nLCBE ZXRhY2hpbmcgYW5kIFVubG9hZGluZw0KIA0KIEJlZm9yZSBnb2luZyBvbiB0byBob3cgdG8gYXR0 YWNoLCBkZXRhY2ggYW5kIHVubG9hZCB0aGUgZnJhbWVidWZmZXIgY29uc29sZSwgYW4NCmRpZmYg LS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJjb24uYyBiL2RyaXZlcnMvdmlkZW8v ZmJkZXYvY29yZS9mYmNvbi5jDQppbmRleCA4OTc2MTkwYjZjMWYuLjU1MmNmZWU2M2Q3NiAxMDA2 NDQNCi0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYmNvbi5jDQorKysgYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L2NvcmUvZmJjb24uYw0KQEAgLTUxMCw2ICs1MTAsMTEgQEAgc3RhdGljIGlu dCBfX2luaXQgZmJfY29uc29sZV9zZXR1cChjaGFyICp0aGlzX29wdCkNCiAJCQljb250aW51ZTsN CiAJCX0NCiAjZW5kaWYNCisNCisJCWlmICghc3RyY21wKG9wdGlvbnMsICJjZW50ZXItbG9nbyIp KSB7DQorCQkJZmJfY2VudGVyX2xvZ28gPSB0cnVlOw0KKwkJCWNvbnRpbnVlOw0KKwkJfQ0KIAl9 DQogCXJldHVybiAxOw0KIH0NCmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUv ZmJtZW0uYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYm1lbS5jDQppbmRleCA1NThlZDJl ZDMxMjQuLmNiNDNhMjI1OGM1MSAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29y ZS9mYm1lbS5jDQorKysgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJtZW0uYw0KQEAgLTUz LDYgKzUzLDkgQEAgRVhQT1JUX1NZTUJPTChyZWdpc3RlcmVkX2ZiKTsNCiBpbnQgbnVtX3JlZ2lz dGVyZWRfZmIgX19yZWFkX21vc3RseTsNCiBFWFBPUlRfU1lNQk9MKG51bV9yZWdpc3RlcmVkX2Zi KTsNCiANCitib29sIGZiX2NlbnRlcl9sb2dvIF9fcmVhZF9tb3N0bHk7DQorRVhQT1JUX1NZTUJP TChmYl9jZW50ZXJfbG9nbyk7DQorDQogc3RhdGljIHN0cnVjdCBmYl9pbmZvICpnZXRfZmJfaW5m byh1bnNpZ25lZCBpbnQgaWR4KQ0KIHsNCiAJc3RydWN0IGZiX2luZm8gKmZiX2luZm87DQpAQCAt NTA2LDggKzUwOSw3IEBAIHN0YXRpYyBpbnQgZmJfc2hvd19sb2dvX2xpbmUoc3RydWN0IGZiX2lu Zm8gKmluZm8sIGludCByb3RhdGUsDQogCQlmYl9zZXRfbG9nbyhpbmZvLCBsb2dvLCBsb2dvX25l dywgZmJfbG9nby5kZXB0aCk7DQogCX0NCiANCi0jaWZkZWYgQ09ORklHX0ZCX0xPR09fQ0VOVEVS DQotCXsNCisJaWYgKGZiX2NlbnRlcl9sb2dvKSB7DQogCQlpbnQgeHJlcyA9IGluZm8tPnZhci54 cmVzOw0KIAkJaW50IHlyZXMgPSBpbmZvLT52YXIueXJlczsNCiANCkBAIC01MjAsMTEgKzUyMiwx MSBAQCBzdGF0aWMgaW50IGZiX3Nob3dfbG9nb19saW5lKHN0cnVjdCBmYl9pbmZvICppbmZvLCBp bnQgcm90YXRlLA0KIAkJCS0tbjsNCiAJCWltYWdlLmR4ID0gKHhyZXMgLSBuICogKGxvZ28tPndp ZHRoICsgOCkgLSA4KSAvIDI7DQogCQlpbWFnZS5keSA9IHkgPzogKHlyZXMgLSBsb2dvLT5oZWln aHQpIC8gMjsNCisJfSBlbHNlIHsNCisJCWltYWdlLmR4ID0gMDsNCisJCWltYWdlLmR5ID0geTsN CiAJfQ0KLSNlbHNlDQotCWltYWdlLmR4ID0gMDsNCi0JaW1hZ2UuZHkgPSB5Ow0KLSNlbmRpZg0K Kw0KIAlpbWFnZS53aWR0aCA9IGxvZ28tPndpZHRoOw0KIAlpbWFnZS5oZWlnaHQgPSBsb2dvLT5o ZWlnaHQ7DQogDQpAQCAtNjg0LDkgKzY4Niw4IEBAIGludCBmYl9wcmVwYXJlX2xvZ28oc3RydWN0 IGZiX2luZm8gKmluZm8sIGludCByb3RhdGUpDQogIAl9DQogDQogCWhlaWdodCA9IGZiX2xvZ28u bG9nby0+aGVpZ2h0Ow0KLSNpZmRlZiBDT05GSUdfRkJfTE9HT19DRU5URVINCi0JaGVpZ2h0ICs9 ICh5cmVzIC0gZmJfbG9nby5sb2dvLT5oZWlnaHQpIC8gMjsNCi0jZW5kaWYNCisJaWYgKGZiX2Nl bnRlcl9sb2dvKQ0KKwkJaGVpZ2h0ICs9ICh5cmVzIC0gZmJfbG9nby5sb2dvLT5oZWlnaHQpIC8g MjsNCiANCiAJcmV0dXJuIGZiX3ByZXBhcmVfZXh0cmFfbG9nb3MoaW5mbywgaGVpZ2h0LCB5cmVz KTsNCiB9DQpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcgYi9kcml2ZXJz L3ZpZGVvL2xvZ28vS2NvbmZpZw0KaW5kZXggMWU5NzJjNGU4OGIxLi5kMWY2MTk2YzhiOWEgMTAw NjQ0DQotLS0gYS9kcml2ZXJzL3ZpZGVvL2xvZ28vS2NvbmZpZw0KKysrIGIvZHJpdmVycy92aWRl by9sb2dvL0tjb25maWcNCkBAIC0xMCwxNSArMTAsNiBAQCBtZW51Y29uZmlnIExPR08NCiANCiBp ZiBMT0dPDQogDQotY29uZmlnIEZCX0xPR09fQ0VOVEVSDQotCWJvb2wgIkNlbnRlciB0aGUgbG9n byINCi0JZGVwZW5kcyBvbiBGQj15DQotCWhlbHANCi0JICBXaGVuIHRoaXMgb3B0aW9uIGlzIHNl bGVjdGVkLCB0aGUgYm9vdHVwIGxvZ28gaXMgY2VudGVyZWQgYm90aA0KLQkgIGhvcml6b250YWxs eSBhbmQgdmVydGljYWxseS4gSWYgbW9yZSB0aGFuIG9uZSBsb2dvIGlzIGRpc3BsYXllZA0KLQkg IGR1ZSB0byBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2YgbG9nb3MgaXMgY2Vu dGVyZWQNCi0JICBhcyBhIHdob2xlLg0KLQ0KIGNvbmZpZyBGQl9MT0dPX0VYVFJBDQogCWJvb2wN CiAJZGVwZW5kcyBvbiBGQj15DQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9mYi5oIGIvaW5j bHVkZS9saW51eC9mYi5oDQppbmRleCA3Y2RkMzFhNjk3MTkuLmY1MmVmMGFkNjc4MSAxMDA2NDQN Ci0tLSBhL2luY2x1ZGUvbGludXgvZmIuaA0KKysrIGIvaW5jbHVkZS9saW51eC9mYi5oDQpAQCAt NjUzLDYgKzY1Myw3IEBAIGV4dGVybiBpbnQgZmJfbmV3X21vZGVsaXN0KHN0cnVjdCBmYl9pbmZv ICppbmZvKTsNCiANCiBleHRlcm4gc3RydWN0IGZiX2luZm8gKnJlZ2lzdGVyZWRfZmJbRkJfTUFY XTsNCiBleHRlcm4gaW50IG51bV9yZWdpc3RlcmVkX2ZiOw0KK2V4dGVybiBib29sIGZiX2NlbnRl cl9sb2dvOw0KIGV4dGVybiBzdHJ1Y3QgY2xhc3MgKmZiX2NsYXNzOw0KIA0KICNkZWZpbmUgZm9y X2VhY2hfcmVnaXN0ZXJlZF9mYihpKQkJXA0KLS0gDQoyLjExLjANCg0K ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option 2019-01-07 8:26 ` Peter Rosin (?) @ 2019-01-07 8:40 ` Geert Uytterhoeven -1 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 8:40 UTC (permalink / raw) To: Peter Rosin Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List Hi Peter, On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-06 10:33, Geert Uytterhoeven wrote: > > On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >> extra logos are not considered when centering the first logo vertically. > >> > >> Signed-off-by: Peter Rosin <peda@axentia.se> > > > >> --- a/drivers/video/logo/Kconfig > >> +++ b/drivers/video/logo/Kconfig > >> @@ -10,6 +10,15 @@ menuconfig LOGO > >> > >> if LOGO > >> > >> +config FB_LOGO_CENTER > >> + bool "Center the logo" > >> + depends on FB=y > >> + help > >> + When this option is selected, the bootup logo is centered both > >> + horizontally and vertically. If more than one logo is displayed > >> + due to multiple CPUs, the collected line of logos is centered > >> + as a whole. > >> + > > > > Isn't a kernel command line option more suitable to configure the position > > of the logo? > > That didn't occur to me previously, but it does make sense now that you > mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > can avoid possible regressions for folks who might start to rely on > CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > > Cheers, > Peter > > From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Thanks for your patch! > --- a/Documentation/fb/fbcon.txt > +++ b/Documentation/fb/fbcon.txt > @@ -163,6 +163,12 @@ C. Boot options > be preserved until there actually is some text is output to the console. > This option causes fbcon to bind immediately to the fbdev device. > > +7. fbcon=center-logo > + > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed due to > + multiple CPUs, the collected line of logos is centered as a whole. > + What about making this more generic, than an option specific for centering? Else people want fbcon=left-logo or fbcon=right-logo soon? fbcon=logo-pos:<pos> With <pos> being "center", "left", "top", "right", "bottom", and combinations like "top,center"? Or is that complicating stuff too much? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 8:40 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 8:40 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Jonathan Corbet, Linux Documentation List, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-06 10:33, Geert Uytterhoeven wrote: > > On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >> extra logos are not considered when centering the first logo vertically. > >> > >> Signed-off-by: Peter Rosin <peda@axentia.se> > > > >> --- a/drivers/video/logo/Kconfig > >> +++ b/drivers/video/logo/Kconfig > >> @@ -10,6 +10,15 @@ menuconfig LOGO > >> > >> if LOGO > >> > >> +config FB_LOGO_CENTER > >> + bool "Center the logo" > >> + depends on FB=y > >> + help > >> + When this option is selected, the bootup logo is centered both > >> + horizontally and vertically. If more than one logo is displayed > >> + due to multiple CPUs, the collected line of logos is centered > >> + as a whole. > >> + > > > > Isn't a kernel command line option more suitable to configure the position > > of the logo? > > That didn't occur to me previously, but it does make sense now that you > mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > can avoid possible regressions for folks who might start to rely on > CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > > Cheers, > Peter > > From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Thanks for your patch! > --- a/Documentation/fb/fbcon.txt > +++ b/Documentation/fb/fbcon.txt > @@ -163,6 +163,12 @@ C. Boot options > be preserved until there actually is some text is output to the console. > This option causes fbcon to bind immediately to the fbdev device. > > +7. fbcon=center-logo > + > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed due to > + multiple CPUs, the collected line of logos is centered as a whole. > + What about making this more generic, than an option specific for centering? Else people want fbcon=left-logo or fbcon=right-logo soon? fbcon=logo-pos:<pos> With <pos> being "center", "left", "top", "right", "bottom", and combinations like "top,center"? Or is that complicating stuff too much? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 8:40 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 8:40 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Jonathan Corbet, Linux Documentation List, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-06 10:33, Geert Uytterhoeven wrote: > > On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >> extra logos are not considered when centering the first logo vertically. > >> > >> Signed-off-by: Peter Rosin <peda@axentia.se> > > > >> --- a/drivers/video/logo/Kconfig > >> +++ b/drivers/video/logo/Kconfig > >> @@ -10,6 +10,15 @@ menuconfig LOGO > >> > >> if LOGO > >> > >> +config FB_LOGO_CENTER > >> + bool "Center the logo" > >> + depends on FB=y > >> + help > >> + When this option is selected, the bootup logo is centered both > >> + horizontally and vertically. If more than one logo is displayed > >> + due to multiple CPUs, the collected line of logos is centered > >> + as a whole. > >> + > > > > Isn't a kernel command line option more suitable to configure the position > > of the logo? > > That didn't occur to me previously, but it does make sense now that you > mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > can avoid possible regressions for folks who might start to rely on > CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > > Cheers, > Peter > > From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Thanks for your patch! > --- a/Documentation/fb/fbcon.txt > +++ b/Documentation/fb/fbcon.txt > @@ -163,6 +163,12 @@ C. Boot options > be preserved until there actually is some text is output to the console. > This option causes fbcon to bind immediately to the fbdev device. > > +7. fbconÎnter-logo > + > + When this option is selected, the bootup logo is centered both > + horizontally and vertically. If more than one logo is displayed due to > + multiple CPUs, the collected line of logos is centered as a whole. > + What about making this more generic, than an option specific for centering? Else people want fbcon=left-logo or fbcon=right-logo soon? fbcon=logo-pos:<pos> With <pos> being "center", "left", "top", "right", "bottom", and combinations like "top,center"? Or is that complicating stuff too much? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option 2019-01-07 8:40 ` Geert Uytterhoeven @ 2019-01-07 8:59 ` Peter Rosin -1 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 8:59 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 2019-01-07 09:40, Geert Uytterhoeven wrote: > Hi Peter, > > On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>> extra logos are not considered when centering the first logo vertically. >>>> >>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>> >>>> --- a/drivers/video/logo/Kconfig >>>> +++ b/drivers/video/logo/Kconfig >>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>> >>>> if LOGO >>>> >>>> +config FB_LOGO_CENTER >>>> + bool "Center the logo" >>>> + depends on FB=y >>>> + help >>>> + When this option is selected, the bootup logo is centered both >>>> + horizontally and vertically. If more than one logo is displayed >>>> + due to multiple CPUs, the collected line of logos is centered >>>> + as a whole. >>>> + >>> >>> Isn't a kernel command line option more suitable to configure the position >>> of the logo? >> >> That didn't occur to me previously, but it does make sense now that you >> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >> can avoid possible regressions for folks who might start to rely on >> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >> >> Cheers, >> Peter >> >> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >> From: Peter Rosin <peda@axentia.se> >> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >> Cc: Jonathan Corbet <corbet@lwn.net> >> Cc: Peter Rosin <peda@axentia.se> >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-fbdev@vger.kernel.org >> Cc: linux-doc@vger.kernel.org >> To: linux-kernel@vger.kernel.org >> Date: Mon, 7 Jan 2019 08:35:26 +0100 >> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >> option >> >> A command line option is much more flexible than a config option and >> the supporting code is small. Gets rid of #ifdefs in the code too... >> >> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Peter Rosin <peda@axentia.se> > > Thanks for your patch! > >> --- a/Documentation/fb/fbcon.txt >> +++ b/Documentation/fb/fbcon.txt >> @@ -163,6 +163,12 @@ C. Boot options >> be preserved until there actually is some text is output to the console. >> This option causes fbcon to bind immediately to the fbdev device. >> >> +7. fbcon=center-logo >> + >> + When this option is selected, the bootup logo is centered both >> + horizontally and vertically. If more than one logo is displayed due to >> + multiple CPUs, the collected line of logos is centered as a whole. >> + > > What about making this more generic, than an option specific for centering? > Else people want fbcon=left-logo or fbcon=right-logo soon? > > fbcon=logo-pos:<pos> > > With <pos> being "center", "left", "top", "right", "bottom", and combinations > like "top,center"? Or is that complicating stuff too much? I'm not too keen on implementing all that when I have zero use for it. I can however rename the trigger for the existing fb_center_logo bool to fbcon=logo-pos:center and add a check for "top,left" to reset the bool to false. Then the other variants can be added later by whomever and when needed. Is that good enough? Cheers, Peter ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 8:59 ` Peter Rosin 0 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 8:59 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List T24gMjAxOS0wMS0wNyAwOTo0MCwgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOg0KPiBIaSBQZXRl ciwNCj4gDQo+IE9uIE1vbiwgSmFuIDcsIDIwMTkgYXQgOToyNiBBTSBQZXRlciBSb3NpbiA8cGVk YUBheGVudGlhLnNlPiB3cm90ZToNCj4+IE9uIDIwMTktMDEtMDYgMTA6MzMsIEdlZXJ0IFV5dHRl cmhvZXZlbiB3cm90ZToNCj4+PiBPbiBNb24sIE5vdiAyNiwgMjAxOCBhdCAxMDo1OSBQTSBQZXRl ciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPiB3cm90ZToNCj4+Pj4gSWYgdGhlcmUgYXJlIGV4dHJh IGxvZ29zIChDT05GSUdfRkJfTE9HT19FWFRSQSkgdGhlIGhlaWdodHMgb2YgdGhlc2UNCj4+Pj4g ZXh0cmEgbG9nb3MgYXJlIG5vdCBjb25zaWRlcmVkIHdoZW4gY2VudGVyaW5nIHRoZSBmaXJzdCBs b2dvIHZlcnRpY2FsbHkuDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFJvc2luIDxw ZWRhQGF4ZW50aWEuc2U+DQo+Pj4NCj4+Pj4gLS0tIGEvZHJpdmVycy92aWRlby9sb2dvL0tjb25m aWcNCj4+Pj4gKysrIGIvZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcNCj4+Pj4gQEAgLTEwLDYg KzEwLDE1IEBAIG1lbnVjb25maWcgTE9HTw0KPj4+Pg0KPj4+PiAgaWYgTE9HTw0KPj4+Pg0KPj4+ PiArY29uZmlnIEZCX0xPR09fQ0VOVEVSDQo+Pj4+ICsgICAgICAgYm9vbCAiQ2VudGVyIHRoZSBs b2dvIg0KPj4+PiArICAgICAgIGRlcGVuZHMgb24gRkI9eQ0KPj4+PiArICAgICAgIGhlbHANCj4+ Pj4gKyAgICAgICAgIFdoZW4gdGhpcyBvcHRpb24gaXMgc2VsZWN0ZWQsIHRoZSBib290dXAgbG9n byBpcyBjZW50ZXJlZCBib3RoDQo+Pj4+ICsgICAgICAgICBob3Jpem9udGFsbHkgYW5kIHZlcnRp Y2FsbHkuIElmIG1vcmUgdGhhbiBvbmUgbG9nbyBpcyBkaXNwbGF5ZWQNCj4+Pj4gKyAgICAgICAg IGR1ZSB0byBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2YgbG9nb3MgaXMgY2Vu dGVyZWQNCj4+Pj4gKyAgICAgICAgIGFzIGEgd2hvbGUuDQo+Pj4+ICsNCj4+Pg0KPj4+IElzbid0 IGEga2VybmVsIGNvbW1hbmQgbGluZSBvcHRpb24gbW9yZSBzdWl0YWJsZSB0byBjb25maWd1cmUg dGhlIHBvc2l0aW9uDQo+Pj4gb2YgdGhlIGxvZ28/DQo+Pg0KPj4gVGhhdCBkaWRuJ3Qgb2NjdXIg dG8gbWUgcHJldmlvdXNseSwgYnV0IGl0IGRvZXMgbWFrZSBzZW5zZSBub3cgdGhhdCB5b3UNCj4+ IG1lbnRpb24gaXQuIFRoaXMgaXMgb24gdG9wIG9mIHY1LjAtcmMxLCBhbmQgaWYgYXBwbGllZCBi ZWZvcmUgdjUuMCB3ZQ0KPj4gY2FuIGF2b2lkIHBvc3NpYmxlIHJlZ3Jlc3Npb25zIGZvciBmb2xr cyB3aG8gbWlnaHQgc3RhcnQgdG8gcmVseSBvbg0KPj4gQ09ORklHX0ZCX0xPR09fQ0VOVEVSIGlm IHY1LjAgaXMgcmVsZWFzZWQgdy9vIHRoaXMuDQo+Pg0KPj4gQ2hlZXJzLA0KPj4gUGV0ZXINCj4+ DQo+PiBGcm9tIGRlNzM1M2FiNTE5YmE5YjVjOWVhM2Y2MmQ2MDdiYjhlOTRiNjg3Y2MgTW9uIFNl cCAxNyAwMDowMDowMCAyMDAxDQo+PiBGcm9tOiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNl Pg0KPj4gQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5n LmNvbT4NCj4+IENjOiBKb25hdGhhbiBDb3JiZXQgPGNvcmJldEBsd24ubmV0Pg0KPj4gQ2M6IFBl dGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQo+PiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZw0KPj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZw0KPj4gQ2M6IGxp bnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmcNCj4+IFRvOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwu b3JnDQo+PiBEYXRlOiBNb24sIDcgSmFuIDIwMTkgMDg6MzU6MjYgKzAxMDANCj4+IFN1YmplY3Q6 IFtQQVRDSF0gZmJkZXY6IGZibWVtOiBjb252ZXJ0IENPTkZJR19GQl9MT0dPX0NFTlRFUiBpbnRv IGEgY21kIGxpbmUNCj4+ICBvcHRpb24NCj4+DQo+PiBBIGNvbW1hbmQgbGluZSBvcHRpb24gaXMg bXVjaCBtb3JlIGZsZXhpYmxlIHRoYW4gYSBjb25maWcgb3B0aW9uIGFuZA0KPj4gdGhlIHN1cHBv cnRpbmcgY29kZSBpcyBzbWFsbC4gR2V0cyByaWQgb2YgI2lmZGVmcyBpbiB0aGUgY29kZSB0b28u Li4NCj4+DQo+PiBTdWdnZXN0ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnRAbGludXgt bTY4ay5vcmc+DQo+PiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNl Pg0KPiANCj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoIQ0KPiANCj4+IC0tLSBhL0RvY3VtZW50YXRp b24vZmIvZmJjb24udHh0DQo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2ZiL2ZiY29uLnR4dA0KPj4g QEAgLTE2Myw2ICsxNjMsMTIgQEAgQy4gQm9vdCBvcHRpb25zDQo+PiAgICAgICAgIGJlIHByZXNl cnZlZCB1bnRpbCB0aGVyZSBhY3R1YWxseSBpcyBzb21lIHRleHQgaXMgb3V0cHV0IHRvIHRoZSBj b25zb2xlLg0KPj4gICAgICAgICBUaGlzIG9wdGlvbiBjYXVzZXMgZmJjb24gdG8gYmluZCBpbW1l ZGlhdGVseSB0byB0aGUgZmJkZXYgZGV2aWNlLg0KPj4NCj4+ICs3LiBmYmNvbj1jZW50ZXItbG9n bw0KPj4gKw0KPj4gKyAgICAgICBXaGVuIHRoaXMgb3B0aW9uIGlzIHNlbGVjdGVkLCB0aGUgYm9v dHVwIGxvZ28gaXMgY2VudGVyZWQgYm90aA0KPj4gKyAgICAgICBob3Jpem9udGFsbHkgYW5kIHZl cnRpY2FsbHkuIElmIG1vcmUgdGhhbiBvbmUgbG9nbyBpcyBkaXNwbGF5ZWQgZHVlIHRvDQo+PiAr ICAgICAgIG11bHRpcGxlIENQVXMsIHRoZSBjb2xsZWN0ZWQgbGluZSBvZiBsb2dvcyBpcyBjZW50 ZXJlZCBhcyBhIHdob2xlLg0KPj4gKw0KPiANCj4gV2hhdCBhYm91dCBtYWtpbmcgdGhpcyBtb3Jl IGdlbmVyaWMsIHRoYW4gYW4gb3B0aW9uIHNwZWNpZmljIGZvciBjZW50ZXJpbmc/DQo+IEVsc2Ug cGVvcGxlIHdhbnQgZmJjb249bGVmdC1sb2dvIG9yIGZiY29uPXJpZ2h0LWxvZ28gc29vbj8NCj4g DQo+ICAgICBmYmNvbj1sb2dvLXBvczo8cG9zPg0KPiANCj4gV2l0aCA8cG9zPiBiZWluZyAiY2Vu dGVyIiwgImxlZnQiLCAidG9wIiwgInJpZ2h0IiwgImJvdHRvbSIsIGFuZCBjb21iaW5hdGlvbnMN Cj4gbGlrZSAidG9wLGNlbnRlciI/IE9yIGlzIHRoYXQgY29tcGxpY2F0aW5nIHN0dWZmIHRvbyBt dWNoPw0KDQpJJ20gbm90IHRvbyBrZWVuIG9uIGltcGxlbWVudGluZyBhbGwgdGhhdCB3aGVuIEkg aGF2ZSB6ZXJvIHVzZSBmb3IgaXQuIEkgY2FuDQpob3dldmVyIHJlbmFtZSB0aGUgdHJpZ2dlciBm b3IgdGhlIGV4aXN0aW5nIGZiX2NlbnRlcl9sb2dvIGJvb2wgdG8NCg0KCWZiY29uPWxvZ28tcG9z OmNlbnRlcg0KDQphbmQgYWRkIGEgY2hlY2sgZm9yICJ0b3AsbGVmdCIgdG8gcmVzZXQgdGhlIGJv b2wgdG8gZmFsc2UuIFRoZW4gdGhlIG90aGVyDQp2YXJpYW50cyBjYW4gYmUgYWRkZWQgbGF0ZXIg Ynkgd2hvbWV2ZXIgYW5kIHdoZW4gbmVlZGVkLg0KDQpJcyB0aGF0IGdvb2QgZW5vdWdoPw0KDQpD aGVlcnMsDQpQZXRlcg0K ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option 2019-01-07 8:59 ` Peter Rosin @ 2019-01-07 9:02 ` Peter Rosin -1 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 9:02 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 2019-01-07 09:59, Peter Rosin wrote: > On 2019-01-07 09:40, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>>> extra logos are not considered when centering the first logo vertically. >>>>> >>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>> >>>>> --- a/drivers/video/logo/Kconfig >>>>> +++ b/drivers/video/logo/Kconfig >>>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>>> >>>>> if LOGO >>>>> >>>>> +config FB_LOGO_CENTER >>>>> + bool "Center the logo" >>>>> + depends on FB=y >>>>> + help >>>>> + When this option is selected, the bootup logo is centered both >>>>> + horizontally and vertically. If more than one logo is displayed >>>>> + due to multiple CPUs, the collected line of logos is centered >>>>> + as a whole. >>>>> + >>>> >>>> Isn't a kernel command line option more suitable to configure the position >>>> of the logo? >>> >>> That didn't occur to me previously, but it does make sense now that you >>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >>> can avoid possible regressions for folks who might start to rely on >>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >>> >>> Cheers, >>> Peter >>> >>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >>> From: Peter Rosin <peda@axentia.se> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>> Cc: Jonathan Corbet <corbet@lwn.net> >>> Cc: Peter Rosin <peda@axentia.se> >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: linux-doc@vger.kernel.org >>> To: linux-kernel@vger.kernel.org >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >>> option >>> >>> A command line option is much more flexible than a config option and >>> the supporting code is small. Gets rid of #ifdefs in the code too... >>> >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >> >> Thanks for your patch! >> >>> --- a/Documentation/fb/fbcon.txt >>> +++ b/Documentation/fb/fbcon.txt >>> @@ -163,6 +163,12 @@ C. Boot options >>> be preserved until there actually is some text is output to the console. >>> This option causes fbcon to bind immediately to the fbdev device. >>> >>> +7. fbcon=center-logo >>> + >>> + When this option is selected, the bootup logo is centered both >>> + horizontally and vertically. If more than one logo is displayed due to >>> + multiple CPUs, the collected line of logos is centered as a whole. >>> + >> >> What about making this more generic, than an option specific for centering? >> Else people want fbcon=left-logo or fbcon=right-logo soon? >> >> fbcon=logo-pos:<pos> >> >> With <pos> being "center", "left", "top", "right", "bottom", and combinations >> like "top,center"? Or is that complicating stuff too much? > > I'm not too keen on implementing all that when I have zero use for it. I can > however rename the trigger for the existing fb_center_logo bool to > > fbcon=logo-pos:center > > and add a check for "top,left" to reset the bool to false. Then the other > variants can be added later by whomever and when needed. > > Is that good enough? Ouch, I just realized that using a comma is a no-go, as that is already separating fbcon suboptions, so I suggest top-left instead. Cheers, Peter ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 9:02 ` Peter Rosin 0 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 9:02 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List T24gMjAxOS0wMS0wNyAwOTo1OSwgUGV0ZXIgUm9zaW4gd3JvdGU6DQo+IE9uIDIwMTktMDEtMDcg MDk6NDAsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToNCj4+IEhpIFBldGVyLA0KPj4NCj4+IE9u IE1vbiwgSmFuIDcsIDIwMTkgYXQgOToyNiBBTSBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNl PiB3cm90ZToNCj4+PiBPbiAyMDE5LTAxLTA2IDEwOjMzLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3Jv dGU6DQo+Pj4+IE9uIE1vbiwgTm92IDI2LCAyMDE4IGF0IDEwOjU5IFBNIFBldGVyIFJvc2luIDxw ZWRhQGF4ZW50aWEuc2U+IHdyb3RlOg0KPj4+Pj4gSWYgdGhlcmUgYXJlIGV4dHJhIGxvZ29zIChD T05GSUdfRkJfTE9HT19FWFRSQSkgdGhlIGhlaWdodHMgb2YgdGhlc2UNCj4+Pj4+IGV4dHJhIGxv Z29zIGFyZSBub3QgY29uc2lkZXJlZCB3aGVuIGNlbnRlcmluZyB0aGUgZmlyc3QgbG9nbyB2ZXJ0 aWNhbGx5Lg0KPj4+Pj4NCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFJvc2luIDxwZWRhQGF4 ZW50aWEuc2U+DQo+Pj4+DQo+Pj4+PiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2xvZ28vS2NvbmZpZw0K Pj4+Pj4gKysrIGIvZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcNCj4+Pj4+IEBAIC0xMCw2ICsx MCwxNSBAQCBtZW51Y29uZmlnIExPR08NCj4+Pj4+DQo+Pj4+PiAgaWYgTE9HTw0KPj4+Pj4NCj4+ Pj4+ICtjb25maWcgRkJfTE9HT19DRU5URVINCj4+Pj4+ICsgICAgICAgYm9vbCAiQ2VudGVyIHRo ZSBsb2dvIg0KPj4+Pj4gKyAgICAgICBkZXBlbmRzIG9uIEZCPXkNCj4+Pj4+ICsgICAgICAgaGVs cA0KPj4+Pj4gKyAgICAgICAgIFdoZW4gdGhpcyBvcHRpb24gaXMgc2VsZWN0ZWQsIHRoZSBib290 dXAgbG9nbyBpcyBjZW50ZXJlZCBib3RoDQo+Pj4+PiArICAgICAgICAgaG9yaXpvbnRhbGx5IGFu ZCB2ZXJ0aWNhbGx5LiBJZiBtb3JlIHRoYW4gb25lIGxvZ28gaXMgZGlzcGxheWVkDQo+Pj4+PiAr ICAgICAgICAgZHVlIHRvIG11bHRpcGxlIENQVXMsIHRoZSBjb2xsZWN0ZWQgbGluZSBvZiBsb2dv cyBpcyBjZW50ZXJlZA0KPj4+Pj4gKyAgICAgICAgIGFzIGEgd2hvbGUuDQo+Pj4+PiArDQo+Pj4+ DQo+Pj4+IElzbid0IGEga2VybmVsIGNvbW1hbmQgbGluZSBvcHRpb24gbW9yZSBzdWl0YWJsZSB0 byBjb25maWd1cmUgdGhlIHBvc2l0aW9uDQo+Pj4+IG9mIHRoZSBsb2dvPw0KPj4+DQo+Pj4gVGhh dCBkaWRuJ3Qgb2NjdXIgdG8gbWUgcHJldmlvdXNseSwgYnV0IGl0IGRvZXMgbWFrZSBzZW5zZSBu b3cgdGhhdCB5b3UNCj4+PiBtZW50aW9uIGl0LiBUaGlzIGlzIG9uIHRvcCBvZiB2NS4wLXJjMSwg YW5kIGlmIGFwcGxpZWQgYmVmb3JlIHY1LjAgd2UNCj4+PiBjYW4gYXZvaWQgcG9zc2libGUgcmVn cmVzc2lvbnMgZm9yIGZvbGtzIHdobyBtaWdodCBzdGFydCB0byByZWx5IG9uDQo+Pj4gQ09ORklH X0ZCX0xPR09fQ0VOVEVSIGlmIHY1LjAgaXMgcmVsZWFzZWQgdy9vIHRoaXMuDQo+Pj4NCj4+PiBD aGVlcnMsDQo+Pj4gUGV0ZXINCj4+Pg0KPj4+IEZyb20gZGU3MzUzYWI1MTliYTliNWM5ZWEzZjYy ZDYwN2JiOGU5NGI2ODdjYyBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDENCj4+PiBGcm9tOiBQZXRl ciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPg0KPj4+IENjOiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3 aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+DQo+Pj4gQ2M6IEpvbmF0aGFuIENvcmJldCA8 Y29yYmV0QGx3bi5uZXQ+DQo+Pj4gQ2M6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQo+ Pj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4+PiBDYzogbGludXgtZmJk ZXZAdmdlci5rZXJuZWwub3JnDQo+Pj4gQ2M6IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmcNCj4+ PiBUbzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KPj4+IERhdGU6IE1vbiwgNyBKYW4g MjAxOSAwODozNToyNiArMDEwMA0KPj4+IFN1YmplY3Q6IFtQQVRDSF0gZmJkZXY6IGZibWVtOiBj b252ZXJ0IENPTkZJR19GQl9MT0dPX0NFTlRFUiBpbnRvIGEgY21kIGxpbmUNCj4+PiAgb3B0aW9u DQo+Pj4NCj4+PiBBIGNvbW1hbmQgbGluZSBvcHRpb24gaXMgbXVjaCBtb3JlIGZsZXhpYmxlIHRo YW4gYSBjb25maWcgb3B0aW9uIGFuZA0KPj4+IHRoZSBzdXBwb3J0aW5nIGNvZGUgaXMgc21hbGwu IEdldHMgcmlkIG9mICNpZmRlZnMgaW4gdGhlIGNvZGUgdG9vLi4uDQo+Pj4NCj4+PiBTdWdnZXN0 ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnRAbGludXgtbTY4ay5vcmc+DQo+Pj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4NCj4+DQo+PiBUaGFua3Mg Zm9yIHlvdXIgcGF0Y2ghDQo+Pg0KPj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZmIvZmJjb24udHh0 DQo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9mYi9mYmNvbi50eHQNCj4+PiBAQCAtMTYzLDYgKzE2 MywxMiBAQCBDLiBCb290IG9wdGlvbnMNCj4+PiAgICAgICAgIGJlIHByZXNlcnZlZCB1bnRpbCB0 aGVyZSBhY3R1YWxseSBpcyBzb21lIHRleHQgaXMgb3V0cHV0IHRvIHRoZSBjb25zb2xlLg0KPj4+ ICAgICAgICAgVGhpcyBvcHRpb24gY2F1c2VzIGZiY29uIHRvIGJpbmQgaW1tZWRpYXRlbHkgdG8g dGhlIGZiZGV2IGRldmljZS4NCj4+Pg0KPj4+ICs3LiBmYmNvbj1jZW50ZXItbG9nbw0KPj4+ICsN Cj4+PiArICAgICAgIFdoZW4gdGhpcyBvcHRpb24gaXMgc2VsZWN0ZWQsIHRoZSBib290dXAgbG9n byBpcyBjZW50ZXJlZCBib3RoDQo+Pj4gKyAgICAgICBob3Jpem9udGFsbHkgYW5kIHZlcnRpY2Fs bHkuIElmIG1vcmUgdGhhbiBvbmUgbG9nbyBpcyBkaXNwbGF5ZWQgZHVlIHRvDQo+Pj4gKyAgICAg ICBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2YgbG9nb3MgaXMgY2VudGVyZWQg YXMgYSB3aG9sZS4NCj4+PiArDQo+Pg0KPj4gV2hhdCBhYm91dCBtYWtpbmcgdGhpcyBtb3JlIGdl bmVyaWMsIHRoYW4gYW4gb3B0aW9uIHNwZWNpZmljIGZvciBjZW50ZXJpbmc/DQo+PiBFbHNlIHBl b3BsZSB3YW50IGZiY29uPWxlZnQtbG9nbyBvciBmYmNvbj1yaWdodC1sb2dvIHNvb24/DQo+Pg0K Pj4gICAgIGZiY29uPWxvZ28tcG9zOjxwb3M+DQo+Pg0KPj4gV2l0aCA8cG9zPiBiZWluZyAiY2Vu dGVyIiwgImxlZnQiLCAidG9wIiwgInJpZ2h0IiwgImJvdHRvbSIsIGFuZCBjb21iaW5hdGlvbnMN Cj4+IGxpa2UgInRvcCxjZW50ZXIiPyBPciBpcyB0aGF0IGNvbXBsaWNhdGluZyBzdHVmZiB0b28g bXVjaD8NCj4gDQo+IEknbSBub3QgdG9vIGtlZW4gb24gaW1wbGVtZW50aW5nIGFsbCB0aGF0IHdo ZW4gSSBoYXZlIHplcm8gdXNlIGZvciBpdC4gSSBjYW4NCj4gaG93ZXZlciByZW5hbWUgdGhlIHRy aWdnZXIgZm9yIHRoZSBleGlzdGluZyBmYl9jZW50ZXJfbG9nbyBib29sIHRvDQo+IA0KPiAJZmJj b249bG9nby1wb3M6Y2VudGVyDQo+IA0KPiBhbmQgYWRkIGEgY2hlY2sgZm9yICJ0b3AsbGVmdCIg dG8gcmVzZXQgdGhlIGJvb2wgdG8gZmFsc2UuIFRoZW4gdGhlIG90aGVyDQo+IHZhcmlhbnRzIGNh biBiZSBhZGRlZCBsYXRlciBieSB3aG9tZXZlciBhbmQgd2hlbiBuZWVkZWQuDQo+IA0KPiBJcyB0 aGF0IGdvb2QgZW5vdWdoPw0KDQpPdWNoLCBJIGp1c3QgcmVhbGl6ZWQgdGhhdCB1c2luZyBhIGNv bW1hIGlzIGEgbm8tZ28sIGFzIHRoYXQgaXMgYWxyZWFkeQ0Kc2VwYXJhdGluZyBmYmNvbiBzdWJv cHRpb25zLCBzbyBJIHN1Z2dlc3QgdG9wLWxlZnQgaW5zdGVhZC4NCg0KQ2hlZXJzLA0KUGV0ZXIN Cg= ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option 2019-01-07 9:02 ` Peter Rosin (?) @ 2019-01-07 9:11 ` Geert Uytterhoeven -1 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 9:11 UTC (permalink / raw) To: Peter Rosin Cc: Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List Hi Peter, On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-07 09:59, Peter Rosin wrote: > > On 2019-01-07 09:40, Geert Uytterhoeven wrote: > >> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > >>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: > >>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >>>>> extra logos are not considered when centering the first logo vertically. > >>>>> > >>>>> Signed-off-by: Peter Rosin <peda@axentia.se> > >>>> > >>>>> --- a/drivers/video/logo/Kconfig > >>>>> +++ b/drivers/video/logo/Kconfig > >>>>> @@ -10,6 +10,15 @@ menuconfig LOGO > >>>>> > >>>>> if LOGO > >>>>> > >>>>> +config FB_LOGO_CENTER > >>>>> + bool "Center the logo" > >>>>> + depends on FB=y > >>>>> + help > >>>>> + When this option is selected, the bootup logo is centered both > >>>>> + horizontally and vertically. If more than one logo is displayed > >>>>> + due to multiple CPUs, the collected line of logos is centered > >>>>> + as a whole. > >>>>> + > >>>> > >>>> Isn't a kernel command line option more suitable to configure the position > >>>> of the logo? > >>> > >>> That didn't occur to me previously, but it does make sense now that you > >>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > >>> can avoid possible regressions for folks who might start to rely on > >>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > >>> > >>> Cheers, > >>> Peter > >>> > >>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > >>> From: Peter Rosin <peda@axentia.se> > >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > >>> Cc: Jonathan Corbet <corbet@lwn.net> > >>> Cc: Peter Rosin <peda@axentia.se> > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: linux-doc@vger.kernel.org > >>> To: linux-kernel@vger.kernel.org > >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 > >>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > >>> option > >>> > >>> A command line option is much more flexible than a config option and > >>> the supporting code is small. Gets rid of #ifdefs in the code too... > >>> > >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > >>> Signed-off-by: Peter Rosin <peda@axentia.se> > >> > >> Thanks for your patch! > >> > >>> --- a/Documentation/fb/fbcon.txt > >>> +++ b/Documentation/fb/fbcon.txt > >>> @@ -163,6 +163,12 @@ C. Boot options > >>> be preserved until there actually is some text is output to the console. > >>> This option causes fbcon to bind immediately to the fbdev device. > >>> > >>> +7. fbcon=center-logo > >>> + > >>> + When this option is selected, the bootup logo is centered both > >>> + horizontally and vertically. If more than one logo is displayed due to > >>> + multiple CPUs, the collected line of logos is centered as a whole. > >>> + > >> > >> What about making this more generic, than an option specific for centering? > >> Else people want fbcon=left-logo or fbcon=right-logo soon? > >> > >> fbcon=logo-pos:<pos> > >> > >> With <pos> being "center", "left", "top", "right", "bottom", and combinations > >> like "top,center"? Or is that complicating stuff too much? > > > > I'm not too keen on implementing all that when I have zero use for it. I can > > however rename the trigger for the existing fb_center_logo bool to > > > > fbcon=logo-pos:center > > > > and add a check for "top,left" to reset the bool to false. Then the other > > variants can be added later by whomever and when needed. > > > > Is that good enough? > > Ouch, I just realized that using a comma is a no-go, as that is already > separating fbcon suboptions, so I suggest top-left instead. Sure, sounds fine to me. I just want to avoid having a parameter system that complicates future extension. I think you can drop the check for top-left, as the bool defaults to false. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 9:11 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 9:11 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Jonathan Corbet, Linux Documentation List, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-07 09:59, Peter Rosin wrote: > > On 2019-01-07 09:40, Geert Uytterhoeven wrote: > >> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > >>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: > >>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >>>>> extra logos are not considered when centering the first logo vertically. > >>>>> > >>>>> Signed-off-by: Peter Rosin <peda@axentia.se> > >>>> > >>>>> --- a/drivers/video/logo/Kconfig > >>>>> +++ b/drivers/video/logo/Kconfig > >>>>> @@ -10,6 +10,15 @@ menuconfig LOGO > >>>>> > >>>>> if LOGO > >>>>> > >>>>> +config FB_LOGO_CENTER > >>>>> + bool "Center the logo" > >>>>> + depends on FB=y > >>>>> + help > >>>>> + When this option is selected, the bootup logo is centered both > >>>>> + horizontally and vertically. If more than one logo is displayed > >>>>> + due to multiple CPUs, the collected line of logos is centered > >>>>> + as a whole. > >>>>> + > >>>> > >>>> Isn't a kernel command line option more suitable to configure the position > >>>> of the logo? > >>> > >>> That didn't occur to me previously, but it does make sense now that you > >>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > >>> can avoid possible regressions for folks who might start to rely on > >>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > >>> > >>> Cheers, > >>> Peter > >>> > >>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > >>> From: Peter Rosin <peda@axentia.se> > >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > >>> Cc: Jonathan Corbet <corbet@lwn.net> > >>> Cc: Peter Rosin <peda@axentia.se> > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: linux-doc@vger.kernel.org > >>> To: linux-kernel@vger.kernel.org > >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 > >>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > >>> option > >>> > >>> A command line option is much more flexible than a config option and > >>> the supporting code is small. Gets rid of #ifdefs in the code too... > >>> > >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > >>> Signed-off-by: Peter Rosin <peda@axentia.se> > >> > >> Thanks for your patch! > >> > >>> --- a/Documentation/fb/fbcon.txt > >>> +++ b/Documentation/fb/fbcon.txt > >>> @@ -163,6 +163,12 @@ C. Boot options > >>> be preserved until there actually is some text is output to the console. > >>> This option causes fbcon to bind immediately to the fbdev device. > >>> > >>> +7. fbcon=center-logo > >>> + > >>> + When this option is selected, the bootup logo is centered both > >>> + horizontally and vertically. If more than one logo is displayed due to > >>> + multiple CPUs, the collected line of logos is centered as a whole. > >>> + > >> > >> What about making this more generic, than an option specific for centering? > >> Else people want fbcon=left-logo or fbcon=right-logo soon? > >> > >> fbcon=logo-pos:<pos> > >> > >> With <pos> being "center", "left", "top", "right", "bottom", and combinations > >> like "top,center"? Or is that complicating stuff too much? > > > > I'm not too keen on implementing all that when I have zero use for it. I can > > however rename the trigger for the existing fb_center_logo bool to > > > > fbcon=logo-pos:center > > > > and add a check for "top,left" to reset the bool to false. Then the other > > variants can be added later by whomever and when needed. > > > > Is that good enough? > > Ouch, I just realized that using a comma is a no-go, as that is already > separating fbcon suboptions, so I suggest top-left instead. Sure, sounds fine to me. I just want to avoid having a parameter system that complicates future extension. I think you can drop the check for top-left, as the bool defaults to false. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option @ 2019-01-07 9:11 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2019-01-07 9:11 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Jonathan Corbet, Linux Documentation List, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz Hi Peter, On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: > On 2019-01-07 09:59, Peter Rosin wrote: > > On 2019-01-07 09:40, Geert Uytterhoeven wrote: > >> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: > >>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: > >>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: > >>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > >>>>> extra logos are not considered when centering the first logo vertically. > >>>>> > >>>>> Signed-off-by: Peter Rosin <peda@axentia.se> > >>>> > >>>>> --- a/drivers/video/logo/Kconfig > >>>>> +++ b/drivers/video/logo/Kconfig > >>>>> @@ -10,6 +10,15 @@ menuconfig LOGO > >>>>> > >>>>> if LOGO > >>>>> > >>>>> +config FB_LOGO_CENTER > >>>>> + bool "Center the logo" > >>>>> + depends on FB=y > >>>>> + help > >>>>> + When this option is selected, the bootup logo is centered both > >>>>> + horizontally and vertically. If more than one logo is displayed > >>>>> + due to multiple CPUs, the collected line of logos is centered > >>>>> + as a whole. > >>>>> + > >>>> > >>>> Isn't a kernel command line option more suitable to configure the position > >>>> of the logo? > >>> > >>> That didn't occur to me previously, but it does make sense now that you > >>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we > >>> can avoid possible regressions for folks who might start to rely on > >>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. > >>> > >>> Cheers, > >>> Peter > >>> > >>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 > >>> From: Peter Rosin <peda@axentia.se> > >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > >>> Cc: Jonathan Corbet <corbet@lwn.net> > >>> Cc: Peter Rosin <peda@axentia.se> > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: linux-doc@vger.kernel.org > >>> To: linux-kernel@vger.kernel.org > >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 > >>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line > >>> option > >>> > >>> A command line option is much more flexible than a config option and > >>> the supporting code is small. Gets rid of #ifdefs in the code too... > >>> > >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > >>> Signed-off-by: Peter Rosin <peda@axentia.se> > >> > >> Thanks for your patch! > >> > >>> --- a/Documentation/fb/fbcon.txt > >>> +++ b/Documentation/fb/fbcon.txt > >>> @@ -163,6 +163,12 @@ C. Boot options > >>> be preserved until there actually is some text is output to the console. > >>> This option causes fbcon to bind immediately to the fbdev device. > >>> > >>> +7. fbconÎnter-logo > >>> + > >>> + When this option is selected, the bootup logo is centered both > >>> + horizontally and vertically. If more than one logo is displayed due to > >>> + multiple CPUs, the collected line of logos is centered as a whole. > >>> + > >> > >> What about making this more generic, than an option specific for centering? > >> Else people want fbcon=left-logo or fbcon=right-logo soon? > >> > >> fbcon=logo-pos:<pos> > >> > >> With <pos> being "center", "left", "top", "right", "bottom", and combinations > >> like "top,center"? Or is that complicating stuff too much? > > > > I'm not too keen on implementing all that when I have zero use for it. I can > > however rename the trigger for the existing fb_center_logo bool to > > > > fbcon=logo-pos:center > > > > and add a check for "top,left" to reset the bool to false. Then the other > > variants can be added later by whomever and when needed. > > > > Is that good enough? > > Ouch, I just realized that using a comma is a no-go, as that is already > separating fbcon suboptions, so I suggest top-left instead. Sure, sounds fine to me. I just want to avoid having a parameter system that complicates future extension. I think you can drop the check for top-left, as the bool defaults to false. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option 2019-01-07 9:11 ` Geert Uytterhoeven @ 2019-01-07 10:35 ` Peter Rosin -1 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 10:35 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 2019-01-07 10:11, Geert Uytterhoeven wrote: > Hi Peter, > > On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: >> On 2019-01-07 09:59, Peter Rosin wrote: >>> On 2019-01-07 09:40, Geert Uytterhoeven wrote: >>>> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >>>>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>>>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>>>>> extra logos are not considered when centering the first logo vertically. >>>>>>> >>>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>>> >>>>>>> --- a/drivers/video/logo/Kconfig >>>>>>> +++ b/drivers/video/logo/Kconfig >>>>>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>>>>> >>>>>>> if LOGO >>>>>>> >>>>>>> +config FB_LOGO_CENTER >>>>>>> + bool "Center the logo" >>>>>>> + depends on FB=y >>>>>>> + help >>>>>>> + When this option is selected, the bootup logo is centered both >>>>>>> + horizontally and vertically. If more than one logo is displayed >>>>>>> + due to multiple CPUs, the collected line of logos is centered >>>>>>> + as a whole. >>>>>>> + >>>>>> >>>>>> Isn't a kernel command line option more suitable to configure the position >>>>>> of the logo? >>>>> >>>>> That didn't occur to me previously, but it does make sense now that you >>>>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >>>>> can avoid possible regressions for folks who might start to rely on >>>>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >>>>> >>>>> Cheers, >>>>> Peter >>>>> >>>>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >>>>> From: Peter Rosin <peda@axentia.se> >>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>>>> Cc: Jonathan Corbet <corbet@lwn.net> >>>>> Cc: Peter Rosin <peda@axentia.se> >>>>> Cc: dri-devel@lists.freedesktop.org >>>>> Cc: linux-fbdev@vger.kernel.org >>>>> Cc: linux-doc@vger.kernel.org >>>>> To: linux-kernel@vger.kernel.org >>>>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>>>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >>>>> option >>>>> >>>>> A command line option is much more flexible than a config option and >>>>> the supporting code is small. Gets rid of #ifdefs in the code too... >>>>> >>>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>> >>>> Thanks for your patch! >>>> >>>>> --- a/Documentation/fb/fbcon.txt >>>>> +++ b/Documentation/fb/fbcon.txt >>>>> @@ -163,6 +163,12 @@ C. Boot options >>>>> be preserved until there actually is some text is output to the console. >>>>> This option causes fbcon to bind immediately to the fbdev device. >>>>> >>>>> +7. fbcon=center-logo >>>>> + >>>>> + When this option is selected, the bootup logo is centered both >>>>> + horizontally and vertically. If more than one logo is displayed due to >>>>> + multiple CPUs, the collected line of logos is centered as a whole. >>>>> + >>>> >>>> What about making this more generic, than an option specific for centering? >>>> Else people want fbcon=left-logo or fbcon=right-logo soon? >>>> >>>> fbcon=logo-pos:<pos> >>>> >>>> With <pos> being "center", "left", "top", "right", "bottom", and combinations >>>> like "top,center"? Or is that complicating stuff too much? >>> >>> I'm not too keen on implementing all that when I have zero use for it. I can >>> however rename the trigger for the existing fb_center_logo bool to >>> >>> fbcon=logo-pos:center >>> >>> and add a check for "top,left" to reset the bool to false. Then the other >>> variants can be added later by whomever and when needed. >>> >>> Is that good enough? >> >> Ouch, I just realized that using a comma is a no-go, as that is already >> separating fbcon suboptions, so I suggest top-left instead. > > Sure, sounds fine to me. I just want to avoid having a parameter system > that complicates future extension. > I think you can drop the check for top-left, as the bool defaults to false. Right. So, here's an update... Again, it would probably be best if this went in before 5.0 is released. Changes since v1: - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust the help text accordingly). Cheers, Peter From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 From: Peter Rosin <peda@axentia.se> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Peter Rosin <peda@axentia.se> Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Cc: linux-doc@vger.kernel.org To: linux-kernel@vger.kernel.org Date: Mon, 7 Jan 2019 08:35:26 +0100 Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line option A command line option is much more flexible than a config option and the supporting code is small. Gets rid of #ifdefs in the code too... Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Peter Rosin <peda@axentia.se> --- Documentation/fb/fbcon.txt | 8 ++++++++ drivers/video/fbdev/core/fbcon.c | 7 +++++++ drivers/video/fbdev/core/fbmem.c | 19 ++++++++++--------- drivers/video/logo/Kconfig | 9 --------- include/linux/fb.h | 1 + 5 files changed, 26 insertions(+), 18 deletions(-) diff --git a/Documentation/fb/fbcon.txt b/Documentation/fb/fbcon.txt index 62af30511a95..60a5ec04e8f0 100644 --- a/Documentation/fb/fbcon.txt +++ b/Documentation/fb/fbcon.txt @@ -163,6 +163,14 @@ C. Boot options be preserved until there actually is some text is output to the console. This option causes fbcon to bind immediately to the fbdev device. +7. fbcon=logo-pos:<location> + + The only possible 'location' is 'center' (without quotes), and when + given, the bootup logo is moved from the default top-left corner + location to the center of the framebuffer. If more than one logo is + displayed due to multiple CPUs, the collected line of logos is moved + as a whole. + C. Attaching, Detaching and Unloading Before going on to how to attach, detach and unload the framebuffer console, an diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 8976190b6c1f..bfa1360ec750 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -510,6 +510,13 @@ static int __init fb_console_setup(char *this_opt) continue; } #endif + + if (!strncmp(options, "logo-pos:", 9)) { + options += 9; + if (!strcmp(options, "center")) + fb_center_logo = true; + continue; + } } return 1; } diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 558ed2ed3124..cb43a2258c51 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -53,6 +53,9 @@ EXPORT_SYMBOL(registered_fb); int num_registered_fb __read_mostly; EXPORT_SYMBOL(num_registered_fb); +bool fb_center_logo __read_mostly; +EXPORT_SYMBOL(fb_center_logo); + static struct fb_info *get_fb_info(unsigned int idx) { struct fb_info *fb_info; @@ -506,8 +509,7 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, fb_set_logo(info, logo, logo_new, fb_logo.depth); } -#ifdef CONFIG_FB_LOGO_CENTER - { + if (fb_center_logo) { int xres = info->var.xres; int yres = info->var.yres; @@ -520,11 +522,11 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, --n; image.dx = (xres - n * (logo->width + 8) - 8) / 2; image.dy = y ?: (yres - logo->height) / 2; + } else { + image.dx = 0; + image.dy = y; } -#else - image.dx = 0; - image.dy = y; -#endif + image.width = logo->width; image.height = logo->height; @@ -684,9 +686,8 @@ int fb_prepare_logo(struct fb_info *info, int rotate) } height = fb_logo.logo->height; -#ifdef CONFIG_FB_LOGO_CENTER - height += (yres - fb_logo.logo->height) / 2; -#endif + if (fb_center_logo) + height += (yres - fb_logo.logo->height) / 2; return fb_prepare_extra_logos(info, height, yres); } diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig index 1e972c4e88b1..d1f6196c8b9a 100644 --- a/drivers/video/logo/Kconfig +++ b/drivers/video/logo/Kconfig @@ -10,15 +10,6 @@ menuconfig LOGO if LOGO -config FB_LOGO_CENTER - bool "Center the logo" - depends on FB=y - help - When this option is selected, the bootup logo is centered both - horizontally and vertically. If more than one logo is displayed - due to multiple CPUs, the collected line of logos is centered - as a whole. - config FB_LOGO_EXTRA bool depends on FB=y diff --git a/include/linux/fb.h b/include/linux/fb.h index 7cdd31a69719..f52ef0ad6781 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -653,6 +653,7 @@ extern int fb_new_modelist(struct fb_info *info); extern struct fb_info *registered_fb[FB_MAX]; extern int num_registered_fb; +extern bool fb_center_logo; extern struct class *fb_class; #define for_each_registered_fb(i) \ -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-07 10:35 ` Peter Rosin 0 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-07 10:35 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List T24gMjAxOS0wMS0wNyAxMDoxMSwgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOg0KPiBIaSBQZXRl ciwNCj4gDQo+IE9uIE1vbiwgSmFuIDcsIDIwMTkgYXQgMTA6MDMgQU0gUGV0ZXIgUm9zaW4gPHBl ZGFAYXhlbnRpYS5zZT4gd3JvdGU6DQo+PiBPbiAyMDE5LTAxLTA3IDA5OjU5LCBQZXRlciBSb3Np biB3cm90ZToNCj4+PiBPbiAyMDE5LTAxLTA3IDA5OjQwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3Jv dGU6DQo+Pj4+IE9uIE1vbiwgSmFuIDcsIDIwMTkgYXQgOToyNiBBTSBQZXRlciBSb3NpbiA8cGVk YUBheGVudGlhLnNlPiB3cm90ZToNCj4+Pj4+IE9uIDIwMTktMDEtMDYgMTA6MzMsIEdlZXJ0IFV5 dHRlcmhvZXZlbiB3cm90ZToNCj4+Pj4+PiBPbiBNb24sIE5vdiAyNiwgMjAxOCBhdCAxMDo1OSBQ TSBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPiB3cm90ZToNCj4+Pj4+Pj4gSWYgdGhlcmUg YXJlIGV4dHJhIGxvZ29zIChDT05GSUdfRkJfTE9HT19FWFRSQSkgdGhlIGhlaWdodHMgb2YgdGhl c2UNCj4+Pj4+Pj4gZXh0cmEgbG9nb3MgYXJlIG5vdCBjb25zaWRlcmVkIHdoZW4gY2VudGVyaW5n IHRoZSBmaXJzdCBsb2dvIHZlcnRpY2FsbHkuDQo+Pj4+Pj4+DQo+Pj4+Pj4+IFNpZ25lZC1vZmYt Ynk6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQo+Pj4+Pj4NCj4+Pj4+Pj4gLS0tIGEv ZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcNCj4+Pj4+Pj4gKysrIGIvZHJpdmVycy92aWRlby9s b2dvL0tjb25maWcNCj4+Pj4+Pj4gQEAgLTEwLDYgKzEwLDE1IEBAIG1lbnVjb25maWcgTE9HTw0K Pj4+Pj4+Pg0KPj4+Pj4+PiAgaWYgTE9HTw0KPj4+Pj4+Pg0KPj4+Pj4+PiArY29uZmlnIEZCX0xP R09fQ0VOVEVSDQo+Pj4+Pj4+ICsgICAgICAgYm9vbCAiQ2VudGVyIHRoZSBsb2dvIg0KPj4+Pj4+ PiArICAgICAgIGRlcGVuZHMgb24gRkI9eQ0KPj4+Pj4+PiArICAgICAgIGhlbHANCj4+Pj4+Pj4g KyAgICAgICAgIFdoZW4gdGhpcyBvcHRpb24gaXMgc2VsZWN0ZWQsIHRoZSBib290dXAgbG9nbyBp cyBjZW50ZXJlZCBib3RoDQo+Pj4+Pj4+ICsgICAgICAgICBob3Jpem9udGFsbHkgYW5kIHZlcnRp Y2FsbHkuIElmIG1vcmUgdGhhbiBvbmUgbG9nbyBpcyBkaXNwbGF5ZWQNCj4+Pj4+Pj4gKyAgICAg ICAgIGR1ZSB0byBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2YgbG9nb3MgaXMg Y2VudGVyZWQNCj4+Pj4+Pj4gKyAgICAgICAgIGFzIGEgd2hvbGUuDQo+Pj4+Pj4+ICsNCj4+Pj4+ Pg0KPj4+Pj4+IElzbid0IGEga2VybmVsIGNvbW1hbmQgbGluZSBvcHRpb24gbW9yZSBzdWl0YWJs ZSB0byBjb25maWd1cmUgdGhlIHBvc2l0aW9uDQo+Pj4+Pj4gb2YgdGhlIGxvZ28/DQo+Pj4+Pg0K Pj4+Pj4gVGhhdCBkaWRuJ3Qgb2NjdXIgdG8gbWUgcHJldmlvdXNseSwgYnV0IGl0IGRvZXMgbWFr ZSBzZW5zZSBub3cgdGhhdCB5b3UNCj4+Pj4+IG1lbnRpb24gaXQuIFRoaXMgaXMgb24gdG9wIG9m IHY1LjAtcmMxLCBhbmQgaWYgYXBwbGllZCBiZWZvcmUgdjUuMCB3ZQ0KPj4+Pj4gY2FuIGF2b2lk IHBvc3NpYmxlIHJlZ3Jlc3Npb25zIGZvciBmb2xrcyB3aG8gbWlnaHQgc3RhcnQgdG8gcmVseSBv bg0KPj4+Pj4gQ09ORklHX0ZCX0xPR09fQ0VOVEVSIGlmIHY1LjAgaXMgcmVsZWFzZWQgdy9vIHRo aXMuDQo+Pj4+Pg0KPj4+Pj4gQ2hlZXJzLA0KPj4+Pj4gUGV0ZXINCj4+Pj4+DQo+Pj4+PiBGcm9t IGRlNzM1M2FiNTE5YmE5YjVjOWVhM2Y2MmQ2MDdiYjhlOTRiNjg3Y2MgTW9uIFNlcCAxNyAwMDow MDowMCAyMDAxDQo+Pj4+PiBGcm9tOiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPg0KPj4+ Pj4gQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNv bT4NCj4+Pj4+IENjOiBKb25hdGhhbiBDb3JiZXQgPGNvcmJldEBsd24ubmV0Pg0KPj4+Pj4gQ2M6 IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+DQo+Pj4+PiBDYzogZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZw0KPj4+Pj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZw0K Pj4+Pj4gQ2M6IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmcNCj4+Pj4+IFRvOiBsaW51eC1rZXJu ZWxAdmdlci5rZXJuZWwub3JnDQo+Pj4+PiBEYXRlOiBNb24sIDcgSmFuIDIwMTkgMDg6MzU6MjYg KzAxMDANCj4+Pj4+IFN1YmplY3Q6IFtQQVRDSF0gZmJkZXY6IGZibWVtOiBjb252ZXJ0IENPTkZJ R19GQl9MT0dPX0NFTlRFUiBpbnRvIGEgY21kIGxpbmUNCj4+Pj4+ICBvcHRpb24NCj4+Pj4+DQo+ Pj4+PiBBIGNvbW1hbmQgbGluZSBvcHRpb24gaXMgbXVjaCBtb3JlIGZsZXhpYmxlIHRoYW4gYSBj b25maWcgb3B0aW9uIGFuZA0KPj4+Pj4gdGhlIHN1cHBvcnRpbmcgY29kZSBpcyBzbWFsbC4gR2V0 cyByaWQgb2YgI2lmZGVmcyBpbiB0aGUgY29kZSB0b28uLi4NCj4+Pj4+DQo+Pj4+PiBTdWdnZXN0 ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnRAbGludXgtbTY4ay5vcmc+DQo+Pj4+PiBT aWduZWQtb2ZmLWJ5OiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPg0KPj4+Pg0KPj4+PiBU aGFua3MgZm9yIHlvdXIgcGF0Y2ghDQo+Pj4+DQo+Pj4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2Zi L2ZiY29uLnR4dA0KPj4+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9mYi9mYmNvbi50eHQNCj4+Pj4+ IEBAIC0xNjMsNiArMTYzLDEyIEBAIEMuIEJvb3Qgb3B0aW9ucw0KPj4+Pj4gICAgICAgICBiZSBw cmVzZXJ2ZWQgdW50aWwgdGhlcmUgYWN0dWFsbHkgaXMgc29tZSB0ZXh0IGlzIG91dHB1dCB0byB0 aGUgY29uc29sZS4NCj4+Pj4+ICAgICAgICAgVGhpcyBvcHRpb24gY2F1c2VzIGZiY29uIHRvIGJp bmQgaW1tZWRpYXRlbHkgdG8gdGhlIGZiZGV2IGRldmljZS4NCj4+Pj4+DQo+Pj4+PiArNy4gZmJj b249Y2VudGVyLWxvZ28NCj4+Pj4+ICsNCj4+Pj4+ICsgICAgICAgV2hlbiB0aGlzIG9wdGlvbiBp cyBzZWxlY3RlZCwgdGhlIGJvb3R1cCBsb2dvIGlzIGNlbnRlcmVkIGJvdGgNCj4+Pj4+ICsgICAg ICAgaG9yaXpvbnRhbGx5IGFuZCB2ZXJ0aWNhbGx5LiBJZiBtb3JlIHRoYW4gb25lIGxvZ28gaXMg ZGlzcGxheWVkIGR1ZSB0bw0KPj4+Pj4gKyAgICAgICBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVj dGVkIGxpbmUgb2YgbG9nb3MgaXMgY2VudGVyZWQgYXMgYSB3aG9sZS4NCj4+Pj4+ICsNCj4+Pj4N Cj4+Pj4gV2hhdCBhYm91dCBtYWtpbmcgdGhpcyBtb3JlIGdlbmVyaWMsIHRoYW4gYW4gb3B0aW9u IHNwZWNpZmljIGZvciBjZW50ZXJpbmc/DQo+Pj4+IEVsc2UgcGVvcGxlIHdhbnQgZmJjb249bGVm dC1sb2dvIG9yIGZiY29uPXJpZ2h0LWxvZ28gc29vbj8NCj4+Pj4NCj4+Pj4gICAgIGZiY29uPWxv Z28tcG9zOjxwb3M+DQo+Pj4+DQo+Pj4+IFdpdGggPHBvcz4gYmVpbmcgImNlbnRlciIsICJsZWZ0 IiwgInRvcCIsICJyaWdodCIsICJib3R0b20iLCBhbmQgY29tYmluYXRpb25zDQo+Pj4+IGxpa2Ug InRvcCxjZW50ZXIiPyBPciBpcyB0aGF0IGNvbXBsaWNhdGluZyBzdHVmZiB0b28gbXVjaD8NCj4+ Pg0KPj4+IEknbSBub3QgdG9vIGtlZW4gb24gaW1wbGVtZW50aW5nIGFsbCB0aGF0IHdoZW4gSSBo YXZlIHplcm8gdXNlIGZvciBpdC4gSSBjYW4NCj4+PiBob3dldmVyIHJlbmFtZSB0aGUgdHJpZ2dl ciBmb3IgdGhlIGV4aXN0aW5nIGZiX2NlbnRlcl9sb2dvIGJvb2wgdG8NCj4+Pg0KPj4+ICAgICAg IGZiY29uPWxvZ28tcG9zOmNlbnRlcg0KPj4+DQo+Pj4gYW5kIGFkZCBhIGNoZWNrIGZvciAidG9w LGxlZnQiIHRvIHJlc2V0IHRoZSBib29sIHRvIGZhbHNlLiBUaGVuIHRoZSBvdGhlcg0KPj4+IHZh cmlhbnRzIGNhbiBiZSBhZGRlZCBsYXRlciBieSB3aG9tZXZlciBhbmQgd2hlbiBuZWVkZWQuDQo+ Pj4NCj4+PiBJcyB0aGF0IGdvb2QgZW5vdWdoPw0KPj4NCj4+IE91Y2gsIEkganVzdCByZWFsaXpl ZCB0aGF0IHVzaW5nIGEgY29tbWEgaXMgYSBuby1nbywgYXMgdGhhdCBpcyBhbHJlYWR5DQo+PiBz ZXBhcmF0aW5nIGZiY29uIHN1Ym9wdGlvbnMsIHNvIEkgc3VnZ2VzdCB0b3AtbGVmdCBpbnN0ZWFk Lg0KPiANCj4gU3VyZSwgc291bmRzIGZpbmUgdG8gbWUuICBJIGp1c3Qgd2FudCB0byBhdm9pZCBo YXZpbmcgYSBwYXJhbWV0ZXIgc3lzdGVtDQo+IHRoYXQgY29tcGxpY2F0ZXMgZnV0dXJlIGV4dGVu c2lvbi4NCj4gSSB0aGluayB5b3UgY2FuIGRyb3AgdGhlIGNoZWNrIGZvciB0b3AtbGVmdCwgYXMg dGhlIGJvb2wgZGVmYXVsdHMgdG8gZmFsc2UuDQoNClJpZ2h0LiBTbywgaGVyZSdzIGFuIHVwZGF0 ZS4uLg0KDQpBZ2FpbiwgaXQgd291bGQgcHJvYmFibHkgYmUgYmVzdCBpZiB0aGlzIHdlbnQgaW4g YmVmb3JlIDUuMCBpcyByZWxlYXNlZC4NCg0KQ2hhbmdlcyBzaW5jZSB2MToNCi0gcmVuYW1lIGZy b20gZmJjb249Y2VudGVyLWxvZ28gb3B0aW9uIHRvIGZiY29uPWxvZ28tcG9zOmNlbnRlciAoYW5k IGFkanVzdA0KICB0aGUgaGVscCB0ZXh0IGFjY29yZGluZ2x5KS4NCg0KQ2hlZXJzLA0KUGV0ZXIN Cg0KRnJvbSBlYmZiMmZlYjdlYTQyOThhYzljMjIyZTZlYTZmOWM5YTkyNDUyMDg0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4NCkNj OiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+DQpD YzogSm9uYXRoYW4gQ29yYmV0IDxjb3JiZXRAbHduLm5ldD4NCkNjOiBQZXRlciBSb3NpbiA8cGVk YUBheGVudGlhLnNlPg0KQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCkNjOiBs aW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcNCkNjOiBsaW51eC1kb2NAdmdlci5rZXJuZWwub3Jn DQpUbzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KRGF0ZTogTW9uLCA3IEphbiAyMDE5 IDA4OjM1OjI2ICswMTAwDQpTdWJqZWN0OiBbUEFUQ0ggdjJdIGZiZGV2OiBmYm1lbTogY29udmVy dCBDT05GSUdfRkJfTE9HT19DRU5URVIgaW50byBhIGNtZA0KIGxpbmUgb3B0aW9uDQoNCkEgY29t bWFuZCBsaW5lIG9wdGlvbiBpcyBtdWNoIG1vcmUgZmxleGlibGUgdGhhbiBhIGNvbmZpZyBvcHRp b24gYW5kDQp0aGUgc3VwcG9ydGluZyBjb2RlIGlzIHNtYWxsLiBHZXRzIHJpZCBvZiAjaWZkZWZz IGluIHRoZSBjb2RlIHRvby4uLg0KDQpTdWdnZXN0ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8 Z2VlcnRAbGludXgtbTY4ay5vcmc+DQpTaWduZWQtb2ZmLWJ5OiBQZXRlciBSb3NpbiA8cGVkYUBh eGVudGlhLnNlPg0KLS0tDQogRG9jdW1lbnRhdGlvbi9mYi9mYmNvbi50eHQgICAgICAgfCAgOCAr KysrKysrKw0KIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYmNvbi5jIHwgIDcgKysrKysrKw0K IGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYm1lbS5jIHwgMTkgKysrKysrKysrKy0tLS0tLS0t LQ0KIGRyaXZlcnMvdmlkZW8vbG9nby9LY29uZmlnICAgICAgIHwgIDkgLS0tLS0tLS0tDQogaW5j bHVkZS9saW51eC9mYi5oICAgICAgICAgICAgICAgfCAgMSArDQogNSBmaWxlcyBjaGFuZ2VkLCAy NiBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZmIvZmJjb24udHh0IGIvRG9jdW1lbnRhdGlvbi9mYi9mYmNvbi50eHQNCmluZGV4IDYy YWYzMDUxMWE5NS4uNjBhNWVjMDRlOGYwIDEwMDY0NA0KLS0tIGEvRG9jdW1lbnRhdGlvbi9mYi9m YmNvbi50eHQNCisrKyBiL0RvY3VtZW50YXRpb24vZmIvZmJjb24udHh0DQpAQCAtMTYzLDYgKzE2 MywxNCBAQCBDLiBCb290IG9wdGlvbnMNCiAJYmUgcHJlc2VydmVkIHVudGlsIHRoZXJlIGFjdHVh bGx5IGlzIHNvbWUgdGV4dCBpcyBvdXRwdXQgdG8gdGhlIGNvbnNvbGUuDQogCVRoaXMgb3B0aW9u IGNhdXNlcyBmYmNvbiB0byBiaW5kIGltbWVkaWF0ZWx5IHRvIHRoZSBmYmRldiBkZXZpY2UuDQog DQorNy4gZmJjb249bG9nby1wb3M6PGxvY2F0aW9uPg0KKw0KKwlUaGUgb25seSBwb3NzaWJsZSAn bG9jYXRpb24nIGlzICdjZW50ZXInICh3aXRob3V0IHF1b3RlcyksIGFuZCB3aGVuDQorCWdpdmVu LCB0aGUgYm9vdHVwIGxvZ28gaXMgbW92ZWQgZnJvbSB0aGUgZGVmYXVsdCB0b3AtbGVmdCBjb3Ju ZXINCisJbG9jYXRpb24gdG8gdGhlIGNlbnRlciBvZiB0aGUgZnJhbWVidWZmZXIuIElmIG1vcmUg dGhhbiBvbmUgbG9nbyBpcw0KKwlkaXNwbGF5ZWQgZHVlIHRvIG11bHRpcGxlIENQVXMsIHRoZSBj b2xsZWN0ZWQgbGluZSBvZiBsb2dvcyBpcyBtb3ZlZA0KKwlhcyBhIHdob2xlLg0KKw0KIEMuIEF0 dGFjaGluZywgRGV0YWNoaW5nIGFuZCBVbmxvYWRpbmcNCiANCiBCZWZvcmUgZ29pbmcgb24gdG8g aG93IHRvIGF0dGFjaCwgZGV0YWNoIGFuZCB1bmxvYWQgdGhlIGZyYW1lYnVmZmVyIGNvbnNvbGUs IGFuDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZiY29uLmMgYi9kcml2 ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJjb24uYw0KaW5kZXggODk3NjE5MGI2YzFmLi5iZmExMzYw ZWM3NTAgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJjb24uYw0KKysr IGIvZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZiY29uLmMNCkBAIC01MTAsNiArNTEwLDEzIEBA IHN0YXRpYyBpbnQgX19pbml0IGZiX2NvbnNvbGVfc2V0dXAoY2hhciAqdGhpc19vcHQpDQogCQkJ Y29udGludWU7DQogCQl9DQogI2VuZGlmDQorDQorCQlpZiAoIXN0cm5jbXAob3B0aW9ucywgImxv Z28tcG9zOiIsIDkpKSB7DQorCQkJb3B0aW9ucyArPSA5Ow0KKwkJCWlmICghc3RyY21wKG9wdGlv bnMsICJjZW50ZXIiKSkNCisJCQkJZmJfY2VudGVyX2xvZ28gPSB0cnVlOw0KKwkJCWNvbnRpbnVl Ow0KKwkJfQ0KIAl9DQogCXJldHVybiAxOw0KIH0NCmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVv L2ZiZGV2L2NvcmUvZmJtZW0uYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYm1lbS5jDQpp bmRleCA1NThlZDJlZDMxMjQuLmNiNDNhMjI1OGM1MSAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvdmlk ZW8vZmJkZXYvY29yZS9mYm1lbS5jDQorKysgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJt ZW0uYw0KQEAgLTUzLDYgKzUzLDkgQEAgRVhQT1JUX1NZTUJPTChyZWdpc3RlcmVkX2ZiKTsNCiBp bnQgbnVtX3JlZ2lzdGVyZWRfZmIgX19yZWFkX21vc3RseTsNCiBFWFBPUlRfU1lNQk9MKG51bV9y ZWdpc3RlcmVkX2ZiKTsNCiANCitib29sIGZiX2NlbnRlcl9sb2dvIF9fcmVhZF9tb3N0bHk7DQor RVhQT1JUX1NZTUJPTChmYl9jZW50ZXJfbG9nbyk7DQorDQogc3RhdGljIHN0cnVjdCBmYl9pbmZv ICpnZXRfZmJfaW5mbyh1bnNpZ25lZCBpbnQgaWR4KQ0KIHsNCiAJc3RydWN0IGZiX2luZm8gKmZi X2luZm87DQpAQCAtNTA2LDggKzUwOSw3IEBAIHN0YXRpYyBpbnQgZmJfc2hvd19sb2dvX2xpbmUo c3RydWN0IGZiX2luZm8gKmluZm8sIGludCByb3RhdGUsDQogCQlmYl9zZXRfbG9nbyhpbmZvLCBs b2dvLCBsb2dvX25ldywgZmJfbG9nby5kZXB0aCk7DQogCX0NCiANCi0jaWZkZWYgQ09ORklHX0ZC X0xPR09fQ0VOVEVSDQotCXsNCisJaWYgKGZiX2NlbnRlcl9sb2dvKSB7DQogCQlpbnQgeHJlcyA9 IGluZm8tPnZhci54cmVzOw0KIAkJaW50IHlyZXMgPSBpbmZvLT52YXIueXJlczsNCiANCkBAIC01 MjAsMTEgKzUyMiwxMSBAQCBzdGF0aWMgaW50IGZiX3Nob3dfbG9nb19saW5lKHN0cnVjdCBmYl9p bmZvICppbmZvLCBpbnQgcm90YXRlLA0KIAkJCS0tbjsNCiAJCWltYWdlLmR4ID0gKHhyZXMgLSBu ICogKGxvZ28tPndpZHRoICsgOCkgLSA4KSAvIDI7DQogCQlpbWFnZS5keSA9IHkgPzogKHlyZXMg LSBsb2dvLT5oZWlnaHQpIC8gMjsNCisJfSBlbHNlIHsNCisJCWltYWdlLmR4ID0gMDsNCisJCWlt YWdlLmR5ID0geTsNCiAJfQ0KLSNlbHNlDQotCWltYWdlLmR4ID0gMDsNCi0JaW1hZ2UuZHkgPSB5 Ow0KLSNlbmRpZg0KKw0KIAlpbWFnZS53aWR0aCA9IGxvZ28tPndpZHRoOw0KIAlpbWFnZS5oZWln aHQgPSBsb2dvLT5oZWlnaHQ7DQogDQpAQCAtNjg0LDkgKzY4Niw4IEBAIGludCBmYl9wcmVwYXJl X2xvZ28oc3RydWN0IGZiX2luZm8gKmluZm8sIGludCByb3RhdGUpDQogIAl9DQogDQogCWhlaWdo dCA9IGZiX2xvZ28ubG9nby0+aGVpZ2h0Ow0KLSNpZmRlZiBDT05GSUdfRkJfTE9HT19DRU5URVIN Ci0JaGVpZ2h0ICs9ICh5cmVzIC0gZmJfbG9nby5sb2dvLT5oZWlnaHQpIC8gMjsNCi0jZW5kaWYN CisJaWYgKGZiX2NlbnRlcl9sb2dvKQ0KKwkJaGVpZ2h0ICs9ICh5cmVzIC0gZmJfbG9nby5sb2dv LT5oZWlnaHQpIC8gMjsNCiANCiAJcmV0dXJuIGZiX3ByZXBhcmVfZXh0cmFfbG9nb3MoaW5mbywg aGVpZ2h0LCB5cmVzKTsNCiB9DQpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9sb2dvL0tjb25m aWcgYi9kcml2ZXJzL3ZpZGVvL2xvZ28vS2NvbmZpZw0KaW5kZXggMWU5NzJjNGU4OGIxLi5kMWY2 MTk2YzhiOWEgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL3ZpZGVvL2xvZ28vS2NvbmZpZw0KKysrIGIv ZHJpdmVycy92aWRlby9sb2dvL0tjb25maWcNCkBAIC0xMCwxNSArMTAsNiBAQCBtZW51Y29uZmln IExPR08NCiANCiBpZiBMT0dPDQogDQotY29uZmlnIEZCX0xPR09fQ0VOVEVSDQotCWJvb2wgIkNl bnRlciB0aGUgbG9nbyINCi0JZGVwZW5kcyBvbiBGQj15DQotCWhlbHANCi0JICBXaGVuIHRoaXMg b3B0aW9uIGlzIHNlbGVjdGVkLCB0aGUgYm9vdHVwIGxvZ28gaXMgY2VudGVyZWQgYm90aA0KLQkg IGhvcml6b250YWxseSBhbmQgdmVydGljYWxseS4gSWYgbW9yZSB0aGFuIG9uZSBsb2dvIGlzIGRp c3BsYXllZA0KLQkgIGR1ZSB0byBtdWx0aXBsZSBDUFVzLCB0aGUgY29sbGVjdGVkIGxpbmUgb2Yg bG9nb3MgaXMgY2VudGVyZWQNCi0JICBhcyBhIHdob2xlLg0KLQ0KIGNvbmZpZyBGQl9MT0dPX0VY VFJBDQogCWJvb2wNCiAJZGVwZW5kcyBvbiBGQj15DQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51 eC9mYi5oIGIvaW5jbHVkZS9saW51eC9mYi5oDQppbmRleCA3Y2RkMzFhNjk3MTkuLmY1MmVmMGFk Njc4MSAxMDA2NDQNCi0tLSBhL2luY2x1ZGUvbGludXgvZmIuaA0KKysrIGIvaW5jbHVkZS9saW51 eC9mYi5oDQpAQCAtNjUzLDYgKzY1Myw3IEBAIGV4dGVybiBpbnQgZmJfbmV3X21vZGVsaXN0KHN0 cnVjdCBmYl9pbmZvICppbmZvKTsNCiANCiBleHRlcm4gc3RydWN0IGZiX2luZm8gKnJlZ2lzdGVy ZWRfZmJbRkJfTUFYXTsNCiBleHRlcm4gaW50IG51bV9yZWdpc3RlcmVkX2ZiOw0KK2V4dGVybiBi b29sIGZiX2NlbnRlcl9sb2dvOw0KIGV4dGVybiBzdHJ1Y3QgY2xhc3MgKmZiX2NsYXNzOw0KIA0K ICNkZWZpbmUgZm9yX2VhY2hfcmVnaXN0ZXJlZF9mYihpKQkJXA0KLS0gDQoyLjExLjANCg0K ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option 2019-01-07 10:35 ` Peter Rosin (?) @ 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-16 16:45 UTC (permalink / raw) To: Peter Rosin Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 01/07/2019 11:35 AM, Peter Rosin wrote: > On 2019-01-07 10:11, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: >>> On 2019-01-07 09:59, Peter Rosin wrote: >>>> On 2019-01-07 09:40, Geert Uytterhoeven wrote: >>>>> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >>>>>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>>>>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>>>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>>>>>> extra logos are not considered when centering the first logo vertically. >>>>>>>> >>>>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>>>> >>>>>>>> --- a/drivers/video/logo/Kconfig >>>>>>>> +++ b/drivers/video/logo/Kconfig >>>>>>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>>>>>> >>>>>>>> if LOGO >>>>>>>> >>>>>>>> +config FB_LOGO_CENTER >>>>>>>> + bool "Center the logo" >>>>>>>> + depends on FB=y >>>>>>>> + help >>>>>>>> + When this option is selected, the bootup logo is centered both >>>>>>>> + horizontally and vertically. If more than one logo is displayed >>>>>>>> + due to multiple CPUs, the collected line of logos is centered >>>>>>>> + as a whole. >>>>>>>> + >>>>>>> >>>>>>> Isn't a kernel command line option more suitable to configure the position >>>>>>> of the logo? >>>>>> >>>>>> That didn't occur to me previously, but it does make sense now that you >>>>>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >>>>>> can avoid possible regressions for folks who might start to rely on >>>>>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >>>>>> >>>>>> Cheers, >>>>>> Peter >>>>>> >>>>>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >>>>>> From: Peter Rosin <peda@axentia.se> >>>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>>>>> Cc: Jonathan Corbet <corbet@lwn.net> >>>>>> Cc: Peter Rosin <peda@axentia.se> >>>>>> Cc: dri-devel@lists.freedesktop.org >>>>>> Cc: linux-fbdev@vger.kernel.org >>>>>> Cc: linux-doc@vger.kernel.org >>>>>> To: linux-kernel@vger.kernel.org >>>>>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>>>>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >>>>>> option >>>>>> >>>>>> A command line option is much more flexible than a config option and >>>>>> the supporting code is small. Gets rid of #ifdefs in the code too... >>>>>> >>>>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>> >>>>> Thanks for your patch! >>>>> >>>>>> --- a/Documentation/fb/fbcon.txt >>>>>> +++ b/Documentation/fb/fbcon.txt >>>>>> @@ -163,6 +163,12 @@ C. Boot options >>>>>> be preserved until there actually is some text is output to the console. >>>>>> This option causes fbcon to bind immediately to the fbdev device. >>>>>> >>>>>> +7. fbcon=center-logo >>>>>> + >>>>>> + When this option is selected, the bootup logo is centered both >>>>>> + horizontally and vertically. If more than one logo is displayed due to >>>>>> + multiple CPUs, the collected line of logos is centered as a whole. >>>>>> + >>>>> >>>>> What about making this more generic, than an option specific for centering? >>>>> Else people want fbcon=left-logo or fbcon=right-logo soon? >>>>> >>>>> fbcon=logo-pos:<pos> >>>>> >>>>> With <pos> being "center", "left", "top", "right", "bottom", and combinations >>>>> like "top,center"? Or is that complicating stuff too much? >>>> >>>> I'm not too keen on implementing all that when I have zero use for it. I can >>>> however rename the trigger for the existing fb_center_logo bool to >>>> >>>> fbcon=logo-pos:center >>>> >>>> and add a check for "top,left" to reset the bool to false. Then the other >>>> variants can be added later by whomever and when needed. >>>> >>>> Is that good enough? >>> >>> Ouch, I just realized that using a comma is a no-go, as that is already >>> separating fbcon suboptions, so I suggest top-left instead. >> >> Sure, sounds fine to me. I just want to avoid having a parameter system >> that complicates future extension. >> I think you can drop the check for top-left, as the bool defaults to false. > > Right. So, here's an update... > > Again, it would probably be best if this went in before 5.0 is released. > > Changes since v1: > - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust > the help text accordingly). > > Cheers, > Peter > > From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd > line option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 5.0, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-16 16:45 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Linux Documentation List, Jonathan Corbet, linux-kernel, dri-devel, Geert Uytterhoeven On 01/07/2019 11:35 AM, Peter Rosin wrote: > On 2019-01-07 10:11, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: >>> On 2019-01-07 09:59, Peter Rosin wrote: >>>> On 2019-01-07 09:40, Geert Uytterhoeven wrote: >>>>> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >>>>>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>>>>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>>>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>>>>>> extra logos are not considered when centering the first logo vertically. >>>>>>>> >>>>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>>>> >>>>>>>> --- a/drivers/video/logo/Kconfig >>>>>>>> +++ b/drivers/video/logo/Kconfig >>>>>>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>>>>>> >>>>>>>> if LOGO >>>>>>>> >>>>>>>> +config FB_LOGO_CENTER >>>>>>>> + bool "Center the logo" >>>>>>>> + depends on FB=y >>>>>>>> + help >>>>>>>> + When this option is selected, the bootup logo is centered both >>>>>>>> + horizontally and vertically. If more than one logo is displayed >>>>>>>> + due to multiple CPUs, the collected line of logos is centered >>>>>>>> + as a whole. >>>>>>>> + >>>>>>> >>>>>>> Isn't a kernel command line option more suitable to configure the position >>>>>>> of the logo? >>>>>> >>>>>> That didn't occur to me previously, but it does make sense now that you >>>>>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >>>>>> can avoid possible regressions for folks who might start to rely on >>>>>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >>>>>> >>>>>> Cheers, >>>>>> Peter >>>>>> >>>>>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >>>>>> From: Peter Rosin <peda@axentia.se> >>>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>>>>> Cc: Jonathan Corbet <corbet@lwn.net> >>>>>> Cc: Peter Rosin <peda@axentia.se> >>>>>> Cc: dri-devel@lists.freedesktop.org >>>>>> Cc: linux-fbdev@vger.kernel.org >>>>>> Cc: linux-doc@vger.kernel.org >>>>>> To: linux-kernel@vger.kernel.org >>>>>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>>>>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >>>>>> option >>>>>> >>>>>> A command line option is much more flexible than a config option and >>>>>> the supporting code is small. Gets rid of #ifdefs in the code too... >>>>>> >>>>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>> >>>>> Thanks for your patch! >>>>> >>>>>> --- a/Documentation/fb/fbcon.txt >>>>>> +++ b/Documentation/fb/fbcon.txt >>>>>> @@ -163,6 +163,12 @@ C. Boot options >>>>>> be preserved until there actually is some text is output to the console. >>>>>> This option causes fbcon to bind immediately to the fbdev device. >>>>>> >>>>>> +7. fbcon=center-logo >>>>>> + >>>>>> + When this option is selected, the bootup logo is centered both >>>>>> + horizontally and vertically. If more than one logo is displayed due to >>>>>> + multiple CPUs, the collected line of logos is centered as a whole. >>>>>> + >>>>> >>>>> What about making this more generic, than an option specific for centering? >>>>> Else people want fbcon=left-logo or fbcon=right-logo soon? >>>>> >>>>> fbcon=logo-pos:<pos> >>>>> >>>>> With <pos> being "center", "left", "top", "right", "bottom", and combinations >>>>> like "top,center"? Or is that complicating stuff too much? >>>> >>>> I'm not too keen on implementing all that when I have zero use for it. I can >>>> however rename the trigger for the existing fb_center_logo bool to >>>> >>>> fbcon=logo-pos:center >>>> >>>> and add a check for "top,left" to reset the bool to false. Then the other >>>> variants can be added later by whomever and when needed. >>>> >>>> Is that good enough? >>> >>> Ouch, I just realized that using a comma is a no-go, as that is already >>> separating fbcon suboptions, so I suggest top-left instead. >> >> Sure, sounds fine to me. I just want to avoid having a parameter system >> that complicates future extension. >> I think you can drop the check for top-left, as the bool defaults to false. > > Right. So, here's an update... > > Again, it would probably be best if this went in before 5.0 is released. > > Changes since v1: > - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust > the help text accordingly). > > Cheers, > Peter > > From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd > line option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 5.0, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-16 16:45 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Linux Documentation List, Jonathan Corbet, linux-kernel, dri-devel, Geert Uytterhoeven On 01/07/2019 11:35 AM, Peter Rosin wrote: > On 2019-01-07 10:11, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Mon, Jan 7, 2019 at 10:03 AM Peter Rosin <peda@axentia.se> wrote: >>> On 2019-01-07 09:59, Peter Rosin wrote: >>>> On 2019-01-07 09:40, Geert Uytterhoeven wrote: >>>>> On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin <peda@axentia.se> wrote: >>>>>> On 2019-01-06 10:33, Geert Uytterhoeven wrote: >>>>>>> On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin <peda@axentia.se> wrote: >>>>>>>> If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these >>>>>>>> extra logos are not considered when centering the first logo vertically. >>>>>>>> >>>>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>>>> >>>>>>>> --- a/drivers/video/logo/Kconfig >>>>>>>> +++ b/drivers/video/logo/Kconfig >>>>>>>> @@ -10,6 +10,15 @@ menuconfig LOGO >>>>>>>> >>>>>>>> if LOGO >>>>>>>> >>>>>>>> +config FB_LOGO_CENTER >>>>>>>> + bool "Center the logo" >>>>>>>> + depends on FB=y >>>>>>>> + help >>>>>>>> + When this option is selected, the bootup logo is centered both >>>>>>>> + horizontally and vertically. If more than one logo is displayed >>>>>>>> + due to multiple CPUs, the collected line of logos is centered >>>>>>>> + as a whole. >>>>>>>> + >>>>>>> >>>>>>> Isn't a kernel command line option more suitable to configure the position >>>>>>> of the logo? >>>>>> >>>>>> That didn't occur to me previously, but it does make sense now that you >>>>>> mention it. This is on top of v5.0-rc1, and if applied before v5.0 we >>>>>> can avoid possible regressions for folks who might start to rely on >>>>>> CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this. >>>>>> >>>>>> Cheers, >>>>>> Peter >>>>>> >>>>>> From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001 >>>>>> From: Peter Rosin <peda@axentia.se> >>>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>>>>> Cc: Jonathan Corbet <corbet@lwn.net> >>>>>> Cc: Peter Rosin <peda@axentia.se> >>>>>> Cc: dri-devel@lists.freedesktop.org >>>>>> Cc: linux-fbdev@vger.kernel.org >>>>>> Cc: linux-doc@vger.kernel.org >>>>>> To: linux-kernel@vger.kernel.org >>>>>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>>>>> Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line >>>>>> option >>>>>> >>>>>> A command line option is much more flexible than a config option and >>>>>> the supporting code is small. Gets rid of #ifdefs in the code too... >>>>>> >>>>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>>>>> Signed-off-by: Peter Rosin <peda@axentia.se> >>>>> >>>>> Thanks for your patch! >>>>> >>>>>> --- a/Documentation/fb/fbcon.txt >>>>>> +++ b/Documentation/fb/fbcon.txt >>>>>> @@ -163,6 +163,12 @@ C. Boot options >>>>>> be preserved until there actually is some text is output to the console. >>>>>> This option causes fbcon to bind immediately to the fbdev device. >>>>>> >>>>>> +7. fbconÎnter-logo >>>>>> + >>>>>> + When this option is selected, the bootup logo is centered both >>>>>> + horizontally and vertically. If more than one logo is displayed due to >>>>>> + multiple CPUs, the collected line of logos is centered as a whole. >>>>>> + >>>>> >>>>> What about making this more generic, than an option specific for centering? >>>>> Else people want fbcon=left-logo or fbcon=right-logo soon? >>>>> >>>>> fbcon=logo-pos:<pos> >>>>> >>>>> With <pos> being "center", "left", "top", "right", "bottom", and combinations >>>>> like "top,center"? Or is that complicating stuff too much? >>>> >>>> I'm not too keen on implementing all that when I have zero use for it. I can >>>> however rename the trigger for the existing fb_center_logo bool to >>>> >>>> fbcon=logo-pos:center >>>> >>>> and add a check for "top,left" to reset the bool to false. Then the other >>>> variants can be added later by whomever and when needed. >>>> >>>> Is that good enough? >>> >>> Ouch, I just realized that using a comma is a no-go, as that is already >>> separating fbcon suboptions, so I suggest top-left instead. >> >> Sure, sounds fine to me. I just want to avoid having a parameter system >> that complicates future extension. >> I think you can drop the check for top-left, as the bool defaults to false. > > Right. So, here's an update... > > Again, it would probably be best if this went in before 5.0 is released. > > Changes since v1: > - rename from fbconÎnter-logo option to fbcon=logo-pos:center (and adjust > the help text accordingly). > > Cheers, > Peter > > From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 > From: Peter Rosin <peda@axentia.se> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Peter Rosin <peda@axentia.se> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-doc@vger.kernel.org > To: linux-kernel@vger.kernel.org > Date: Mon, 7 Jan 2019 08:35:26 +0100 > Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd > line option > > A command line option is much more flexible than a config option and > the supporting code is small. Gets rid of #ifdefs in the code too... > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Peter Rosin <peda@axentia.se> Patch queued for 5.0, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz @ 2019-01-17 13:40 ` Peter Rosin -1 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-17 13:40 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: > On 01/07/2019 11:35 AM, Peter Rosin wrote: >> Right. So, here's an update... >> >> Again, it would probably be best if this went in before 5.0 is released. >> >> Changes since v1: >> - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust >> the help text accordingly). >> >> Cheers, >> Peter >> >> From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 >> From: Peter Rosin <peda@axentia.se> >> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >> Cc: Jonathan Corbet <corbet@lwn.net> >> Cc: Peter Rosin <peda@axentia.se> >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-fbdev@vger.kernel.org >> Cc: linux-doc@vger.kernel.org >> To: linux-kernel@vger.kernel.org >> Date: Mon, 7 Jan 2019 08:35:26 +0100 >> Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd >> line option >> >> A command line option is much more flexible than a config option and >> the supporting code is small. Gets rid of #ifdefs in the code too... >> >> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Peter Rosin <peda@axentia.se> > > Patch queued for 5.0, thanks. Hmm, I see the patch on the fbdev-for-next branch, but that sounds like stuff destined for 5.1? Maybe you simply don't have any fbdev-for-current or fbdev-fixes branch or something like that? Just checking to make sure we're on the same page... Cheers, Peter ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-17 13:40 ` Peter Rosin 0 siblings, 0 replies; 33+ messages in thread From: Peter Rosin @ 2019-01-17 13:40 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List T24gMjAxOS0wMS0xNiAxNzo0NSwgQmFydGxvbWllaiBab2xuaWVya2lld2ljeiB3cm90ZToNCj4g T24gMDEvMDcvMjAxOSAxMTozNSBBTSwgUGV0ZXIgUm9zaW4gd3JvdGU6DQo+PiBSaWdodC4gU28s IGhlcmUncyBhbiB1cGRhdGUuLi4NCj4+DQo+PiBBZ2FpbiwgaXQgd291bGQgcHJvYmFibHkgYmUg YmVzdCBpZiB0aGlzIHdlbnQgaW4gYmVmb3JlIDUuMCBpcyByZWxlYXNlZC4NCj4+DQo+PiBDaGFu Z2VzIHNpbmNlIHYxOg0KPj4gLSByZW5hbWUgZnJvbSBmYmNvbj1jZW50ZXItbG9nbyBvcHRpb24g dG8gZmJjb249bG9nby1wb3M6Y2VudGVyIChhbmQgYWRqdXN0DQo+PiAgIHRoZSBoZWxwIHRleHQg YWNjb3JkaW5nbHkpLg0KPj4NCj4+IENoZWVycywNCj4+IFBldGVyDQo+Pg0KPj4gRnJvbSBlYmZi MmZlYjdlYTQyOThhYzljMjIyZTZlYTZmOWM5YTkyNDUyMDg0IE1vbiBTZXAgMTcgMDA6MDA6MDAg MjAwMQ0KPj4gRnJvbTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4NCj4+IENjOiBCYXJ0 bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+DQo+PiBDYzog Sm9uYXRoYW4gQ29yYmV0IDxjb3JiZXRAbHduLm5ldD4NCj4+IENjOiBQZXRlciBSb3NpbiA8cGVk YUBheGVudGlhLnNlPg0KPj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4+ IENjOiBsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcNCj4+IENjOiBsaW51eC1kb2NAdmdlci5r ZXJuZWwub3JnDQo+PiBUbzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KPj4gRGF0ZTog TW9uLCA3IEphbiAyMDE5IDA4OjM1OjI2ICswMTAwDQo+PiBTdWJqZWN0OiBbUEFUQ0ggdjJdIGZi ZGV2OiBmYm1lbTogY29udmVydCBDT05GSUdfRkJfTE9HT19DRU5URVIgaW50byBhIGNtZA0KPj4g IGxpbmUgb3B0aW9uDQo+Pg0KPj4gQSBjb21tYW5kIGxpbmUgb3B0aW9uIGlzIG11Y2ggbW9yZSBm bGV4aWJsZSB0aGFuIGEgY29uZmlnIG9wdGlvbiBhbmQNCj4+IHRoZSBzdXBwb3J0aW5nIGNvZGUg aXMgc21hbGwuIEdldHMgcmlkIG9mICNpZmRlZnMgaW4gdGhlIGNvZGUgdG9vLi4uDQo+Pg0KPj4g U3VnZ2VzdGVkLWJ5OiBHZWVydCBVeXR0ZXJob2V2ZW4gPGdlZXJ0QGxpbnV4LW02OGsub3JnPg0K Pj4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4NCj4gDQo+IFBh dGNoIHF1ZXVlZCBmb3IgNS4wLCB0aGFua3MuDQoNCkhtbSwgSSBzZWUgdGhlIHBhdGNoIG9uIHRo ZSBmYmRldi1mb3ItbmV4dCBicmFuY2gsIGJ1dCB0aGF0IHNvdW5kcw0KbGlrZSBzdHVmZiBkZXN0 aW5lZCBmb3IgNS4xPyBNYXliZSB5b3Ugc2ltcGx5IGRvbid0IGhhdmUgYW55DQpmYmRldi1mb3It Y3VycmVudCBvciBmYmRldi1maXhlcyBicmFuY2ggb3Igc29tZXRoaW5nIGxpa2UgdGhhdD8NCg0K SnVzdCBjaGVja2luZyB0byBtYWtlIHN1cmUgd2UncmUgb24gdGhlIHNhbWUgcGFnZS4uLg0KDQpD aGVlcnMsDQpQZXRlcg0K ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option 2019-01-17 13:40 ` Peter Rosin (?) @ 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-17 14:23 UTC (permalink / raw) To: Peter Rosin Cc: Geert Uytterhoeven, linux-kernel, dri-devel, linux-fbdev, Jonathan Corbet, Linux Documentation List On 01/17/2019 02:40 PM, Peter Rosin wrote: > On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: >> On 01/07/2019 11:35 AM, Peter Rosin wrote: >>> Right. So, here's an update... >>> >>> Again, it would probably be best if this went in before 5.0 is released. >>> >>> Changes since v1: >>> - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust >>> the help text accordingly). >>> >>> Cheers, >>> Peter >>> >>> From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 >>> From: Peter Rosin <peda@axentia.se> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>> Cc: Jonathan Corbet <corbet@lwn.net> >>> Cc: Peter Rosin <peda@axentia.se> >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: linux-doc@vger.kernel.org >>> To: linux-kernel@vger.kernel.org >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>> Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd >>> line option >>> >>> A command line option is much more flexible than a config option and >>> the supporting code is small. Gets rid of #ifdefs in the code too... >>> >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >> >> Patch queued for 5.0, thanks. > > Hmm, I see the patch on the fbdev-for-next branch, but that sounds > like stuff destined for 5.1? Maybe you simply don't have any > fbdev-for-current or fbdev-fixes branch or something like that? Yes. the single public fbdev branch has been sufficient for now (there is no active fbdev development and patches for -rcX kernels are even more rare). OTOH there is no problem with adding -fixes branch once needed.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-17 14:23 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Linux Documentation List, Jonathan Corbet, linux-kernel, dri-devel, Geert Uytterhoeven On 01/17/2019 02:40 PM, Peter Rosin wrote: > On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: >> On 01/07/2019 11:35 AM, Peter Rosin wrote: >>> Right. So, here's an update... >>> >>> Again, it would probably be best if this went in before 5.0 is released. >>> >>> Changes since v1: >>> - rename from fbcon=center-logo option to fbcon=logo-pos:center (and adjust >>> the help text accordingly). >>> >>> Cheers, >>> Peter >>> >>> From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 >>> From: Peter Rosin <peda@axentia.se> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>> Cc: Jonathan Corbet <corbet@lwn.net> >>> Cc: Peter Rosin <peda@axentia.se> >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: linux-doc@vger.kernel.org >>> To: linux-kernel@vger.kernel.org >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>> Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd >>> line option >>> >>> A command line option is much more flexible than a config option and >>> the supporting code is small. Gets rid of #ifdefs in the code too... >>> >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >> >> Patch queued for 5.0, thanks. > > Hmm, I see the patch on the fbdev-for-next branch, but that sounds > like stuff destined for 5.1? Maybe you simply don't have any > fbdev-for-current or fbdev-fixes branch or something like that? Yes. the single public fbdev branch has been sufficient for now (there is no active fbdev development and patches for -rcX kernels are even more rare). OTOH there is no problem with adding -fixes branch once needed.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option @ 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 33+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-01-17 14:23 UTC (permalink / raw) To: Peter Rosin Cc: linux-fbdev, Linux Documentation List, Jonathan Corbet, linux-kernel, dri-devel, Geert Uytterhoeven On 01/17/2019 02:40 PM, Peter Rosin wrote: > On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: >> On 01/07/2019 11:35 AM, Peter Rosin wrote: >>> Right. So, here's an update... >>> >>> Again, it would probably be best if this went in before 5.0 is released. >>> >>> Changes since v1: >>> - rename from fbconÎnter-logo option to fbcon=logo-pos:center (and adjust >>> the help text accordingly). >>> >>> Cheers, >>> Peter >>> >>> From ebfb2feb7ea4298ac9c222e6ea6f9c9a92452084 Mon Sep 17 00:00:00 2001 >>> From: Peter Rosin <peda@axentia.se> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >>> Cc: Jonathan Corbet <corbet@lwn.net> >>> Cc: Peter Rosin <peda@axentia.se> >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: linux-doc@vger.kernel.org >>> To: linux-kernel@vger.kernel.org >>> Date: Mon, 7 Jan 2019 08:35:26 +0100 >>> Subject: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd >>> line option >>> >>> A command line option is much more flexible than a config option and >>> the supporting code is small. Gets rid of #ifdefs in the code too... >>> >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >> >> Patch queued for 5.0, thanks. > > Hmm, I see the patch on the fbdev-for-next branch, but that sounds > like stuff destined for 5.1? Maybe you simply don't have any > fbdev-for-current or fbdev-fixes branch or something like that? Yes. the single public fbdev branch has been sufficient for now (there is no active fbdev development and patches for -rcX kernels are even more rare). OTOH there is no problem with adding -fixes branch once needed.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2019-01-17 14:23 UTC | newest] Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-11-26 21:57 [PATCH 0/2] add config option to center the bootup logo Peter Rosin 2018-11-26 21:57 ` [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height Peter Rosin 2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz 2018-12-20 17:37 ` Bartlomiej Zolnierkiewicz 2018-11-26 21:57 ` [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo Peter Rosin 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 2018-12-20 17:38 ` Bartlomiej Zolnierkiewicz 2019-01-06 9:33 ` Geert Uytterhoeven 2019-01-06 9:33 ` Geert Uytterhoeven 2019-01-06 9:33 ` Geert Uytterhoeven 2019-01-07 8:26 ` [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line, option Peter Rosin 2019-01-07 8:26 ` Peter Rosin 2019-01-07 8:40 ` Geert Uytterhoeven 2019-01-07 8:40 ` Geert Uytterhoeven 2019-01-07 8:40 ` Geert Uytterhoeven 2019-01-07 8:59 ` Peter Rosin 2019-01-07 8:59 ` Peter Rosin 2019-01-07 9:02 ` Peter Rosin 2019-01-07 9:02 ` Peter Rosin 2019-01-07 9:11 ` Geert Uytterhoeven 2019-01-07 9:11 ` Geert Uytterhoeven 2019-01-07 9:11 ` Geert Uytterhoeven 2019-01-07 10:35 ` [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option Peter Rosin 2019-01-07 10:35 ` Peter Rosin 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz 2019-01-16 16:45 ` Bartlomiej Zolnierkiewicz 2019-01-17 13:40 ` Peter Rosin 2019-01-17 13:40 ` Peter Rosin 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz 2019-01-17 14:23 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.