All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Atish Patra <atish.patra@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v5 2/7] efi/libstub: Make initrd file loader configurable
Date: Tue, 23 Jun 2020 17:10:34 +0200	[thread overview]
Message-ID: <CAMuHMdVjKQdZ=mMds_h+=ZOZTUZyf34Lu99xjyavtEG_mgRwUQ@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXH3HgmqrEct1ANNNZqb3R+YNpvp+TDkjF7b=1MYFtNa3g@mail.gmail.com>

Hoi Ard,

On Tue, Jun 16, 2020 at 10:16 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> On Tue, 16 Jun 2020 at 09:55, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Apr 22, 2020 at 7:24 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > Loading an initrd passed via the kernel command line is deprecated: it
> > > is limited to files that reside in the same volume as the one the kernel
> > > itself was loaded from, and we have more flexible ways to achieve the
> > > same. So make it configurable so new architectures can decide not to
> > > enable it.
> > >
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Thanks for your patch, which is now commit cf6b83664895a5c7
> > ("efi/libstub: Make initrd file loader configurable")!
> >
> > > --- a/drivers/firmware/efi/Kconfig
> > > +++ b/drivers/firmware/efi/Kconfig
> > > @@ -124,6 +124,17 @@ config EFI_ARMSTUB_DTB_LOADER
> > >           functionality for bootloaders that do not have such support
> > >           this option is necessary.
> > >
> > > +config EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> > > +       bool "Enable the command line initrd loader"
> > > +       depends on EFI_GENERIC_STUB
> > > +       default y
> > > +       help
> > > +         Select this config option to add support for the initrd= command
> > > +         line parameter, allowing an initrd that resides on the same volume
> > > +         as the kernel image to be loaded into memory.
> > > +
> > > +         This method is deprecated.
> >
> > So why the default y?
>
> Every time I try to disable something like this, someone pops out of
> the woodwork to explain how the feature is so vitally important for
> their highly bespoke and vertically integrated boot flow that it has
> to be enabled by default for absolutely everybody.
>
> But patches welcome :-)

Done
https://lore.kernel.org/linux-efi/20200623150935.32181-1-geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
	Atish Patra <atish.patra@wdc.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v5 2/7] efi/libstub: Make initrd file loader configurable
Date: Tue, 23 Jun 2020 17:10:34 +0200	[thread overview]
Message-ID: <CAMuHMdVjKQdZ=mMds_h+=ZOZTUZyf34Lu99xjyavtEG_mgRwUQ@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXH3HgmqrEct1ANNNZqb3R+YNpvp+TDkjF7b=1MYFtNa3g@mail.gmail.com>

Hoi Ard,

On Tue, Jun 16, 2020 at 10:16 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> On Tue, 16 Jun 2020 at 09:55, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Apr 22, 2020 at 7:24 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > Loading an initrd passed via the kernel command line is deprecated: it
> > > is limited to files that reside in the same volume as the one the kernel
> > > itself was loaded from, and we have more flexible ways to achieve the
> > > same. So make it configurable so new architectures can decide not to
> > > enable it.
> > >
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Thanks for your patch, which is now commit cf6b83664895a5c7
> > ("efi/libstub: Make initrd file loader configurable")!
> >
> > > --- a/drivers/firmware/efi/Kconfig
> > > +++ b/drivers/firmware/efi/Kconfig
> > > @@ -124,6 +124,17 @@ config EFI_ARMSTUB_DTB_LOADER
> > >           functionality for bootloaders that do not have such support
> > >           this option is necessary.
> > >
> > > +config EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> > > +       bool "Enable the command line initrd loader"
> > > +       depends on EFI_GENERIC_STUB
> > > +       default y
> > > +       help
> > > +         Select this config option to add support for the initrd= command
> > > +         line parameter, allowing an initrd that resides on the same volume
> > > +         as the kernel image to be loaded into memory.
> > > +
> > > +         This method is deprecated.
> >
> > So why the default y?
>
> Every time I try to disable something like this, someone pops out of
> the woodwork to explain how the feature is so vitally important for
> their highly bespoke and vertically integrated boot flow that it has
> to be enabled by default for absolutely everybody.
>
> But patches welcome :-)

Done
https://lore.kernel.org/linux-efi/20200623150935.32181-1-geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2020-06-23 15:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 17:24 [PATCH v5 0/7] Add UEFI support for RISC-V Ard Biesheuvel
2020-04-22 17:24 ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 1/7] efi/libstub: Move arm-stub to a common file Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 2/7] efi/libstub: Make initrd file loader configurable Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-06-16  7:55   ` Geert Uytterhoeven
2020-06-16  7:55     ` Geert Uytterhoeven
2020-06-16  8:16     ` Ard Biesheuvel
2020-06-16  8:16       ` Ard Biesheuvel
2020-06-23 15:10       ` Geert Uytterhoeven [this message]
2020-06-23 15:10         ` Geert Uytterhoeven
2020-04-22 17:24 ` [PATCH v5 3/7] efi/libstub/riscv: add arch specific efi.h header file Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 4/7] include: pe.h: Add RISC-V related PE definition Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 5/7] RISC-V: Define fixmap bindings for generic early ioremap support Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 6/7] RISC-V: Add PE/COFF header for EFI stub Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 7/7] RISC-V: Add EFI stub support Ard Biesheuvel
2020-04-22 17:24   ` Ard Biesheuvel
2020-04-22 18:48   ` Atish Patra
2020-04-22 18:48     ` Atish Patra
2020-04-23 11:15     ` Ard Biesheuvel
2020-04-23 11:15       ` Ard Biesheuvel
2020-04-23 11:49       ` Ard Biesheuvel
2020-04-23 11:49         ` Ard Biesheuvel
2020-04-22 17:25 ` [PATCH v5 0/7] Add UEFI support for RISC-V Ard Biesheuvel
2020-04-22 17:25   ` Ard Biesheuvel
2020-04-22 18:50 ` Atish Patra
2020-04-22 18:50   ` Atish Patra
2020-04-23 22:43 ` Palmer Dabbelt
2020-04-23 22:43   ` Palmer Dabbelt
2020-04-24 11:08   ` Ard Biesheuvel
2020-04-24 11:08     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVjKQdZ=mMds_h+=ZOZTUZyf34Lu99xjyavtEG_mgRwUQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ardb@kernel.org \
    --cc=atish.patra@wdc.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.