From: Geert Uytterhoeven <geert@linux-m68k.org> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Magnus Damm <magnus.damm@gmail.com>, Russell King <linux@armlinux.org.uk>, Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>, linux-clk <linux-clk@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux PM list <linux-pm@vger.kernel.org> Subject: Re: [PATCH 08/10] clk: renesas: cpg-mssr: Add R8A7742 support Date: Mon, 27 Apr 2020 12:18:50 +0200 [thread overview] Message-ID: <CAMuHMdVrft9Ln=DSKv2hrVcZBuOo9fvbvD_s0JDo0xUQAoG=tQ@mail.gmail.com> (raw) In-Reply-To: <CA+V-a8s6RacEpZ+Z5M8ftKq9NGsVgizdBY137YiYuK_yg-Ozxg@mail.gmail.com> Hi Prabhakar, On Mon, Apr 27, 2020 at 12:07 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Mon, Apr 27, 2020 at 10:10 AM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > On Thu, Apr 23, 2020 at 11:41 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > Add RZ/G1H (R8A7742) Clock Pulse Generator / Module Standby and Software > > > Reset support, using the CPG/MSSR driver core and the common R-Car Gen2 > > > (and RZ/G) code. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/drivers/clk/renesas/r8a7742-cpg-mssr.c > > > > > +static struct cpg_core_clk r8a7742_core_clks[] __initdata = { > > > + DEF_FIXED("zg", R8A7742_CLK_ZG, CLK_PLL1, 3, 1), > > > +static int __init r8a7742_cpg_mssr_init(struct device *dev) > > > +{ > > > + const struct rcar_gen2_cpg_pll_config *cpg_pll_config; > > > + struct device_node *np = dev->of_node; > > > + unsigned int i; > > > + u32 cpg_mode; > > > + int error; > > > + > > > + error = rcar_rst_read_mode_pins(&cpg_mode); > > > + if (error) > > > + return error; > > > + > > > + cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > > > + > > > + if (of_device_is_compatible(np, "renesas,r8a7742-cpg-mssr")) { > > > + /* RZ/G1H uses a 1/3 divider for ZG */ > > > + for (i = 0; i < ARRAY_SIZE(r8a7742_core_clks); i++) > > > + if (r8a7742_core_clks[i].id == R8A7742_CLK_ZG) { > > > + r8a7742_core_clks[i].div = 3; > > > + break; > > > + } > > > + } > > > > Do you really need this part? (copied from r8a7743-cpg-mssr.c ;-) > > If you remove it, r8a7742_core_clks[] can be const, and <linux/of.h> is > > no longer needed, > > > I haven't come far enough to test the GPU yet, so Ill drop this for > now and add this later if needed. The divider is already set to 3 in the table above. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>, Linux PM list <linux-pm@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Michael Turquette <mturquette@baylibre.com>, Magnus Damm <magnus.damm@gmail.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Russell King <linux@armlinux.org.uk>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, linux-clk <linux-clk@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 08/10] clk: renesas: cpg-mssr: Add R8A7742 support Date: Mon, 27 Apr 2020 12:18:50 +0200 [thread overview] Message-ID: <CAMuHMdVrft9Ln=DSKv2hrVcZBuOo9fvbvD_s0JDo0xUQAoG=tQ@mail.gmail.com> (raw) In-Reply-To: <CA+V-a8s6RacEpZ+Z5M8ftKq9NGsVgizdBY137YiYuK_yg-Ozxg@mail.gmail.com> Hi Prabhakar, On Mon, Apr 27, 2020 at 12:07 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Mon, Apr 27, 2020 at 10:10 AM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > On Thu, Apr 23, 2020 at 11:41 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > Add RZ/G1H (R8A7742) Clock Pulse Generator / Module Standby and Software > > > Reset support, using the CPG/MSSR driver core and the common R-Car Gen2 > > > (and RZ/G) code. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/drivers/clk/renesas/r8a7742-cpg-mssr.c > > > > > +static struct cpg_core_clk r8a7742_core_clks[] __initdata = { > > > + DEF_FIXED("zg", R8A7742_CLK_ZG, CLK_PLL1, 3, 1), > > > +static int __init r8a7742_cpg_mssr_init(struct device *dev) > > > +{ > > > + const struct rcar_gen2_cpg_pll_config *cpg_pll_config; > > > + struct device_node *np = dev->of_node; > > > + unsigned int i; > > > + u32 cpg_mode; > > > + int error; > > > + > > > + error = rcar_rst_read_mode_pins(&cpg_mode); > > > + if (error) > > > + return error; > > > + > > > + cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > > > + > > > + if (of_device_is_compatible(np, "renesas,r8a7742-cpg-mssr")) { > > > + /* RZ/G1H uses a 1/3 divider for ZG */ > > > + for (i = 0; i < ARRAY_SIZE(r8a7742_core_clks); i++) > > > + if (r8a7742_core_clks[i].id == R8A7742_CLK_ZG) { > > > + r8a7742_core_clks[i].div = 3; > > > + break; > > > + } > > > + } > > > > Do you really need this part? (copied from r8a7743-cpg-mssr.c ;-) > > If you remove it, r8a7742_core_clks[] can be const, and <linux/of.h> is > > no longer needed, > > > I haven't come far enough to test the GPU yet, so Ill drop this for > now and add this later if needed. The divider is already set to 3 in the table above. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-27 10:19 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-23 21:40 [PATCH 00/10] Add RZ/G1H support Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-23 21:40 ` [PATCH 01/10] dt-bindings: power: rcar-sysc: Document r8a7742 SYSC binding Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 7:39 ` Geert Uytterhoeven 2020-04-27 7:39 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 02/10] dt-bindings: power: rcar-sysc: Add r8a7742 power domain index macros Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 7:44 ` Geert Uytterhoeven 2020-04-27 7:44 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 03/10] soc: renesas: rcar-sysc: add R8A7742 support Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 7:56 ` Geert Uytterhoeven 2020-04-27 7:56 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 04/10] dt-bindings: reset: rcar-rst: Document r8a7742 reset module Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 8:00 ` Geert Uytterhoeven 2020-04-27 8:00 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 05/10] soc: renesas: rcar-rst: Add support for RZ/G1H Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 8:02 ` Geert Uytterhoeven 2020-04-27 8:02 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 06/10] dt-bindings: clock: renesas: cpg-mssr: Document r8a7742 binding Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 8:03 ` Geert Uytterhoeven 2020-04-27 8:03 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 07/10] clk: renesas: Add r8a7742 CPG Core Clock Definitions Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 8:26 ` Geert Uytterhoeven 2020-04-27 8:26 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 08/10] clk: renesas: cpg-mssr: Add R8A7742 support Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 9:10 ` Geert Uytterhoeven 2020-04-27 9:10 ` Geert Uytterhoeven 2020-04-27 10:06 ` Lad, Prabhakar 2020-04-27 10:06 ` Lad, Prabhakar 2020-04-27 10:18 ` Geert Uytterhoeven [this message] 2020-04-27 10:18 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 09/10] ARM: shmobile: r8a7742: Basic SoC support Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 9:16 ` Geert Uytterhoeven 2020-04-27 9:16 ` Geert Uytterhoeven 2020-04-23 21:40 ` [PATCH 10/10] cpufreq: dt: Add support for r8a7742 Lad Prabhakar 2020-04-23 21:40 ` Lad Prabhakar 2020-04-27 9:22 ` Geert Uytterhoeven 2020-04-27 9:22 ` Geert Uytterhoeven 2020-04-27 9:24 ` Viresh Kumar 2020-04-27 9:24 ` Viresh Kumar 2020-04-27 10:20 ` Lad, Prabhakar 2020-04-27 10:20 ` Lad, Prabhakar 2020-04-27 10:22 ` Viresh Kumar 2020-04-27 10:22 ` Viresh Kumar 2020-04-27 10:33 ` Lad, Prabhakar 2020-04-27 10:33 ` Lad, Prabhakar 2020-04-27 9:27 ` [PATCH 00/10] Add RZ/G1H support Geert Uytterhoeven 2020-04-27 9:27 ` Geert Uytterhoeven 2020-04-27 10:30 ` Lad, Prabhakar 2020-04-27 10:30 ` Lad, Prabhakar 2020-04-27 11:18 ` Geert Uytterhoeven 2020-04-27 11:18 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdVrft9Ln=DSKv2hrVcZBuOo9fvbvD_s0JDo0xUQAoG=tQ@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=marian-cristian.rotariu.rb@bp.renesas.com \ --cc=mturquette@baylibre.com \ --cc=p.zabel@pengutronix.de \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.