[PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()

[PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()

[Geert Uytterhoeven]

Commit 8f69e585ca3ad324ea57e113bff06d366dfa010e ("mmc: sdhci-pxav3: Use
devm_* managed helpers") removed the later user of pxa:

drivers/mmc/host/sdhci-pxav3.c: In function 'sdhci_pxav3_remove':
drivers/mmc/host/sdhci-pxav3.c:400:20: warning: unused variable 'pxa' [-Wunused-variable]
  struct sdhci_pxa *pxa = pltfm_host->priv;
                    ^

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mmc/host/sdhci-pxav3.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 527dfa3faeab..6f842fb8e6b8 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -397,7 +397,6 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
 {
 	struct sdhci_host *host = platform_get_drvdata(pdev);
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
-	struct sdhci_pxa *pxa = pltfm_host->priv;
 
 	pm_runtime_get_sync(&pdev->dev);
 	sdhci_remove_host(host, 1);
-- 
1.9.1

Re: [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()

[Laurent Pinchart]

Hi Geert,

Thank you for the patch, but you're a bit too late :-)

http://article.gmane.org/gmane.linux.kernel.mmc/28097

On Friday 08 August 2014 17:32:11 Geert Uytterhoeven wrote:
> Commit 8f69e585ca3ad324ea57e113bff06d366dfa010e ("mmc: sdhci-pxav3: Use
> devm_* managed helpers") removed the later user of pxa:
> 
> drivers/mmc/host/sdhci-pxav3.c: In function 'sdhci_pxav3_remove':
> drivers/mmc/host/sdhci-pxav3.c:400:20: warning: unused variable 'pxa'
> [-Wunused-variable] struct sdhci_pxa *pxa = pltfm_host->priv;
>                     ^
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/mmc/host/sdhci-pxav3.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 527dfa3faeab..6f842fb8e6b8 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -397,7 +397,6 @@ static int sdhci_pxav3_remove(struct platform_device
> *pdev) {
>  	struct sdhci_host *host = platform_get_drvdata(pdev);
>  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> -	struct sdhci_pxa *pxa = pltfm_host->priv;
> 
>  	pm_runtime_get_sync(&pdev->dev);
>  	sdhci_remove_host(host, 1);

-- 
Regards,

Laurent Pinchart

Re: [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()

[Geert Uytterhoeven]

On Fri, Aug 8, 2014 at 5:38 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Thank you for the patch, but you're a bit too late :-)
>
> http://article.gmane.org/gmane.linux.kernel.mmc/28097

Doh, I'm not (yet) on linux-mmc.
It's a pity that fix is not yet in -next.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds