All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurio
Date: Wed, 24 Sep 2014 08:21:12 +0000	[thread overview]
Message-ID: <CAMuHMdWQfSLwqMMigLOZuGFJqQO03Qyw+ZHE1YAgd6mNDGmrEg@mail.gmail.com> (raw)
In-Reply-To: <20140924081455.GU4015@sirena.org.uk>

Hi Mark,

On Wed, Sep 24, 2014 at 10:14 AM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Sep 24, 2014 at 09:02:23AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Sep 24, 2014 at 3:13 AM, Simon Horman <horms@verge.net.au> wrote:
>
>> > What should we call the nodes?
>
>> "regulator0" and "regulator1"?
>> "regulator1v8" and "regulator3v3"?
>
>> Documentation/devicetree/bindings/regulator/regulator.txt doesn't mention
>> node names or (presence/lack of) unit-adresses, but the examples do have
>> unit-addresses.
>
>> Is this another case where we don't follow the "no reg, no unit-address"
>> ePAPR rule?
>
> As far as the regulator API is concerned the node name is completly
> immaterial and all this stuff is just verbiage we're forced to include.
> As far as I can tell the requirement that node names be in the form
> "regulator" or whatever is just another thing that wasn't terribly well
> thought through in ePAPR, they were trying to do classes I think.

So perhaps we should just keep "regulator@0" and "regulator@1"?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Ulrich Hecht
	<ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses)
Date: Wed, 24 Sep 2014 10:21:12 +0200	[thread overview]
Message-ID: <CAMuHMdWQfSLwqMMigLOZuGFJqQO03Qyw+ZHE1YAgd6mNDGmrEg@mail.gmail.com> (raw)
In-Reply-To: <20140924081455.GU4015-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

Hi Mark,

On Wed, Sep 24, 2014 at 10:14 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Sep 24, 2014 at 09:02:23AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Sep 24, 2014 at 3:13 AM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote:
>
>> > What should we call the nodes?
>
>> "regulator0" and "regulator1"?
>> "regulator1v8" and "regulator3v3"?
>
>> Documentation/devicetree/bindings/regulator/regulator.txt doesn't mention
>> node names or (presence/lack of) unit-adresses, but the examples do have
>> unit-addresses.
>
>> Is this another case where we don't follow the "no reg, no unit-address"
>> ePAPR rule?
>
> As far as the regulator API is concerned the node name is completly
> immaterial and all this stuff is just verbiage we're forced to include.
> As far as I can tell the requirement that node names be in the form
> "regulator" or whatever is just another thing that wasn't terribly well
> thought through in ePAPR, they were trying to do classes I think.

So perhaps we should just keep "regulator@0" and "regulator@1"?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses)
Date: Wed, 24 Sep 2014 10:21:12 +0200	[thread overview]
Message-ID: <CAMuHMdWQfSLwqMMigLOZuGFJqQO03Qyw+ZHE1YAgd6mNDGmrEg@mail.gmail.com> (raw)
In-Reply-To: <20140924081455.GU4015@sirena.org.uk>

Hi Mark,

On Wed, Sep 24, 2014 at 10:14 AM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Sep 24, 2014 at 09:02:23AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Sep 24, 2014 at 3:13 AM, Simon Horman <horms@verge.net.au> wrote:
>
>> > What should we call the nodes?
>
>> "regulator0" and "regulator1"?
>> "regulator1v8" and "regulator3v3"?
>
>> Documentation/devicetree/bindings/regulator/regulator.txt doesn't mention
>> node names or (presence/lack of) unit-adresses, but the examples do have
>> unit-addresses.
>
>> Is this another case where we don't follow the "no reg, no unit-address"
>> ePAPR rule?
>
> As far as the regulator API is concerned the node name is completly
> immaterial and all this stuff is just verbiage we're forced to include.
> As far as I can tell the requirement that node names be in the form
> "regulator" or whatever is just another thing that wasn't terribly well
> thought through in ePAPR, they were trying to do classes I think.

So perhaps we should just keep "regulator at 0" and "regulator at 1"?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2014-09-24  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  7:02 regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious r Geert Uytterhoeven
2014-09-24  7:02 ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses) Geert Uytterhoeven
2014-09-24  7:02 ` Geert Uytterhoeven
2014-09-24  8:14 ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurio Mark Brown
2014-09-24  8:14   ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses) Mark Brown
2014-09-24  8:14   ` Mark Brown
2014-09-24  8:21   ` Geert Uytterhoeven [this message]
2014-09-24  8:21     ` Geert Uytterhoeven
2014-09-24  8:21     ` Geert Uytterhoeven
2014-09-24  8:27     ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurio Mark Brown
2014-09-24  8:27       ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses) Mark Brown
2014-09-24  8:27       ` Mark Brown
2014-09-25  1:24       ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurio Simon Horman
2014-09-25  1:24         ` regulator node names and unit-addresses? (Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses) Simon Horman
2014-09-25  1:24         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdWQfSLwqMMigLOZuGFJqQO03Qyw+ZHE1YAgd6mNDGmrEg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.