[PATCH 0/3] clk: renesas: r8a7796: Add CAN/CAN FD support

[PATCH 0/3] clk: renesas: r8a7796: Add CAN/CAN FD support

[Chris Paterson]

This patch series adds clk support for CAN and CAN FD to the r8a7796.

Based on renesas-drivers-2016-11-15-v4.9-rc5.

Chris Paterson (3):
  clk: renesas: r8a7796: Add CAN peripheral clock
  clk: renesas: r8a7796: Add CANFD clock
  clk: renesas: r8a7796: Add CAN FD peripheral clock

 drivers/clk/renesas/r8a7796-cpg-mssr.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
1.9.1

[PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Chris Paterson]

Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 7d298c5..99b19ce 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -181,6 +181,8 @@ enum clk_ids {
 	DEF_MOD("gpio2",		 910,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio1",		 911,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio0",		 912,	R8A7796_CLK_S3D4),
+	DEF_MOD("can-if1",		 915,	R8A7796_CLK_S3D4),
+	DEF_MOD("can-if0",		 916,	R8A7796_CLK_S3D4),
 	DEF_MOD("i2c6",			 918,	R8A7796_CLK_S0D6),
 	DEF_MOD("i2c5",			 919,	R8A7796_CLK_S0D6),
 	DEF_MOD("i2c4",			 927,	R8A7796_CLK_S0D6),
-- 
1.9.1

[PATCH 2/3] clk: renesas: r8a7796: Add CANFD clock

[Chris Paterson]

Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 99b19ce..b461383 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -103,6 +103,7 @@ enum clk_ids {
 	DEF_FIXED("cl",         R8A7796_CLK_CL,    CLK_PLL1_DIV2, 48, 1),
 	DEF_FIXED("cp",         R8A7796_CLK_CP,    CLK_EXTAL,      2, 1),
 
+	DEF_DIV6P1("canfd",     R8A7796_CLK_CANFD, CLK_PLL1_DIV4, 0x244),
 	DEF_DIV6P1("csi0",      R8A7796_CLK_CSI0,  CLK_PLL1_DIV4, 0x00c),
 
 	DEF_DIV6_RO("osc",      R8A7796_CLK_OSC,   CLK_EXTAL, CPG_RCKCR,  8),
-- 
1.9.1

[PATCH 3/3] clk: renesas: r8a7796: Add CAN FD peripheral clock

[Chris Paterson]

Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index b461383..a09d6f8 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -182,6 +182,7 @@ enum clk_ids {
 	DEF_MOD("gpio2",		 910,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio1",		 911,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio0",		 912,	R8A7796_CLK_S3D4),
+	DEF_MOD("can-fd",		 914,	R8A7796_CLK_S3D2),
 	DEF_MOD("can-if1",		 915,	R8A7796_CLK_S3D4),
 	DEF_MOD("can-if0",		 916,	R8A7796_CLK_S3D4),
 	DEF_MOD("i2c6",			 918,	R8A7796_CLK_S0D6),
-- 
1.9.1

Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Geert Uytterhoeven]

On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] clk: renesas: r8a7796: Add CANFD clock

[Geert Uytterhoeven]

On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/3] clk: renesas: r8a7796: Add CAN FD peripheral clock

[Geert Uytterhoeven]

On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Geert Uytterhoeven]

Hi Chris,

On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
> <chris.paterson2@renesas.com> wrote:
>> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
>> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

BTW, as all patches in this series were Signed-off-by Ramesh first, does
that mean he's the author, and you should have added his From: line, too?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/3] clk: renesas: r8a7796: Add CAN/CAN FD support

[Geert Uytterhoeven]

Hi Chris,

On Tue, Nov 22, 2016 at 2:45 PM, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> This patch series adds clk support for CAN and CAN FD to the r8a7796.
>
> Based on renesas-drivers-2016-11-15-v4.9-rc5.
>
> Chris Paterson (3):
>   clk: renesas: r8a7796: Add CAN peripheral clock
>   clk: renesas: r8a7796: Add CANFD clock
>   clk: renesas: r8a7796: Add CAN FD peripheral clock

Thank you, will queue in clk-renesas-for-v4.11 once the authorship has been
resolved.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Chris Paterson]

Hello Geert,

Thank you for the review.

> -----Original Message-----
> From: geert.uytterhoeven@gmail.com
> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 23 November 2016 08:06
> To: Chris Paterson <Chris.Paterson2@renesas.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>; Michael Turquette
> <mturquette@baylibre.com>; Stephen Boyd <sboyd@codeaurora.org>;
> Linux-Renesas <linux-renesas-soc@vger.kernel.org>; linux-clk <linux-
> clk@vger.kernel.org>; Ramesh Shanmugasundaram
> <ramesh.shanmugasundaram@bp.renesas.com>
> Subject: Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock
> 
> Hi Chris,
> 
> On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux-
> m68k.org> wrote:
> > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
> > <chris.paterson2@renesas.com> wrote:
> >> Signed-off-by: Ramesh Shanmugasundaram
> >> <ramesh.shanmugasundaram@bp.renesas.com>
> >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> 
> BTW, as all patches in this series were Signed-off-by Ramesh first, does that
> mean he's the author, and you should have added his From: line, too?

Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2][3].

[1] 11c6fb7 clk: shmobile: r8a7795: Add CAN peripheral clock
[2] 7e00d631 clk: shmobile: r8a7795: Add CANFD clock
[3] a080c8c clk: shmobile: r8a7795: Add CAN FD peripheral clock

Apologies for not making this clear in the cover letter.

Kind regards, Chris

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

RE: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Chris Paterson]

SGVsbG8gR2VlcnQsDQoNClRoYW5rIHlvdSBmb3IgdGhlIHJldmlldy4NCg0KPiAtLS0tLU9yaWdp
bmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZWVydC51eXR0ZXJob2V2ZW5AZ21haWwuY29tDQo+
IFttYWlsdG86Z2VlcnQudXl0dGVyaG9ldmVuQGdtYWlsLmNvbV0gT24gQmVoYWxmIE9mIEdlZXJ0
IFV5dHRlcmhvZXZlbg0KPiBTZW50OiAyMyBOb3ZlbWJlciAyMDE2IDA4OjA2DQo+IFRvOiBDaHJp
cyBQYXRlcnNvbiA8Q2hyaXMuUGF0ZXJzb24yQHJlbmVzYXMuY29tPg0KPiBDYzogR2VlcnQgVXl0
dGVyaG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT47IE1pY2hhZWwgVHVycXVldHRlDQo+
IDxtdHVycXVldHRlQGJheWxpYnJlLmNvbT47IFN0ZXBoZW4gQm95ZCA8c2JveWRAY29kZWF1cm9y
YS5vcmc+Ow0KPiBMaW51eC1SZW5lc2FzIDxsaW51eC1yZW5lc2FzLXNvY0B2Z2VyLmtlcm5lbC5v
cmc+OyBsaW51eC1jbGsgPGxpbnV4LQ0KPiBjbGtAdmdlci5rZXJuZWwub3JnPjsgUmFtZXNoIFNo
YW5tdWdhc3VuZGFyYW0NCj4gPHJhbWVzaC5zaGFubXVnYXN1bmRhcmFtQGJwLnJlbmVzYXMuY29t
Pg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvM10gY2xrOiByZW5lc2FzOiByOGE3Nzk2OiBBZGQg
Q0FOIHBlcmlwaGVyYWwgY2xvY2sNCj4gDQo+IEhpIENocmlzLA0KPiANCj4gT24gV2VkLCBOb3Yg
MjMsIDIwMTYgYXQgOTowMyBBTSwgR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydEBsaW51eC0NCj4g
bTY4ay5vcmc+IHdyb3RlOg0KPiA+IE9uIFR1ZSwgTm92IDIyLCAyMDE2IGF0IDI6NDYgUE0sIENo
cmlzIFBhdGVyc29uDQo+ID4gPGNocmlzLnBhdGVyc29uMkByZW5lc2FzLmNvbT4gd3JvdGU6DQo+
ID4+IFNpZ25lZC1vZmYtYnk6IFJhbWVzaCBTaGFubXVnYXN1bmRhcmFtDQo+ID4+IDxyYW1lc2gu
c2hhbm11Z2FzdW5kYXJhbUBicC5yZW5lc2FzLmNvbT4NCj4gPj4gU2lnbmVkLW9mZi1ieTogQ2hy
aXMgUGF0ZXJzb24gPGNocmlzLnBhdGVyc29uMkByZW5lc2FzLmNvbT4NCj4gDQo+IEJUVywgYXMg
YWxsIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMgd2VyZSBTaWduZWQtb2ZmLWJ5IFJhbWVzaCBmaXJz
dCwgZG9lcyB0aGF0DQo+IG1lYW4gaGUncyB0aGUgYXV0aG9yLCBhbmQgeW91IHNob3VsZCBoYXZl
IGFkZGVkIGhpcyBGcm9tOiBsaW5lLCB0b28/DQoNClRlY2huaWNhbGx5IEkgYXV0aG9yZWQgdGhl
c2UgcGF0Y2hlcywgYnV0IHRoZXkgYXJlIGRpcmVjdCBwb3J0cyBmcm9tIFJhbWVzaCdzIHI4YTc3
OTUgcGF0Y2hlcyBbMV1bMl1bM10uDQoNClsxXSAxMWM2ZmI3IGNsazogc2htb2JpbGU6IHI4YTc3
OTU6IEFkZCBDQU4gcGVyaXBoZXJhbCBjbG9jaw0KWzJdIDdlMDBkNjMxIGNsazogc2htb2JpbGU6
IHI4YTc3OTU6IEFkZCBDQU5GRCBjbG9jaw0KWzNdIGEwODBjOGMgY2xrOiBzaG1vYmlsZTogcjhh
Nzc5NTogQWRkIENBTiBGRCBwZXJpcGhlcmFsIGNsb2NrDQoNCkFwb2xvZ2llcyBmb3Igbm90IG1h
a2luZyB0aGlzIGNsZWFyIGluIHRoZSBjb3ZlciBsZXR0ZXIuDQoNCktpbmQgcmVnYXJkcywgQ2hy
aXMNCg0KPiANCj4gR3J7b2V0amUsZWV0aW5nfXMsDQo+IA0KPiAgICAgICAgICAgICAgICAgICAg
ICAgICBHZWVydA0KPiANCj4gLS0NCj4gR2VlcnQgVXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90
cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVydEBsaW51eC0NCj4gbTY4ay5vcmcNCj4gDQo+
IEluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmljYWwgcGVvcGxlLCBJIGNhbGwg
bXlzZWxmIGEgaGFja2VyLiBCdXQNCj4gd2hlbiBJJ20gdGFsa2luZyB0byBqb3VybmFsaXN0cyBJ
IGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlrZSB0aGF0Lg0KPiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIC0tIExpbnVzIFRvcnZhbGRzDQo=

Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock

[Geert Uytterhoeven]

Hi Chris,

On Wed, Nov 23, 2016 at 9:39 AM, Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>> On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux-
>> m68k.org> wrote:
>> > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson
>> > <chris.paterson2@renesas.com> wrote:
>> >> Signed-off-by: Ramesh Shanmugasundaram
>> >> <ramesh.shanmugasundaram@bp.renesas.com>
>> >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
>>
>> BTW, as all patches in this series were Signed-off-by Ramesh first, does that
>> mean he's the author, and you should have added his From: line, too?
>
> Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2][3].

OK, I'll replace his SoB by "based on patches for r8a7795 by Ramesh...".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds