* [PATCH] m68k: fix build failure
@ 2016-01-04 10:57 ` Sudip Mukherjee
0 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-01-04 10:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-kernel, linux-m68k, Sudip Mukherjee, Andrew Morton, Dan Williams
The defconfig build of m68k was failing with the error:
implicit declaration of function '__pfn_to_phys'
Other architectures have added <asm/memory.h>, but if we do so here then
we will also get redeclaration of some other functions. So it is better
to copy these macros into page_mm.h.
Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
m68k defconfig build log of next-20160104 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/100068521
arch/m68k/include/asm/page_mm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
index e7a1946..63aa14d 100644
--- a/arch/m68k/include/asm/page_mm.h
+++ b/arch/m68k/include/asm/page_mm.h
@@ -165,6 +165,9 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
((__p) - pgdat->node_mem_map) + pgdat->node_start_pfn; \
})
+#define __phys_to_pfn(paddr) ((unsigned long)((paddr) >> PAGE_SHIFT))
+#define __pfn_to_phys(pfn) PFN_PHYS(pfn)
+
#define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
#define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] m68k: fix build failure
@ 2016-01-04 10:57 ` Sudip Mukherjee
0 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2016-01-04 10:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-kernel, linux-m68k, Sudip Mukherjee, Andrew Morton, Dan Williams
The defconfig build of m68k was failing with the error:
implicit declaration of function '__pfn_to_phys'
Other architectures have added <asm/memory.h>, but if we do so here then
we will also get redeclaration of some other functions. So it is better
to copy these macros into page_mm.h.
Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
m68k defconfig build log of next-20160104 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/100068521
arch/m68k/include/asm/page_mm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
index e7a1946..63aa14d 100644
--- a/arch/m68k/include/asm/page_mm.h
+++ b/arch/m68k/include/asm/page_mm.h
@@ -165,6 +165,9 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
((__p) - pgdat->node_mem_map) + pgdat->node_start_pfn; \
})
+#define __phys_to_pfn(paddr) ((unsigned long)((paddr) >> PAGE_SHIFT))
+#define __pfn_to_phys(pfn) PFN_PHYS(pfn)
+
#define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
#define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
2016-01-04 10:57 ` Sudip Mukherjee
@ 2016-01-10 9:35 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:35 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The defconfig build of m68k was failing with the error:
> implicit declaration of function '__pfn_to_phys'
>
> Other architectures have added <asm/memory.h>, but if we do so here then
> we will also get redeclaration of some other functions. So it is better
> to copy these macros into page_mm.h.
>
> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
@ 2016-01-10 9:35 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:35 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The defconfig build of m68k was failing with the error:
> implicit declaration of function '__pfn_to_phys'
>
> Other architectures have added <asm/memory.h>, but if we do so here then
> we will also get redeclaration of some other functions. So it is better
> to copy these macros into page_mm.h.
>
> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
2016-01-10 9:35 ` Geert Uytterhoeven
@ 2016-01-10 9:37 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:37 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>> The defconfig build of m68k was failing with the error:
>> implicit declaration of function '__pfn_to_phys'
>>
>> Other architectures have added <asm/memory.h>, but if we do so here then
>> we will also get redeclaration of some other functions. So it is better
>> to copy these macros into page_mm.h.
>>
>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Or should I take this through the m68k tree? It's getting a bit late for
adding new v4.5 stuff...
I see it's already in mm.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
@ 2016-01-10 9:37 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:37 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>> The defconfig build of m68k was failing with the error:
>> implicit declaration of function '__pfn_to_phys'
>>
>> Other architectures have added <asm/memory.h>, but if we do so here then
>> we will also get redeclaration of some other functions. So it is better
>> to copy these macros into page_mm.h.
>>
>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Or should I take this through the m68k tree? It's getting a bit late for
adding new v4.5 stuff...
I see it's already in mm.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
2016-01-10 9:37 ` Geert Uytterhoeven
@ 2016-01-10 9:55 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:55 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Sun, Jan 10, 2016 at 10:37 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
>> <sudipm.mukherjee@gmail.com> wrote:
>>> The defconfig build of m68k was failing with the error:
>>> implicit declaration of function '__pfn_to_phys'
>>>
>>> Other architectures have added <asm/memory.h>, but if we do so here then
>>> we will also get redeclaration of some other functions. So it is better
>>> to copy these macros into page_mm.h.
>>>
>>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Or should I take this through the m68k tree? It's getting a bit late for
> adding new v4.5 stuff...
>
> I see it's already in mm.
I would like to withdraw my Acked-by.
I'm gonna apply it to page.h instead of page_mm.h, to cover the nommu
case, and will queue for v4.5.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] m68k: fix build failure
@ 2016-01-10 9:55 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-10 9:55 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, linux-m68k, Andrew Morton, Dan Williams
On Sun, Jan 10, 2016 at 10:37 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
>> <sudipm.mukherjee@gmail.com> wrote:
>>> The defconfig build of m68k was failing with the error:
>>> implicit declaration of function '__pfn_to_phys'
>>>
>>> Other architectures have added <asm/memory.h>, but if we do so here then
>>> we will also get redeclaration of some other functions. So it is better
>>> to copy these macros into page_mm.h.
>>>
>>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Or should I take this through the m68k tree? It's getting a bit late for
> adding new v4.5 stuff...
>
> I see it's already in mm.
I would like to withdraw my Acked-by.
I'm gonna apply it to page.h instead of page_mm.h, to cover the nommu
case, and will queue for v4.5.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-10 9:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-04 10:57 [PATCH] m68k: fix build failure Sudip Mukherjee
2016-01-04 10:57 ` Sudip Mukherjee
2016-01-10 9:35 ` Geert Uytterhoeven
2016-01-10 9:35 ` Geert Uytterhoeven
2016-01-10 9:37 ` Geert Uytterhoeven
2016-01-10 9:37 ` Geert Uytterhoeven
2016-01-10 9:55 ` Geert Uytterhoeven
2016-01-10 9:55 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.