All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: r8a77965: Add SATA controller node
@ 2018-07-30  7:33 Wolfram Sang
  2018-08-02 11:13 ` Simon Horman
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2018-07-30  7:33 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Simon Horman, Takeshi Kihara, Wolfram Sang, Geert Uytterhoeven

From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch adds SATA controller node for the R8A77965 SoC.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[wsa: rebased to upstream base]
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Changes since v1:
	* sorted it according to address (Thanks, Geert!)
	* added Geert's tag

 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 0cd44461a0bd..bf22efb82cbf 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1507,6 +1507,17 @@
 			status = "disabled";
 		};
 
+		sata: sata@ee300000 {
+			compatible = "renesas,sata-r8a77965",
+				     "renesas,rcar-gen3-sata";
+			reg = <0 0xee300000 0 0x200000>;
+			interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 815>;
+			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+			resets = <&cpg 815>;
+			status = "disabled";
+		};
+
 		gic: interrupt-controller@f1010000 {
 			compatible = "arm,gic-400";
 			#interrupt-cells = <3>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node
  2018-07-30  7:33 [PATCH v2] arm64: dts: r8a77965: Add SATA controller node Wolfram Sang
@ 2018-08-02 11:13 ` Simon Horman
  2018-08-02 11:31   ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2018-08-02 11:13 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-renesas-soc, Takeshi Kihara, Geert Uytterhoeven

On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> 
> This patch adds SATA controller node for the R8A77965 SoC.
> 
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [wsa: rebased to upstream base]
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Changes since v1:
> 	* sorted it according to address (Thanks, Geert!)
> 	* added Geert's tag
> 
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 0cd44461a0bd..bf22efb82cbf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1507,6 +1507,17 @@
>  			status = "disabled";
>  		};
>  
> +		sata: sata@ee300000 {
> +			compatible = "renesas,sata-r8a77965",
> +				     "renesas,rcar-gen3-sata";
> +			reg = <0 0xee300000 0 0x200000>;
> +			interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 815>;
> +			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> +			resets = <&cpg 815>;
> +			status = "disabled";

Is it intentional that there is no iommus property here?

> +		};
> +
>  		gic: interrupt-controller@f1010000 {
>  			compatible = "arm,gic-400";
>  			#interrupt-cells = <3>;
> -- 
> 2.11.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node
  2018-08-02 11:13 ` Simon Horman
@ 2018-08-02 11:31   ` Geert Uytterhoeven
  2018-08-09 10:41     ` Simon Horman
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-08-02 11:31 UTC (permalink / raw)
  To: Simon Horman
  Cc: Wolfram Sang, Linux-Renesas, Takeshi Kihara, Geert Uytterhoeven

Hi Simon,

On Thu, Aug 2, 2018 at 1:13 PM Simon Horman <horms@verge.net.au> wrote:
> On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> > From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > This patch adds SATA controller node for the R8A77965 SoC.
> >
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > [wsa: rebased to upstream base]
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >
> > Changes since v1:
> >       * sorted it according to address (Thanks, Geert!)
> >       * added Geert's tag
> >
> >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > index 0cd44461a0bd..bf22efb82cbf 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > @@ -1507,6 +1507,17 @@
> >                       status = "disabled";
> >               };
> >
> > +             sata: sata@ee300000 {
> > +                     compatible = "renesas,sata-r8a77965",
> > +                                  "renesas,rcar-gen3-sata";
> > +                     reg = <0 0xee300000 0 0x200000>;
> > +                     interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> > +                     clocks = <&cpg CPG_MOD 815>;
> > +                     power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> > +                     resets = <&cpg 815>;
> > +                     status = "disabled";
>
> Is it intentional that there is no iommus property here?

Because none of the other device nodes have iommus properties yet?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node
  2018-08-02 11:31   ` Geert Uytterhoeven
@ 2018-08-09 10:41     ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-08-09 10:41 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Wolfram Sang, Linux-Renesas, Takeshi Kihara, Geert Uytterhoeven

On Thu, Aug 02, 2018 at 01:31:52PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Aug 2, 2018 at 1:13 PM Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > > This patch adds SATA controller node for the R8A77965 SoC.
> > >
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > > [wsa: rebased to upstream base]
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > >
> > > Changes since v1:
> > >       * sorted it according to address (Thanks, Geert!)
> > >       * added Geert's tag
> > >
> > >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > index 0cd44461a0bd..bf22efb82cbf 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > @@ -1507,6 +1507,17 @@
> > >                       status = "disabled";
> > >               };
> > >
> > > +             sata: sata@ee300000 {
> > > +                     compatible = "renesas,sata-r8a77965",
> > > +                                  "renesas,rcar-gen3-sata";
> > > +                     reg = <0 0xee300000 0 0x200000>;
> > > +                     interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> > > +                     clocks = <&cpg CPG_MOD 815>;
> > > +                     power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> > > +                     resets = <&cpg 815>;
> > > +                     status = "disabled";
> >
> > Is it intentional that there is no iommus property here?
> 
> Because none of the other device nodes have iommus properties yet?

That is my unstated assumption too.

I've gone ahead and applied this patch for v4.20.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-09 13:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30  7:33 [PATCH v2] arm64: dts: r8a77965: Add SATA controller node Wolfram Sang
2018-08-02 11:13 ` Simon Horman
2018-08-02 11:31   ` Geert Uytterhoeven
2018-08-09 10:41     ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.