All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 4/7] sh_eth: offload RX checksum on R8A7740
Date: Thu, 31 Jan 2019 11:11:38 +0000	[thread overview]
Message-ID: <CAMuHMdWcgpW50m5p2dG74xV0L-toieU9_N7-JDkpatc=3ssJ_Q@mail.gmail.com> (raw)
In-Reply-To: <918892bc-4b2d-0235-cb51-749ca49bd4e8@cogentembedded.com>

Hi Sergei,

On Thu, Jan 31, 2019 at 11:52 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 01/29/2019 09:20 PM, Geert Uytterhoeven wrote:
> >> The R-Mobile A1 (R8A7740) SoC manual describes the Ether MAC's RX checksum
> >> offload the same way as it's implemented in the EtherAVB MAC...
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > Thanks for your patch!
> >
> > Running netperf as described in patch 2/7, perf tells me there's a reduction
> > for csum_partial from ca. 1.9% to 0.01%, so this feature seems to work.
>
>    Hm, what about do_csum()?

I had looked for that, but didn't see it. Probably inlined, as it's static.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 4/7] sh_eth: offload RX checksum on R8A7740
Date: Thu, 31 Jan 2019 12:11:38 +0100	[thread overview]
Message-ID: <CAMuHMdWcgpW50m5p2dG74xV0L-toieU9_N7-JDkpatc=3ssJ_Q@mail.gmail.com> (raw)
In-Reply-To: <918892bc-4b2d-0235-cb51-749ca49bd4e8@cogentembedded.com>

Hi Sergei,

On Thu, Jan 31, 2019 at 11:52 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 01/29/2019 09:20 PM, Geert Uytterhoeven wrote:
> >> The R-Mobile A1 (R8A7740) SoC manual describes the Ether MAC's RX checksum
> >> offload the same way as it's implemented in the EtherAVB MAC...
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > Thanks for your patch!
> >
> > Running netperf as described in patch 2/7, perf tells me there's a reduction
> > for csum_partial from ca. 1.9% to 0.01%, so this feature seems to work.
>
>    Hm, what about do_csum()?

I had looked for that, but didn't see it. Probably inlined, as it's static.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2019-01-31 11:11 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-27 17:33 [PATCH 0/7] sh_eth: implement simple RX checksum offload Sergei Shtylyov
2019-01-27 17:33 ` Sergei Shtylyov
2019-01-27 17:36 ` [PATCH 1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum Sergei Shtylyov
2019-01-27 17:36   ` Sergei Shtylyov
2019-01-28  9:21   ` Geert Uytterhoeven
2019-01-28  9:21     ` Geert Uytterhoeven
2019-01-28 11:08     ` Sergei Shtylyov
2019-01-28 11:08       ` Sergei Shtylyov
2019-01-28 19:15       ` David Miller
2019-01-28 19:15         ` David Miller
2019-01-27 17:37 ` [PATCH 2/7] sh_eth: RX checksum offload support Sergei Shtylyov
2019-01-27 17:37   ` Sergei Shtylyov
2019-01-28 12:18   ` Simon Horman
2019-01-28 12:18     ` Simon Horman
2019-01-28 15:45     ` Sergei Shtylyov
2019-01-28 15:45       ` Sergei Shtylyov
2019-01-29  7:58       ` Simon Horman
2019-01-29  7:58         ` Simon Horman
2019-01-29 15:43         ` Sergei Shtylyov
2019-01-29 15:43           ` Sergei Shtylyov
2019-01-30 10:06           ` Simon Horman
2019-01-30 10:06             ` Simon Horman
2019-01-27 17:38 ` [PATCH 3/7] sh_eth: offload RX checksum on R7S72100 Sergei Shtylyov
2019-01-27 17:38   ` Sergei Shtylyov
2019-01-28 12:20   ` Simon Horman
2019-01-28 12:20     ` Simon Horman
2019-01-28 15:21     ` Sergei Shtylyov
2019-01-28 15:21       ` Sergei Shtylyov
2019-01-29  8:00       ` Simon Horman
2019-01-29  8:00         ` Simon Horman
2019-01-29 10:37         ` Sergei Shtylyov
2019-01-29 10:37           ` Sergei Shtylyov
2019-01-29 15:02           ` Chris Brandt
2019-01-29 15:02             ` Chris Brandt
2019-01-29 16:03             ` Sergei Shtylyov
2019-01-29 16:03               ` Sergei Shtylyov
2019-01-30 10:08           ` Simon Horman
2019-01-30 10:08             ` Simon Horman
2019-01-27 17:39 ` [PATCH 4/7] sh_eth: offload RX checksum on R8A7740 Sergei Shtylyov
2019-01-27 17:39   ` Sergei Shtylyov
2019-01-29 18:20   ` Geert Uytterhoeven
2019-01-29 18:20     ` Geert Uytterhoeven
2019-01-31 10:52     ` Sergei Shtylyov
2019-01-31 10:52       ` Sergei Shtylyov
2019-01-31 11:11       ` Geert Uytterhoeven [this message]
2019-01-31 11:11         ` Geert Uytterhoeven
2019-01-27 17:40 ` [PATCH 5/7] sh_eth: offload RX checksum on R8A77980 Sergei Shtylyov
2019-01-27 17:40   ` Sergei Shtylyov
2019-01-27 17:41 ` [PATCH 6/7] sh_eth: offload RX checksum on SH7734 Sergei Shtylyov
2019-01-27 17:41   ` Sergei Shtylyov
2019-01-27 17:42 ` [PATCH 7/7] sh_eth: offload RX checksum on SH7763 Sergei Shtylyov
2019-01-27 17:42   ` Sergei Shtylyov
2019-02-04 11:55   ` Rob Landley
2019-02-04 11:55     ` Rob Landley
2019-02-04 15:17     ` Sergei Shtylyov
2019-02-04 15:17       ` Sergei Shtylyov
2019-01-27 17:52 ` [PATCH 0/7] sh_eth: implement simple RX checksum offload Heiner Kallweit
2019-01-27 17:52   ` Heiner Kallweit
2019-01-29 11:06   ` Sergei Shtylyov
2019-01-29 11:06     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWcgpW50m5p2dG74xV0L-toieU9_N7-JDkpatc=3ssJ_Q@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=davem@davemloft.net \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.