From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
Omkar Kulkarni <okulkarni@marvell.com>,
Hannes Reinecke <hare@suse.de>,
Dean Balandin <dbalandin@marvell.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Shai Malin <smalin@marvell.com>, Petr Mladek <pmladek@suse.com>,
linux-nvme@lists.infradead.org, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
Date: Tue, 8 Jun 2021 15:37:47 +0200 [thread overview]
Message-ID: <CAMuHMdWgLf8GJfOaRUyx=AvOTnuOs8FS-2=C+OCk02OLDCyrDg@mail.gmail.com> (raw)
In-Reply-To: <20210608121925.GA24201@lst.de>
Hi Christoph,
On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@lst.de> wrote:
> On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> > The help text for the symbol controlling support for the NVM Express
> > over Fabrics TCP offload common layer suggests to not enable this
> > support when unsure.
> >
> > Hence drop the "default m", which actually means "default y" if
> > CONFIG_MODULES is not enabled.
> >
> > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Err, where did this appear from? This code has not been accepted into
> the NVMe tree and is indeed not acceptable in this form.
It was applied to net-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
Omkar Kulkarni <okulkarni@marvell.com>,
Hannes Reinecke <hare@suse.de>,
Dean Balandin <dbalandin@marvell.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Shai Malin <smalin@marvell.com>, Petr Mladek <pmladek@suse.com>,
linux-nvme@lists.infradead.org, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
Date: Tue, 8 Jun 2021 15:37:47 +0200 [thread overview]
Message-ID: <CAMuHMdWgLf8GJfOaRUyx=AvOTnuOs8FS-2=C+OCk02OLDCyrDg@mail.gmail.com> (raw)
In-Reply-To: <20210608121925.GA24201@lst.de>
Hi Christoph,
On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@lst.de> wrote:
> On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> > The help text for the symbol controlling support for the NVM Express
> > over Fabrics TCP offload common layer suggests to not enable this
> > support when unsure.
> >
> > Hence drop the "default m", which actually means "default y" if
> > CONFIG_MODULES is not enabled.
> >
> > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Err, where did this appear from? This code has not been accepted into
> the NVMe tree and is indeed not acceptable in this form.
It was applied to net-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-08 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 10:56 [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m Geert Uytterhoeven
2021-06-08 10:56 ` Geert Uytterhoeven
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 13:37 ` Geert Uytterhoeven [this message]
2021-06-08 13:37 ` Geert Uytterhoeven
2021-06-08 13:43 ` please drop the nvme code from net-next Christoph Hellwig
2021-06-08 13:43 ` Christoph Hellwig
2021-06-08 19:08 ` David Miller
2021-06-08 19:08 ` David Miller
2021-06-08 19:40 ` Keith Busch
2021-06-08 19:40 ` Keith Busch
2021-06-08 19:10 ` [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m patchwork-bot+netdevbpf
2021-06-08 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWgLf8GJfOaRUyx=AvOTnuOs8FS-2=C+OCk02OLDCyrDg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=axboe@fb.com \
--cc=davem@davemloft.net \
--cc=dbalandin@marvell.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=himanshu.madhani@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=okulkarni@marvell.com \
--cc=pmladek@suse.com \
--cc=sagi@grimberg.me \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.