* [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
@ 2018-03-20 7:51 Magnus Damm
2018-03-21 8:51 ` Simon Horman
2018-03-21 9:30 ` Geert Uytterhoeven
0 siblings, 2 replies; 7+ messages in thread
From: Magnus Damm @ 2018-03-20 7:51 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: horms+renesas, Magnus Damm
From: Magnus Damm <damm+renesas@opensource.se>
Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
for [R-Car V3M] the DS1 bit field should be bit 0.
Update the ipmmu-main property to make it match the data sheet.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Based on top of renesas-drivers-2018-03-13-v4.16-rc5
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi 2018-03-20 15:26:18.250607110 +0900
@@ -160,7 +160,7 @@
ipmmu_ds1: mmu@e7740000 {
compatible = "renesas,ipmmu-r8a77970";
reg = <0 0xe7740000 0 0x1000>;
- renesas,ipmmu-main = <&ipmmu_mm 1>;
+ renesas,ipmmu-main = <&ipmmu_mm 0>;
power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
#iommu-cells = <1>;
};
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-20 7:51 [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number Magnus Damm
@ 2018-03-21 8:51 ` Simon Horman
2018-03-21 9:57 ` Simon Horman
2018-03-21 9:30 ` Geert Uytterhoeven
1 sibling, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-03-21 8:51 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc
On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
> for [R-Car V3M] the DS1 bit field should be bit 0.
>
> Update the ipmmu-main property to make it match the data sheet.
Thanks, I have confirmed this. Apologies for this error.
AFIK this IP block is currently unused, I wonder if it,
ipmmu_mm and ipmmu_rt should have status = "disabled" added.
For now I have applied this change to v4.18 with the following tag:
Fixes: ce3b52a1595b ("arm64: dts: renesas: r8a77970: Add IPMMU device
nodes")
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> Based on top of renesas-drivers-2018-03-13-v4.16-rc5
>
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi 2018-03-20 15:26:18.250607110 +0900
> @@ -160,7 +160,7 @@
> ipmmu_ds1: mmu@e7740000 {
> compatible = "renesas,ipmmu-r8a77970";
> reg = <0 0xe7740000 0 0x1000>;
> - renesas,ipmmu-main = <&ipmmu_mm 1>;
> + renesas,ipmmu-main = <&ipmmu_mm 0>;
> power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> #iommu-cells = <1>;
> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-20 7:51 [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number Magnus Damm
2018-03-21 8:51 ` Simon Horman
@ 2018-03-21 9:30 ` Geert Uytterhoeven
1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-03-21 9:30 UTC (permalink / raw)
To: Magnus Damm; +Cc: Linux-Renesas, Simon Horman
On Tue, Mar 20, 2018 at 8:51 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
> for [R-Car V3M] the DS1 bit field should be bit 0.
>
> Update the ipmmu-main property to make it match the data sheet.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-21 8:51 ` Simon Horman
@ 2018-03-21 9:57 ` Simon Horman
2018-03-22 6:07 ` Magnus Damm
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-03-21 9:57 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc
On Wed, Mar 21, 2018 at 09:51:33AM +0100, Simon Horman wrote:
> On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm+renesas@opensource.se>
> >
> > Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
> > for [R-Car V3M] the DS1 bit field should be bit 0.
> >
> > Update the ipmmu-main property to make it match the data sheet.
>
> Thanks, I have confirmed this. Apologies for this error.
>
> AFIK this IP block is currently unused, I wonder if it,
> ipmmu_mm and ipmmu_rt should have status = "disabled" added.
Sorry, I take that back, I now see the nodes used elsewhere in
the same DT file.
>
> For now I have applied this change to v4.18 with the following tag:
>
> Fixes: ce3b52a1595b ("arm64: dts: renesas: r8a77970: Add IPMMU device
> nodes")
>
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> > ---
> > Based on top of renesas-drivers-2018-03-13-v4.16-rc5
> >
> > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi 2018-03-20 15:26:18.250607110 +0900
> > @@ -160,7 +160,7 @@
> > ipmmu_ds1: mmu@e7740000 {
> > compatible = "renesas,ipmmu-r8a77970";
> > reg = <0 0xe7740000 0 0x1000>;
> > - renesas,ipmmu-main = <&ipmmu_mm 1>;
> > + renesas,ipmmu-main = <&ipmmu_mm 0>;
> > power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> > #iommu-cells = <1>;
> > };
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-21 9:57 ` Simon Horman
@ 2018-03-22 6:07 ` Magnus Damm
2018-03-22 7:59 ` Simon Horman
2018-03-22 8:07 ` Geert Uytterhoeven
0 siblings, 2 replies; 7+ messages in thread
From: Magnus Damm @ 2018-03-22 6:07 UTC (permalink / raw)
To: Simon Horman; +Cc: Linux-Renesas
Hi Simon,
On Wed, Mar 21, 2018 at 6:57 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Mar 21, 2018 at 09:51:33AM +0100, Simon Horman wrote:
>> On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote:
>> > From: Magnus Damm <damm+renesas@opensource.se>
>> >
>> > Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
>> > for [R-Car V3M] the DS1 bit field should be bit 0.
>> >
>> > Update the ipmmu-main property to make it match the data sheet.
>>
>> Thanks, I have confirmed this. Apologies for this error.
>>
>> AFIK this IP block is currently unused, I wonder if it,
>> ipmmu_mm and ipmmu_rt should have status = "disabled" added.
>
> Sorry, I take that back, I now see the nodes used elsewhere in
> the same DT file.
Thanks for your help! My opinion is that for R-Car Gen3 we don't
really need to keep any IPMMU nodes in disabled state in DT. This
since the whitelist code in the IPMMU driver will include software
policy handling to during runtime make sure only desired devices get
enabled.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-22 6:07 ` Magnus Damm
@ 2018-03-22 7:59 ` Simon Horman
2018-03-22 8:07 ` Geert Uytterhoeven
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2018-03-22 7:59 UTC (permalink / raw)
To: Magnus Damm; +Cc: Linux-Renesas
On Thu, Mar 22, 2018 at 03:07:49PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Wed, Mar 21, 2018 at 6:57 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Mar 21, 2018 at 09:51:33AM +0100, Simon Horman wrote:
> >> On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote:
> >> > From: Magnus Damm <damm+renesas@opensource.se>
> >> >
> >> > Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
> >> > for [R-Car V3M] the DS1 bit field should be bit 0.
> >> >
> >> > Update the ipmmu-main property to make it match the data sheet.
> >>
> >> Thanks, I have confirmed this. Apologies for this error.
> >>
> >> AFIK this IP block is currently unused, I wonder if it,
> >> ipmmu_mm and ipmmu_rt should have status = "disabled" added.
> >
> > Sorry, I take that back, I now see the nodes used elsewhere in
> > the same DT file.
>
> Thanks for your help! My opinion is that for R-Car Gen3 we don't
> really need to keep any IPMMU nodes in disabled state in DT. This
> since the whitelist code in the IPMMU driver will include software
> policy handling to during runtime make sure only desired devices get
> enabled.
Agreed
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number
2018-03-22 6:07 ` Magnus Damm
2018-03-22 7:59 ` Simon Horman
@ 2018-03-22 8:07 ` Geert Uytterhoeven
1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-03-22 8:07 UTC (permalink / raw)
To: Magnus Damm; +Cc: Simon Horman, Linux-Renesas
Hi Magnus,
On Thu, Mar 22, 2018 at 7:07 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Wed, Mar 21, 2018 at 6:57 PM, Simon Horman <horms@verge.net.au> wrote:
>> On Wed, Mar 21, 2018 at 09:51:33AM +0100, Simon Horman wrote:
>>> On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote:
>>> > From: Magnus Damm <damm+renesas@opensource.se>
>>> >
>>> > Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation
>>> > for [R-Car V3M] the DS1 bit field should be bit 0.
>>> >
>>> > Update the ipmmu-main property to make it match the data sheet.
>>>
>>> Thanks, I have confirmed this. Apologies for this error.
>>>
>>> AFIK this IP block is currently unused, I wonder if it,
>>> ipmmu_mm and ipmmu_rt should have status = "disabled" added.
>>
>> Sorry, I take that back, I now see the nodes used elsewhere in
>> the same DT file.
>
> Thanks for your help! My opinion is that for R-Car Gen3 we don't
> really need to keep any IPMMU nodes in disabled state in DT. This
> since the whitelist code in the IPMMU driver will include software
> policy handling to during runtime make sure only desired devices get
> enabled.
Good, DT == hardware description taking over again.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-22 8:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20 7:51 [PATCH] arm64: dts: renesas: r8a77970: Update IPMMU DS1 bit number Magnus Damm
2018-03-21 8:51 ` Simon Horman
2018-03-21 9:57 ` Simon Horman
2018-03-22 6:07 ` Magnus Damm
2018-03-22 7:59 ` Simon Horman
2018-03-22 8:07 ` Geert Uytterhoeven
2018-03-21 9:30 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.