All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
@ 2016-06-21  7:21 ` Kuninori Morimoto
  0 siblings, 0 replies; 9+ messages in thread
From: Kuninori Morimoto @ 2016-06-21  7:21 UTC (permalink / raw)
  To: Simon, Geert Uytterhoeven, Linus Walleij
  Cc: Magnus, Linux-Renesas, Laurent Pinchart, linux-gpio, linux-kernel


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 1434a6f..cb55a9a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -556,6 +556,9 @@ static const u16 pinmux_data[] = {
 	PINMUX_SINGLE(AVS2),
 	PINMUX_SINGLE(HDMI0_CEC),
 	PINMUX_SINGLE(HDMI1_CEC),
+	PINMUX_SINGLE(I2C_SEL_0_1),
+	PINMUX_SINGLE(I2C_SEL_3_1),
+	PINMUX_SINGLE(I2C_SEL_5_1),
 	PINMUX_SINGLE(MSIOF0_RXD),
 	PINMUX_SINGLE(MSIOF0_SCK),
 	PINMUX_SINGLE(MSIOF0_TXD),
@@ -1405,11 +1408,6 @@ static const u16 pinmux_data[] = {
 	PINMUX_IPSR_MSEL(IP17_7_4,	STP_ISSYNC_0_E,		SEL_SSP1_0_4),
 	PINMUX_IPSR_MSEL(IP17_7_4,	RIF2_D1_B,		SEL_DRIF2_1),
 	PINMUX_IPSR_GPSR(IP17_7_4,	TPU0TO3),
-
-	/* I2C */
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_0_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_3_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_5_1),
 };
 
 static const struct sh_pfc_pin pinmux_pins[] = {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
@ 2016-06-21  7:21 ` Kuninori Morimoto
  0 siblings, 0 replies; 9+ messages in thread
From: Kuninori Morimoto @ 2016-06-21  7:21 UTC (permalink / raw)
  To: Simon, Geert Uytterhoeven, Linus Walleij
  Cc: Magnus, Linux-Renesas, Laurent Pinchart, linux-gpio, linux-kernel


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 1434a6f..cb55a9a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -556,6 +556,9 @@ static const u16 pinmux_data[] = {
 	PINMUX_SINGLE(AVS2),
 	PINMUX_SINGLE(HDMI0_CEC),
 	PINMUX_SINGLE(HDMI1_CEC),
+	PINMUX_SINGLE(I2C_SEL_0_1),
+	PINMUX_SINGLE(I2C_SEL_3_1),
+	PINMUX_SINGLE(I2C_SEL_5_1),
 	PINMUX_SINGLE(MSIOF0_RXD),
 	PINMUX_SINGLE(MSIOF0_SCK),
 	PINMUX_SINGLE(MSIOF0_TXD),
@@ -1405,11 +1408,6 @@ static const u16 pinmux_data[] = {
 	PINMUX_IPSR_MSEL(IP17_7_4,	STP_ISSYNC_0_E,		SEL_SSP1_0_4),
 	PINMUX_IPSR_MSEL(IP17_7_4,	RIF2_D1_B,		SEL_DRIF2_1),
 	PINMUX_IPSR_GPSR(IP17_7_4,	TPU0TO3),
-
-	/* I2C */
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_0_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_3_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_5_1),
 };
 
 static const struct sh_pfc_pin pinmux_pins[] = {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-21  7:21 ` Kuninori Morimoto
  (?)
@ 2016-06-23  8:47 ` Linus Walleij
  2016-06-23  8:55   ` Geert Uytterhoeven
  -1 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2016-06-23  8:47 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Simon, Geert Uytterhoeven, Magnus, Linux-Renesas,
	Laurent Pinchart, linux-gpio, linux-kernel

On Tue, Jun 21, 2016 at 9:21 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Geert, are you queuing this?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-23  8:47 ` Linus Walleij
@ 2016-06-23  8:55   ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2016-06-23  8:55 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Kuninori Morimoto, Simon, Magnus, Linux-Renesas,
	Laurent Pinchart, linux-gpio, linux-kernel

Hi Linus,

On Thu, Jun 23, 2016 at 10:47 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Tue, Jun 21, 2016 at 9:21 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
>
>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thx!

> Geert, are you queuing this?

Sure, it's time to prepare a pull request soon...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-21  7:22     ` Geert Uytterhoeven
@ 2016-06-21  7:24       ` Kuninori Morimoto
  0 siblings, 0 replies; 9+ messages in thread
From: Kuninori Morimoto @ 2016-06-21  7:24 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Simon, Magnus, Linux-Renesas


Hi Geert

> >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> >
> >> > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
> >> >
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Oops, I didn't Cc to gpio ML
> > I will send this patch again (with Geert's Reviewed-by)
> 
> No problem, it's trivial, and it will go through my sh-pfc-for-v4.8 anyway...

OK, Thank you !

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-21  7:19   ` Kuninori Morimoto
@ 2016-06-21  7:22     ` Geert Uytterhoeven
  2016-06-21  7:24       ` Kuninori Morimoto
  0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2016-06-21  7:22 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas

Hi Morimoto-san,

On Tue, Jun 21, 2016 at 9:19 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >
>> > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Oops, I didn't Cc to gpio ML
> I will send this patch again (with Geert's Reviewed-by)

No problem, it's trivial, and it will go through my sh-pfc-for-v4.8 anyway...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-21  7:08 ` Geert Uytterhoeven
@ 2016-06-21  7:19   ` Kuninori Morimoto
  2016-06-21  7:22     ` Geert Uytterhoeven
  0 siblings, 1 reply; 9+ messages in thread
From: Kuninori Morimoto @ 2016-06-21  7:19 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Simon, Magnus, Linux-Renesas


Hi Geert

Thank you for your review

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Oops, I didn't Cc to gpio ML
I will send this patch again (with Geert's Reviewed-by)

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
  2016-06-21  2:46 Kuninori Morimoto
@ 2016-06-21  7:08 ` Geert Uytterhoeven
  2016-06-21  7:19   ` Kuninori Morimoto
  0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2016-06-21  7:08 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas

On Tue, Jun 21, 2016 at 4:46 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
@ 2016-06-21  2:46 Kuninori Morimoto
  2016-06-21  7:08 ` Geert Uytterhoeven
  0 siblings, 1 reply; 9+ messages in thread
From: Kuninori Morimoto @ 2016-06-21  2:46 UTC (permalink / raw)
  To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 1434a6f..cb55a9a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -556,6 +556,9 @@ static const u16 pinmux_data[] = {
 	PINMUX_SINGLE(AVS2),
 	PINMUX_SINGLE(HDMI0_CEC),
 	PINMUX_SINGLE(HDMI1_CEC),
+	PINMUX_SINGLE(I2C_SEL_0_1),
+	PINMUX_SINGLE(I2C_SEL_3_1),
+	PINMUX_SINGLE(I2C_SEL_5_1),
 	PINMUX_SINGLE(MSIOF0_RXD),
 	PINMUX_SINGLE(MSIOF0_SCK),
 	PINMUX_SINGLE(MSIOF0_TXD),
@@ -1405,11 +1408,6 @@ static const u16 pinmux_data[] = {
 	PINMUX_IPSR_MSEL(IP17_7_4,	STP_ISSYNC_0_E,		SEL_SSP1_0_4),
 	PINMUX_IPSR_MSEL(IP17_7_4,	RIF2_D1_B,		SEL_DRIF2_1),
 	PINMUX_IPSR_GPSR(IP17_7_4,	TPU0TO3),
-
-	/* I2C */
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_0_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_3_1),
-	PINMUX_IPSR_NOGP(0,		I2C_SEL_5_1),
 };
 
 static const struct sh_pfc_pin pinmux_pins[] = {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-23  8:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21  7:21 [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C Kuninori Morimoto
2016-06-21  7:21 ` Kuninori Morimoto
2016-06-23  8:47 ` Linus Walleij
2016-06-23  8:55   ` Geert Uytterhoeven
  -- strict thread matches above, loose matches on Subject: below --
2016-06-21  2:46 Kuninori Morimoto
2016-06-21  7:08 ` Geert Uytterhoeven
2016-06-21  7:19   ` Kuninori Morimoto
2016-06-21  7:22     ` Geert Uytterhoeven
2016-06-21  7:24       ` Kuninori Morimoto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.