All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [RFC] ARM: shmobile: Add early debugging support using SCIF(A)
Date: Fri, 03 Oct 2014 11:28:39 +0000	[thread overview]
Message-ID: <CAMuHMdWk7BdpH9zrx8WmU2TL57uRKaFS=Uwqc+5zZoufgLYTFA@mail.gmail.com> (raw)
In-Reply-To: <542E7843.8090703@renesas.com>

Hi Khiem-san,

On Fri, Oct 3, 2014 at 12:19 PM, Khiem Nguyen
<khiem.nguyen.xt@renesas.com> wrote:
>> Does enable CONFIG_EARLY_PRINTK help?
>
> For multi-platform defconfig, it does not help.

Make sure to also disable CONFIG_ARCH_R8A7740 and
CONFIG_ARCH_R8A7779, else arch/arm/include/debug/scif.S
will use a wrong value for SCIF_VIRT.

As there's no runtime configuration, enabling support for multiple SoCs
that need conflicting parameters may not work.

I've just verified that shmobile_defconfig + CONFIG_DEBUG_LL works
as-is for armadillo.
For r8a791/koelsch, I had to disable r8a7740 and r8a7789 support,
and either correct DEBUG_UART_PHYS manually, or also disable
r8a7794 support.

> However, I have also tried with legacy defconfig (lager_defconfig),
> kernel boot is OK.

Thanks!

> As legacy defconfig will become deprecated in near future,
> I think this patch should support multi-platform defconfig.

CONFIG_DEBUG_LL is not to be enabled in any multi-platform
defconfig. It's only meant for desperate developers, running a kernel
for one specific platform. Cfr. its help text:

config DEBUG_LL
        bool "Kernel low-level debugging functions (read help!)"
        depends on DEBUG_KERNEL
        help
          Say Y here to include definitions of printascii, printch, printhex
          in the kernel.  This is helpful if you are debugging code that
          executes before the console is initialized.

          Note that selecting this option will limit the kernel to a single
          UART definition, as specified below. Attempting to boot the kernel
          image on a different platform *will not work*, so this option should
          not be enabled for kernels that are intended to be portable.

All defconfigs enabling CONFIG_DEBUG_LL are defconfigs for
legacy platforms.
The only exceptions are bcm2835_defconfig, moxart_defconfig,
s5pv210_defconfig, and tegra_defconfig, which support only one
platform, or a family of very similar platforms.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] ARM: shmobile: Add early debugging support using SCIF(A)
Date: Fri, 3 Oct 2014 13:28:39 +0200	[thread overview]
Message-ID: <CAMuHMdWk7BdpH9zrx8WmU2TL57uRKaFS=Uwqc+5zZoufgLYTFA@mail.gmail.com> (raw)
In-Reply-To: <542E7843.8090703@renesas.com>

Hi Khiem-san,

On Fri, Oct 3, 2014 at 12:19 PM, Khiem Nguyen
<khiem.nguyen.xt@renesas.com> wrote:
>> Does enable CONFIG_EARLY_PRINTK help?
>
> For multi-platform defconfig, it does not help.

Make sure to also disable CONFIG_ARCH_R8A7740 and
CONFIG_ARCH_R8A7779, else arch/arm/include/debug/scif.S
will use a wrong value for SCIF_VIRT.

As there's no runtime configuration, enabling support for multiple SoCs
that need conflicting parameters may not work.

I've just verified that shmobile_defconfig + CONFIG_DEBUG_LL works
as-is for armadillo.
For r8a791/koelsch, I had to disable r8a7740 and r8a7789 support,
and either correct DEBUG_UART_PHYS manually, or also disable
r8a7794 support.

> However, I have also tried with legacy defconfig (lager_defconfig),
> kernel boot is OK.

Thanks!

> As legacy defconfig will become deprecated in near future,
> I think this patch should support multi-platform defconfig.

CONFIG_DEBUG_LL is not to be enabled in any multi-platform
defconfig. It's only meant for desperate developers, running a kernel
for one specific platform. Cfr. its help text:

config DEBUG_LL
        bool "Kernel low-level debugging functions (read help!)"
        depends on DEBUG_KERNEL
        help
          Say Y here to include definitions of printascii, printch, printhex
          in the kernel.  This is helpful if you are debugging code that
          executes before the console is initialized.

          Note that selecting this option will limit the kernel to a single
          UART definition, as specified below. Attempting to boot the kernel
          image on a different platform *will not work*, so this option should
          not be enabled for kernels that are intended to be portable.

All defconfigs enabling CONFIG_DEBUG_LL are defconfigs for
legacy platforms.
The only exceptions are bcm2835_defconfig, moxart_defconfig,
s5pv210_defconfig, and tegra_defconfig, which support only one
platform, or a family of very similar platforms.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2014-10-03 11:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 19:02 [PATCH] [RFC] ARM: shmobile: Add early debugging support using SCIF(A) Geert Uytterhoeven
2014-10-02 19:02 ` Geert Uytterhoeven
2014-10-03  0:04 ` Khiem Nguyen
2014-10-03  0:04   ` Khiem Nguyen
2014-10-03  7:21   ` Geert Uytterhoeven
2014-10-03  7:21     ` Geert Uytterhoeven
2014-10-03 10:19     ` Khiem Nguyen
2014-10-03 10:19       ` Khiem Nguyen
2014-10-03 11:28       ` Geert Uytterhoeven [this message]
2014-10-03 11:28         ` Geert Uytterhoeven
2014-10-05 22:18 ` Laurent Pinchart
2014-10-05 22:18   ` Laurent Pinchart
2014-10-06  6:03   ` Wolfram Sang
2014-10-06  6:03     ` Wolfram Sang
2014-10-06  6:14     ` Magnus Damm
2014-10-06  6:14       ` Magnus Damm
2014-10-06  8:56     ` Geert Uytterhoeven
2014-10-06  8:56       ` Geert Uytterhoeven
2014-10-06  9:01       ` Wolfram Sang
2014-10-06  9:01         ` Wolfram Sang
2014-10-06  9:08   ` Geert Uytterhoeven
2014-10-06  9:08     ` Geert Uytterhoeven
2014-10-07 10:37   ` Ian Molton
2014-10-07 10:37     ` Ian Molton
2014-10-07 11:07     ` Geert Uytterhoeven
2014-10-07 11:07       ` Geert Uytterhoeven
2014-10-07 12:39       ` Geert Uytterhoeven
2014-10-07 12:39         ` Geert Uytterhoeven
2014-10-05 23:36 ` Magnus Damm
2014-10-05 23:36   ` Magnus Damm
2014-10-06  9:18   ` Geert Uytterhoeven
2014-10-06  9:18     ` Geert Uytterhoeven
2014-10-07 10:49 ` Arnd Bergmann
2014-10-07 10:49   ` Arnd Bergmann
2014-10-07 11:46   ` Geert Uytterhoeven
2014-10-07 11:46     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWk7BdpH9zrx8WmU2TL57uRKaFS=Uwqc+5zZoufgLYTFA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.