From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-clk <linux-clk@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Gaku Inami <gaku.inami.xw@bp.renesas.com>,
Michael Turquette <mturquette@baylibre.com>,
SH-Linux <linux-sh@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"Simon Horman [Horms]" <horms@verge.net.au>
Subject: Re: [PATCH v5 02/05] clk: shmobile: Add Renesas R-Car Gen3 CPG support
Date: Tue, 01 Sep 2015 11:36:28 +0000 [thread overview]
Message-ID: <CAMuHMdWkBPhPJP5WUkDv+1psiZ9iFQv65t9QB5+qq=+Kn7L0mA@mail.gmail.com> (raw)
In-Reply-To: <CANqRtoSw92UoVBvTJfzGvxmYwefNndqqnj2_8iqi5O=FUeLMGA@mail.gmail.com>
Hi Magnus,
On Tue, Sep 1, 2015 at 12:59 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> +/*
>>> + * MD EXTAL PLL0 PLL1 PLL2 PLL3 PLL4
>>> + * 14 13 19 17 (MHz) *1 *1 *1
>>> + *-------------------------------------------------------------------
>>> + * 0 0 0 0 16.66 x 1 x180/2 x192/2 x144/2 x192 x144
>>> + * 0 0 0 1 16.66 x 1 x180/2 x192/2 x144/2 x128 x144
>>> + * 0 0 1 0 Prohibited setting
>>> + * 0 0 1 1 16.66 x 1 x180/2 x192/2 x144/2 x192 x144
>>> + * 0 1 0 0 20 x 1 x150/2 x156/2 x120/2 x156 x120
>>> + * 0 1 0 1 20 x 1 x150/2 x156/2 x120/2 x106 x120
>>> + * 0 1 1 0 Prohibited setting
>>> + * 0 1 1 1 20 x 1 x150/2 x156/2 x120/2 x156 x120
>>> + * 1 0 0 0 25 x 1 x120/2 x128/2 x96/2 x128 x96
>>> + * 1 0 0 1 25 x 1 x120/2 x128/2 x96/2 x84 x96
>>> + * 1 0 1 0 Prohibited setting
>>> + * 1 0 1 1 25 x 1 x120/2 x128/2 x96/2 x128 x96
>>> + * 1 1 0 0 33.33 / 2 x180/2 x192/2 x144/2 x192 x144
>>> + * 1 1 0 1 33.33 / 2 x180/2 x192/2 x144/2 x128 x144
>>> + * 1 1 1 0 Prohibited setting
>>> + * 1 1 1 1 33.33 / 2 x180/2 x192/2 x144/2 x192 x144
>>> + *
>>> + * *1 : datasheet indicates VCO output (PLLx = VCO/2)
>>
>> As explained in a separate e-mail there's a few clocks on R8A7795 that derive
>> directly from PLL1 VCO. I thus wonder whether we shouldn't expose the PLL1
>> clock as the VCO output and create VCO/2 using a fixed factor clock in DT.
>
> Do you think that would reduce complexity or simplify the code? If so
> I think we should do it. Otherwise I think it makes sense to simply
> follow the data sheet.
It would avoid having to apply a multiplier of two to the RPC clock.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-clk <linux-clk@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Gaku Inami <gaku.inami.xw@bp.renesas.com>,
Michael Turquette <mturquette@baylibre.com>,
SH-Linux <linux-sh@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"Simon Horman [Horms]" <horms@verge.net.au>
Subject: Re: [PATCH v5 02/05] clk: shmobile: Add Renesas R-Car Gen3 CPG support
Date: Tue, 1 Sep 2015 13:36:28 +0200 [thread overview]
Message-ID: <CAMuHMdWkBPhPJP5WUkDv+1psiZ9iFQv65t9QB5+qq=+Kn7L0mA@mail.gmail.com> (raw)
In-Reply-To: <CANqRtoSw92UoVBvTJfzGvxmYwefNndqqnj2_8iqi5O=FUeLMGA@mail.gmail.com>
Hi Magnus,
On Tue, Sep 1, 2015 at 12:59 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> +/*
>>> + * MD EXTAL PLL0 PLL1 PLL2 PLL3 PLL4
>>> + * 14 13 19 17 (MHz) *1 *1 *1
>>> + *-------------------------------------------------------------------
>>> + * 0 0 0 0 16.66 x 1 x180/2 x192/2 x144/2 x192 x144
>>> + * 0 0 0 1 16.66 x 1 x180/2 x192/2 x144/2 x128 x144
>>> + * 0 0 1 0 Prohibited setting
>>> + * 0 0 1 1 16.66 x 1 x180/2 x192/2 x144/2 x192 x144
>>> + * 0 1 0 0 20 x 1 x150/2 x156/2 x120/2 x156 x120
>>> + * 0 1 0 1 20 x 1 x150/2 x156/2 x120/2 x106 x120
>>> + * 0 1 1 0 Prohibited setting
>>> + * 0 1 1 1 20 x 1 x150/2 x156/2 x120/2 x156 x120
>>> + * 1 0 0 0 25 x 1 x120/2 x128/2 x96/2 x128 x96
>>> + * 1 0 0 1 25 x 1 x120/2 x128/2 x96/2 x84 x96
>>> + * 1 0 1 0 Prohibited setting
>>> + * 1 0 1 1 25 x 1 x120/2 x128/2 x96/2 x128 x96
>>> + * 1 1 0 0 33.33 / 2 x180/2 x192/2 x144/2 x192 x144
>>> + * 1 1 0 1 33.33 / 2 x180/2 x192/2 x144/2 x128 x144
>>> + * 1 1 1 0 Prohibited setting
>>> + * 1 1 1 1 33.33 / 2 x180/2 x192/2 x144/2 x192 x144
>>> + *
>>> + * *1 : datasheet indicates VCO output (PLLx = VCO/2)
>>
>> As explained in a separate e-mail there's a few clocks on R8A7795 that derive
>> directly from PLL1 VCO. I thus wonder whether we shouldn't expose the PLL1
>> clock as the VCO output and create VCO/2 using a fixed factor clock in DT.
>
> Do you think that would reduce complexity or simplify the code? If so
> I think we should do it. Otherwise I think it makes sense to simply
> follow the data sheet.
It would avoid having to apply a multiplier of two to the RPC clock.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-09-01 11:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 12:48 [PATCH v5 00/05] Renesas R-Car Gen3 CPG support V5 Magnus Damm
2015-08-31 12:48 ` Magnus Damm
2015-08-31 12:48 ` [PATCH v5 01/05] clk: shmobile: Rework CONFIG_ARCH_SHMOBILE_MULTI Magnus Damm
2015-08-31 12:48 ` Magnus Damm
2015-08-31 12:49 ` [PATCH v5 02/05] clk: shmobile: Add Renesas R-Car Gen3 CPG support Magnus Damm
2015-08-31 12:49 ` Magnus Damm
2015-09-01 6:00 ` Laurent Pinchart
2015-09-01 6:00 ` Laurent Pinchart
2015-09-01 10:59 ` Magnus Damm
2015-09-01 10:59 ` Magnus Damm
2015-09-01 11:36 ` Geert Uytterhoeven [this message]
2015-09-01 11:36 ` Geert Uytterhoeven
2015-09-01 11:51 ` Laurent Pinchart
2015-09-01 11:51 ` Laurent Pinchart
2015-09-01 12:30 ` Laurent Pinchart
2015-09-01 12:30 ` Laurent Pinchart
2015-09-02 2:27 ` Magnus Damm
2015-09-02 2:27 ` Magnus Damm
2015-09-02 5:21 ` Laurent Pinchart
2015-09-02 5:21 ` Laurent Pinchart
2015-09-02 8:24 ` Magnus Damm
2015-09-02 8:24 ` Magnus Damm
2015-09-01 14:23 ` Geert Uytterhoeven
2015-09-01 14:23 ` Geert Uytterhoeven
2015-08-31 12:49 ` [PATCH v5 03/05] clk: shmobile: rcar-gen3: Add CPG/MSTP Clock Domain support Magnus Damm
2015-08-31 12:49 ` Magnus Damm
2015-08-31 12:49 ` [PATCH v5 04/05] clk: shmobile: Add r8a7795 SoC to MSTP bindings Magnus Damm
2015-08-31 12:49 ` Magnus Damm
2015-09-01 6:02 ` Laurent Pinchart
2015-09-01 6:02 ` Laurent Pinchart
2015-08-31 12:49 ` [PATCH v5 05/05] clk: shmobile: Make MSTP clock-output-names optional Magnus Damm
2015-08-31 12:49 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWkBPhPJP5WUkDv+1psiZ9iFQv65t9QB5+qq=+Kn7L0mA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=gaku.inami.xw@bp.renesas.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.