[PATCH] PTI implicit declaration fix.

[PATCH] PTI implicit declaration fix.

[james_p_freyensee]

From: J Freyensee <james_p_freyensee@linux.intel.com>

In a certain compile configuration, functions like
'kmalloc' and 'copy_from_user' were coming up as
implicit errors.  This patch adds slab.h and
uaccess.h to the driver.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
---
 drivers/misc/pti.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index 8653bd0..4ba4e5f 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -22,6 +22,8 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/uaccess.h>
 #include <linux/sched.h>
 #include <linux/interrupt.h>
 #include <linux/console.h>
-- 
1.7.0.4

Re: [PATCH] PTI implicit declaration fix.

[Geert Uytterhoeven]

On Fri, Jul 8, 2011 at 23:34,  <james_p_freyensee@linux.intel.com> wrote:
> From: J Freyensee <james_p_freyensee@linux.intel.com>
>
> In a certain compile configuration, functions like
> 'kmalloc' and 'copy_from_user' were coming up as
> implicit errors.  This patch adds slab.h and
> uaccess.h to the driver.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Please don't add "Acked-by" lines before people have ack'ed your patches.

> Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> ---
>  drivers/misc/pti.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
> index 8653bd0..4ba4e5f 100644
> --- a/drivers/misc/pti.c
> +++ b/drivers/misc/pti.c
> @@ -22,6 +22,8 @@
>  */
>
>  #include <linux/init.h>
> +#include <linux/slab.h>
> +#include <linux/uaccess.h>
>  #include <linux/sched.h>
>  #include <linux/interrupt.h>
>  #include <linux/console.h>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] PTI implicit declaration fix.

[J Freyensee]

On 07/09/2011 01:08 AM, Geert Uytterhoeven wrote:
> On Fri, Jul 8, 2011 at 23:34,<james_p_freyensee@linux.intel.com>  wrote:
>> From: J Freyensee<james_p_freyensee@linux.intel.com>
>>
>> In a certain compile configuration, functions like
>> 'kmalloc' and 'copy_from_user' were coming up as
>> implicit errors.  This patch adds slab.h and
>> uaccess.h to the driver.
>>
>> Reported-by: Geert Uytterhoeven<geert@linux-m68k.org>
>> Acked-by: Geert Uytterhoeven<geert@linux-m68k.org>
>
> Please don't add "Acked-by" lines before people have ack'ed your patches.
>

Okay...so should I re-send this patch out without the Acked-by in it? 
Or is it okay this time and next time please do this?

>> Signed-off-by: J Freyensee<james_p_freyensee@linux.intel.com>
>> ---
>>   drivers/misc/pti.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
>> index 8653bd0..4ba4e5f 100644
>> --- a/drivers/misc/pti.c
>> +++ b/drivers/misc/pti.c
>> @@ -22,6 +22,8 @@
>>   */
>>
>>   #include<linux/init.h>
>> +#include<linux/slab.h>
>> +#include<linux/uaccess.h>
>>   #include<linux/sched.h>
>>   #include<linux/interrupt.h>
>>   #include<linux/console.h>
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Re: [PATCH] PTI implicit declaration fix.

[Geert Uytterhoeven]

On Mon, Jul 11, 2011 at 18:10, J Freyensee
<james_p_freyensee@linux.intel.com> wrote:
> On 07/09/2011 01:08 AM, Geert Uytterhoeven wrote:
>> On Fri, Jul 8, 2011 at 23:34,<james_p_freyensee@linux.intel.com>  wrote:
>>>
>>> From: J Freyensee<james_p_freyensee@linux.intel.com>
>>>
>>> In a certain compile configuration, functions like
>>> 'kmalloc' and 'copy_from_user' were coming up as
>>> implicit errors.  This patch adds slab.h and
>>> uaccess.h to the driver.
>>>
>>> Reported-by: Geert Uytterhoeven<geert@linux-m68k.org>
>>> Acked-by: Geert Uytterhoeven<geert@linux-m68k.org>
>>
>> Please don't add "Acked-by" lines before people have ack'ed your patches.
>>
>
> Okay...so should I re-send this patch out without the Acked-by in it? Or is
> it okay this time and next time please do this?

It's OK for now. It's a trivial patch anyway.

>>> Signed-off-by: J Freyensee<james_p_freyensee@linux.intel.com>
>>> ---
>>>  drivers/misc/pti.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
>>> index 8653bd0..4ba4e5f 100644
>>> --- a/drivers/misc/pti.c
>>> +++ b/drivers/misc/pti.c
>>> @@ -22,6 +22,8 @@
>>>  */
>>>
>>>  #include<linux/init.h>
>>> +#include<linux/slab.h>
>>> +#include<linux/uaccess.h>
>>>  #include<linux/sched.h>
>>>  #include<linux/interrupt.h>
>>>  #include<linux/console.h>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds