[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

	Hi Simon, Magnus,

This patch series improves the topology description in DT of the ARM GIC
on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
module clock, and adds the GIC to the SYSC "always on" PM Domain.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.  Hence this
series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
INTC-SYS a critical clock"), which is in v4.11-rc1.

This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
less dependencies.

Changes compared to v1:
  - Add missing "power-domains" property,
  - Add clock-names property,
  - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
  - Add r8a7792 patch,
  - Please refer to the individual patch changelogs for more details
    (v1 dates back to 2014).

Thanks for applying!

Geert Uytterhoeven (6):
  ARM: dts: r8a73a4: Add INTC-SYS clock to device tree
  ARM: dts: r8a7790: Add INTC-SYS clock to device tree
  ARM: dts: r8a7791: Add INTC-SYS clock to device tree
  ARM: dts: r8a7792: Add INTC-SYS clock to device tree
  ARM: dts: r8a7793: Add INTC-SYS clock to device tree
  ARM: dts: r8a7794: Add INTC-SYS clock to device tree

 arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
 arch/arm/boot/dts/r8a7790.dtsi            |  9 ++++++---
 arch/arm/boot/dts/r8a7791.dtsi            |  9 ++++++---
 arch/arm/boot/dts/r8a7792.dtsi            | 11 ++++++++---
 arch/arm/boot/dts/r8a7793.dtsi            | 11 ++++++++---
 arch/arm/boot/dts/r8a7794.dtsi            |  9 ++++++---
 include/dt-bindings/clock/r8a73a4-clock.h |  1 +
 include/dt-bindings/clock/r8a7790-clock.h |  1 +
 include/dt-bindings/clock/r8a7791-clock.h |  1 +
 include/dt-bindings/clock/r8a7792-clock.h |  1 +
 include/dt-bindings/clock/r8a7793-clock.h |  5 +++--
 include/dt-bindings/clock/r8a7794-clock.h |  1 +
 12 files changed, 51 insertions(+), 21 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
so it can be power managed using that clock in the future.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Add missing "power-domains" property,
  - Add clock-names property,
  - Drop RFC status,
  - Change one-line summary prefix to match current arm-soc practices,
  - s/GIC driver/GIC-400 driver/,
  - Document critical clock dependency.
---
 arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
 include/dt-bindings/clock/r8a73a4-clock.h |  1 +
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
--- a/arch/arm/boot/dts/r8a73a4.dtsi
+++ b/arch/arm/boot/dts/r8a73a4.dtsi
@@ -467,6 +467,9 @@
 			<0 0xf1004000 0 0x2000>,
 			<0 0xf1006000 0 0x2000>;
 		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+		clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
+		clock-names = "clk";
+		power-domains = <&pd_c4>;
 	};
 
 	bsc: bus@fec10000 {
@@ -725,16 +728,18 @@
 		mstp4_clks: mstp4_clks@e6150140 {
 			compatible = "renesas,r8a73a4-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&main_div2_clk>, <&main_div2_clk>,
+			clocks = <&main_div2_clk>, <&cpg_clocks R8A73A4_CLK_ZS>,
+				 <&main_div2_clk>,
 				 <&cpg_clocks R8A73A4_CLK_HP>,
 				 <&cpg_clocks R8A73A4_CLK_HP>;
 			#clock-cells = <1>;
 			clock-indices = <
-				R8A73A4_CLK_IRQC R8A73A4_CLK_IIC5
-				R8A73A4_CLK_IIC4 R8A73A4_CLK_IIC3
+				R8A73A4_CLK_IRQC R8A73A4_CLK_INTC_SYS
+				R8A73A4_CLK_IIC5 R8A73A4_CLK_IIC4
+				R8A73A4_CLK_IIC3
 			>;
 			clock-output-names =
-				"irqc", "iic5", "iic4", "iic3";
+				"irqc", "intc-sys", "iic5", "iic4", "iic3";
 		};
 		mstp5_clks: mstp5_clks@e6150144 {
 			compatible = "renesas,r8a73a4-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a73a4-clock.h b/include/dt-bindings/clock/r8a73a4-clock.h
index dd11ecdf837e8e65..4b36681572570c15 100644
--- a/include/dt-bindings/clock/r8a73a4-clock.h
+++ b/include/dt-bindings/clock/r8a73a4-clock.h
@@ -54,6 +54,7 @@
 #define R8A73A4_CLK_IIC3	11
 #define R8A73A4_CLK_IIC4	10
 #define R8A73A4_CLK_IIC5	9
+#define R8A73A4_CLK_INTC_SYS	8
 #define R8A73A4_CLK_IRQC	7
 
 /* MSTP5 */
-- 
2.7.4

[PATCH v2 2/6] ARM: dts: r8a7790: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the "always
on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop RFC status,
  - Rebased on top of CPG Clock Domain support,
  - Add clock-names property,
  - Change one-line summary prefix to match current arm-soc practices.
  - Rebased on top of R-Car SYSC PM Domain support,
  - s/GIC driver/GIC-400 driver/,
  - Document critical clock dependency.
---
 arch/arm/boot/dts/r8a7790.dtsi            | 9 ++++++---
 include/dt-bindings/clock/r8a7790-clock.h | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 20cf191e0852b10a..2a1967d70804278c 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -185,6 +185,9 @@
 			<0 0xf1004000 0 0x2000>,
 			<0 0xf1006000 0 0x2000>;
 		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+		clocks = <&mstp4_clks R8A7790_CLK_INTC_SYS>;
+		clock-names = "clk";
+		power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
 	};
 
 	gpio0: gpio@e6050000 {
@@ -1364,10 +1367,10 @@
 		mstp4_clks: mstp4_clks@e6150140 {
 			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&cp_clk>;
+			clocks = <&cp_clk>, <&zs_clk>;
 			#clock-cells = <1>;
-			clock-indices = <R8A7790_CLK_IRQC>;
-			clock-output-names = "irqc";
+			clock-indices = <R8A7790_CLK_IRQC R8A7790_CLK_INTC_SYS>;
+			clock-output-names = "irqc", "intc-sys";
 		};
 		mstp5_clks: mstp5_clks@e6150144 {
 			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
index fa5e8da809f2e802..20641fa68e731ec0 100644
--- a/include/dt-bindings/clock/r8a7790-clock.h
+++ b/include/dt-bindings/clock/r8a7790-clock.h
@@ -82,6 +82,7 @@
 
 /* MSTP4 */
 #define R8A7790_CLK_IRQC		7
+#define R8A7790_CLK_INTC_SYS		8
 
 /* MSTP5 */
 #define R8A7790_CLK_AUDIO_DMAC1		1
-- 
2.7.4

[PATCH v2 3/6] ARM: dts: r8a7791: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the "always
on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop RFC status,
  - Rebased on top of CPG Clock Domain support,
  - Add clock-names property,
  - Change one-line summary prefix to match current arm-soc practices.
  - Rebased on top of R-Car SYSC PM Domain support,
  - s/GIC driver/GIC-400 driver/,
  - Document critical clock dependency.
---
 arch/arm/boot/dts/r8a7791.dtsi            | 9 ++++++---
 include/dt-bindings/clock/r8a7791-clock.h | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 7cad65a28f251172..525377df16eedb8f 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -117,6 +117,9 @@
 			<0 0xf1004000 0 0x2000>,
 			<0 0xf1006000 0 0x2000>;
 		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
+		clocks = <&mstp4_clks R8A7791_CLK_INTC_SYS>;
+		clock-names = "clk";
+		power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
 	};
 
 	gpio0: gpio@e6050000 {
@@ -1365,10 +1368,10 @@
 		mstp4_clks: mstp4_clks@e6150140 {
 			compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&cp_clk>;
+			clocks = <&cp_clk>, <&zs_clk>;
 			#clock-cells = <1>;
-			clock-indices = <R8A7791_CLK_IRQC>;
-			clock-output-names = "irqc";
+			clock-indices = <R8A7791_CLK_IRQC R8A7791_CLK_INTC_SYS>;
+			clock-output-names = "irqc", "intc-sys";
 		};
 		mstp5_clks: mstp5_clks@e6150144 {
 			compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7791-clock.h b/include/dt-bindings/clock/r8a7791-clock.h
index ffa11379b3f0ade9..adc50dc31ab3423e 100644
--- a/include/dt-bindings/clock/r8a7791-clock.h
+++ b/include/dt-bindings/clock/r8a7791-clock.h
@@ -72,6 +72,7 @@
 
 /* MSTP4 */
 #define R8A7791_CLK_IRQC		7
+#define R8A7791_CLK_INTC_SYS		8
 
 /* MSTP5 */
 #define R8A7791_CLK_AUDIO_DMAC1		1
-- 
2.7.4

[PATCH v2 4/6] ARM: dts: r8a7792: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the "always
on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 arch/arm/boot/dts/r8a7792.dtsi            | 11 ++++++++---
 include/dt-bindings/clock/r8a7792-clock.h |  1 +
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7792.dtsi b/arch/arm/boot/dts/r8a7792.dtsi
index c762f44f7732f352..6c0797ebc08f029c 100644
--- a/arch/arm/boot/dts/r8a7792.dtsi
+++ b/arch/arm/boot/dts/r8a7792.dtsi
@@ -92,6 +92,9 @@
 			      <0 0xf1006000 0 0x2000>;
 			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) |
 				      IRQ_TYPE_LEVEL_HIGH)>;
+			clocks = <&mstp4_clks R8A7792_CLK_INTC_SYS>;
+			clock-names = "clk";
+			power-domains = <&sysc R8A7792_PD_ALWAYS_ON>;
 		};
 
 		irqc: interrupt-controller@e61c0000 {
@@ -895,10 +898,12 @@
 			compatible = "renesas,r8a7792-mstp-clocks",
 				     "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&cp_clk>;
+			clocks = <&cp_clk>, <&zs_clk>;
 			#clock-cells = <1>;
-			clock-indices = <R8A7792_CLK_IRQC>;
-			clock-output-names = "irqc";
+			clock-indices = <
+				R8A7792_CLK_IRQC R8A7792_CLK_INTC_SYS
+			>;
+			clock-output-names = "irqc", "intc-sys";
 		};
 		mstp7_clks: mstp7_clks@e615014c {
 			compatible = "renesas,r8a7792-mstp-clocks",
diff --git a/include/dt-bindings/clock/r8a7792-clock.h b/include/dt-bindings/clock/r8a7792-clock.h
index 9a8b392ceb000fc3..94dd16a1e6e6963d 100644
--- a/include/dt-bindings/clock/r8a7792-clock.h
+++ b/include/dt-bindings/clock/r8a7792-clock.h
@@ -45,6 +45,7 @@
 
 /* MSTP4 */
 #define R8A7792_CLK_IRQC		7
+#define R8A7792_CLK_INTC_SYS		8
 
 /* MSTP5 */
 #define R8A7792_CLK_AUDIO_DMAC0		2
-- 
2.7.4

[PATCH v2 5/6] ARM: dts: r8a7793: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the "always
on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop RFC status,
  - Rebased on top of CPG Clock Domain support,
  - Add clock-names property,
  - Change one-line summary prefix to match current arm-soc practices.
  - Rebased on top of R-Car SYSC PM Domain support,
  - s/GIC driver/GIC-400 driver/,
  - Document critical clock dependency.
---
 arch/arm/boot/dts/r8a7793.dtsi            | 11 ++++++++---
 include/dt-bindings/clock/r8a7793-clock.h |  5 +++--
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index 38506f563b2b2e5a..f36772a642c008ef 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -108,6 +108,9 @@
 			<0 0xf1004000 0 0x2000>,
 			<0 0xf1006000 0 0x2000>;
 		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
+		clocks = <&mstp4_clks R8A7793_CLK_INTC_SYS>;
+		clock-names = "clk";
+		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
 	};
 
 	gpio0: gpio@e6050000 {
@@ -1178,10 +1181,12 @@
 		mstp4_clks: mstp4_clks@e6150140 {
 			compatible = "renesas,r8a7793-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&cp_clk>;
+			clocks = <&cp_clk>, <&zs_clk>;
 			#clock-cells = <1>;
-			clock-indices = <R8A7793_CLK_IRQC>;
-			clock-output-names = "irqc";
+			clock-indices = <
+				R8A7793_CLK_IRQC R8A7793_CLK_INTC_SYS
+			>;
+			clock-output-names = "irqc", "intc-sys";
 		};
 		mstp5_clks: mstp5_clks@e6150144 {
 			compatible = "renesas,r8a7793-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7793-clock.h b/include/dt-bindings/clock/r8a7793-clock.h
index efcbc594fe82e683..7318d45d4e7e9888 100644
--- a/include/dt-bindings/clock/r8a7793-clock.h
+++ b/include/dt-bindings/clock/r8a7793-clock.h
@@ -77,10 +77,11 @@
 
 /* MSTP4 */
 #define R8A7793_CLK_IRQC		7
+#define R8A7793_CLK_INTC_SYS		8
 
 /* MSTP5 */
-#define R8A7793_CLK_AUDIO_DMAC1         1
-#define R8A7793_CLK_AUDIO_DMAC0         2
+#define R8A7793_CLK_AUDIO_DMAC1		1
+#define R8A7793_CLK_AUDIO_DMAC0		2
 #define R8A7793_CLK_ADSP_MOD		6
 #define R8A7793_CLK_THERMAL		22
 #define R8A7793_CLK_PWM			23
-- 
2.7.4

[PATCH v2 6/6] ARM: dts: r8a7794: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the "always
on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop RFC status,
  - Rebased on top of CPG Clock Domain support,
  - Add clock-names property,
  - Change one-line summary prefix to match current arm-soc practices.
  - Rebased on top of R-Car SYSC PM Domain support,
  - s/GIC driver/GIC-400 driver/,
  - Document critical clock dependency.
---
 arch/arm/boot/dts/r8a7794.dtsi            | 9 ++++++---
 include/dt-bindings/clock/r8a7794-clock.h | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index cb31cd2232f9166f..38bf9ed8e739ea2b 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -74,6 +74,9 @@
 			<0 0xf1004000 0 0x2000>,
 			<0 0xf1006000 0 0x2000>;
 		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
+		clocks = <&mstp4_clks R8A7794_CLK_INTC_SYS>;
+		clock-names = "clk";
+		power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
 	};
 
 	gpio0: gpio@e6050000 {
@@ -1247,10 +1250,10 @@
 		mstp4_clks: mstp4_clks@e6150140 {
 			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe6150140 0 4>, <0 0xe615004c 0 4>;
-			clocks = <&cp_clk>;
+			clocks = <&cp_clk>, <&zs_clk>;
 			#clock-cells = <1>;
-			clock-indices = <R8A7794_CLK_IRQC>;
-			clock-output-names = "irqc";
+			clock-indices = <R8A7794_CLK_IRQC R8A7794_CLK_INTC_SYS>;
+			clock-output-names = "irqc", "intc-sys";
 		};
 		mstp5_clks: mstp5_clks@e6150144 {
 			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7794-clock.h b/include/dt-bindings/clock/r8a7794-clock.h
index 88e64846cf370ff4..a26776f7deddbaa4 100644
--- a/include/dt-bindings/clock/r8a7794-clock.h
+++ b/include/dt-bindings/clock/r8a7794-clock.h
@@ -64,6 +64,7 @@
 
 /* MSTP4 */
 #define R8A7794_CLK_IRQC		7
+#define R8A7794_CLK_INTC_SYS		8
 
 /* MSTP5 */
 #define R8A7794_CLK_AUDIO_DMAC0		2
-- 
2.7.4

Re: [PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Sergei Shtylyov]

Hello!

On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:

> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
> so it can be power managed using that clock in the future.
>
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Drop RFC status,
>   - Change one-line summary prefix to match current arm-soc practices,
>   - s/GIC driver/GIC-400 driver/,
>   - Document critical clock dependency.
> ---
>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
> --- a/arch/arm/boot/dts/r8a73a4.dtsi
> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> @@ -467,6 +467,9 @@
>  			<0 0xf1004000 0 0x2000>,
>  			<0 0xf1006000 0 0x2000>;
>  		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> +		clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
> +		clock-names = "clk";

    Do we really need such "clock-names"?

[...]

MBR, Sergei

[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Sergei Shtylyov]

Hello!

On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:

> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
> so it can be power managed using that clock in the future.
>
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Drop RFC status,
>   - Change one-line summary prefix to match current arm-soc practices,
>   - s/GIC driver/GIC-400 driver/,
>   - Document critical clock dependency.
> ---
>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
> --- a/arch/arm/boot/dts/r8a73a4.dtsi
> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> @@ -467,6 +467,9 @@
>  			<0 0xf1004000 0 0x2000>,
>  			<0 0xf1006000 0 0x2000>;
>  		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> +		clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
> +		clock-names = "clk";

    Do we really need such "clock-names"?

[...]

MBR, Sergei

Re: [PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Sergei,

On Tue, Mar 7, 2017 at 10:27 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:
>> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
>> so it can be power managed using that clock in the future.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> v2:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Drop RFC status,
>>   - Change one-line summary prefix to match current arm-soc practices,
>>   - s/GIC driver/GIC-400 driver/,
>>   - Document critical clock dependency.
>> ---
>>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>>  2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi
>> b/arch/arm/boot/dts/r8a73a4.dtsi
>> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
>> --- a/arch/arm/boot/dts/r8a73a4.dtsi
>> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
>> @@ -467,6 +467,9 @@
>>                         <0 0xf1004000 0 0x2000>,
>>                         <0 0xf1006000 0 0x2000>;
>>                 interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) |
>> IRQ_TYPE_LEVEL_HIGH)>;
>> +               clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
>> +               clock-names = "clk";
>
>    Do we really need such "clock-names"?

Yes. The ARM/GIC maintainers objected against not using clock-names, as
some GIC variants have multiple clocks.
Hence commit afbbd23381767aec ("irqchip/gic: Document optional Clock and
Power Domain properties") was born...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Sergei,

On Tue, Mar 7, 2017 at 10:27 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:
>> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
>> so it can be power managed using that clock in the future.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> v2:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Drop RFC status,
>>   - Change one-line summary prefix to match current arm-soc practices,
>>   - s/GIC driver/GIC-400 driver/,
>>   - Document critical clock dependency.
>> ---
>>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>>  2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi
>> b/arch/arm/boot/dts/r8a73a4.dtsi
>> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
>> --- a/arch/arm/boot/dts/r8a73a4.dtsi
>> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
>> @@ -467,6 +467,9 @@
>>                         <0 0xf1004000 0 0x2000>,
>>                         <0 0xf1006000 0 0x2000>;
>>                 interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) |
>> IRQ_TYPE_LEVEL_HIGH)>;
>> +               clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
>> +               clock-names = "clk";
>
>    Do we really need such "clock-names"?

Yes. The ARM/GIC maintainers objected against not using clock-names, as
some GIC variants have multiple clocks.
Hence commit afbbd23381767aec ("irqchip/gic: Document optional Clock and
Power Domain properties") was born...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series improves the topology description in DT of the ARM GIC
> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.  Hence this
> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> INTC-SYS a critical clock"), which is in v4.11-rc1.
> 
> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> less dependencies.
> 
> Changes compared to v1:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>   - Add r8a7792 patch,
>   - Please refer to the individual patch changelogs for more details
>     (v1 dates back to 2014).
> 
> Thanks for applying!

Thanks, done.

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series improves the topology description in DT of the ARM GIC
> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.  Hence this
> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> INTC-SYS a critical clock"), which is in v4.11-rc1.
> 
> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> less dependencies.
> 
> Changes compared to v1:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>   - Add r8a7792 patch,
>   - Please refer to the individual patch changelogs for more details
>     (v1 dates back to 2014).
> 
> Thanks for applying!

Thanks, done.

Re: [PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Simon,

On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
>> This patch series improves the topology description in DT of the ARM GIC
>> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
>> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
>> module clock, and adds the GIC to the SYSC "always on" PM Domain.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.  Hence this
>> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
>> INTC-SYS a critical clock"), which is in v4.11-rc1.
>>
>> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
>> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
>> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
>> less dependencies.
>>
>> Changes compared to v1:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>>   - Add r8a7792 patch,
>>   - Please refer to the individual patch changelogs for more details
>>     (v1 dates back to 2014).
>>
>> Thanks for applying!
>
> Thanks, done.

Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
device tree"?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Simon,

On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
>> This patch series improves the topology description in DT of the ARM GIC
>> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
>> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
>> module clock, and adds the GIC to the SYSC "always on" PM Domain.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.  Hence this
>> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
>> INTC-SYS a critical clock"), which is in v4.11-rc1.
>>
>> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
>> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
>> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
>> less dependencies.
>>
>> Changes compared to v1:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>>   - Add r8a7792 patch,
>>   - Please refer to the individual patch changelogs for more details
>>     (v1 dates back to 2014).
>>
>> Thanks for applying!
>
> Thanks, done.

Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
device tree"?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Fri, Mar 10, 2017 at 12:19:07PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> >> This patch series improves the topology description in DT of the ARM GIC
> >> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> >> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> >> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> >>
> >> Note that currently the GIC-400 driver doesn't support module clocks nor
> >> Runtime PM, so this must be handled as a critical clock.  Hence this
> >> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> >> INTC-SYS a critical clock"), which is in v4.11-rc1.
> >>
> >> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> >> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> >> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> >> less dependencies.
> >>
> >> Changes compared to v1:
> >>   - Add missing "power-domains" property,
> >>   - Add clock-names property,
> >>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
> >>   - Add r8a7792 patch,
> >>   - Please refer to the individual patch changelogs for more details
> >>     (v1 dates back to 2014).
> >>
> >> Thanks for applying!
> >
> > Thanks, done.
> 
> Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
> device tree"?

Sorry about that, I have it queued up now.

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Fri, Mar 10, 2017 at 12:19:07PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> >> This patch series improves the topology description in DT of the ARM GIC
> >> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> >> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> >> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> >>
> >> Note that currently the GIC-400 driver doesn't support module clocks nor
> >> Runtime PM, so this must be handled as a critical clock.  Hence this
> >> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> >> INTC-SYS a critical clock"), which is in v4.11-rc1.
> >>
> >> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> >> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> >> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> >> less dependencies.
> >>
> >> Changes compared to v1:
> >>   - Add missing "power-domains" property,
> >>   - Add clock-names property,
> >>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
> >>   - Add r8a7792 patch,
> >>   - Please refer to the individual patch changelogs for more details
> >>     (v1 dates back to 2014).
> >>
> >> Thanks for applying!
> >
> > Thanks, done.
> 
> Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
> device tree"?

Sorry about that, I have it queued up now.