[PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

[PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

[Geert Uytterhoeven]

The comment about offset zero was not updated when changing behavior:
  - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
  - Zero really means offset zero.

Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mtd/cmdlinepart.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
index fbd5affc0acfe3fe..3ea44cff9b759e3c 100644
--- a/drivers/mtd/cmdlinepart.c
+++ b/drivers/mtd/cmdlinepart.c
@@ -190,7 +190,10 @@ static struct mtd_partition * newpart(char *s,
 		extra_mem = (unsigned char *)(parts + *num_parts);
 	}
 
-	/* enter this partition (offset will be calculated later if it is zero at this point) */
+	/*
+	 * enter this partition (offset will be calculated later if it is
+	 * OFFSET_CONTINUOUS at this point)
+	 */
 	parts[this_part].size = size;
 	parts[this_part].offset = offset;
 	parts[this_part].mask_flags = mask_flags;
-- 
2.7.4

Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

[Boris Brezillon]

On Tue, 22 May 2018 17:07:53 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> The comment about offset zero was not updated when changing behavior:
>   - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
>   - Zero really means offset zero.
> 
> Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")

Did we switch to 16bytes for the short commit ids (I usually use 12
bytes)?

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/mtd/cmdlinepart.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index fbd5affc0acfe3fe..3ea44cff9b759e3c 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -190,7 +190,10 @@ static struct mtd_partition * newpart(char *s,
>  		extra_mem = (unsigned char *)(parts + *num_parts);
>  	}
>  
> -	/* enter this partition (offset will be calculated later if it is zero at this point) */
> +	/*
> +	 * enter this partition (offset will be calculated later if it is
> +	 * OFFSET_CONTINUOUS at this point)
> +	 */
>  	parts[this_part].size = size;
>  	parts[this_part].offset = offset;
>  	parts[this_part].mask_flags = mask_flags;

Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

[Geert Uytterhoeven]

Hi Boris,

On Wed, May 23, 2018 at 8:20 AM, Boris Brezillon
<boris.brezillon@bootlin.com> wrote:
> On Tue, 22 May 2018 17:07:53 +0200
> Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>> The comment about offset zero was not updated when changing behavior:
>>   - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
>>   - Zero really means offset zero.
>>
>> Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
>
> Did we switch to 16bytes for the short commit ids (I usually use 12
> bytes)?

Checkpatch says 12+ chars. I'm putting my bet on Linux growth ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

[Boris Brezillon]

On Tue, 22 May 2018 17:07:53 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> The comment about offset zero was not updated when changing behavior:
>   - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
>   - Zero really means offset zero.
> 
> Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied.

Thanks,

Boris

> ---
>  drivers/mtd/cmdlinepart.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index fbd5affc0acfe3fe..3ea44cff9b759e3c 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -190,7 +190,10 @@ static struct mtd_partition * newpart(char *s,
>  		extra_mem = (unsigned char *)(parts + *num_parts);
>  	}
>  
> -	/* enter this partition (offset will be calculated later if it is zero at this point) */
> +	/*
> +	 * enter this partition (offset will be calculated later if it is
> +	 * OFFSET_CONTINUOUS at this point)
> +	 */
>  	parts[this_part].size = size;
>  	parts[this_part].offset = offset;
>  	parts[this_part].mask_flags = mask_flags;