All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ARM: dts: r8a7793: Add MMCIF0
@ 2016-04-29 16:01 Ulrich Hecht
  2016-05-02  8:00 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Hecht @ 2016-04-29 16:01 UTC (permalink / raw)
  To: horms
  Cc: linux-renesas-soc, linux-mmc, sergei.shtylyov, geert,
	magnus.damm, Ulrich Hecht

Same as on r8a7791.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---

This version addresses the issues found by Geert and Simon (thank you):

- change back to one DMA controller
- use GIC_SPI
- add max-frequency

CU
Uli


 arch/arm/boot/dts/r8a7793.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index 1dd6d20..f76cc4c 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -543,6 +543,19 @@
 		status = "disabled";
 	};
 
+	mmcif0: mmcif@ee200000 {
+		compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
+		dma-names = "tx", "rx";
+		power-domains = <&cpg_clocks>;
+		reg-io-width = <4>;
+		status = "disabled";
+		max-frequency = <97500000>;
+	};
+
 	scifa0: serial@e6c40000 {
 		compatible = "renesas,scifa-r8a7793",
 			     "renesas,rcar-gen2-scifa", "renesas,scifa";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] ARM: dts: r8a7793: Add MMCIF0
  2016-04-29 16:01 [PATCH v3] ARM: dts: r8a7793: Add MMCIF0 Ulrich Hecht
@ 2016-05-02  8:00 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-05-02  8:00 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: Simon Horman, linux-renesas-soc, Linux MMC List, Sergei Shtylyov,
	Magnus Damm

Hi Ulrich,

On Fri, Apr 29, 2016 at 6:01 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -543,6 +543,19 @@
>                 status = "disabled";
>         };
>
> +       mmcif0: mmcif@ee200000 {
> +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> +               reg = <0 0xee200000 0 0x80>;
> +               interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
> +               dma-names = "tx", "rx";
> +               power-domains = <&cpg_clocks>;

Although the above would still work, all other nodes have been updated to

        power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;

> +               reg-io-width = <4>;
> +               status = "disabled";
> +               max-frequency = <97500000>;
> +       };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-02  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29 16:01 [PATCH v3] ARM: dts: r8a7793: Add MMCIF0 Ulrich Hecht
2016-05-02  8:00 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.