* [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC
@ 2015-02-16 16:58 Ulrich Hecht
2015-02-16 17:29 ` Laurent Pinchart
2015-02-16 17:41 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Ulrich Hecht @ 2015-02-16 16:58 UTC (permalink / raw)
To: linux-sh
Move the Ethernet node to the new BSC node, as its connected to the
Bus State Controller.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7778-bockw.dts | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts b/arch/arm/boot/dts/r8a7778-bockw.dts
index 80e1465..97a1132 100644
--- a/arch/arm/boot/dts/r8a7778-bockw.dts
+++ b/arch/arm/boot/dts/r8a7778-bockw.dts
@@ -46,17 +46,6 @@
regulator-always-on;
};
- ethernet@18300000 {
- compatible = "smsc,lan9220", "smsc,lan9115";
- reg = <0x18300000 0x1000>;
-
- phy-mode = "mii";
- interrupt-parent = <&irqpin>;
- interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
- reg-io-width = <4>;
- vddvario-supply = <&fixedregulator3v3>;
- vdd33a-supply = <&fixedregulator3v3>;
- };
sound {
compatible = "simple-audio-card";
@@ -76,6 +65,20 @@
};
};
+&bsc {
+ ethernet@18300000 {
+ compatible = "smsc,lan89218", "smsc,lan9115";
+ reg = <0x18300000 0x1000>;
+
+ phy-mode = "mii";
+ interrupt-parent = <&irqpin>;
+ interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
+ reg-io-width = <4>;
+ vddvario-supply = <&fixedregulator3v3>;
+ vdd33a-supply = <&fixedregulator3v3>;
+ };
+};
+
&i2c0 {
status = "okay";
--
2.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC
2015-02-16 16:58 [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC Ulrich Hecht
@ 2015-02-16 17:29 ` Laurent Pinchart
2015-02-16 17:41 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2015-02-16 17:29 UTC (permalink / raw)
To: linux-sh
Hi Ulrich,
Thank you for the patch.
On Monday 16 February 2015 17:58:58 Ulrich Hecht wrote:
> Move the Ethernet node to the new BSC node, as its connected to the
> Bus State Controller.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
But please see below for an additional comment.
> ---
> arch/arm/boot/dts/r8a7778-bockw.dts | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts
> b/arch/arm/boot/dts/r8a7778-bockw.dts index 80e1465..97a1132 100644
> --- a/arch/arm/boot/dts/r8a7778-bockw.dts
> +++ b/arch/arm/boot/dts/r8a7778-bockw.dts
> @@ -46,17 +46,6 @@
> regulator-always-on;
> };
>
> - ethernet@18300000 {
> - compatible = "smsc,lan9220", "smsc,lan9115";
> - reg = <0x18300000 0x1000>;
> -
> - phy-mode = "mii";
> - interrupt-parent = <&irqpin>;
> - interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
> - reg-io-width = <4>;
> - vddvario-supply = <&fixedregulator3v3>;
> - vdd33a-supply = <&fixedregulator3v3>;
> - };
>
> sound {
> compatible = "simple-audio-card";
> @@ -76,6 +65,20 @@
> };
> };
>
> +&bsc {
> + ethernet@18300000 {
> + compatible = "smsc,lan89218", "smsc,lan9115";
> + reg = <0x18300000 0x1000>;
> +
> + phy-mode = "mii";
> + interrupt-parent = <&irqpin>;
> + interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
> + reg-io-width = <4>;
> + vddvario-supply = <&fixedregulator3v3>;
> + vdd33a-supply = <&fixedregulator3v3>;
Regulators are not documented in
Documentation/devicetree/bindings/net/smsc911x.txt. Would you like to submit
an additional patch to add them ? The tricky part is that different chip
versions use different power supplies (at least the names vary, but I expect
the number of supplies to vary as well, for instance the 9221 chip has
vddvario, vdd33a and vdd33reg), but the driver currently hardcodes the
supplies names.
> + };
> +};
> +
> &i2c0 {
> status = "okay";
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC
2015-02-16 16:58 [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC Ulrich Hecht
2015-02-16 17:29 ` Laurent Pinchart
@ 2015-02-16 17:41 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-02-16 17:41 UTC (permalink / raw)
To: linux-sh
On Mon, Feb 16, 2015 at 5:58 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Move the Ethernet node to the new BSC node, as its connected to the
> Bus State Controller.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-16 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-16 16:58 [PATCH v3 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC Ulrich Hecht
2015-02-16 17:29 ` Laurent Pinchart
2015-02-16 17:41 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.