[PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

	Hi Simon, Magnus,

On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
"mdio".

When initial support was added for R-Car H3, the MDIO pin was forgotten,
and the MDC pin got its own group named "mdc".  During the addition of
support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
M3-W are pin compatible, and can be mounted on the same boards, the
decision was made to just add the MDIO pin to the existing "mdc" group.
Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
compatibility, and to R-Car D3, in the name of consistency among R-Car
Gen3 SoCs.

However, this decision keeps on being questioned when adding new SoC
support.  Hence bite the bullet and admit our mistake, and rename the
pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.

This series is the DTS part, and depends on the series '[PATCH 0/6]
pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.

Geert Uytterhoeven (3):
  arm64: dts: renesas: salvator-common: Rename EtherAVB "mdc" pin group
    to "mdio"
  arm64: dts: renesas: ulcb: Rename EtherAVB "mdc" pin group to "mdio"
  arm64: dts: renesas: draak: Rename EtherAVB "mdc" pin group to "mdio"

 arch/arm64/boot/dts/renesas/r8a77995-draak.dts   | 2 +-
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 6 +++---
 arch/arm64/boot/dts/renesas/ulcb.dtsi            | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/3] arm64: dts: renesas: salvator-common: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

On other Renesas SoCs, the pin group for the MDIO bus is named "mdio"
instead of "mdc".  Fix the inconsistency, now the pinctrl drivers for
R-Car H3, M3-W, and M3-N have gained support for the traditional pin
group name.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This depends on:
  - pinctrl: sh-pfc: r8a7795-es1: Rename EtherAVB "mdc" pin group to "mdio"
  - pinctrl: sh-pfc: r8a7795: Rename EtherAVB "mdc" pin group to "mdio"
  - pinctrl: sh-pfc: r8a7796: Rename EtherAVB "mdc" pin group to "mdio"
  - pinctrl: sh-pfc: r8a77965: Rename EtherAVB "mdc" pin group to "mdio"
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 2a7f36abd2dd85c6..1642bc9c8906f010 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -416,12 +416,12 @@
 
 	avb_pins: avb {
 		mux {
-			groups = "avb_link", "avb_mdc", "avb_mii";
+			groups = "avb_link", "avb_mdio", "avb_mii";
 			function = "avb";
 		};
 
-		pins_mdc {
-			groups = "avb_mdc";
+		pins_mdio {
+			groups = "avb_mdio";
 			drive-strength = <24>;
 		};
 
-- 
2.7.4

[PATCH 2/3] arm64: dts: renesas: ulcb: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

On other Renesas SoCs, the pin group for the MDIO bus is named "mdio"
instead of "mdc".  Fix the inconsistency, now the pinctrl drivers for
R-Car H3, M3-W, and M3-N have gained support for the traditional pin
group name.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This depends on:
  - pinctrl: sh-pfc: r8a7795-es1: Rename EtherAVB "mdc" pin group to "mdio"
  - pinctrl: sh-pfc: r8a7795: Rename EtherAVB "mdc" pin group to "mdio"
  - pinctrl: sh-pfc: r8a7796: Rename EtherAVB "mdc" pin group to "mdio"
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 6f814845f8b665f3..93402783d52f0927 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -255,12 +255,12 @@
 
 	avb_pins: avb {
 		mux {
-			groups = "avb_link", "avb_mdc", "avb_mii";
+			groups = "avb_link", "avb_mdio", "avb_mii";
 			function = "avb";
 		};
 
-		pins_mdc {
-			groups = "avb_mdc";
+		pins_mdio {
+			groups = "avb_mdio";
 			drive-strength = <24>;
 		};
 
-- 
2.7.4

[PATCH 3/3] arm64: dts: renesas: draak: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

On other Renesas SoCs, the pin group for the MDIO bus is named "mdio"
instead of "mdc".  Fix the inconsistency, now the pinctrl drivers for
R-Car H3, M3-W, and M3-N have gained support for the traditional pin
group name.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This depends on:
  - pinctrl: sh-pfc: r8a77995: Rename EtherAVB "mdc" pin group to "mdio"
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index d03f19414028c6c4..9d73de8bc94d3873 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -91,7 +91,7 @@
 &pfc {
 	avb0_pins: avb {
 		mux {
-			groups = "avb0_link", "avb0_mdc", "avb0_mii";
+			groups = "avb0_link", "avb0_mdio", "avb0_mii";
 			function = "avb0";
 		};
 	};
-- 
2.7.4

Re: [PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Simon Horman]

On Mon, Mar 12, 2018 at 04:11:57PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
> "mdio".
> 
> When initial support was added for R-Car H3, the MDIO pin was forgotten,
> and the MDC pin got its own group named "mdc".  During the addition of
> support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
> M3-W are pin compatible, and can be mounted on the same boards, the
> decision was made to just add the MDIO pin to the existing "mdc" group.
> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
> compatibility, and to R-Car D3, in the name of consistency among R-Car
> Gen3 SoCs.
> 
> However, this decision keeps on being questioned when adding new SoC
> support.  Hence bite the bullet and admit our mistake, and rename the
> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.
> 
> This series is the DTS part, and depends on the series '[PATCH 0/6]
> pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.

Hi Geert,

could you comment on the forwards/backwards compatibility considerations
of this series?

Re: [PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

Hi Simon,

On Tue, Mar 13, 2018 at 7:49 PM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Mar 12, 2018 at 04:11:57PM +0100, Geert Uytterhoeven wrote:
>> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
>> "mdio".
>>
>> When initial support was added for R-Car H3, the MDIO pin was forgotten,
>> and the MDC pin got its own group named "mdc".  During the addition of
>> support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
>> M3-W are pin compatible, and can be mounted on the same boards, the
>> decision was made to just add the MDIO pin to the existing "mdc" group.
>> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
>> compatibility, and to R-Car D3, in the name of consistency among R-Car
>> Gen3 SoCs.
>>
>> However, this decision keeps on being questioned when adding new SoC
>> support.  Hence bite the bullet and admit our mistake, and rename the
>> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.
>>
>> This series is the DTS part, and depends on the series '[PATCH 0/6]
>> pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.
>
> could you comment on the forwards/backwards compatibility considerations
> of this series?

Old and new kernels work with old DT (tested on Salvator-X(S).
New DT requires a new kernel, hence the dependency of the DTS part on the
driver part.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Simon Horman]

On Tue, Mar 13, 2018 at 08:23:05PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Mar 13, 2018 at 7:49 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Mar 12, 2018 at 04:11:57PM +0100, Geert Uytterhoeven wrote:
> >> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
> >> "mdio".
> >>
> >> When initial support was added for R-Car H3, the MDIO pin was forgotten,
> >> and the MDC pin got its own group named "mdc".  During the addition of
> >> support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
> >> M3-W are pin compatible, and can be mounted on the same boards, the
> >> decision was made to just add the MDIO pin to the existing "mdc" group.
> >> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
> >> compatibility, and to R-Car D3, in the name of consistency among R-Car
> >> Gen3 SoCs.
> >>
> >> However, this decision keeps on being questioned when adding new SoC
> >> support.  Hence bite the bullet and admit our mistake, and rename the
> >> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.
> >>
> >> This series is the DTS part, and depends on the series '[PATCH 0/6]
> >> pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.
> >
> > could you comment on the forwards/backwards compatibility considerations
> > of this series?
> 
> Old and new kernels work with old DT (tested on Salvator-X(S).
> New DT requires a new kernel, hence the dependency of the DTS part on the
> driver part.

Thanks, that is fine by me.

I have marked these patches as deferred. Please repost or ping me
once the dependency is available in an RC release.

Re: [PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Geert Uytterhoeven]

Hi Simon,

On Fri, Mar 16, 2018 at 9:39 AM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Mar 13, 2018 at 08:23:05PM +0100, Geert Uytterhoeven wrote:
>> On Tue, Mar 13, 2018 at 7:49 PM, Simon Horman <horms@verge.net.au> wrote:
>> > On Mon, Mar 12, 2018 at 04:11:57PM +0100, Geert Uytterhoeven wrote:
>> >> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
>> >> "mdio".
>> >>
>> >> When initial support was added for R-Car H3, the MDIO pin was forgotten,
>> >> and the MDC pin got its own group named "mdc".  During the addition of
>> >> support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
>> >> M3-W are pin compatible, and can be mounted on the same boards, the
>> >> decision was made to just add the MDIO pin to the existing "mdc" group.
>> >> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
>> >> compatibility, and to R-Car D3, in the name of consistency among R-Car
>> >> Gen3 SoCs.
>> >>
>> >> However, this decision keeps on being questioned when adding new SoC
>> >> support.  Hence bite the bullet and admit our mistake, and rename the
>> >> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.
>> >>
>> >> This series is the DTS part, and depends on the series '[PATCH 0/6]
>> >> pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.
>> >
>> > could you comment on the forwards/backwards compatibility considerations
>> > of this series?
>>
>> Old and new kernels work with old DT (tested on Salvator-X(S).
>> New DT requires a new kernel, hence the dependency of the DTS part on the
>> driver part.
>
> Thanks, that is fine by me.
>
> I have marked these patches as deferred. Please repost or ping me
> once the dependency is available in an RC release.

Now in v4.17-rc1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/3] arm64: dts: renesas: Rename EtherAVB "mdc" pin group to "mdio"

[Simon Horman]

On Wed, Apr 18, 2018 at 03:47:33PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 16, 2018 at 9:39 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Mar 13, 2018 at 08:23:05PM +0100, Geert Uytterhoeven wrote:
> >> On Tue, Mar 13, 2018 at 7:49 PM, Simon Horman <horms@verge.net.au> wrote:
> >> > On Mon, Mar 12, 2018 at 04:11:57PM +0100, Geert Uytterhoeven wrote:
> >> >> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
> >> >> "mdio".
> >> >>
> >> >> When initial support was added for R-Car H3, the MDIO pin was forgotten,
> >> >> and the MDC pin got its own group named "mdc".  During the addition of
> >> >> support for R-Car M3-W, this mistake was noticed.  But as R-Car H3 and
> >> >> M3-W are pin compatible, and can be mounted on the same boards, the
> >> >> decision was made to just add the MDIO pin to the existing "mdc" group.
> >> >> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
> >> >> compatibility, and to R-Car D3, in the name of consistency among R-Car
> >> >> Gen3 SoCs.
> >> >>
> >> >> However, this decision keeps on being questioned when adding new SoC
> >> >> support.  Hence bite the bullet and admit our mistake, and rename the
> >> >> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs.
> >> >>
> >> >> This series is the DTS part, and depends on the series '[PATCH 0/6]
> >> >> pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"'.
> >> >
> >> > could you comment on the forwards/backwards compatibility considerations
> >> > of this series?
> >>
> >> Old and new kernels work with old DT (tested on Salvator-X(S).
> >> New DT requires a new kernel, hence the dependency of the DTS part on the
> >> driver part.
> >
> > Thanks, that is fine by me.
> >
> > I have marked these patches as deferred. Please repost or ping me
> > once the dependency is available in an RC release.
> 
> Now in v4.17-rc1.

Thanks, applied.