* [PATCH v4] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
@ 2021-03-16 14:05 Geert Uytterhoeven
2021-03-16 16:11 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 14:05 UTC (permalink / raw)
To: Luca Ceresoli, Michael Turquette, Stephen Boyd, Rob Herring, Adam Ford
Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven,
Rob Herring
- Remove unneeded reference for "idt,slew-percent", as vendor specific
properties having a standard unit suffix don't need a type,
- Add missing "additionalProperties: false" for subnodes, to catch
typos in properties,
- Fix property names in example.
Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Stephen Boyd <sboyd@kernel.org>
---
This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage", which
is part of dt-schema v2021.2.1.
v4:
- Add Reviewed-by, Acked-by,
v3:
- Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
v2:
- Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
('clk: vc5: Use "idt,voltage-microvolt" instead of
"idt,voltage-microvolts"'),
- Drop reference to clock.yaml, which is already applied
unconditionally,
- Drop removal of allOf around if condition, as it is unnecessary
churn.
---
.../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index c268debe5b8d58cd..a7d00c552e3de161 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -84,9 +84,10 @@ patternProperties:
enum: [ 1800000, 2500000, 3300000 ]
idt,slew-percent:
description: The Slew rate control for CMOS single-ended.
- $ref: /schemas/types.yaml#/definitions/uint32
enum: [ 80, 85, 90, 100 ]
+ additionalProperties: false
+
required:
- compatible
- reg
@@ -141,13 +142,13 @@ examples:
clock-names = "xin";
OUT1 {
- idt,drive-mode = <VC5_CMOSD>;
- idt,voltage-microvolts = <1800000>;
+ idt,mode = <VC5_CMOSD>;
+ idt,voltage-microvolt = <1800000>;
idt,slew-percent = <80>;
};
OUT4 {
- idt,drive-mode = <VC5_LVDS>;
+ idt,mode = <VC5_LVDS>;
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-03-16 14:05 [PATCH v4] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
@ 2021-03-16 16:11 ` Rob Herring
2021-03-16 16:22 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-03-16 16:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Luca Ceresoli, Michael Turquette, Stephen Boyd, Adam Ford,
linux-clk, devicetree, open list:MEDIA DRIVERS FOR RENESAS - FCP
On Tue, Mar 16, 2021 at 8:05 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
Care to also fix 'idt,xtal-load-femtofarads' which was recently added?
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage", which
> is part of dt-schema v2021.2.1.
>
> v4:
> - Add Reviewed-by, Acked-by,
>
> v3:
> - Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
>
> v2:
> - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> ('clk: vc5: Use "idt,voltage-microvolt" instead of
> "idt,voltage-microvolts"'),
> - Drop reference to clock.yaml, which is already applied
> unconditionally,
> - Drop removal of allOf around if condition, as it is unnecessary
> churn.
> ---
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index c268debe5b8d58cd..a7d00c552e3de161 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -84,9 +84,10 @@ patternProperties:
> enum: [ 1800000, 2500000, 3300000 ]
> idt,slew-percent:
> description: The Slew rate control for CMOS single-ended.
> - $ref: /schemas/types.yaml#/definitions/uint32
> enum: [ 80, 85, 90, 100 ]
>
> + additionalProperties: false
> +
> required:
> - compatible
> - reg
> @@ -141,13 +142,13 @@ examples:
> clock-names = "xin";
>
> OUT1 {
> - idt,drive-mode = <VC5_CMOSD>;
> - idt,voltage-microvolts = <1800000>;
> + idt,mode = <VC5_CMOSD>;
> + idt,voltage-microvolt = <1800000>;
> idt,slew-percent = <80>;
> };
>
> OUT4 {
> - idt,drive-mode = <VC5_LVDS>;
> + idt,mode = <VC5_LVDS>;
> };
> };
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-03-16 16:11 ` Rob Herring
@ 2021-03-16 16:22 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 16:22 UTC (permalink / raw)
To: Rob Herring
Cc: Luca Ceresoli, Michael Turquette, Stephen Boyd, Adam Ford,
linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:MEDIA DRIVERS FOR RENESAS - FCP
Hi Rob,
On Tue, Mar 16, 2021 at 5:11 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Tue, Mar 16, 2021 at 8:05 AM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > - Remove unneeded reference for "idt,slew-percent", as vendor specific
> > properties having a standard unit suffix don't need a type,
>
> Care to also fix 'idt,xtal-load-femtofarads' which was recently added?
Sure, stay tuned for v5.
(meh, that should have been "femtofarad", but given "picofarads" ...)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-16 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 14:05 [PATCH v4] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
2021-03-16 16:11 ` Rob Herring
2021-03-16 16:22 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.