From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Wolfram Sang <wsa@sang-engineering.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH/RFC v2 1/2] arm64: dts: r8a7795: Add support for R-Car H3 ES2.0
Date: Thu, 20 Apr 2017 11:36:59 +0200 [thread overview]
Message-ID: <CAMuHMdXOzyo+kzaGAXp+jZTtUejYyXCQzezo+SmvNVQuEC9=_Q@mail.gmail.com> (raw)
In-Reply-To: <1612430.SNEha5n02K@avalon>
Hi Laurent,
On Mon, Mar 27, 2017 at 10:48 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Friday 24 Mar 2017 14:37:44 Geert Uytterhoeven wrote:
>> Update r8a7795.dtsi so it corresponds to R-Car H3 ES2.0 or later:
>> - The following devices no longer exist on ES2.0, and are thus removed:
>> fcpf2, fcpvd3, fcpvi2, fdp1-2, usb3-if1, vspd3, vspi2.
>> - The DU <-> VSPD topology is different on ES2.0, hence remove the
>> "vsps" property from the DU node until the driver can handle this.
>
> I think I'll need a different compatible string between ES1.x and ES2 for the
> DU. It could make sense to move the whole DU node to *-es1.dtsi. We can decide
> about that later when I'll have a DU driver prototype ready.
Why would you need a different compatible string?
Can't you use soc_device_match() to handle ES1.x SoCs?
The different DU <-> VSPD topology is handled through the vsps property in DTS.
Are the ports different, too? That can be handled in DTS.
The main reason why I kept the DU node in r8a7795.dtsi is that the board DTS
refers to it. Sharing board DTS means there needs to be at least a
placeholder node for the DU in r8a7795.dtsi, unless you want to keep on
shuffling board overrides around.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC v2 1/2] arm64: dts: r8a7795: Add support for R-Car H3 ES2.0
Date: Thu, 20 Apr 2017 11:36:59 +0200 [thread overview]
Message-ID: <CAMuHMdXOzyo+kzaGAXp+jZTtUejYyXCQzezo+SmvNVQuEC9=_Q@mail.gmail.com> (raw)
In-Reply-To: <1612430.SNEha5n02K@avalon>
Hi Laurent,
On Mon, Mar 27, 2017 at 10:48 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Friday 24 Mar 2017 14:37:44 Geert Uytterhoeven wrote:
>> Update r8a7795.dtsi so it corresponds to R-Car H3 ES2.0 or later:
>> - The following devices no longer exist on ES2.0, and are thus removed:
>> fcpf2, fcpvd3, fcpvi2, fdp1-2, usb3-if1, vspd3, vspi2.
>> - The DU <-> VSPD topology is different on ES2.0, hence remove the
>> "vsps" property from the DU node until the driver can handle this.
>
> I think I'll need a different compatible string between ES1.x and ES2 for the
> DU. It could make sense to move the whole DU node to *-es1.dtsi. We can decide
> about that later when I'll have a DU driver prototype ready.
Why would you need a different compatible string?
Can't you use soc_device_match() to handle ES1.x SoCs?
The different DU <-> VSPD topology is handled through the vsps property in DTS.
Are the ports different, too? That can be handled in DTS.
The main reason why I kept the DU node in r8a7795.dtsi is that the board DTS
refers to it. Sharing board DTS means there needs to be at least a
placeholder node for the DU in r8a7795.dtsi, unless you want to keep on
shuffling board overrides around.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-04-20 9:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 13:37 [PATCH/RFC v2 0/2] arm64: dts: r8a7795: Add support for R-Car H3 ES2.0 Geert Uytterhoeven
2017-03-24 13:37 ` Geert Uytterhoeven
[not found] ` <1490362665-4422-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2017-03-24 13:37 ` [PATCH/RFC v2 1/2] " Geert Uytterhoeven
2017-03-24 13:37 ` Geert Uytterhoeven
2017-03-27 8:48 ` Laurent Pinchart
2017-03-27 8:48 ` Laurent Pinchart
2017-03-29 8:13 ` Simon Horman
2017-03-29 8:13 ` Simon Horman
2017-03-29 8:31 ` Geert Uytterhoeven
2017-03-29 8:31 ` Geert Uytterhoeven
2017-03-29 8:45 ` Simon Horman
2017-03-29 8:45 ` Simon Horman
2017-04-20 9:36 ` Geert Uytterhoeven [this message]
2017-04-20 9:36 ` Geert Uytterhoeven
2017-04-20 10:42 ` Laurent Pinchart
2017-04-20 10:42 ` Laurent Pinchart
2017-04-20 10:55 ` Geert Uytterhoeven
2017-04-20 10:55 ` Geert Uytterhoeven
2017-04-20 10:55 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWmvhZjxKfEdGJ3d_w0d2s2kK+8iW1tsEM584qZc+dVEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-20 11:24 ` Laurent Pinchart
2017-04-20 11:24 ` Laurent Pinchart
2017-04-20 11:24 ` Laurent Pinchart
2017-04-20 11:36 ` Geert Uytterhoeven
2017-04-20 11:36 ` Geert Uytterhoeven
2017-03-24 13:37 ` [PATCH/RFC v2 2/2] arm64: dts: r8a7795: salvator-x: " Geert Uytterhoeven
2017-03-24 13:37 ` Geert Uytterhoeven
2017-03-24 13:37 ` Geert Uytterhoeven
2017-03-30 10:48 ` [PATCH/RFC v2 0/2] arm64: dts: r8a7795: " Sjoerd Simons
2017-03-30 10:48 ` Sjoerd Simons
2017-03-30 10:48 ` Sjoerd Simons
[not found] ` <1490870898.3471.3.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-03-30 11:13 ` Geert Uytterhoeven
2017-03-30 11:13 ` Geert Uytterhoeven
2017-03-30 11:13 ` Geert Uytterhoeven
2017-03-30 11:50 ` Sjoerd Simons
2017-03-30 11:50 ` Sjoerd Simons
2017-03-30 12:08 ` Geert Uytterhoeven
2017-03-30 12:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXOzyo+kzaGAXp+jZTtUejYyXCQzezo+SmvNVQuEC9=_Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.