All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board
@ 2018-07-30 11:52 Yoshihiro Shimoda
  2018-07-30 15:33 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Yoshihiro Shimoda @ 2018-07-30 11:52 UTC (permalink / raw)
  To: horms, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda

This patch adds PWM device nodes and enables PWM3 and PWM5 for
R-Car E3 Ebisu board.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 I have submitted dt-bindings for R-Car E3 (not merged into PWM subsystem yet):
 https://patchwork.kernel.org/patch/10548969/

 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 24 +++++++++
 arch/arm64/boot/dts/renesas/r8a77990.dtsi      | 70 ++++++++++++++++++++++++++
 2 files changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 2bc3a48..31934a3 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -67,6 +67,16 @@
 		};
 	};
 
+	pwm3_pins: pwm3 {
+		groups = "pwm3_b";
+		function = "pwm3";
+	};
+
+	pwm5_pins: pwm5 {
+		groups = "pwm5_a";
+		function = "pwm5";
+	};
+
 	usb0_pins: usb {
 		groups = "usb0_b";
 		function = "usb0";
@@ -78,6 +88,20 @@
 	};
 };
 
+&pwm3 {
+	pinctrl-0 = <&pwm3_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pwm5 {
+	pinctrl-0 = <&pwm5_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &rwdt {
 	timeout-sec = <60>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 2c8f119..2ee0edf 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -337,6 +337,76 @@
 			status = "disabled";
 		};
 
+		pwm0: pwm@e6e30000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e30000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm1: pwm@e6e31000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e31000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm2: pwm@e6e32000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e32000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm3: pwm@e6e33000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e33000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm4: pwm@e6e34000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e34000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm5: pwm@e6e35000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e35000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm6: pwm@e6e36000 {
+			compatible = "renesas,pwm-r8a77990", "renesas,pwm-rcar";
+			reg = <0 0xe6e36000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
 		scif2: serial@e6e88000 {
 			compatible = "renesas,scif-r8a77990",
 				     "renesas,rcar-gen3-scif", "renesas,scif";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board
  2018-07-30 11:52 [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board Yoshihiro Shimoda
@ 2018-07-30 15:33 ` Geert Uytterhoeven
  2018-07-31  6:14   ` Yoshihiro Shimoda
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-07-30 15:33 UTC (permalink / raw)
  To: Yoshihiro Shimoda; +Cc: Simon Horman, Magnus Damm, Linux-Renesas

Hi Shimoda-san,

On Mon, Jul 30, 2018 at 1:55 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch adds PWM device nodes and enables PWM3 and PWM5 for
> R-Car E3 Ebisu board.

Thanks for your patch!

This is used for blacklight control, right?
It may be a good idea to mention that in the comments and/or patch
description.

> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board
  2018-07-30 15:33 ` Geert Uytterhoeven
@ 2018-07-31  6:14   ` Yoshihiro Shimoda
  2018-07-31  6:39     ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Yoshihiro Shimoda @ 2018-07-31  6:14 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Simon Horman, Magnus Damm, Linux-Renesas

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, July 31, 2018 12:34 AM
> 
> Hi Shimoda-san,
> 
> On Mon, Jul 30, 2018 at 1:55 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > This patch adds PWM device nodes and enables PWM3 and PWM5 for
> > R-Car E3 Ebisu board.
> 
> Thanks for your patch!

Thank you for your review!

> This is used for blacklight control, right?

Yes.

> It may be a good idea to mention that in the comments and/or patch
> description.

I got it. I'll revise the patch description as the following. Is it good?

---
This patch adds PWM device nodes and enables PWM3 and PWM5 for
R-Car E3 Ebisu board. These devices are used for backlight control.
---

Best regards,
Yoshihiro Shimoda

> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board
  2018-07-31  6:14   ` Yoshihiro Shimoda
@ 2018-07-31  6:39     ` Geert Uytterhoeven
  2018-07-31  7:32       ` Yoshihiro Shimoda
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-07-31  6:39 UTC (permalink / raw)
  To: Yoshihiro Shimoda; +Cc: Simon Horman, Magnus Damm, Linux-Renesas

Hi Shimoda-san,

On Tue, Jul 31, 2018 at 8:14 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Tuesday, July 31, 2018 12:34 AM
> > On Mon, Jul 30, 2018 at 1:55 PM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > This patch adds PWM device nodes and enables PWM3 and PWM5 for
> > > R-Car E3 Ebisu board.
> >
> > Thanks for your patch!
>
> Thank you for your review!
>
> > This is used for blacklight control, right?
>
> Yes.
>
> > It may be a good idea to mention that in the comments and/or patch
> > description.
>
> I got it. I'll revise the patch description as the following. Is it good?
>
> ---
> This patch adds PWM device nodes and enables PWM3 and PWM5 for
> R-Car E3 Ebisu board. These devices are used for backlight control.

Sounds good to me. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board
  2018-07-31  6:39     ` Geert Uytterhoeven
@ 2018-07-31  7:32       ` Yoshihiro Shimoda
  0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Shimoda @ 2018-07-31  7:32 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Simon Horman, Magnus Damm, Linux-Renesas

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, July 31, 2018 3:39 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Jul 31, 2018 at 8:14 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Geert Uytterhoeven, Sent: Tuesday, July 31, 2018 12:34 AM
> > > On Mon, Jul 30, 2018 at 1:55 PM Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > > This patch adds PWM device nodes and enables PWM3 and PWM5 for
> > > > R-Car E3 Ebisu board.
> > >
> > > Thanks for your patch!
> >
> > Thank you for your review!
> >
> > > This is used for blacklight control, right?
> >
> > Yes.
> >
> > > It may be a good idea to mention that in the comments and/or patch
> > > description.
> >
> > I got it. I'll revise the patch description as the following. Is it good?
> >
> > ---
> > This patch adds PWM device nodes and enables PWM3 and PWM5 for
> > R-Car E3 Ebisu board. These devices are used for backlight control.
> 
> Sounds good to me. Thanks!

Thank you for your comment! I'll submit v2 patch.

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-31  9:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 11:52 [PATCH] arm64: dts: renesas: r8a77990: Enable PWM for Ebisu board Yoshihiro Shimoda
2018-07-30 15:33 ` Geert Uytterhoeven
2018-07-31  6:14   ` Yoshihiro Shimoda
2018-07-31  6:39     ` Geert Uytterhoeven
2018-07-31  7:32       ` Yoshihiro Shimoda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.