From: Geert Uytterhoeven <geert@linux-m68k.org> To: Finn Thain <fthain@telegraphics.com.au> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>, Michael Schmitz <schmitzmic@gmail.com>, Sam Creasey <sammy@sammy.net>, scsi <linux-scsi@vger.kernel.org>, Linux/m68k <linux-m68k@vger.kernel.org>, Russell King <linux@arm.linux.org.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 12/29] ncr5380: Cleanup host info() methods Date: Fri, 3 Oct 2014 10:32:15 +0200 [thread overview] Message-ID: <CAMuHMdXVVvbSqZ1fKqbd3TgjO7ymcOLojhUhXsph-Nn8UUStNw@mail.gmail.com> (raw) In-Reply-To: <20141002065631.136827342@telegraphics.com.au> On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > +static void prepare_info(struct Scsi_Host *instance) > +{ > + struct NCR5380_hostdata *hostdata = shost_priv(instance); > + > + snprintf(hostdata->info, sizeof(hostdata->info), [...] > + ""); > + hostdata->info[sizeof(hostdata->info) - 1] = '\0'; snprintf() will make sure the string is zero-terminated, so doing this manually is not needed. This applies to all three occurrences. > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/29] ncr5380: Cleanup host info() methods Date: Fri, 3 Oct 2014 10:32:15 +0200 [thread overview] Message-ID: <CAMuHMdXVVvbSqZ1fKqbd3TgjO7ymcOLojhUhXsph-Nn8UUStNw@mail.gmail.com> (raw) In-Reply-To: <20141002065631.136827342@telegraphics.com.au> On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > +static void prepare_info(struct Scsi_Host *instance) > +{ > + struct NCR5380_hostdata *hostdata = shost_priv(instance); > + > + snprintf(hostdata->info, sizeof(hostdata->info), [...] > + ""); > + hostdata->info[sizeof(hostdata->info) - 1] = '\0'; snprintf() will make sure the string is zero-terminated, so doing this manually is not needed. This applies to all three occurrences. > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2014-10-03 8:32 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-02 6:56 [PATCH 00/29] Fixes, cleanups and modernization for NCR5380 drivers Finn Thain 2014-10-02 6:56 ` [PATCH 01/29] ncr5380: Use printk() not pr_debug() Finn Thain 2014-10-06 9:11 ` Hannes Reinecke 2014-10-02 6:56 ` [PATCH 02/29] ncr5380: Remove unused hostdata fields Finn Thain 2014-10-06 9:12 ` Hannes Reinecke 2014-10-02 6:56 ` [PATCH 03/29] ncr5380: Fix compiler warnings and __setup options Finn Thain 2014-10-06 9:19 ` Hannes Reinecke 2014-10-02 6:56 ` [PATCH 04/29] ncr5380: Remove unused macros Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-06 9:21 ` Hannes Reinecke 2014-10-06 9:21 ` Hannes Reinecke 2014-10-02 6:56 ` [PATCH 05/29] ncr5380: Remove useless prototypes Finn Thain 2014-10-02 6:56 ` [PATCH 06/29] ncr5380: Remove more " Finn Thain 2014-10-02 6:56 ` [PATCH 07/29] ncr5380: Cleanup TAG_NEXT and TAG_NONE macros Finn Thain 2014-10-03 8:09 ` Geert Uytterhoeven 2014-10-03 10:12 ` Finn Thain 2014-10-06 9:19 ` Hannes Reinecke 2014-10-06 12:26 ` Finn Thain 2014-10-02 6:56 ` [PATCH 08/29] ncr5380: Remove redundant AUTOSENSE macro Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-02 6:56 ` [PATCH 09/29] ncr5380: Remove duplicate comments Finn Thain 2014-10-02 6:56 ` [PATCH 10/29] ncr5380: Fix SCSI_IRQ_NONE bugs Finn Thain 2014-10-03 8:22 ` Geert Uytterhoeven 2014-10-03 10:42 ` Finn Thain 2014-10-02 6:56 ` [PATCH 11/29] ncr5380: Remove NCR5380_STATS Finn Thain 2014-10-02 6:56 ` [PATCH 12/29] ncr5380: Cleanup host info() methods Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-03 8:32 ` Geert Uytterhoeven [this message] 2014-10-03 8:32 ` Geert Uytterhoeven 2014-10-02 6:56 ` [PATCH 13/29] ncr5380: Move static PDMA spin counters to host data Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-02 6:56 ` [PATCH 14/29] ncr5380: Remove pointless compiler command line override macros Finn Thain 2014-10-02 6:56 ` [PATCH 15/29] ncr5380: Remove *_RELEASE macros Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-02 6:56 ` [PATCH 16/29] ncr5380: Drop legacy scsi.h include Finn Thain 2014-10-02 6:56 ` Finn Thain 2014-10-02 6:56 ` [PATCH 17/29] dmx3191d: Use IRQ_NONE Finn Thain 2014-10-03 8:41 ` Geert Uytterhoeven 2014-10-02 6:56 ` [PATCH 18/29] mac_scsi: Remove header Finn Thain 2014-10-02 6:56 ` [PATCH 19/29] mac_scsi: Add module option to Kconfig Finn Thain 2014-10-03 8:44 ` Geert Uytterhoeven 2014-10-03 10:49 ` Finn Thain 2014-10-03 11:31 ` Geert Uytterhoeven 2014-10-02 6:56 ` [PATCH 20/29] mac_scsi: Cleanup PDMA code Finn Thain 2014-10-02 6:56 ` [PATCH 21/29] mac_scsi: Convert to platform device Finn Thain 2014-10-03 9:08 ` Geert Uytterhoeven 2014-10-02 6:56 ` [PATCH 22/29] atari_scsi: Fix atari_scsi deadlocks on Falcon Finn Thain 2014-10-03 9:19 ` Geert Uytterhoeven 2014-10-02 6:56 ` [PATCH 23/29] atari_scsi: Convert to platform device Finn Thain 2014-10-03 9:34 ` Geert Uytterhoeven 2014-10-03 11:10 ` Finn Thain 2014-10-04 23:43 ` Michael Schmitz 2014-10-06 7:05 ` Finn Thain 2014-10-06 8:14 ` Michael Schmitz 2014-10-08 11:59 ` Finn Thain 2014-10-06 8:36 ` Geert Uytterhoeven 2014-10-20 7:33 ` Michael Schmitz 2014-10-20 11:22 ` Finn Thain 2014-10-20 18:34 ` Michael Schmitz 2014-10-26 7:37 ` Michael Schmitz 2014-10-27 0:15 ` Finn Thain 2014-10-02 6:56 ` [PATCH 24/29] atari_scsi: Remove header Finn Thain 2014-10-02 6:56 ` [PATCH 25/29] sun3_scsi: Convert to platform device Finn Thain 2014-10-02 6:56 ` [PATCH 26/29] sun3_scsi: Move macro definitions Finn Thain 2014-10-02 6:56 ` [PATCH 27/29] ncr5380: Remove ENABLE_IRQ/DISABLE_IRQ macros Finn Thain 2014-10-02 6:56 ` [PATCH 28/29] atari_NCR5380: Refactor Falcon special cases Finn Thain 2014-10-06 9:28 ` Hannes Reinecke 2014-10-06 11:34 ` Finn Thain 2014-10-06 13:41 ` Ondrej Zary 2014-10-02 6:56 ` [PATCH 29/29] atari_NCR5380: Refactor Falcon locking Finn Thain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdXVVvbSqZ1fKqbd3TgjO7ymcOLojhUhXsph-Nn8UUStNw@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=JBottomley@parallels.com \ --cc=fthain@telegraphics.com.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-m68k@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=sammy@sammy.net \ --cc=schmitzmic@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.