* [PATCH] i2c: rcar: add IRQ check
@ 2021-04-04 17:52 Sergey Shtylyov
2021-04-05 14:34 ` Sergey Shtylyov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sergey Shtylyov @ 2021-04-04 17:52 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: linux-renesas-soc
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_irq() with the
invalid IRQ #s.
Fixes: 6ccbe607132b ("i2c: add Renesas R-Car I2C driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/i2c/busses/i2c-rcar.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux/drivers/i2c/busses/i2c-rcar.c
===================================================================
--- linux.orig/drivers/i2c/busses/i2c-rcar.c
+++ linux/drivers/i2c/busses/i2c-rcar.c
@@ -1027,7 +1027,9 @@ static int rcar_i2c_probe(struct platfor
if (of_property_read_bool(dev->of_node, "smbus"))
priv->flags |= ID_P_HOST_NOTIFY;
- priv->irq = platform_get_irq(pdev, 0);
+ priv->irq = ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
+ goto out_pm_disable;
ret = devm_request_irq(dev, priv->irq, irqhandler, irqflags, dev_name(dev), priv);
if (ret < 0) {
dev_err(dev, "cannot get irq %d\n", priv->irq);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: rcar: add IRQ check
2021-04-04 17:52 [PATCH] i2c: rcar: add IRQ check Sergey Shtylyov
@ 2021-04-05 14:34 ` Sergey Shtylyov
2021-04-06 7:37 ` Geert Uytterhoeven
2021-04-08 21:04 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Sergey Shtylyov @ 2021-04-05 14:34 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: linux-renesas-soc
On 4/4/21 8:52 PM, Sergey Shtylyov wrote:
> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to devm_request_irq() (which
> takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
> an original error code. Stop calling devm_request_irq() with the
> invalid IRQ #s.
>
> Fixes: 6ccbe607132b ("i2c: add Renesas R-Car I2C driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Sorry, forgot to mention that this patch is against the 'master' branch of
Wolfram's 'linux.git' repo...
MBR, Sergey
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: rcar: add IRQ check
2021-04-04 17:52 [PATCH] i2c: rcar: add IRQ check Sergey Shtylyov
2021-04-05 14:34 ` Sergey Shtylyov
@ 2021-04-06 7:37 ` Geert Uytterhoeven
2021-04-08 21:04 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-04-06 7:37 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: Wolfram Sang, Linux I2C, Linux-Renesas
On Sun, Apr 4, 2021 at 7:53 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to devm_request_irq() (which
> takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
> an original error code. Stop calling devm_request_irq() with the
> invalid IRQ #s.
>
> Fixes: 6ccbe607132b ("i2c: add Renesas R-Car I2C driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: rcar: add IRQ check
2021-04-04 17:52 [PATCH] i2c: rcar: add IRQ check Sergey Shtylyov
2021-04-05 14:34 ` Sergey Shtylyov
2021-04-06 7:37 ` Geert Uytterhoeven
@ 2021-04-08 21:04 ` Wolfram Sang
2021-04-09 19:33 ` Sergey Shtylyov
2 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2021-04-08 21:04 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: linux-i2c, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
> + priv->irq = ret = platform_get_irq(pdev, 0);
Please no double assignments. Otherwise good catch!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-09 19:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 17:52 [PATCH] i2c: rcar: add IRQ check Sergey Shtylyov
2021-04-05 14:34 ` Sergey Shtylyov
2021-04-06 7:37 ` Geert Uytterhoeven
2021-04-08 21:04 ` Wolfram Sang
2021-04-09 19:33 ` Sergey Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.