Re: [PATCH v8 5/7] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: linux-can@vger.kernel.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Wolfgang Grandegger <wg@grandegger.com>,
	David Miller <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Carsten Emde <c.emde@osadl.org>,
	armbru@redhat.com, netdev <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marin Jerabek <martin.jerabek01@gmail.com>,
	Ondrej Ille <ondrej.ille@gmail.com>,
	Jiri Novak <jnovak@fel.cvut.cz>,
	Jaroslav Beran <jara.beran@gmail.com>,
	Petr Porazil <porazil@pikron.com>, Pavel Machek <pavel@ucw.cz>,
	Drew Fustini <pdp7pdp7@gmail.com>
Subject: Re: [PATCH v8 5/7] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.
Date: Tue, 3 May 2022 13:37:46 +0200	[thread overview]
Message-ID: <CAMuHMdXY_sHw4W8_y+r1LMhGM+CF7RQtRFQzEC8wYKYSR98Daw@mail.gmail.com> (raw)
In-Reply-To: <4d5c53499bafe7717815f948801bd5aedaa05c12.1647904780.git.pisa@cmp.felk.cvut.cz>

Hi Pavel,

On Tue, Mar 22, 2022 at 1:06 AM Pavel Pisa <pisa@cmp.felk.cvut.cz> wrote:
> Platform bus adaptation for CTU CAN FD open-source IP core.
>
> The core has been tested together with OpenCores SJA1000
> modified to be CAN FD frames tolerant on MicroZed Zynq based
> MZ_APO education kits designed by Petr Porazil from PiKRON.com
> company. FPGA design
>
>   https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1000-top.
>
> The kit description at the Computer Architectures course pages
>
>   https://cw.fel.cvut.cz/wiki/courses/b35apo/documentation/mz_apo/start .
>
> Kit carrier board and mechanics design source files
>
>   https://gitlab.com/pikron/projects/mz_apo/microzed_apo
>
> The work is documented in Martin Jeřábek's diploma theses
> Open-source and Open-hardware CAN FD Protocol Support
>
>   https://dspace.cvut.cz/handle/10467/80366
> .
>
> Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> Signed-off-by: Martin Jerabek <martin.jerabek01@gmail.com>
> Signed-off-by: Ondrej Ille <ondrej.ille@gmail.com>

Thanks for your patch, which is now commit e8f0c23a2415fa8f ("can:
ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.") in
linux-can-next/master.

> --- /dev/null
> +++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c

> +/* Match table for OF platform binding */
> +static const struct of_device_id ctucan_of_match[] = {
> +       { .compatible = "ctu,ctucanfd-2", },

Do you need to match on the above compatible value?
The driver seems to treat the hardware the same, and the DT
bindings state the compatible value below should always be present.

> +       { .compatible = "ctu,ctucanfd", },
> +       { /* end of list */ },
> +};
> +MODULE_DEVICE_TABLE(of, ctucan_of_match);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds