All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ondrej Ille <ondrej.ille@gmail.com>
Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>,
	linux-can@vger.kernel.org, devicetree@vger.kernel.org,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Wolfgang Grandegger <wg@grandegger.com>,
	David Miller <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	mark.rutland@arm.com, Carsten Emde <c.emde@osadl.org>,
	armbru@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Marin Jerabek <martin.jerabek01@gmail.com>,
	Jiri Novak <jnovak@fel.cvut.cz>,
	Jaroslav Beran <jara.beran@gmail.com>,
	Petr Porazil <porazil@pikron.com>, Pavel Machek <pavel@ucw.cz>,
	Drew Fustini <pdp7pdp7@gmail.com>
Subject: Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation
Date: Wed, 30 Mar 2022 09:54:22 +0200	[thread overview]
Message-ID: <20220330075422.4kxnayrdcxz7o5lo@pengutronix.de> (raw)
In-Reply-To: <CAA7ZjpZbppBy_C+NyN4LWQF2-a-ktfjYeNELTzwsz4B-fBiTpw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

On 30.03.2022 09:46:08, Ondrej Ille wrote:
> sorry for the late reply, my work duties are keeping me very busy.

Known problem :)

> Let me just quickly comment on topics discussed in the emails above.
> 
> *1. Separation of PROP and TSEG1*
> 
> IMHO there is no real benefit. The reason why CTU CAN FD has this
> split is legacy. First implementation back in 2015 had this split
> since I wanted to follow the standard. In HW, the first thing done in
> bit timing logic (prescaler module), these two numbers are added, and
> all further resynchronization/hard-synchronization is done with TSEG1
> value...

Thanks for the insight. It's not easy to get in touch with the
developers of the proprietary IP cores :)

Never the less, there's another IP core which has different sizes for
the prop and tseg1 register. So an update of the bit timing constant
would help both.

> *2. Number of TXT Buffers and RX Buffer size:*
> 
> Pavel already replied with TXTB_INFO. The same role has the RX_MEM_INFO
> register, when it comes to RX side.

Thanks for the clarification.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2022-03-30  7:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 23:32 [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 1/7] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 2/7] dt-bindings: net: can: binding for CTU CAN FD open-source IP core Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 3/7] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part Pavel Pisa
2022-08-10 20:00   ` Marc Kleine-Budde
2022-08-12 10:07     ` Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 4/7] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 5/7] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support Pavel Pisa
2022-05-03 11:37   ` Geert Uytterhoeven
2022-05-03 15:07     ` Pavel Pisa
2022-05-04  6:34       ` Marc Kleine-Budde
2022-03-21 23:32 ` [PATCH v8 6/7] docs: ctucanfd: CTU CAN FD open-source IP core documentation Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 7/7] MAINTAINERS: Add maintainers for CTU CAN FD IP core driver Pavel Pisa
2022-03-22  7:46 ` [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Marc Kleine-Budde
2022-03-22  8:18   ` Pavel Pisa
2022-03-22  8:33     ` Oliver Hartkopp
2022-03-22  9:22     ` Marc Kleine-Budde
2022-03-22 13:19       ` Pavel Pisa
     [not found]         ` <CAA7ZjpZbppBy_C+NyN4LWQF2-a-ktfjYeNELTzwsz4B-fBiTpw@mail.gmail.com>
2022-03-30  7:54           ` Marc Kleine-Budde [this message]
2022-04-06  8:20       ` Pavel Pisa
2022-04-19 15:35         ` Marc Kleine-Budde
2022-04-20 16:40           ` Oliver Hartkopp
2022-04-20 21:28             ` Pavel Pisa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330075422.4kxnayrdcxz7o5lo@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=armbru@redhat.com \
    --cc=c.emde@osadl.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jara.beran@gmail.com \
    --cc=jnovak@fel.cvut.cz \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.jerabek01@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ondrej.ille@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=pdp7pdp7@gmail.com \
    --cc=pisa@cmp.felk.cvut.cz \
    --cc=porazil@pikron.com \
    --cc=robh+dt@kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.