* [PATCH] soc: renesas: r8a77970-sysc: fix power area parents
@ 2018-02-16 20:09 Sergei Shtylyov
2018-02-17 14:12 ` Sergei Shtylyov
2018-02-19 8:38 ` Geert Uytterhoeven
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-02-16 20:09 UTC (permalink / raw)
To: Simon Horman, linux-renesas-soc; +Cc: Magnus Damm
According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s
Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have
the A3IR area as a parent, thus the SYSC driver has those parents wrong...
Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/soc/renesas/r8a77970-sysc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Index: renesas/drivers/soc/renesas/r8a77970-sysc.c
===================================================================
--- renesas.orig/drivers/soc/renesas/r8a77970-sysc.c
+++ renesas/drivers/soc/renesas/r8a77970-sysc.c
@@ -25,12 +25,12 @@ static const struct rcar_sysc_area r8a77
PD_CPU_NOCR },
{ "cr7", 0x240, 0, R8A77970_PD_CR7, R8A77970_PD_ALWAYS_ON },
{ "a3ir", 0x180, 0, R8A77970_PD_A3IR, R8A77970_PD_ALWAYS_ON },
- { "a2ir0", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_ALWAYS_ON },
- { "a2ir1", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A2IR0 },
- { "a2ir2", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A2IR0 },
- { "a2ir3", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A2IR0 },
- { "a2sc0", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_ALWAYS_ON },
- { "a2sc1", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A2SC0 },
+ { "a2ir0", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_A3IR },
+ { "a2ir1", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A3IR },
+ { "a2ir2", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A3IR },
+ { "a2ir3", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A3IR },
+ { "a2sc0", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_A3IR },
+ { "a2sc1", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A3IR },
};
const struct rcar_sysc_info r8a77970_sysc_info __initconst = {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: renesas: r8a77970-sysc: fix power area parents
2018-02-16 20:09 [PATCH] soc: renesas: r8a77970-sysc: fix power area parents Sergei Shtylyov
@ 2018-02-17 14:12 ` Sergei Shtylyov
2018-02-19 8:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-02-17 14:12 UTC (permalink / raw)
To: Simon Horman, linux-renesas-soc; +Cc: Magnus Damm
On 02/16/2018 11:09 PM, Sergei Shtylyov wrote:
> According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s
> Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have
> the A3IR area as a parent, thus the SYSC driver has those parents wrong...
>
> Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> drivers/soc/renesas/r8a77970-sysc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Index: renesas/drivers/soc/renesas/r8a77970-sysc.c
> ===================================================================
> --- renesas.orig/drivers/soc/renesas/r8a77970-sysc.c
> +++ renesas/drivers/soc/renesas/r8a77970-sysc.c
Done against the recent 'devel' tag but should apply to Linus' repo...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: renesas: r8a77970-sysc: fix power area parents
2018-02-16 20:09 [PATCH] soc: renesas: r8a77970-sysc: fix power area parents Sergei Shtylyov
2018-02-17 14:12 ` Sergei Shtylyov
@ 2018-02-19 8:38 ` Geert Uytterhoeven
2018-02-19 9:01 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-02-19 8:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Simon Horman, linux-renesas-soc, Magnus Damm
On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s
> Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have
> the A3IR area as a parent, thus the SYSC driver has those parents wrong...
>
> Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sorry for missing this in my original review.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: renesas: r8a77970-sysc: fix power area parents
2018-02-19 8:38 ` Geert Uytterhoeven
@ 2018-02-19 9:01 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-02-19 9:01 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Sergei Shtylyov, linux-renesas-soc, Magnus Damm
On Mon, Feb 19, 2018 at 09:38:15AM +0100, Geert Uytterhoeven wrote:
> On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s
> > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have
> > the A3IR area as a parent, thus the SYSC driver has those parents wrong...
> >
> > Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support")
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Sorry for missing this in my original review.
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-19 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-16 20:09 [PATCH] soc: renesas: r8a77970-sysc: fix power area parents Sergei Shtylyov
2018-02-17 14:12 ` Sergei Shtylyov
2018-02-19 8:38 ` Geert Uytterhoeven
2018-02-19 9:01 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.