All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
@ 2016-04-04  1:22 Simon Horman
  2016-04-04  1:22 ` [PATCH 1/2] ARM: shmobile: timer: Fix preset_lpj leading to too short delays Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Simon Horman @ 2016-04-04  1:22 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC drivers updates for v4.7.


The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:

  Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-drivers-for-v4.7

for you to fetch changes up to cd89841fc6dbb6dc11aa113769f39dcd30be720f:

  ARM: shmobile: timer: Drop support for Cortex A8 (2016-03-28 09:01:31 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Drivers Updates for v4.7

Loop delay calculation updates:
* Remove check for no longer supported Cortex A8 cores
* Correct short calculation of delay

----------------------------------------------------------------
Geert Uytterhoeven (2):
      ARM: shmobile: timer: Fix preset_lpj leading to too short delays
      ARM: shmobile: timer: Drop support for Cortex A8

 arch/arm/mach-shmobile/timer.c | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: shmobile: timer: Fix preset_lpj leading to too short delays
  2016-04-04  1:22 [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Simon Horman
@ 2016-04-04  1:22 ` Simon Horman
  2016-04-04  1:22   ` Simon Horman
  2016-04-13 19:43 ` [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Olof Johansson
  2 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2016-04-04  1:22 UTC (permalink / raw)
  To: linux-arm-kernel

From: Geert Uytterhoeven <geert+renesas@glider.be>

On all shmobile ARM SoCs, loop-based delays may complete early, which
can be after only 1/3 (Cortex A9) or 1/2 (Cortex A7 or A15) of the
minimum required time.

This is caused by calculating preset_lpj based on incorrect assumptions
about the number of clock cycles per loop:
  - All of Cortex A7, A9, and A15 run __loop_delay() at 1 loop per
    CPU clock cycle,
  - As of commit 11d4bb1bd067f9d0 ("ARM: 7907/1: lib: delay-loop: Add
    align directive to fix BogoMIPS calculation"), Cortex A8 runs
    __loop_delay() at 1 loop per 2 instead of 3 CPU clock cycles.

On SoCs with Cortex A7 and/or A15 CPU cores, this went unnoticed, as
delays use the ARM arch timer if available. R-Car Gen2 doesn't work if
the arch timer is disabled. However, APE6 can be used without the arch
timer.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/timer.c | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
index ad008e4b0c49..67d79f9c6bad 100644
--- a/arch/arm/mach-shmobile/timer.c
+++ b/arch/arm/mach-shmobile/timer.c
@@ -40,8 +40,7 @@ static void __init shmobile_setup_delay_hz(unsigned int max_cpu_core_hz,
 void __init shmobile_init_delay(void)
 {
 	struct device_node *np, *cpus;
-	bool is_a7_a8_a9 = false;
-	bool is_a15 = false;
+	unsigned int div = 0;
 	bool has_arch_timer = false;
 	u32 max_freq = 0;
 
@@ -55,27 +54,22 @@ void __init shmobile_init_delay(void)
 		if (!of_property_read_u32(np, "clock-frequency", &freq))
 			max_freq = max(max_freq, freq);
 
-		if (of_device_is_compatible(np, "arm,cortex-a8") ||
-		    of_device_is_compatible(np, "arm,cortex-a9")) {
-			is_a7_a8_a9 = true;
-		} else if (of_device_is_compatible(np, "arm,cortex-a7")) {
-			is_a7_a8_a9 = true;
-			has_arch_timer = true;
-		} else if (of_device_is_compatible(np, "arm,cortex-a15")) {
-			is_a15 = true;
+		if (of_device_is_compatible(np, "arm,cortex-a8")) {
+			div = 2;
+		} else if (of_device_is_compatible(np, "arm,cortex-a9")) {
+			div = 1;
+		} else if (of_device_is_compatible(np, "arm,cortex-a7") ||
+			 of_device_is_compatible(np, "arm,cortex-a15")) {
+			div = 1;
 			has_arch_timer = true;
 		}
 	}
 
 	of_node_put(cpus);
 
-	if (!max_freq)
+	if (!max_freq || !div)
 		return;
 
-	if (!has_arch_timer || !IS_ENABLED(CONFIG_ARM_ARCH_TIMER)) {
-		if (is_a7_a8_a9)
-			shmobile_setup_delay_hz(max_freq, 1, 3);
-		else if (is_a15)
-			shmobile_setup_delay_hz(max_freq, 2, 4);
-	}
+	if (!has_arch_timer || !IS_ENABLED(CONFIG_ARM_ARCH_TIMER))
+		shmobile_setup_delay_hz(max_freq, 1, div);
 }
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8
  2016-04-04  1:22 [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Simon Horman
@ 2016-04-04  1:22   ` Simon Horman
  2016-04-04  1:22   ` Simon Horman
  2016-04-13 19:43 ` [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Olof Johansson
  2 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2016-04-04  1:22 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Geert Uytterhoeven, Simon Horman

From: Geert Uytterhoeven <geert+renesas@glider.be>

Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
core (sh7372 aka SH-Mobile AP4).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/timer.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
index 67d79f9c6bad..1fc7759feab1 100644
--- a/arch/arm/mach-shmobile/timer.c
+++ b/arch/arm/mach-shmobile/timer.c
@@ -54,9 +54,7 @@ void __init shmobile_init_delay(void)
 		if (!of_property_read_u32(np, "clock-frequency", &freq))
 			max_freq = max(max_freq, freq);
 
-		if (of_device_is_compatible(np, "arm,cortex-a8")) {
-			div = 2;
-		} else if (of_device_is_compatible(np, "arm,cortex-a9")) {
+		if (of_device_is_compatible(np, "arm,cortex-a9")) {
 			div = 1;
 		} else if (of_device_is_compatible(np, "arm,cortex-a7") ||
 			 of_device_is_compatible(np, "arm,cortex-a15")) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8
@ 2016-04-04  1:22   ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2016-04-04  1:22 UTC (permalink / raw)
  To: linux-arm-kernel

From: Geert Uytterhoeven <geert+renesas@glider.be>

Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
core (sh7372 aka SH-Mobile AP4).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/timer.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
index 67d79f9c6bad..1fc7759feab1 100644
--- a/arch/arm/mach-shmobile/timer.c
+++ b/arch/arm/mach-shmobile/timer.c
@@ -54,9 +54,7 @@ void __init shmobile_init_delay(void)
 		if (!of_property_read_u32(np, "clock-frequency", &freq))
 			max_freq = max(max_freq, freq);
 
-		if (of_device_is_compatible(np, "arm,cortex-a8")) {
-			div = 2;
-		} else if (of_device_is_compatible(np, "arm,cortex-a9")) {
+		if (of_device_is_compatible(np, "arm,cortex-a9")) {
 			div = 1;
 		} else if (of_device_is_compatible(np, "arm,cortex-a7") ||
 			 of_device_is_compatible(np, "arm,cortex-a15")) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8
  2016-04-04  1:22   ` Simon Horman
  (?)
@ 2016-04-13 19:41   ` Olof Johansson
  2016-04-13 19:50     ` Geert Uytterhoeven
  -1 siblings, 1 reply; 15+ messages in thread
From: Olof Johansson @ 2016-04-13 19:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Sun, Apr 3, 2016 at 6:22 PM, Simon Horman <horms+renesas@verge.net.au> wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
> file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
> core (sh7372 aka SH-Mobile AP4).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/mach-shmobile/timer.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
> index 67d79f9c6bad..1fc7759feab1 100644
> --- a/arch/arm/mach-shmobile/timer.c
> +++ b/arch/arm/mach-shmobile/timer.c
> @@ -54,9 +54,7 @@ void __init shmobile_init_delay(void)
>                 if (!of_property_read_u32(np, "clock-frequency", &freq))
>                         max_freq = max(max_freq, freq);
>
> -               if (of_device_is_compatible(np, "arm,cortex-a8")) {
> -                       div = 2;
> -               } else if (of_device_is_compatible(np, "arm,cortex-a9")) {
> +               if (of_device_is_compatible(np, "arm,cortex-a9")) {
>                         div = 1;
>                 } else if (of_device_is_compatible(np, "arm,cortex-a7") ||
>                          of_device_is_compatible(np, "arm,cortex-a15")) {

This setting of div doesn't make much sense now. It's always 1. This
function seems more complicated than it has to be...


-Olof

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-04  1:22 [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Simon Horman
  2016-04-04  1:22 ` [PATCH 1/2] ARM: shmobile: timer: Fix preset_lpj leading to too short delays Simon Horman
  2016-04-04  1:22   ` Simon Horman
@ 2016-04-13 19:43 ` Olof Johansson
  2016-04-13 19:57   ` Geert Uytterhoeven
  2 siblings, 1 reply; 15+ messages in thread
From: Olof Johansson @ 2016-04-13 19:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
> 
> Please consider these Renesas ARM based SoC drivers updates for v4.7.
> 
> 
> The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:
> 
>   Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-drivers-for-v4.7
> 
> for you to fetch changes up to cd89841fc6dbb6dc11aa113769f39dcd30be720f:
> 
>   ARM: shmobile: timer: Drop support for Cortex A8 (2016-03-28 09:01:31 +0900)
> 
> ----------------------------------------------------------------
> Renesas ARM Based SoC Drivers Updates for v4.7
> 
> Loop delay calculation updates:
> * Remove check for no longer supported Cortex A8 cores
> * Correct short calculation of delay
> 
> ----------------------------------------------------------------
> Geert Uytterhoeven (2):
>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
>       ARM: shmobile: timer: Drop support for Cortex A8

I don't understand your naming. THis isn't driver code, this is SoC code.

Anyway, I replied to the drop-A8 patch, the resulting function doesn't make
much sense once that code path is removed (div is always 1). Seems like this
should be cleaned up in other ways instead.

So, not merging this branch for now since I think it should be revisited.


-Olof

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8
  2016-04-13 19:41   ` Olof Johansson
@ 2016-04-13 19:50     ` Geert Uytterhoeven
  0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-04-13 19:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,

On Wed, Apr 13, 2016 at 9:41 PM, Olof Johansson <olof@lixom.net> wrote:
> On Sun, Apr 3, 2016 at 6:22 PM, Simon Horman <horms+renesas@verge.net.au> wrote:
>> From: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
>> file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
>> core (sh7372 aka SH-Mobile AP4).
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> ---
>>  arch/arm/mach-shmobile/timer.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
>> index 67d79f9c6bad..1fc7759feab1 100644
>> --- a/arch/arm/mach-shmobile/timer.c
>> +++ b/arch/arm/mach-shmobile/timer.c
>> @@ -54,9 +54,7 @@ void __init shmobile_init_delay(void)
>>                 if (!of_property_read_u32(np, "clock-frequency", &freq))
>>                         max_freq = max(max_freq, freq);
>>
>> -               if (of_device_is_compatible(np, "arm,cortex-a8")) {
>> -                       div = 2;
>> -               } else if (of_device_is_compatible(np, "arm,cortex-a9")) {
>> +               if (of_device_is_compatible(np, "arm,cortex-a9")) {
>>                         div = 1;
>>                 } else if (of_device_is_compatible(np, "arm,cortex-a7") ||
>>                          of_device_is_compatible(np, "arm,cortex-a15")) {
>
> This setting of div doesn't make much sense now. It's always 1. This
> function seems more complicated than it has to be...

Yes, there are definitely more areas for improvement in this organic piece of
code...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-13 19:43 ` [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Olof Johansson
@ 2016-04-13 19:57   ` Geert Uytterhoeven
  2016-04-13 20:23     ` Olof Johansson
  0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-04-13 19:57 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,

On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
> On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
>> Please consider these Renesas ARM based SoC drivers updates for v4.7.
>>
>>
>> The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:
>>
>>   Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-drivers-for-v4.7
>>
>> for you to fetch changes up to cd89841fc6dbb6dc11aa113769f39dcd30be720f:
>>
>>   ARM: shmobile: timer: Drop support for Cortex A8 (2016-03-28 09:01:31 +0900)
>>
>> ----------------------------------------------------------------
>> Renesas ARM Based SoC Drivers Updates for v4.7
>>
>> Loop delay calculation updates:
>> * Remove check for no longer supported Cortex A8 cores
>> * Correct short calculation of delay
>>
>> ----------------------------------------------------------------
>> Geert Uytterhoeven (2):
>>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
>>       ARM: shmobile: timer: Drop support for Cortex A8
>
> I don't understand your naming. THis isn't driver code, this is SoC code.
>
> Anyway, I replied to the drop-A8 patch, the resulting function doesn't make
> much sense once that code path is removed (div is always 1). Seems like this
> should be cleaned up in other ways instead.
>
> So, not merging this branch for now since I think it should be revisited.

The reason these are small separate patches is because especially the
first one may be backported to stable, as it's a real bug fix.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-13 19:57   ` Geert Uytterhoeven
@ 2016-04-13 20:23     ` Olof Johansson
  2016-04-14  8:19       ` Geert Uytterhoeven
  0 siblings, 1 reply; 15+ messages in thread
From: Olof Johansson @ 2016-04-13 20:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
> Hi Olof,
> 
> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
> >> Please consider these Renesas ARM based SoC drivers updates for v4.7.
> >>
> >>
> >> The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:
> >>
> >>   Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-drivers-for-v4.7
> >>
> >> for you to fetch changes up to cd89841fc6dbb6dc11aa113769f39dcd30be720f:
> >>
> >>   ARM: shmobile: timer: Drop support for Cortex A8 (2016-03-28 09:01:31 +0900)
> >>
> >> ----------------------------------------------------------------
> >> Renesas ARM Based SoC Drivers Updates for v4.7
> >>
> >> Loop delay calculation updates:
> >> * Remove check for no longer supported Cortex A8 cores
> >> * Correct short calculation of delay
> >>
> >> ----------------------------------------------------------------
> >> Geert Uytterhoeven (2):
> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
> >>       ARM: shmobile: timer: Drop support for Cortex A8
> >
> > I don't understand your naming. THis isn't driver code, this is SoC code.
> >
> > Anyway, I replied to the drop-A8 patch, the resulting function doesn't make
> > much sense once that code path is removed (div is always 1). Seems like this
> > should be cleaned up in other ways instead.
> >
> > So, not merging this branch for now since I think it should be revisited.
> 
> The reason these are small separate patches is because especially the
> first one may be backported to stable, as it's a real bug fix.

Ok, so then the second shouldn't just remove cortex-a8, but rework the function
(yet again).


-Olof

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-13 20:23     ` Olof Johansson
@ 2016-04-14  8:19       ` Geert Uytterhoeven
  2016-04-15  0:33         ` Simon Horman
  0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-04-14  8:19 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,Simon,

On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
> On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
>> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
>> >> Geert Uytterhoeven (2):
>> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
>> >>       ARM: shmobile: timer: Drop support for Cortex A8
>> >
>> > I don't understand your naming. THis isn't driver code, this is SoC code.
>> >
>> > Anyway, I replied to the drop-A8 patch, the resulting function doesn't make
>> > much sense once that code path is removed (div is always 1). Seems like this
>> > should be cleaned up in other ways instead.
>> >
>> > So, not merging this branch for now since I think it should be revisited.
>>
>> The reason these are small separate patches is because especially the
>> first one may be backported to stable, as it's a real bug fix.
>
> Ok, so then the second shouldn't just remove cortex-a8, but rework the function
> (yet again).

Sure, reworking it...

Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
already in v4.6-rc1.  The latter makes bad behavior due to too short delays
more likely to happen.

Sorry for not noticing before.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-14  8:19       ` Geert Uytterhoeven
@ 2016-04-15  0:33         ` Simon Horman
  2016-04-15  6:35           ` Geert Uytterhoeven
  0 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2016-04-15  0:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 14, 2016 at 10:19:04AM +0200, Geert Uytterhoeven wrote:
> Hi Olof,Simon,
> 
> On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
> > On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
> >> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
> >> >> Geert Uytterhoeven (2):
> >> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
> >> >>       ARM: shmobile: timer: Drop support for Cortex A8
> >> >
> >> > I don't understand your naming. THis isn't driver code, this is SoC code.
> >> >
> >> > Anyway, I replied to the drop-A8 patch, the resulting function doesn't make
> >> > much sense once that code path is removed (div is always 1). Seems like this
> >> > should be cleaned up in other ways instead.
> >> >
> >> > So, not merging this branch for now since I think it should be revisited.
> >>
> >> The reason these are small separate patches is because especially the
> >> first one may be backported to stable, as it's a real bug fix.
> >
> > Ok, so then the second shouldn't just remove cortex-a8, but rework the function
> > (yet again).
> 
> Sure, reworking it...
> 
> Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
> leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
> ("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
> already in v4.6-rc1.  The latter makes bad behavior due to too short delays
> more likely to happen.
> 
> Sorry for not noticing before.

Likewise, sorry for the mix-up.

I can think of two ways to resolve this, likely there are others:
1. Submit "ARM: shmobile: timer: Fix preset_lpj leading to too short delays"
   or conversely
2. Submit a reversion of 406663ed61c8 ("ARM: shmobile: defconfig: Do not
   enable CONFIG_CPU_BPREDICT_DISABLE") as a fix for v4.6.

Or perhaps it is a problem that can just be ironed out in v4.7.
Let me know what you think.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-15  0:33         ` Simon Horman
@ 2016-04-15  6:35           ` Geert Uytterhoeven
  2016-04-18  3:55             ` Simon Horman
  0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-04-15  6:35 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Fri, Apr 15, 2016 at 2:33 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Apr 14, 2016 at 10:19:04AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
>> > On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
>> >> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
>> >> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
>> >> >> Geert Uytterhoeven (2):
>> >> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
>> >> >>       ARM: shmobile: timer: Drop support for Cortex A8

>> Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
>> leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
>> ("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
>> already in v4.6-rc1.  The latter makes bad behavior due to too short delays
>> more likely to happen.
>>
>> Sorry for not noticing before.
>
> Likewise, sorry for the mix-up.
>
> I can think of two ways to resolve this, likely there are others:
> 1. Submit "ARM: shmobile: timer: Fix preset_lpj leading to too short delays"
>    or conversely
> 2. Submit a reversion of 406663ed61c8 ("ARM: shmobile: defconfig: Do not
>    enable CONFIG_CPU_BPREDICT_DISABLE") as a fix for v4.6.
>
> Or perhaps it is a problem that can just be ironed out in v4.7.
> Let me know what you think.

I prefer option 1, i.e. fixing the bug instead of papering over it in
the defconfig.
Users may not use the defconfig, and have CONFIG_CPU_BPREDICT_DISABLE
enabled anyway.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-15  6:35           ` Geert Uytterhoeven
@ 2016-04-18  3:55             ` Simon Horman
  2016-04-19  7:25               ` Geert Uytterhoeven
  0 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2016-04-18  3:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Apr 15, 2016 at 08:35:48AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Apr 15, 2016 at 2:33 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Apr 14, 2016 at 10:19:04AM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
> >> > On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
> >> >> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
> >> >> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
> >> >> >> Geert Uytterhoeven (2):
> >> >> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
> >> >> >>       ARM: shmobile: timer: Drop support for Cortex A8
> 
> >> Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
> >> leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
> >> ("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
> >> already in v4.6-rc1.  The latter makes bad behavior due to too short delays
> >> more likely to happen.
> >>
> >> Sorry for not noticing before.
> >
> > Likewise, sorry for the mix-up.
> >
> > I can think of two ways to resolve this, likely there are others:
> > 1. Submit "ARM: shmobile: timer: Fix preset_lpj leading to too short delays"
> >    or conversely
> > 2. Submit a reversion of 406663ed61c8 ("ARM: shmobile: defconfig: Do not
> >    enable CONFIG_CPU_BPREDICT_DISABLE") as a fix for v4.6.
> >
> > Or perhaps it is a problem that can just be ironed out in v4.7.
> > Let me know what you think.
> 
> I prefer option 1, i.e. fixing the bug instead of papering over it in
> the defconfig.
> Users may not use the defconfig, and have CONFIG_CPU_BPREDICT_DISABLE
> enabled anyway.

Thanks, that reasoning sounds fine to me.

I plan to re-queue "ARM: shmobile: timer: Fix preset_lpj leading to too
short delays" in fixes-for-v4.6 and I plan to push that in a revised
renesas-next tag later today. I would appreciate you double checking that
all is in order. 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-18  3:55             ` Simon Horman
@ 2016-04-19  7:25               ` Geert Uytterhoeven
  2016-04-19 22:48                 ` Simon Horman
  0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-04-19  7:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Mon, Apr 18, 2016 at 5:55 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Apr 15, 2016 at 08:35:48AM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 15, 2016 at 2:33 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Thu, Apr 14, 2016 at 10:19:04AM +0200, Geert Uytterhoeven wrote:
>> >> On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
>> >> > On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
>> >> >> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
>> >> >> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
>> >> >> >> Geert Uytterhoeven (2):
>> >> >> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
>> >> >> >>       ARM: shmobile: timer: Drop support for Cortex A8
>>
>> >> Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
>> >> leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
>> >> ("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
>> >> already in v4.6-rc1.  The latter makes bad behavior due to too short delays
>> >> more likely to happen.
>> >>
>> >> Sorry for not noticing before.
>> >
>> > Likewise, sorry for the mix-up.
>> >
>> > I can think of two ways to resolve this, likely there are others:
>> > 1. Submit "ARM: shmobile: timer: Fix preset_lpj leading to too short delays"
>> >    or conversely
>> > 2. Submit a reversion of 406663ed61c8 ("ARM: shmobile: defconfig: Do not
>> >    enable CONFIG_CPU_BPREDICT_DISABLE") as a fix for v4.6.
>> >
>> > Or perhaps it is a problem that can just be ironed out in v4.7.
>> > Let me know what you think.
>>
>> I prefer option 1, i.e. fixing the bug instead of papering over it in
>> the defconfig.
>> Users may not use the defconfig, and have CONFIG_CPU_BPREDICT_DISABLE
>> enabled anyway.
>
> Thanks, that reasoning sounds fine to me.
>
> I plan to re-queue "ARM: shmobile: timer: Fix preset_lpj leading to too
> short delays" in fixes-for-v4.6 and I plan to push that in a revised
> renesas-next tag later today. I would appreciate you double checking that
> all is in order.

Thanks, that commit looks fine!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7
  2016-04-19  7:25               ` Geert Uytterhoeven
@ 2016-04-19 22:48                 ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2016-04-19 22:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Apr 19, 2016 at 09:25:20AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Apr 18, 2016 at 5:55 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Fri, Apr 15, 2016 at 08:35:48AM +0200, Geert Uytterhoeven wrote:
> >> On Fri, Apr 15, 2016 at 2:33 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > On Thu, Apr 14, 2016 at 10:19:04AM +0200, Geert Uytterhoeven wrote:
> >> >> On Wed, Apr 13, 2016 at 10:23 PM, Olof Johansson <olof@lixom.net> wrote:
> >> >> > On Wed, Apr 13, 2016 at 09:57:39PM +0200, Geert Uytterhoeven wrote:
> >> >> >> On Wed, Apr 13, 2016 at 9:43 PM, Olof Johansson <olof@lixom.net> wrote:
> >> >> >> > On Mon, Apr 04, 2016 at 10:22:56AM +0900, Simon Horman wrote:
> >> >> >> >> Geert Uytterhoeven (2):
> >> >> >> >>       ARM: shmobile: timer: Fix preset_lpj leading to too short delays
> >> >> >> >>       ARM: shmobile: timer: Drop support for Cortex A8
> >>
> >> >> Simon: I'm a bit surprised to see that "ARM: shmobile: timer: Fix preset_lpj
> >> >> leading to too short delays" got postponed to v4.7, while commit 406663ed61c8
> >> >> ("ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE") is
> >> >> already in v4.6-rc1.  The latter makes bad behavior due to too short delays
> >> >> more likely to happen.
> >> >>
> >> >> Sorry for not noticing before.
> >> >
> >> > Likewise, sorry for the mix-up.
> >> >
> >> > I can think of two ways to resolve this, likely there are others:
> >> > 1. Submit "ARM: shmobile: timer: Fix preset_lpj leading to too short delays"
> >> >    or conversely
> >> > 2. Submit a reversion of 406663ed61c8 ("ARM: shmobile: defconfig: Do not
> >> >    enable CONFIG_CPU_BPREDICT_DISABLE") as a fix for v4.6.
> >> >
> >> > Or perhaps it is a problem that can just be ironed out in v4.7.
> >> > Let me know what you think.
> >>
> >> I prefer option 1, i.e. fixing the bug instead of papering over it in
> >> the defconfig.
> >> Users may not use the defconfig, and have CONFIG_CPU_BPREDICT_DISABLE
> >> enabled anyway.
> >
> > Thanks, that reasoning sounds fine to me.
> >
> > I plan to re-queue "ARM: shmobile: timer: Fix preset_lpj leading to too
> > short delays" in fixes-for-v4.6 and I plan to push that in a revised
> > renesas-next tag later today. I would appreciate you double checking that
> > all is in order.
> 
> Thanks, that commit looks fine!

Great, thanks for checking.

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2016-04-19 22:48 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04  1:22 [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Simon Horman
2016-04-04  1:22 ` [PATCH 1/2] ARM: shmobile: timer: Fix preset_lpj leading to too short delays Simon Horman
2016-04-04  1:22 ` [PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8 Simon Horman
2016-04-04  1:22   ` Simon Horman
2016-04-13 19:41   ` Olof Johansson
2016-04-13 19:50     ` Geert Uytterhoeven
2016-04-13 19:43 ` [GIT PULL] Renesas ARM Based SoC Drivers Updates for v4.7 Olof Johansson
2016-04-13 19:57   ` Geert Uytterhoeven
2016-04-13 20:23     ` Olof Johansson
2016-04-14  8:19       ` Geert Uytterhoeven
2016-04-15  0:33         ` Simon Horman
2016-04-15  6:35           ` Geert Uytterhoeven
2016-04-18  3:55             ` Simon Horman
2016-04-19  7:25               ` Geert Uytterhoeven
2016-04-19 22:48                 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.