* [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support
@ 2022-04-04 12:34 Wolfram Sang
2022-04-05 7:12 ` Geert Uytterhoeven
2022-04-07 11:04 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2022-04-04 12:34 UTC (permalink / raw)
To: linux-mmc
Cc: linux-renesas-soc, Yoshihiro Shimoda, Wolfram Sang, Takeshi Saito
The hardware evolved, so we only need to disable HS400 support on ES1.*
revisions. Update the code.
Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
[wsa: refactored to top-of-tree]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Another HS400 update for a specific SoC. Builds fine. But I can't test
because of no HW. Reviews from Geert and/or Shimoda-san would be much
appreciated.
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 2cd81d22c3c3..c9585c4fd812 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -215,6 +215,7 @@ static const struct soc_device_attribute sdhi_quirks_match[] = {
{ .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx },
{ .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 },
{ .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_r8a7796_es13 },
+ { .soc_id = "r8a77980", .revision = "ES1.*", .data = &sdhi_quirks_nohs400 },
{ /* Sentinel. */ }
};
@@ -265,7 +266,6 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
{ .compatible = "renesas,sdhi-r8a77961", .data = &of_r8a77961_compatible, },
{ .compatible = "renesas,sdhi-r8a77965", .data = &of_r8a77965_compatible, },
{ .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
- { .compatible = "renesas,sdhi-r8a77980", .data = &of_rcar_gen3_nohs400_compatible, },
{ .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
{ .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
{ .compatible = "renesas,rcar-gen3-sdhi", .data = &of_rcar_gen3_compatible, },
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support
2022-04-04 12:34 [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support Wolfram Sang
@ 2022-04-05 7:12 ` Geert Uytterhoeven
2022-04-07 11:04 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-04-05 7:12 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux MMC List, Linux-Renesas, Yoshihiro Shimoda, Takeshi Saito
Hi Wolfram,
On Tue, Apr 5, 2022 at 2:33 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> The hardware evolved, so we only need to disable HS400 support on ES1.*
> revisions. Update the code.
>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [wsa: refactored to top-of-tree]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Another HS400 update for a specific SoC. Builds fine. But I can't test
> because of no HW. Reviews from Geert and/or Shimoda-san would be much
> appreciated.
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -215,6 +215,7 @@ static const struct soc_device_attribute sdhi_quirks_match[] = {
> { .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx },
> { .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 },
> { .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_r8a7796_es13 },
> + { .soc_id = "r8a77980", .revision = "ES1.*", .data = &sdhi_quirks_nohs400 },
LGTM.
> { /* Sentinel. */ }
> };
>
> @@ -265,7 +266,6 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
> { .compatible = "renesas,sdhi-r8a77961", .data = &of_r8a77961_compatible, },
> { .compatible = "renesas,sdhi-r8a77965", .data = &of_r8a77965_compatible, },
> { .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
> - { .compatible = "renesas,sdhi-r8a77980", .data = &of_rcar_gen3_nohs400_compatible, },
arch/arm64/boot/dts/renesas/r8a77980.dtsi always had the
family-specific compatible value, so this is OK.
> { .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
> { .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
> { .compatible = "renesas,rcar-gen3-sdhi", .data = &of_rcar_gen3_compatible, },
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support
2022-04-04 12:34 [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support Wolfram Sang
2022-04-05 7:12 ` Geert Uytterhoeven
@ 2022-04-07 11:04 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-04-07 11:04 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-mmc, linux-renesas-soc, Yoshihiro Shimoda, Takeshi Saito
On Mon, 4 Apr 2022 at 14:34, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> The hardware evolved, so we only need to disable HS400 support on ES1.*
> revisions. Update the code.
>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [wsa: refactored to top-of-tree]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> Another HS400 update for a specific SoC. Builds fine. But I can't test
> because of no HW. Reviews from Geert and/or Shimoda-san would be much
> appreciated.
>
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index 2cd81d22c3c3..c9585c4fd812 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -215,6 +215,7 @@ static const struct soc_device_attribute sdhi_quirks_match[] = {
> { .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx },
> { .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 },
> { .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_r8a7796_es13 },
> + { .soc_id = "r8a77980", .revision = "ES1.*", .data = &sdhi_quirks_nohs400 },
> { /* Sentinel. */ }
> };
>
> @@ -265,7 +266,6 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
> { .compatible = "renesas,sdhi-r8a77961", .data = &of_r8a77961_compatible, },
> { .compatible = "renesas,sdhi-r8a77965", .data = &of_r8a77965_compatible, },
> { .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
> - { .compatible = "renesas,sdhi-r8a77980", .data = &of_rcar_gen3_nohs400_compatible, },
> { .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
> { .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
> { .compatible = "renesas,rcar-gen3-sdhi", .data = &of_rcar_gen3_compatible, },
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-07 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-04 12:34 [PATCH] mmc: renesas_sdhi: R-Car V3H ES2.0 gained HS400 support Wolfram Sang
2022-04-05 7:12 ` Geert Uytterhoeven
2022-04-07 11:04 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.