* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-15 8:00 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-15 8:00 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, jacopo mondi, Simon Horman
Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v2
* Correct register range start address
Based on renesas-devel-20180514-v4.17-rc5
---
arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index 508d93440ee8..35e2fc957458 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -77,6 +77,16 @@
status = "disabled";
};
+ ceu1: ceu@fe914000 {
+ reg = <0xfe914000 0x3000>;
+ compatible = "renesas,r8a7740-ceu";
+ interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
+ clock-names = "ceu21";
+ power-domains = <&pd_a4r>;
+ status = "disabled";
+ };
+
cmt1: timer@e6138000 {
compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
reg = <0xe6138000 0x170>;
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-15 8:00 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-15 8:00 UTC (permalink / raw)
To: linux-arm-kernel
Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v2
* Correct register range start address
Based on renesas-devel-20180514-v4.17-rc5
---
arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index 508d93440ee8..35e2fc957458 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -77,6 +77,16 @@
status = "disabled";
};
+ ceu1: ceu at fe914000 {
+ reg = <0xfe914000 0x3000>;
+ compatible = "renesas,r8a7740-ceu";
+ interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
+ clock-names = "ceu21";
+ power-domains = <&pd_a4r>;
+ status = "disabled";
+ };
+
cmt1: timer at e6138000 {
compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
reg = <0xe6138000 0x170>;
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2] ARM: dts: r8a7740: Add CEU1
2018-05-15 8:00 ` Simon Horman
@ 2018-05-15 8:23 ` jacopo mondi
-1 siblings, 0 replies; 10+ messages in thread
From: jacopo mondi @ 2018-05-15 8:23 UTC (permalink / raw)
To: Simon Horman; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
Hi Simon,
On Tue, May 15, 2018 at 10:00:38AM +0200, Simon Horman wrote:
> Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thank you!
j
> ---
> v2
> * Correct register range start address
>
> Based on renesas-devel-20180514-v4.17-rc5
> ---
> arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index 508d93440ee8..35e2fc957458 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -77,6 +77,16 @@
> status = "disabled";
> };
>
> + ceu1: ceu@fe914000 {
> + reg = <0xfe914000 0x3000>;
> + compatible = "renesas,r8a7740-ceu";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> + clock-names = "ceu21";
> + power-domains = <&pd_a4r>;
> + status = "disabled";
> + };
> +
> cmt1: timer@e6138000 {
> compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> reg = <0xe6138000 0x170>;
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-15 8:23 ` jacopo mondi
0 siblings, 0 replies; 10+ messages in thread
From: jacopo mondi @ 2018-05-15 8:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tue, May 15, 2018 at 10:00:38AM +0200, Simon Horman wrote:
> Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thank you!
j
> ---
> v2
> * Correct register range start address
>
> Based on renesas-devel-20180514-v4.17-rc5
> ---
> arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index 508d93440ee8..35e2fc957458 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -77,6 +77,16 @@
> status = "disabled";
> };
>
> + ceu1: ceu at fe914000 {
> + reg = <0xfe914000 0x3000>;
> + compatible = "renesas,r8a7740-ceu";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> + clock-names = "ceu21";
> + power-domains = <&pd_a4r>;
> + status = "disabled";
> + };
> +
> cmt1: timer at e6138000 {
> compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> reg = <0xe6138000 0x170>;
> --
> 2.11.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180515/4878e59e/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] ARM: dts: r8a7740: Add CEU1
2018-05-15 8:23 ` jacopo mondi
@ 2018-05-16 7:02 ` Simon Horman
-1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-16 7:02 UTC (permalink / raw)
To: jacopo mondi; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm
On Tue, May 15, 2018 at 10:23:10AM +0200, jacopo mondi wrote:
> Hi Simon,
>
> On Tue, May 15, 2018 at 10:00:38AM +0200, Simon Horman wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks, applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-16 7:02 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-16 7:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 15, 2018 at 10:23:10AM +0200, jacopo mondi wrote:
> Hi Simon,
>
> On Tue, May 15, 2018 at 10:00:38AM +0200, Simon Horman wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks, applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] ARM: dts: r8a7740: Add CEU1
2018-05-15 8:00 ` Simon Horman
@ 2018-05-16 7:40 ` Geert Uytterhoeven
-1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-05-16 7:40 UTC (permalink / raw)
To: Simon Horman; +Cc: Linux-Renesas, Linux ARM, Magnus Damm, jacopo mondi
Hi Simon,
On Tue, May 15, 2018 at 10:00 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v2
> * Correct register range start address
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Minor question below.
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -77,6 +77,16 @@
> status = "disabled";
> };
>
> + ceu1: ceu@fe914000 {
> + reg = <0xfe914000 0x3000>;
> + compatible = "renesas,r8a7740-ceu";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> + clock-names = "ceu21";
Why the "clock-names" property? It's not mentioned in the DT bindings, and
may cause issues if the bindings are ever amended.
> + power-domains = <&pd_a4r>;
> + status = "disabled";
> + };
> +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-16 7:40 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-05-16 7:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tue, May 15, 2018 at 10:00 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v2
> * Correct register range start address
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Minor question below.
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -77,6 +77,16 @@
> status = "disabled";
> };
>
> + ceu1: ceu at fe914000 {
> + reg = <0xfe914000 0x3000>;
> + compatible = "renesas,r8a7740-ceu";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> + clock-names = "ceu21";
Why the "clock-names" property? It's not mentioned in the DT bindings, and
may cause issues if the bindings are ever amended.
> + power-domains = <&pd_a4r>;
> + status = "disabled";
> + };
> +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] ARM: dts: r8a7740: Add CEU1
2018-05-16 7:40 ` Geert Uytterhoeven
@ 2018-05-16 8:55 ` Simon Horman
-1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-16 8:55 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux-Renesas, Linux ARM, Magnus Damm, jacopo mondi
On Wed, May 16, 2018 at 09:40:10AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 15, 2018 at 10:00 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > v2
> > * Correct register range start address
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Minor question below.
>
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -77,6 +77,16 @@
> > status = "disabled";
> > };
> >
> > + ceu1: ceu@fe914000 {
> > + reg = <0xfe914000 0x3000>;
> > + compatible = "renesas,r8a7740-ceu";
> > + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> > + clock-names = "ceu21";
>
> Why the "clock-names" property? It's not mentioned in the DT bindings, and
> may cause issues if the bindings are ever amended.
Thanks, I copied this from CEU0 where you have also raised the same issue.
I have dropped the property for now.
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] ARM: dts: r8a7740: Add CEU1
@ 2018-05-16 8:55 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-05-16 8:55 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 16, 2018 at 09:40:10AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 15, 2018 at 10:00 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > v2
> > * Correct register range start address
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Minor question below.
>
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -77,6 +77,16 @@
> > status = "disabled";
> > };
> >
> > + ceu1: ceu at fe914000 {
> > + reg = <0xfe914000 0x3000>;
> > + compatible = "renesas,r8a7740-ceu";
> > + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> > + clock-names = "ceu21";
>
> Why the "clock-names" property? It's not mentioned in the DT bindings, and
> may cause issues if the bindings are ever amended.
Thanks, I copied this from CEU0 where you have also raised the same issue.
I have dropped the property for now.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-05-16 8:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 8:00 [PATCH v2] ARM: dts: r8a7740: Add CEU1 Simon Horman
2018-05-15 8:00 ` Simon Horman
2018-05-15 8:23 ` jacopo mondi
2018-05-15 8:23 ` jacopo mondi
2018-05-16 7:02 ` Simon Horman
2018-05-16 7:02 ` Simon Horman
2018-05-16 7:40 ` Geert Uytterhoeven
2018-05-16 7:40 ` Geert Uytterhoeven
2018-05-16 8:55 ` Simon Horman
2018-05-16 8:55 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.